Ros-diffs February 2014

ros-diffs@reactos.org

17 participants
464 discussions

[janderwald] 62071: [INF] - add swenum bus filter registration - not yet used

by janderwald＠svn.reactos.org

Author: janderwald Date: Sun Feb 9 15:41:41 2014 New Revision: 62071 URL: http://svn.reactos.org/svn/reactos?rev=62071&view=rev Log: [INF] - add swenum bus filter registration - not yet used Modified: trunk/reactos/media/inf/machine.inf Modified: trunk/reactos/media/inf/machine.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/machine.inf?rev=… ============================================================================== Binary files - no diff available.

10 years, 7 months

[janderwald] 62070: [USBHUB] - dont assert on invalid configuration descriptors CORE-7730 #comment please re-test

by janderwald＠svn.reactos.org

Author: janderwald Date: Sun Feb 9 13:59:25 2014 New Revision: 62070 URL: http://svn.reactos.org/svn/reactos?rev=62070&view=rev Log: [USBHUB] - dont assert on invalid configuration descriptors CORE-7730 #comment please re-test Modified: trunk/reactos/drivers/usb/usbhub/fdo.c Modified: trunk/reactos/drivers/usb/usbhub/fdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbhub/fdo.c?r… ============================================================================== --- trunk/reactos/drivers/usb/usbhub/fdo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbhub/fdo.c [iso-8859-1] Sun Feb 9 13:59:25 2014 @@ -849,6 +849,12 @@ // use first interface descriptor available // InterfaceDescriptor = USBD_ParseConfigurationDescriptorEx(ConfigurationDescriptor, ConfigurationDescriptor, 0, -1, -1, -1, -1); + if (InterfaceDescriptor == NULL) + { + DPRINT1("Error USBD_ParseConfigurationDescriptorEx failed to parse interface descriptor\n"); + return STATUS_INVALID_PARAMETER; + } + ASSERT(InterfaceDescriptor); //

10 years, 7 months

[janderwald] 62069: [USBCGGP] - remove assert CORE-7833 #comment fixed #resolve

by janderwald＠svn.reactos.org

Author: janderwald Date: Sun Feb 9 13:48:30 2014 New Revision: 62069 URL: http://svn.reactos.org/svn/reactos?rev=62069&view=rev Log: [USBCGGP] - remove assert CORE-7833 #comment fixed #resolve Modified: trunk/reactos/drivers/usb/usbccgp/pdo.c Modified: trunk/reactos/drivers/usb/usbccgp/pdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbccgp/pdo.c?… ============================================================================== --- trunk/reactos/drivers/usb/usbccgp/pdo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbccgp/pdo.c [iso-8859-1] Sun Feb 9 13:48:30 2014 @@ -757,7 +757,6 @@ // invalid parameter // DPRINT1("InterfaceInformation InterfaceNumber %x Alternative %x NumberOfPipes %x not found\n", InterfaceInformation->InterfaceNumber, InterfaceInformation->AlternateSetting, InterfaceInformation->NumberOfPipes); - ASSERT(FALSE); return STATUS_INVALID_PARAMETER; }

10 years, 7 months

[tkreuzer] 62068: [WIN32K] Replace pldevNext and pldevPrev with a LIST_ENTRY and use standard list routines instead of broken manual handling. Should fix crash in user32:sysparams test

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Sun Feb 9 12:46:19 2014 New Revision: 62068 URL: http://svn.reactos.org/svn/reactos?rev=62068&view=rev Log: [WIN32K] Replace pldevNext and pldevPrev with a LIST_ENTRY and use standard list routines instead of broken manual handling. Should fix crash in user32:sysparams test Modified: trunk/reactos/win32ss/gdi/eng/ldevobj.c trunk/reactos/win32ss/gdi/eng/ldevobj.h Modified: trunk/reactos/win32ss/gdi/eng/ldevobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/eng/ldevobj.c?… ============================================================================== --- trunk/reactos/win32ss/gdi/eng/ldevobj.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/eng/ldevobj.c [iso-8859-1] Sun Feb 9 12:46:19 2014 @@ -18,7 +18,7 @@ /** Globals *******************************************************************/ static HSEMAPHORE ghsemLDEVList; -static LDEVOBJ *gpldevHead = NULL; +static LIST_ENTRY gleLdevListHead; static LDEVOBJ *gpldevWin32k = NULL; @@ -30,6 +30,9 @@ InitLDEVImpl(VOID) { ULONG cbSize; + + /* Initialize the LDEV list head */ + InitializeListHead(&gleLdevListHead); /* Initialize the loader lock */ ghsemLDEVList = EngCreateSemaphore(); @@ -50,8 +53,8 @@ } /* Initialize the LDEVOBJ for win32k */ - gpldevWin32k->pldevNext = NULL; - gpldevWin32k->pldevPrev = NULL; + gpldevWin32k->leLink.Flink = NULL; + gpldevWin32k->leLink.Blink = NULL; gpldevWin32k->ldevtype = LDEV_DEVICE_DISPLAY; gpldevWin32k->cRefs = 1; gpldevWin32k->ulDriverVersion = GDI_ENGINE_VERSION; @@ -320,6 +323,7 @@ _In_ ULONG ldevtype) { WCHAR acwBuffer[MAX_PATH]; + PLIST_ENTRY pleLink; PLDEVOBJ pldev; UNICODE_STRING strDriverName; SIZE_T cwcLength; @@ -368,13 +372,15 @@ EngAcquireSemaphore(ghsemLDEVList); /* Search the List of LDEVS for the driver name */ - for (pldev = gpldevHead; pldev != NULL; pldev = pldev->pldevNext) - { + for (pleLink = gleLdevListHead.Flink; + pleLink != &gleLdevListHead; + pleLink = pleLink->Flink) + { + pldev = CONTAINING_RECORD(pleLink, LDEVOBJ, leLink); + /* Check if the ldev is associated with a file */ if (pldev->pGdiDriverInfo) { - ERR("Driver Name 1 %wZ\n", &strDriverName); - ERR("Driver Name 2 %wZ\n", &pldev->pGdiDriverInfo->DriverName); /* Check for match (case insensative) */ if (RtlEqualUnicodeString(&pldev->pGdiDriverInfo->DriverName, &strDriverName, 1)) { @@ -385,7 +391,7 @@ } /* Did we find one? */ - if (!pldev) + if (pleLink == &gleLdevListHead) { /* No, allocate a new LDEVOBJ */ pldev = LDEVOBJ_AllocLDEV(ldevtype); @@ -421,11 +427,7 @@ } /* Insert the LDEV into the global list */ - pldev->pldevPrev = NULL; - pldev->pldevNext = gpldevHead; - if (gpldevHead) - gpldevHead->pldevPrev = pldev; - gpldevHead = pldev; + InsertHeadList(&gleLdevListHead, &pldev->leLink); } /* Increase ref count */ @@ -459,7 +461,7 @@ PLDEVOBJ pldev = (PLDEVOBJ)hModule; /* Make sure the LDEV is in the list */ - ASSERT(pldev->pldevPrev || pldev->pldevNext); + ASSERT((pldev->leLink.Flink != NULL) && (pldev->leLink.Blink != NULL)); /* Lock loader */ EngAcquireSemaphore(ghsemLDEVList); @@ -471,10 +473,7 @@ if (pldev->cRefs == 0) { /* Remove ldev from the list */ - if (pldev->pldevPrev) - pldev->pldevPrev->pldevNext = pldev->pldevNext; - if (pldev->pldevNext) - pldev->pldevNext->pldevPrev = pldev->pldevPrev; + RemoveEntryList(&pldev->leLink); /* Unload the image and free the LDEV */ LDEVOBJ_vUnloadImage(pldev); Modified: trunk/reactos/win32ss/gdi/eng/ldevobj.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/eng/ldevobj.h?… ============================================================================== --- trunk/reactos/win32ss/gdi/eng/ldevobj.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/eng/ldevobj.h [iso-8859-1] Sun Feb 9 12:46:19 2014 @@ -15,8 +15,7 @@ typedef struct _LDEVOBJ { - struct _LDEVOBJ *pldevNext; - struct _LDEVOBJ *pldevPrev; + LIST_ENTRY leLink; SYSTEM_GDI_DRIVER_INFORMATION *pGdiDriverInfo; LDEVTYPE ldevtype; ULONG cRefs;

10 years, 7 months

[akhaldi] 62067: [FRAMEBUF] * Add header guards to the main header. * Improve header inclusions. CORE-7716

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sun Feb 9 12:38:16 2014 New Revision: 62067 URL: http://svn.reactos.org/svn/reactos?rev=62067&view=rev Log: [FRAMEBUF] * Add header guards to the main header. * Improve header inclusions. CORE-7716 Modified: trunk/reactos/win32ss/drivers/displays/framebuf/framebuf.h Modified: trunk/reactos/win32ss/drivers/displays/framebuf/framebuf.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/displays/f… ============================================================================== --- trunk/reactos/win32ss/drivers/displays/framebuf/framebuf.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/displays/framebuf/framebuf.h [iso-8859-1] Sun Feb 9 12:38:16 2014 @@ -18,9 +18,11 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +#ifndef _FRAMEBUF_PCH_ +#define _FRAMEBUF_PCH_ + #include <stdarg.h> #include <windef.h> -#include <guiddef.h> #include <wingdi.h> #include <winddi.h> #include <winioctl.h> @@ -157,3 +159,5 @@ IN PPALETTEENTRY ppalent, IN ULONG iStart, IN ULONG cColors); + +#endif /* _FRAMEBUF_PCH_ */

10 years, 7 months

[akhaldi] 62066: [CPLS] * Prepare the CMake scripts for PCH. CORE-7716

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sun Feb 9 12:26:28 2014 New Revision: 62066 URL: http://svn.reactos.org/svn/reactos?rev=62066&view=rev Log: [CPLS] * Prepare the CMake scripts for PCH. CORE-7716 Modified: trunk/reactos/dll/cpl/access/CMakeLists.txt trunk/reactos/dll/cpl/appwiz/CMakeLists.txt trunk/reactos/dll/cpl/console/CMakeLists.txt trunk/reactos/dll/cpl/desk/CMakeLists.txt trunk/reactos/dll/cpl/inetcpl/CMakeLists.txt trunk/reactos/dll/cpl/input/CMakeLists.txt trunk/reactos/dll/cpl/intl/CMakeLists.txt trunk/reactos/dll/cpl/main/CMakeLists.txt trunk/reactos/dll/cpl/mmsys/CMakeLists.txt trunk/reactos/dll/cpl/powercfg/CMakeLists.txt trunk/reactos/dll/cpl/sysdm/CMakeLists.txt trunk/reactos/dll/cpl/timedate/CMakeLists.txt trunk/reactos/dll/cpl/usrmgr/CMakeLists.txt trunk/reactos/dll/cpl/wined3dcfg/CMakeLists.txt Modified: trunk/reactos/dll/cpl/access/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/access/CMakeLists.… ============================================================================== --- trunk/reactos/dll/cpl/access/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/access/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,17 +1,21 @@ spec2def(access.cpl access.spec) -add_library(access SHARED +list(APPEND SOURCE access.c display.c general.c keyboard.c mouse.c sound.c + access.h) + +add_library(access SHARED + ${SOURCE} access.rc ${CMAKE_CURRENT_BINARY_DIR}/access.def) set_module_type(access cpl UNICODE) add_importlibs(access user32 gdi32 advapi32 comctl32 msvcrt kernel32) -add_pch(access access.h) +add_pch(access access.h SOURCE) add_cd_file(TARGET access DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/appwiz/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/CMakeLists.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -8,10 +8,14 @@ spec2def(appwiz.cpl appwiz.spec) -add_library(appwiz SHARED +list(APPEND SOURCE addons.c appwiz.c createlink.c + appwiz.h) + +add_library(appwiz SHARED + ${SOURCE} appwiz.rc ${CMAKE_CURRENT_BINARY_DIR}/appwiz.def) @@ -19,5 +23,5 @@ target_link_libraries(appwiz uuid wine) add_importlibs(appwiz urlmon ole32 comctl32 advapi32 shell32 user32 msvcrt kernel32 ntdll) add_delay_importlibs(appwiz msi) -add_pch(appwiz appwiz.h) +add_pch(appwiz appwiz.h SOURCE) add_cd_file(TARGET appwiz DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/console/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/console/CMakeLists… ============================================================================== --- trunk/reactos/dll/cpl/console/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/console/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -11,10 +11,12 @@ font.c layout.c colors.c + console.h) + +add_library(console SHARED + ${SOURCE} console.rc ${CMAKE_CURRENT_BINARY_DIR}/console.def) - -add_library(console SHARED ${SOURCE}) set_module_type(console win32dll UNICODE) @@ -26,5 +28,5 @@ kernel32 ntdll) -add_pch(console console.h) +add_pch(console console.h SOURCE) add_cd_file(TARGET console DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/desk/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/CMakeLists.tx… ============================================================================== --- trunk/reactos/dll/cpl/desk/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,9 +1,8 @@ add_definitions(-D_WIN32) - spec2def(desk.cpl desk.spec) -add_library(desk SHARED +list(APPEND SOURCE advmon.c appearance.c background.c @@ -19,10 +18,14 @@ settings.c monslctl.c general.c - desk.rc draw.c theme.c muireg.c + desk.h) + +add_library(desk SHARED + ${SOURCE} + desk.rc ${CMAKE_CURRENT_BINARY_DIR}/desk.def) set_module_type(desk cpl UNICODE) @@ -43,5 +46,5 @@ kernel32 ntdll) -add_pch(desk desk.h) +add_pch(desk desk.h SOURCE) add_cd_file(TARGET desk DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/inetcpl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/inetcpl/CMakeLists… ============================================================================== --- trunk/reactos/dll/cpl/inetcpl/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/inetcpl/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -7,12 +7,17 @@ content.c general.c security.c + inetcpl.h) + +add_library(inetcpl SHARED + ${SOURCE} + inetcpl.rc ${CMAKE_CURRENT_BINARY_DIR}/inetcpl_stubs.c ${CMAKE_CURRENT_BINARY_DIR}/inetcpl.def) -add_library(inetcpl SHARED ${SOURCE} inetcpl.rc) set_module_type(inetcpl cpl UNICODE) target_link_libraries(inetcpl wine) add_importlibs(inetcpl advapi32 comctl32 user32 shlwapi msvcrt kernel32 ntdll) add_delay_importlibs(inetcpl cryptui wininet ole32 urlmon shell32) +add_pch(inetcpl inetcpl.h SOURCE) add_cd_file(TARGET inetcpl DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/input/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/input/CMakeLists.t… ============================================================================== --- trunk/reactos/dll/cpl/input/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/input/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,13 +1,17 @@ spec2def(input.dll input.spec) -add_library(input SHARED +list(APPEND SOURCE input.c settings.c advsettings.c keysettings.c add.c changekeyseq.c + input.h) + +add_library(input SHARED + ${SOURCE} input.rc ${CMAKE_CURRENT_BINARY_DIR}/input.def) @@ -21,5 +25,5 @@ gdi32 kernel32) -add_pch(input input.h) +add_pch(input input.h SOURCE) add_cd_file(TARGET input DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/intl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/intl/CMakeLists.tx… ============================================================================== --- trunk/reactos/dll/cpl/intl/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/intl/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,7 +1,7 @@ spec2def(intl.cpl intl.spec) -add_library(intl SHARED +list(APPEND SOURCE currency.c date.c generalp.c @@ -14,6 +14,10 @@ languages.c advanced.c sort.c + intl.h) + +add_library(intl SHARED + ${SOURCE} intl.rc ${CMAKE_CURRENT_BINARY_DIR}/intl.def) @@ -29,5 +33,5 @@ kernel32 ntdll) -add_pch(intl intl.h) +add_pch(intl intl.h SOURCE) add_cd_file(TARGET intl DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/main/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/main/CMakeLists.tx… ============================================================================== --- trunk/reactos/dll/cpl/main/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/main/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,10 +1,14 @@ spec2def(main.cpl main.spec) -add_library(main SHARED +list(APPEND SOURCE keyboard.c main.c mouse.c + main.h) + +add_library(main SHARED + ${SOURCE} main.rc ${CMAKE_CURRENT_BINARY_DIR}/main.def) @@ -22,5 +26,5 @@ gdi32 kernel32) -add_pch(main main.h) +add_pch(main main.h SOURCE) add_cd_file(TARGET main DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/mmsys/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/mmsys/CMakeLists.t… ============================================================================== --- trunk/reactos/dll/cpl/mmsys/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/mmsys/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,12 +1,16 @@ spec2def(mmsys.cpl mmsys.spec) -add_library(mmsys SHARED +list(APPEND SOURCE mmsys.c sounds.c volume.c audio.c voice.c + mmsys.h) + +add_library(mmsys SHARED + ${SOURCE} mmsys.rc ${CMAKE_CURRENT_BINARY_DIR}/mmsys.def) @@ -27,5 +31,5 @@ kernel32 comdlg32) -add_pch(mmsys mmsys.h) +add_pch(mmsys mmsys.h SOURCE) add_cd_file(TARGET mmsys DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/powercfg/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/powercfg/CMakeList… ============================================================================== --- trunk/reactos/dll/cpl/powercfg/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/powercfg/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,12 +1,16 @@ spec2def(powercfg.cpl powercfg.spec) -add_library(powercfg SHARED +list(APPEND SOURCE powercfg.c powershemes.c alarms.c advanced.c hibernate.c + powercfg.h) + +add_library(powercfg SHARED + ${SOURCE} powercfg.rc ${CMAKE_CURRENT_BINARY_DIR}/powercfg.def) @@ -22,5 +26,5 @@ kernel32 ntdll) -add_pch(powercfg powercfg.h) +add_pch(powercfg powercfg.h SOURCE) add_cd_file(TARGET powercfg DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/sysdm/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/CMakeLists.t… ============================================================================== --- trunk/reactos/dll/cpl/sysdm/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/sysdm/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -12,10 +12,13 @@ sysdm.c userprofile.c virtmem.c + precomp.h) + +add_library(sysdm SHARED + ${SOURCE} sysdm.rc ${CMAKE_CURRENT_BINARY_DIR}/sysdm.def) -add_library(sysdm SHARED ${SOURCE}) set_module_type(sysdm cpl UNICODE) add_importlibs(sysdm @@ -33,5 +36,5 @@ kernel32 ntdll) -add_pch(sysdm precomp.h) +add_pch(sysdm precomp.h SOURCE) add_cd_file(TARGET sysdm DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/timedate/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/timedate/CMakeList… ============================================================================== --- trunk/reactos/dll/cpl/timedate/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/timedate/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,7 +1,7 @@ spec2def(timedate.cpl timedate.spec) -add_library(timedate SHARED +list(APPEND SOURCE clock.c dateandtime.c internettime.c @@ -9,6 +9,10 @@ ntpclient.c timedate.c timezone.c + timedate.h) + +add_library(timedate SHARED + ${SOURCE} timedate.rc ${CMAKE_CURRENT_BINARY_DIR}/timedate.def) @@ -24,5 +28,5 @@ msvcrt kernel32) -add_pch(timedate timedate.h) +add_pch(timedate timedate.h SOURCE) add_cd_file(TARGET timedate DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/usrmgr/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/usrmgr/CMakeLists.… ============================================================================== --- trunk/reactos/dll/cpl/usrmgr/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/usrmgr/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -3,7 +3,7 @@ spec2def(usrmgr.cpl usrmgr.spec) -add_library(usrmgr SHARED +list(APPEND SOURCE extra.c groupprops.c groups.c @@ -11,6 +11,10 @@ userprops.c users.c usrmgr.c + usrmgr.h) + +add_library(usrmgr SHARED + ${SOURCE} usrmgr.rc ${CMAKE_CURRENT_BINARY_DIR}/usrmgr.def) @@ -26,5 +30,5 @@ kernel32 ntdll) -add_pch(usrmgr usrmgr.h) +add_pch(usrmgr usrmgr.h SOURCE) add_cd_file(TARGET usrmgr DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/cpl/wined3dcfg/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/wined3dcfg/CMakeLi… ============================================================================== --- trunk/reactos/dll/cpl/wined3dcfg/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/wined3dcfg/CMakeLists.txt [iso-8859-1] Sun Feb 9 12:26:28 2014 @@ -1,9 +1,13 @@ spec2def(wined3dcfg.cpl wined3dcfg.spec) -add_library(wined3dcfg SHARED +list(APPEND SOURCE wined3dcfg.c general.c + wined3dcfg.h) + +add_library(wined3dcfg SHARED + ${SOURCE} wined3dcfg.rc ${CMAKE_CURRENT_BINARY_DIR}/wined3dcfg.def) @@ -16,5 +20,5 @@ advapi32 kernel32) -add_pch(wined3dcfg wined3dcfg.h) +add_pch(wined3dcfg wined3dcfg.h SOURCE) add_cd_file(TARGET wined3dcfg DESTINATION reactos/system32 FOR all)

10 years, 7 months

[hbelusca] 62065: [MSGINA]: Fix a memory leak. Caught by mudhead. CORE-7871 #resolve #comment Fixed in rev.62065, thanks.

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Sun Feb 9 11:17:29 2014 New Revision: 62065 URL: http://svn.reactos.org/svn/reactos?rev=62065&view=rev Log: [MSGINA]: Fix a memory leak. Caught by mudhead. CORE-7871 #resolve #comment Fixed in rev.62065, thanks. Modified: trunk/reactos/dll/win32/msgina/gui.c Modified: trunk/reactos/dll/win32/msgina/gui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/gui.c?rev… ============================================================================== --- trunk/reactos/dll/win32/msgina/gui.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msgina/gui.c [iso-8859-1] Sun Feb 9 11:17:29 2014 @@ -110,7 +110,13 @@ if (!pgContext->hStatusWindow) { - msg = (PDISPLAYSTATUSMSG)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(DISPLAYSTATUSMSG)); + /* + * If everything goes correctly, 'msg' is freed + * by the 'StartupWindowThread' thread. + */ + msg = (PDISPLAYSTATUSMSG)HeapAlloc(GetProcessHeap(), + HEAP_ZERO_MEMORY, + sizeof(DISPLAYSTATUSMSG)); if(!msg) return FALSE; @@ -120,22 +126,23 @@ msg->pMessage = pMessage; msg->hDesktop = hDesktop; - msg->StartupEvent = CreateEventW( - NULL, - TRUE, - FALSE, - NULL); + msg->StartupEvent = CreateEventW(NULL, + TRUE, + FALSE, + NULL); if (!msg->StartupEvent) + { + HeapFree(GetProcessHeap(), 0, msg); return FALSE; - - Thread = CreateThread( - NULL, - 0, - StartupWindowThread, - (PVOID)msg, - 0, - &ThreadId); + } + + Thread = CreateThread(NULL, + 0, + StartupWindowThread, + (PVOID)msg, + 0, + &ThreadId); if (Thread) { CloseHandle(Thread); @@ -375,7 +382,7 @@ if (!ConnectToLsa(pgContext)) { ERR("ConnectToLsa() failed\n"); - return FALSE; + goto done; } /* Call the authentication package */

10 years, 7 months

[akhaldi] 62064: [FDEBUG] * Add Albanian translation. By Ardit Dani. [ACLUI] * Enable the Albanian translation. CORE-7868 #resolve #comment Committed in r62064. Thanks !

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sun Feb 9 10:52:09 2014 New Revision: 62064 URL: http://svn.reactos.org/svn/reactos?rev=62064&view=rev Log: [FDEBUG] * Add Albanian translation. By Ardit Dani. [ACLUI] * Enable the Albanian translation. CORE-7868 #resolve #comment Committed in r62064. Thanks ! Added: trunk/reactos/boot/freeldr/fdebug/lang/sq-AL.rc (with props) Modified: trunk/reactos/boot/freeldr/fdebug/fdebug.rc trunk/reactos/dll/win32/aclui/aclui.rc Modified: trunk/reactos/boot/freeldr/fdebug/fdebug.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/fdebug/fdebug… ============================================================================== --- trunk/reactos/boot/freeldr/fdebug/fdebug.rc [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/fdebug/fdebug.rc [iso-8859-1] Sun Feb 9 10:52:09 2014 @@ -28,3 +28,4 @@ #include "lang/ru-RU.rc" #include "lang/tr-TR.rc" #include "lang/uk-UA.rc" +#include "lang/sq-AL.rc" Added: trunk/reactos/boot/freeldr/fdebug/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/fdebug/lang/s… ============================================================================== --- trunk/reactos/boot/freeldr/fdebug/lang/sq-AL.rc (added) +++ trunk/reactos/boot/freeldr/fdebug/lang/sq-AL.rc [iso-8859-1] Sun Feb 9 10:52:09 2014 @@ -0,0 +1,87 @@ +/* TRANSLATOR : Ardit Dani (Ard1t) (ardit.dani(a)gmail.com) + * DATE OF TR: 18-01-2014 +*/ + +LANGUAGE LANG_ALBANIAN, SUBLANG_NEUTRAL + +/* Menu */ +IDC_FDEBUG MENU +BEGIN + POPUP "&Skeda" + BEGIN + MENUITEM "&Lidhu", IDM_FILE_CONNECT + MENUITEM "&Shkeputu", IDM_FILE_DISCONNECT, GRAYED + MENUITEM SEPARATOR + MENUITEM "&Pastro Ekranin", IDM_FILE_CLEARDISPLAY + MENUITEM SEPARATOR + MENUITEM "&Fillo Regjistrimin", IDM_FILE_STARTCAPTURE + MENUITEM "N&dalo rregjistrimin", IDM_FILE_STOPCAPTURE, GRAYED + MENUITEM SEPARATOR + MENUITEM "&Eko vendase", IDM_FILE_LOCALECHO + MENUITEM SEPARATOR + MENUITEM "D&il", IDM_EXIT + END + POPUP "&NdihmÃ«" + BEGIN + MENUITEM "&Rreth ...", IDM_ABOUT + END +END + +/* Accelerators */ +IDC_FDEBUG ACCELERATORS +BEGIN + 63, IDM_ABOUT, ASCII, ALT // "?" + 47, IDM_ABOUT, ASCII, ALT // "/" +END + +/* Dialogs */ + +IDD_ABOUTBOX DIALOGEX 22, 17, 259, 210 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU +CAPTION "About FreeLoader Debugger" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "FreeLoader Debugger v1.0\nCopyright (C) 2003\nby Brian Palmer (brianp(a)reactos.org)", IDC_STATIC, "Static", SS_LEFTNOWORDWRAP | WS_GROUP, 53, 28, 122, 26 + DEFPUSHBUTTON "OK", IDOK, 183, 189, 44, 14, WS_GROUP + ICON IDI_FDEBUG, IDC_STATIC, 19, 30, 20, 20 + EDITTEXT IDC_LICENSE_EDIT, 53, 63, 174, 107, ES_MULTILINE | ES_READONLY | WS_VSCROLL +END + +IDD_CONNECTION DIALOGEX 0, 0, 196, 100 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "Opsione lidhje" +FONT 8, "MS Shell Dlg" +BEGIN + LTEXT "Indiko njÃ« port COM (e.g. COM1):", IDC_STATIC, 7, 7, 108, 8 + EDITTEXT IDC_COMPORT, 7, 17, 182, 14, ES_AUTOHSCROLL + LTEXT "Indiko baud rate (e.g. 115200):", IDC_STATIC, 7, 38, 114, 8 + EDITTEXT IDC_BAUTRATE, 7, 48, 182, 14, ES_AUTOHSCROLL + DEFPUSHBUTTON "OK", IDOK, 45, 79, 50, 14 + PUSHBUTTON "Anulo", IDCANCEL, 100, 79, 50, 14 +END + +IDD_CAPTURE DIALOGEX 0, 0, 251, 95 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "Dokumenti per rretgjistrim" +FONT 8, "MS Shell Dlg" +BEGIN + LTEXT "Emri i dokumentit pÃ«r kapur:", IDC_STATIC, 7, 17, 62, 8 + EDITTEXT IDC_CAPTUREFILENAME, 7, 26, 181, 14, ES_AUTOHSCROLL + PUSHBUTTON "&Shfleto", IDC_BROWSE, 194, 26, 50, 14 + DEFPUSHBUTTON "OK", IDOK, 139, 74, 50, 14 + PUSHBUTTON "Anulo", IDCANCEL, 194, 74, 50, 14 +END + +/* String Tables */ + +STRINGTABLE +BEGIN + IDS_APP_TITLE "fdebug" + IDS_HELLO "Hello World!" + IDC_FDEBUG "FDEBUG" +END + +STRINGTABLE +BEGIN + IDS_LICENSE "Ky program Ã«shtÃ« software falas; ju mund ta shpÃ«rndani dhe / ose modifikoni sipas kushteve tÃ« GNU General Public License publikuar nga Free Software Foundation; sipas versionit 2 tÃ« LiÃ§encÃ«s, ose (sipas opinionit tuaj) Ã§do versioni tÃ« mÃ«vonshÃ«m.\r\n\r\nKy program shpÃ«rndahet me shpresÃ«n qÃ« do t'ju jetÃ« i dobishÃ«m, por PA ASNJÃ GARANCI; madje edhe pa garancinÃ« e shprehur tÃ« TREGTUESHMÃRISÃ ose PÃRSHTATJES PÃR NJÃ QÃLLIM TÃ CAKTUAR. Shiko LiÃ§encÃ«n Publike tÃ« PÃ«rgjithshme GNU pÃ«r mÃ« shumÃ« detaje.\r\n\r\nJu duhet tÃ« keni marrÃ« njÃ« kopje tÃ« LiÃ§ensÃ«s sÃ« PÃ«rgjithshme Publike GNU sÃ« bashku me kÃ«tÃ« program; nÃ«se jo, shkruani nÃ« Free Software Foundation, Inc, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA." +END Propchange: trunk/reactos/boot/freeldr/fdebug/lang/sq-AL.rc ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/dll/win32/aclui/aclui.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/aclui/aclui.rc?r… ============================================================================== --- trunk/reactos/dll/win32/aclui/aclui.rc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/aclui/aclui.rc [iso-8859-1] Sun Feb 9 10:52:09 2014 @@ -66,6 +66,9 @@ #ifdef LANGUAGE_RU_RU #include "lang/ru-RU.rc" #endif +#ifdef LANGUAGE_SQ_AL + #include "lang/sq-AL.rc" +#endif #ifdef LANGUAGE_SV_SE #include "lang/sv-SE.rc" #endif

10 years, 7 months

[akhaldi] 62063: [BASE/SYSTEM] * Prepare the CMake scripts for PCH. CORE-7716

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sun Feb 9 10:40:34 2014 New Revision: 62063 URL: http://svn.reactos.org/svn/reactos?rev=62063&view=rev Log: [BASE/SYSTEM] * Prepare the CMake scripts for PCH. CORE-7716 Modified: trunk/reactos/base/system/diskpart/CMakeLists.txt trunk/reactos/base/system/msiexec/CMakeLists.txt trunk/reactos/base/system/services/CMakeLists.txt trunk/reactos/base/system/smss/CMakeLists.txt trunk/reactos/base/system/winlogon/CMakeLists.txt Modified: trunk/reactos/base/system/diskpart/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/diskpart/CMake… ============================================================================== --- trunk/reactos/base/system/diskpart/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/system/diskpart/CMakeLists.txt [iso-8859-1] Sun Feb 9 10:40:34 2014 @@ -1,48 +1,50 @@ -add_executable(diskpart - active.c - add.c - assign.c - attach.c - attributes.c - automount.c - break.c - clean.c - compact.c - convert.c - create.c - delete.c - detach.c - detail.c - diskpart.c - expand.c - extend.c - filesystems.c - format.c - gpt.c - help.c - import.c - inactive.c - interpreter.c - list.c - merge.c - offline.c - online.c - recover.c - remove.c - repair.c - rescan.c - retain.c - san.c - select.c - setid.c - shrink.c - uniqueid.c - diskpart.rc) +list(APPEND SOURCE + active.c + add.c + assign.c + attach.c + attributes.c + automount.c + break.c + clean.c + compact.c + convert.c + create.c + delete.c + detach.c + detail.c + diskpart.c + expand.c + extend.c + filesystems.c + format.c + gpt.c + help.c + import.c + inactive.c + interpreter.c + list.c + merge.c + offline.c + online.c + recover.c + remove.c + repair.c + rescan.c + retain.c + san.c + select.c + setid.c + shrink.c + uniqueid.c + diskpart.h) +add_executable(diskpart ${SOURCE} diskpart.rc) set_module_type(diskpart win32cui UNICODE) add_importlibs(diskpart user32 msvcrt advapi32 kernel32) if(MSVC) add_importlibs(diskpart ntdll) endif() +add_pch(diskpart diskpart.h SOURCE) add_cd_file(TARGET diskpart DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/system/msiexec/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/msiexec/CMakeL… ============================================================================== --- trunk/reactos/base/system/msiexec/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/system/msiexec/CMakeLists.txt [iso-8859-1] Sun Feb 9 10:40:34 2014 @@ -3,12 +3,15 @@ include_directories(${REACTOS_SOURCE_DIR}/include/wine) -add_executable(msiexec +list(APPEND SOURCE msiexec.c service.c - rsrc.rc) + precomp.h) + +add_executable(msiexec ${SOURCE} rsrc.rc) set_module_type(msiexec win32gui) target_link_libraries(msiexec uuid wine) add_importlibs(msiexec user32 advapi32 ole32 msi msvcrt kernel32 ntdll) +add_pch(msiexec precomp.h SOURCE) add_cd_file(TARGET msiexec DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/system/services/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/CMake… ============================================================================== --- trunk/reactos/base/system/services/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/system/services/CMakeLists.txt [iso-8859-1] Sun Feb 9 10:40:34 2014 @@ -16,10 +16,10 @@ lock.c rpcserver.c services.c - services.rc + services.h ${CMAKE_CURRENT_BINARY_DIR}/svcctl_s.c) -add_executable(services ${SOURCE}) +add_executable(services ${SOURCE} services.rc) if(NOT MSVC) target_link_libraries(services ${PSEH_LIB}) @@ -27,5 +27,5 @@ set_module_type(services win32gui UNICODE) add_importlibs(services user32 advapi32 rpcrt4 msvcrt kernel32 ntdll) -add_pch(services services.h ${CMAKE_CURRENT_BINARY_DIR}/svcctl_s.h) +add_pch(services services.h SOURCE) add_cd_file(TARGET services DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/system/smss/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/CMakeList… ============================================================================== --- trunk/reactos/base/system/smss/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/system/smss/CMakeLists.txt [iso-8859-1] Sun Feb 9 10:40:34 2014 @@ -11,11 +11,11 @@ smsubsys.c smutil.c smss.c - smss.rc) + smss.h) -add_executable(smss WIN32 ${SOURCE}) +add_executable(smss WIN32 ${SOURCE} smss.rc) target_link_libraries(smss nt ${PSEH_LIB} smlib) -add_pch(smss smss.h) set_module_type(smss nativecui) add_importlibs(smss ntdll) +add_pch(smss smss.h SOURCE) add_cd_file(TARGET smss DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/system/winlogon/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/winlogon/CMake… ============================================================================== --- trunk/reactos/base/system/winlogon/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/system/winlogon/CMakeLists.txt [iso-8859-1] Sun Feb 9 10:40:34 2014 @@ -6,13 +6,11 @@ setup.c winlogon.c wlx.c - winlogon.rc) + winlogon.h) -add_executable(winlogon ${SOURCE}) - +add_executable(winlogon ${SOURCE} winlogon.rc) target_link_libraries(winlogon wine) - set_module_type(winlogon win32gui) add_importlibs(winlogon user32 advapi32 userenv secur32 msvcrt kernel32 ntdll) -add_pch(winlogon winlogon.h) +add_pch(winlogon winlogon.h SOURCE) add_cd_file(TARGET winlogon DESTINATION reactos/system32 FOR all)

10 years, 7 months

[janderwald] 62062: [NETSHELL] - fix identation - found by Christoph

by janderwald＠svn.reactos.org

Author: janderwald Date: Sun Feb 9 10:24:31 2014 New Revision: 62062 URL: http://svn.reactos.org/svn/reactos?rev=62062&view=rev Log: [NETSHELL] - fix identation - found by Christoph Modified: trunk/reactos/dll/win32/netshell/lanconnectui.cpp Modified: trunk/reactos/dll/win32/netshell/lanconnectui.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netshell/lanconn… ============================================================================== --- trunk/reactos/dll/win32/netshell/lanconnectui.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netshell/lanconnectui.cpp [iso-8859-1] Sun Feb 9 10:24:31 2014 @@ -54,7 +54,7 @@ VOID EnumComponents(HWND hDlgCtrl, INetCfg *pNCfg, const GUID *CompGuid, UINT Type); VOID InitializeLANPropertiesUIDlg(HWND hwndDlg); VOID ShowNetworkComponentProperties(HWND hwndDlg); - BOOL GetDeviceInstanceID(OUT LPOLESTR *DeviceInstanceID); + BOOL GetDeviceInstanceID(OUT LPOLESTR *DeviceInstanceID); static INT_PTR CALLBACK LANPropertiesUIDlg(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam); INetConnection * pCon;

10 years, 7 months

← Newer
1
...
27
28
29
30
31
32
33
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs February 2014