Author: akhaldi
Date: Sat May 23 12:24:57 2015
New Revision: 67864
URL: http://svn.reactos.org/svn/reactos?rev=67864&view=rev
Log:
[CMAKE] Do not treat C4189 as an error in Release builds.
Modified:
trunk/reactos/cmake/msvc.cmake
Modified: trunk/reactos/cmake/msvc.cmake
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=67864…
==============================================================================
--- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original)
+++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Sat May 23 12:24:57 2015
@@ -74,6 +74,10 @@
# Enable warnings above the default level, but don't treat them as errors:
# - C4115: named type definition in parentheses
add_compile_flags("/w14115")
+
+if(CMAKE_BUILD_TYPE STREQUAL "Release")
+ add_compile_flags("/w14189")
+endif()
# Debugging
#if(${CMAKE_BUILD_TYPE} STREQUAL "Debug")
Author: akhaldi
Date: Sat May 23 11:45:59 2015
New Revision: 67862
URL: http://svn.reactos.org/svn/reactos?rev=67862&view=rev
Log:
[CMAKE] Default to Debug for the build type in GCC builds.
Modified:
trunk/reactos/CMakeLists.txt
trunk/reactos/toolchain-gcc.cmake
Modified: trunk/reactos/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=67862&r…
==============================================================================
--- trunk/reactos/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/CMakeLists.txt [iso-8859-1] Sat May 23 11:45:59 2015
@@ -45,12 +45,6 @@
# See http://cmake.3232098.n2.nabble.com/Case-insensitive-string-compare-td758026…
# for more information.
string(TOLOWER ${ARCH} ARCH)
-
-# Default to Debug for the build type
-if(NOT CMAKE_BUILD_TYPE)
- set(CMAKE_BUILD_TYPE "Debug" CACHE STRING
- "Choose the type of build, options are: None(CMAKE_CXX_FLAGS or CMAKE_C_FLAGS used) Debug Release RelWithDebInfo MinSizeRel.")
-endif()
# Compile options
if(ARCH STREQUAL "i386")
Modified: trunk/reactos/toolchain-gcc.cmake
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/toolchain-gcc.cmake?rev=67…
==============================================================================
--- trunk/reactos/toolchain-gcc.cmake [iso-8859-1] (original)
+++ trunk/reactos/toolchain-gcc.cmake [iso-8859-1] Sat May 23 11:45:59 2015
@@ -1,6 +1,12 @@
if(NOT ARCH)
set(ARCH i386)
+endif()
+
+# Default to Debug for the build type
+if(NOT DEFINED CMAKE_BUILD_TYPE)
+ set(CMAKE_BUILD_TYPE "Debug" CACHE STRING
+ "Choose the type of build, options are: None(CMAKE_CXX_FLAGS or CMAKE_C_FLAGS used) Debug Release RelWithDebInfo MinSizeRel.")
endif()
# Choose the right MinGW toolchain prefix
Author: akhaldi
Date: Sat May 23 10:31:52 2015
New Revision: 67859
URL: http://svn.reactos.org/svn/reactos?rev=67859&view=rev
Log:
[CMAKE] Fix setting CMake build type so we can use other types too (like Release).
Modified:
trunk/reactos/CMakeLists.txt
Modified: trunk/reactos/CMakeLists.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeLists.txt?rev=67859&r…
==============================================================================
--- trunk/reactos/CMakeLists.txt [iso-8859-1] (original)
+++ trunk/reactos/CMakeLists.txt [iso-8859-1] Sat May 23 10:31:52 2015
@@ -47,8 +47,10 @@
string(TOLOWER ${ARCH} ARCH)
# Default to Debug for the build type
-set(CMAKE_BUILD_TYPE "Debug" CACHE STRING
- "Choose the type of build, options are: None(CMAKE_CXX_FLAGS or CMAKE_C_FLAGS used) Debug Release RelWithDebInfo MinSizeRel." FORCE)
+if(NOT CMAKE_BUILD_TYPE)
+ set(CMAKE_BUILD_TYPE "Debug" CACHE STRING
+ "Choose the type of build, options are: None(CMAKE_CXX_FLAGS or CMAKE_C_FLAGS used) Debug Release RelWithDebInfo MinSizeRel.")
+endif()
# Compile options
if(ARCH STREQUAL "i386")