Ros-diffs May 2015

ros-diffs@reactos.org

15 participants
500 discussions

[hbelusca] 67854: [NTVDM]: Temporarily disable yielding (see r67851) because it causes timing issues (slowdowns).
by hbelusca＠svn.reactos.org 23 May '15

23 May '15

Author: hbelusca Date: Sat May 23 02:08:50 2015 New Revision: 67854 URL: http://svn.reactos.org/svn/reactos?rev=67854&view=rev Log: [NTVDM]: Temporarily disable yielding (see r67851) because it causes timing issues (slowdowns). Modified: trunk/reactos/subsystems/mvdm/ntvdm/clock.c Modified: trunk/reactos/subsystems/mvdm/ntvdm/clock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/cloc… ============================================================================== --- trunk/reactos/subsystems/mvdm/ntvdm/clock.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/mvdm/ntvdm/clock.c [iso-8859-1] Sat May 23 02:08:50 2015 @@ -120,7 +120,8 @@ } /* Yield execution to other threads */ - NtYieldExecution(); + // FIXME: Disabled because it causes timing issues (slowdowns). + // NtYieldExecution(); } }

1 0

[aandrejevic] 67853: [FAST486] Fix FIST(P) and FRNDINT.
by aandrejevic＠svn.reactos.org 22 May '15

22 May '15

Author: aandrejevic Date: Fri May 22 23:09:13 2015 New Revision: 67853 URL: http://svn.reactos.org/svn/reactos?rev=67853&view=rev Log: [FAST486] Fix FIST(P) and FRNDINT. Modified: trunk/reactos/lib/fast486/fpu.c Modified: trunk/reactos/lib/fast486/fpu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/fpu.c?rev=6785… ============================================================================== --- trunk/reactos/lib/fast486/fpu.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/fpu.c [iso-8859-1] Fri May 22 23:09:13 2015 @@ -2086,7 +2086,7 @@ /* Round the result to an integer, towards zero */ if (FPU_ST(0).Exponent < FPU_REAL10_BIAS + 63) { - State->FpuControl.Rc = FPU_ROUND_DOWN; + State->FpuControl.Rc = FPU_ROUND_TRUNCATE; if (Fast486FpuToInteger(State, &Temp, &Integer)) { @@ -2543,7 +2543,7 @@ } /* Check if it can fit in a signed 32-bit integer */ - if ((((ULONGLONG)Temp >> 31) + 1ULL) > 1ULL) + if ((LONGLONG)((LONG)Temp) != Temp) { State->FpuStatus.Ie = TRUE; @@ -3240,7 +3240,7 @@ } /* Check if it can fit in a signed 16-bit integer */ - if ((((ULONGLONG)Temp >> 15) + 1ULL) > 1ULL) + if ((LONGLONG)((SHORT)Temp) != Temp) { /* Raise the invalid operation exception */ State->FpuStatus.Ie = TRUE;

1 0

[aandrejevic] 67852: [FAST486] Fix multiple FP80-to-int conversion issues.
by aandrejevic＠svn.reactos.org 22 May '15

22 May '15

Author: aandrejevic Date: Fri May 22 21:57:28 2015 New Revision: 67852 URL: http://svn.reactos.org/svn/reactos?rev=67852&view=rev Log: [FAST486] Fix multiple FP80-to-int conversion issues. Modified: trunk/reactos/lib/fast486/fpu.c Modified: trunk/reactos/lib/fast486/fpu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/fpu.c?rev=6785… ============================================================================== --- trunk/reactos/lib/fast486/fpu.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/fpu.c [iso-8859-1] Fri May 22 21:57:28 2015 @@ -317,7 +317,7 @@ if (State->FpuControl.Im) { - *Result = 0LL; + *Result = 0x8000000000000000LL; return TRUE; } else @@ -339,16 +339,15 @@ { /* The result is zero */ *Result = 0LL; - - if (UnbiasedExp > -64) - { - Bits = 65 + UnbiasedExp; - Remainder = Value->Mantissa >> (64 - Bits); + Bits = 64; + + if (UnbiasedExp >= -64) + { + Remainder = Value->Mantissa >> (-1 - UnbiasedExp); } else { /* Too small to even have a remainder */ - Bits = 1; Remainder = 0ULL; } } @@ -2536,7 +2535,8 @@ return; } } - else if (!Fast486FpuToInteger(State, &FPU_ST(0), &Temp)) + + if (!Fast486FpuToInteger(State, &FPU_ST(0), &Temp)) { /* Exception occurred */ return; @@ -2547,7 +2547,10 @@ { State->FpuStatus.Ie = TRUE; - if (State->FpuControl.Im) Temp = 0LL; + if (State->FpuControl.Im) + { + Temp = 0x80000000LL; + } else { Fast486FpuException(State); @@ -3229,7 +3232,8 @@ return; } } - else if (!Fast486FpuToInteger(State, &FPU_ST(0), &Temp)) + + if (!Fast486FpuToInteger(State, &FPU_ST(0), &Temp)) { /* Exception occurred */ return; @@ -3241,7 +3245,10 @@ /* Raise the invalid operation exception */ State->FpuStatus.Ie = TRUE; - if (State->FpuControl.Im) Temp = 0LL; + if (State->FpuControl.Im) + { + Temp = 0x8000LL; + } else { Fast486FpuException(State); @@ -3365,7 +3372,8 @@ return; } } - else if (!Fast486FpuToInteger(State, &FPU_ST(0), &Temp)) + + if (!Fast486FpuToInteger(State, &FPU_ST(0), &Temp)) { /* Exception occurred */ return;

1 0

[hbelusca] 67851: [NTVDM]: at the end of a cpu slice, yield execution to other threads in the system.
by hbelusca＠svn.reactos.org 22 May '15

22 May '15

Author: hbelusca Date: Fri May 22 21:21:43 2015 New Revision: 67851 URL: http://svn.reactos.org/svn/reactos?rev=67851&view=rev Log: [NTVDM]: at the end of a cpu slice, yield execution to other threads in the system. Modified: trunk/reactos/subsystems/mvdm/ntvdm/clock.c Modified: trunk/reactos/subsystems/mvdm/ntvdm/clock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/cloc… ============================================================================== --- trunk/reactos/subsystems/mvdm/ntvdm/clock.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/mvdm/ntvdm/clock.c [iso-8859-1] Fri May 22 21:21:43 2015 @@ -118,13 +118,16 @@ /* Update the time of the last timer tick */ Timer->LastTick.QuadPart += Ticks * Timer->Delay; } + + /* Yield execution to other threads */ + NtYieldExecution(); } } PHARDWARE_TIMER CreateHardwareTimer(ULONG Flags, ULONGLONG Delay, PHARDWARE_TIMER_PROC Callback) { PHARDWARE_TIMER Timer; - + Timer = RtlAllocateHeap(RtlGetProcessHeap(), 0, sizeof(*Timer)); if (Timer == NULL) return NULL;

1 0

[tfaber] 67850: [ADVAPI32] - Do not fail in RegQueryInfoKeyW if NtQuerySecurityObject fails, as shown by the test CORE-9719
by tfaber＠svn.reactos.org 22 May '15

22 May '15

Author: tfaber Date: Fri May 22 16:19:23 2015 New Revision: 67850 URL: http://svn.reactos.org/svn/reactos?rev=67850&view=rev Log: [ADVAPI32] - Do not fail in RegQueryInfoKeyW if NtQuerySecurityObject fails, as shown by the test CORE-9719 Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/reg/reg… ============================================================================== --- trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] Fri May 22 16:19:23 2015 @@ -3781,12 +3781,9 @@ NULL, 0, lpcbSecurityDescriptor); - if (!NT_SUCCESS(Status) && Status != STATUS_BUFFER_TOO_SMALL) - { - ERR("NtQuerySecurityObject for key %p (%p) failed with %lx\n", - KeyHandle, hKey, Status); - ErrorCode = RtlNtStatusToDosError(Status); - goto Cleanup; + if (Status != STATUS_BUFFER_TOO_SMALL) + { + *lpcbSecurityDescriptor = 0; } }

1 0

[tfaber] 67849: [ADVAPI32_APITEST] - Fix test failures on Win 2003: unlike on Win7, write rights don't imply read CORE-9719
by tfaber＠svn.reactos.org 22 May '15

22 May '15

Author: tfaber Date: Fri May 22 16:06:58 2015 New Revision: 67849 URL: http://svn.reactos.org/svn/reactos?rev=67849&view=rev Log: [ADVAPI32_APITEST] - Fix test failures on Win 2003: unlike on Win7, write rights don't imply read CORE-9719 Modified: trunk/rostests/apitests/advapi32/RegQueryInfoKey.c Modified: trunk/rostests/apitests/advapi32/RegQueryInfoKey.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/advapi32/RegQuer… ============================================================================== --- trunk/rostests/apitests/advapi32/RegQueryInfoKey.c [iso-8859-1] (original) +++ trunk/rostests/apitests/advapi32/RegQueryInfoKey.c [iso-8859-1] Fri May 22 16:06:58 2015 @@ -63,13 +63,13 @@ TestKeyAccess(KEY_QUERY_VALUE, NO_ERROR, FALSE); /* With the two combined we get everything */ TestKeyAccess(KEY_QUERY_VALUE | READ_CONTROL, NO_ERROR, TRUE); - /* Write rights give us everything too */ - TestKeyAccess(KEY_SET_VALUE, NO_ERROR, TRUE); - TestKeyAccess(KEY_CREATE_SUB_KEY, NO_ERROR, TRUE); - TestKeyAccess(KEY_CREATE_LINK, NO_ERROR, TRUE); - TestKeyAccess(DELETE, NO_ERROR, TRUE); - TestKeyAccess(WRITE_DAC, NO_ERROR, TRUE); - TestKeyAccess(WRITE_OWNER, NO_ERROR, TRUE); + /* Write rights return nothing on 2003 (but succeed and return SD size on Win7) */ + TestKeyAccess(KEY_SET_VALUE, ERROR_ACCESS_DENIED, FALSE); + TestKeyAccess(KEY_CREATE_SUB_KEY, ERROR_ACCESS_DENIED, FALSE); + TestKeyAccess(KEY_CREATE_LINK, ERROR_ACCESS_DENIED, FALSE); + TestKeyAccess(DELETE, ERROR_ACCESS_DENIED, FALSE); + TestKeyAccess(WRITE_DAC, ERROR_ACCESS_DENIED, FALSE); + TestKeyAccess(WRITE_OWNER, ERROR_ACCESS_DENIED, FALSE); /* But these return nothing */ TestKeyAccess(KEY_ENUMERATE_SUB_KEYS, ERROR_ACCESS_DENIED, FALSE); TestKeyAccess(KEY_NOTIFY, ERROR_ACCESS_DENIED, FALSE);

1 0

[tfaber] 67848: [ADVAPI32_APITEST] - Add a test for calling RegQueryInfoKey with different access rights CORE-9719
by tfaber＠svn.reactos.org 22 May '15

22 May '15

Author: tfaber Date: Fri May 22 15:47:02 2015 New Revision: 67848 URL: http://svn.reactos.org/svn/reactos?rev=67848&view=rev Log: [ADVAPI32_APITEST] - Add a test for calling RegQueryInfoKey with different access rights CORE-9719 Added: trunk/rostests/apitests/advapi32/RegQueryInfoKey.c (with props) Modified: trunk/rostests/apitests/advapi32/CMakeLists.txt trunk/rostests/apitests/advapi32/testlist.c Modified: trunk/rostests/apitests/advapi32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/advapi32/CMakeLi… ============================================================================== --- trunk/rostests/apitests/advapi32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/apitests/advapi32/CMakeLists.txt [iso-8859-1] Fri May 22 15:47:02 2015 @@ -6,6 +6,7 @@ LockDatabase.c QueryServiceConfig2.c RegEnumValueW.c + RegQueryInfoKey.c RtlEncryptMemory.c SaferIdentifyLevel.c testlist.c) Added: trunk/rostests/apitests/advapi32/RegQueryInfoKey.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/advapi32/RegQuer… ============================================================================== --- trunk/rostests/apitests/advapi32/RegQueryInfoKey.c (added) +++ trunk/rostests/apitests/advapi32/RegQueryInfoKey.c [iso-8859-1] Fri May 22 15:47:02 2015 @@ -0,0 +1,76 @@ +/* + * PROJECT: ReactOS api tests + * LICENSE: LGPLv2.1+ - See COPYING.Lib in the top level directory + * PURPOSE: Test for RegQueryInfoKey + * PROGRAMMER: Thomas Faber <thomas.faber(a)reactos.org> + */ + +#include <apitest.h> + +#define WIN32_NO_STATUS +#include <winreg.h> + +#define TestKeyAccess(da, er, es) TestKeyAccess_(__FILE__, __LINE__, da, er, es) +static +VOID +TestKeyAccess_( + _In_ PCSTR File, + _In_ INT Line, + _In_ REGSAM DesiredAccess, + _In_ LONG ExpectedReturn, + _In_ BOOLEAN ExpectSd) +{ + DWORD cbSd; + HKEY hKey; + LONG ret; + + ret = RegOpenKeyExW(HKEY_LOCAL_MACHINE, L"Software", 0, DesiredAccess, &hKey); + ok_(File, Line)(ret == NO_ERROR, "RegOpenKeyEx returned %ld\n", ret); + if (ret == NO_ERROR) + { + cbSd = 0x55555555; + ret = RegQueryInfoKeyW(hKey, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, &cbSd, NULL); + ok_(File, Line)(ret == ExpectedReturn, "RegQueryInfoKeyW returned %ld\n", ret); + if (ExpectSd) + ok_(File, Line)(cbSd != 0 && cbSd != 0x55555555, "RegQueryInfoKeyW - cbSd = %lu\n", cbSd); + else + ok_(File, Line)(cbSd == 0, "RegQueryInfoKeyW - cbSd = %lu\n", cbSd); + + cbSd = 0x55555555; + ret = RegQueryInfoKeyA(hKey, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, &cbSd, NULL); + ok_(File, Line)(ret == ExpectedReturn, "RegQueryInfoKeyA returned %ld\n", ret); + if (ExpectSd) + ok_(File, Line)(cbSd != 0 && cbSd != 0x55555555, "RegQueryInfoKeyA - cbSd = %lu\n", cbSd); + else + ok_(File, Line)(cbSd == 0, "RegQueryInfoKeyA - cbSd = %lu\n", cbSd); + ret = RegCloseKey(hKey); + ok_(File, Line)(ret == NO_ERROR, "RegCloseKey returned %ld\n", ret); + } + else + { + skip_(File, Line)("No key handle\n"); + } +} + +START_TEST(RegQueryInfoKey) +{ + /* 0 access just fails the open */ + if (0) + TestKeyAccess(0, ERROR_ACCESS_DENIED, FALSE); + /* Without KEY_QUERY_VALUE we can't query anything */ + TestKeyAccess(READ_CONTROL, ERROR_ACCESS_DENIED, FALSE); + /* Without READ_CONTROL we'll get success but SD size will yield 0 */ + TestKeyAccess(KEY_QUERY_VALUE, NO_ERROR, FALSE); + /* With the two combined we get everything */ + TestKeyAccess(KEY_QUERY_VALUE | READ_CONTROL, NO_ERROR, TRUE); + /* Write rights give us everything too */ + TestKeyAccess(KEY_SET_VALUE, NO_ERROR, TRUE); + TestKeyAccess(KEY_CREATE_SUB_KEY, NO_ERROR, TRUE); + TestKeyAccess(KEY_CREATE_LINK, NO_ERROR, TRUE); + TestKeyAccess(DELETE, NO_ERROR, TRUE); + TestKeyAccess(WRITE_DAC, NO_ERROR, TRUE); + TestKeyAccess(WRITE_OWNER, NO_ERROR, TRUE); + /* But these return nothing */ + TestKeyAccess(KEY_ENUMERATE_SUB_KEYS, ERROR_ACCESS_DENIED, FALSE); + TestKeyAccess(KEY_NOTIFY, ERROR_ACCESS_DENIED, FALSE); +} Propchange: trunk/rostests/apitests/advapi32/RegQueryInfoKey.c ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/rostests/apitests/advapi32/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/advapi32/testlis… ============================================================================== --- trunk/rostests/apitests/advapi32/testlist.c [iso-8859-1] (original) +++ trunk/rostests/apitests/advapi32/testlist.c [iso-8859-1] Fri May 22 15:47:02 2015 @@ -9,6 +9,7 @@ extern void func_LockDatabase(void); extern void func_QueryServiceConfig2(void); extern void func_RegEnumValueW(void); +extern void func_RegQueryInfoKey(void); extern void func_RtlEncryptMemory(void); extern void func_SaferIdentifyLevel(void); @@ -19,7 +20,8 @@ { "HKEY_CLASSES_ROOT", func_HKEY_CLASSES_ROOT }, { "LockDatabase" , func_LockDatabase }, { "QueryServiceConfig2", func_QueryServiceConfig2 }, - { "RegEnumValueW", func_RegEnumValueW}, + { "RegEnumValueW", func_RegEnumValueW }, + { "RegQueryInfoKey", func_RegQueryInfoKey }, { "RtlEncryptMemory", func_RtlEncryptMemory }, { "SaferIdentifyLevel", func_SaferIdentifyLevel },

1 0

[cfinck] 67847: Time to commit some Work-In-Progress stuff before my diff gets too large.. [LOCALSPL] - Begin work on the Local Spooler. Return a structure with function pointers in InitializePrint...
by cfinck＠svn.reactos.org 22 May '15

22 May '15

Author: cfinck Date: Fri May 22 15:29:07 2015 New Revision: 67847 URL: http://svn.reactos.org/svn/reactos?rev=67847&view=rev Log: Time to commit some Work-In-Progress stuff before my diff gets too large.. [LOCALSPL] - Begin work on the Local Spooler. Return a structure with function pointers in InitializePrintProvidor. - Design and document internal structures for managing LocalSpl Handles, Printer Handles, Printers, Print Jobs and Print Processors. Manage Printers and Print Processors in Generic Tables, with one Job Queue per Printer managed as a Doubly Linked List. - Implement LocalOpenPrinter, LocalEnumPrintProcessorDatatypes, LocalEnumPrintProcessors, LocalGetPrintProcessorDirectory, with focus on catching all corner cases. Currently working on LocalStartDocPrinter. - Build upon the documentation at http://www.undocprint.org/formats/winspool/shd to read and write .SHD files. [WINPRINT] Begin work on the Standard Print Processor. Implement EnumPrintProcessorDatatypesW. [WINSPOOL_APITEST] Add an API Test for winspool.drv, currently testing some corner cases of ClosePrinter, EnumPrintProcessorDatatypesW, GetPrintProcessorDirectoryW, OpenPrinterW, StartDocPrinterW. TODO: Find a way to actually test the localspl.dll functions instead of only winspool.drv. This DLL doesn't like to be tested standalone under Windows, e.g. without being used through spoolsv/spoolss. [SPOOLSS] Implement InitializeRouter by calling the InitializePrintProvidor function of localspl there. This function should later also initialize further Print Providers. [SPOOLSV] Call InitializeRouter when starting up the service. [WINSPOOL] Add dummy functions for EnumPrintProcessorDatatypesA/EnumPrintProcessorDatatypesW. [All modules] Fix printf format specifiers for errors (%lu) and statuses (%ld). Added: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/jobs.c (with props) branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/printers.c (with props) branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/printprocessors.c (with props) branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/tools.c (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/ (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/CMakeLists.txt (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/ClosePrinter.c (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/EnumPrintProcessorDatatypes.c (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/GetPrintProcessorDirectory.c (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/OpenPrinter.c (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/StartDocPrinter.c (with props) branches/colins-printing-for-freedom/rostests/apitests/winspool/testlist.c (with props) Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/context.c branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/main.c branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/precomp.h branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/init.c branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/main.c branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/precomp.h branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/rpcserver.c branches/colins-printing-for-freedom/reactos/win32ss/printing/base/winspool/main.c branches/colins-printing-for-freedom/reactos/win32ss/printing/base/winspool/winspool.spec branches/colins-printing-for-freedom/reactos/win32ss/printing/processors/winprint/CMakeLists.txt branches/colins-printing-for-freedom/reactos/win32ss/printing/processors/winprint/main.c branches/colins-printing-for-freedom/reactos/win32ss/printing/processors/winprint/winprint.spec branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/CMakeLists.txt branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/main.c branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/precomp.h branches/colins-printing-for-freedom/rostests/apitests/CMakeLists.txt [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/context.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/main.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolss/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/init.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/main.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/spoolsv/rpcserver.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/winspool/main.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/base/winspool/winspool.spec URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/processors/winprint/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/processors/winprint/main.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/processors/winprint/winprint.spec URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Added: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/jobs.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/main.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Added: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/printers.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Added: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/printprocessors.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Added: branches/colins-printing-for-freedom/reactos/win32ss/printing/providers/localspl/tools.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… Modified: branches/colins-printing-for-freedom/rostests/apitests/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros… Added: branches/colins-printing-for-freedom/rostests/apitests/winspool/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros… Added: branches/colins-printing-for-freedom/rostests/apitests/winspool/ClosePrinter.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros… Added: branches/colins-printing-for-freedom/rostests/apitests/winspool/EnumPrintProcessorDatatypes.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros… Added: branches/colins-printing-for-freedom/rostests/apitests/winspool/GetPrintProcessorDirectory.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros… Added: branches/colins-printing-for-freedom/rostests/apitests/winspool/OpenPrinter.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros… Added: branches/colins-printing-for-freedom/rostests/apitests/winspool/StartDocPrinter.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros… Added: branches/colins-printing-for-freedom/rostests/apitests/winspool/testlist.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/ros…

1 0

[aandrejevic] 67846: [FAST486] Fix Fast486FpuToInteger.
by aandrejevic＠svn.reactos.org 22 May '15

22 May '15

Author: aandrejevic Date: Fri May 22 04:51:20 2015 New Revision: 67846 URL: http://svn.reactos.org/svn/reactos?rev=67846&view=rev Log: [FAST486] Fix Fast486FpuToInteger. Modified: trunk/reactos/lib/fast486/fpu.c Modified: trunk/reactos/lib/fast486/fpu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/fpu.c?rev=6784… ============================================================================== --- trunk/reactos/lib/fast486/fpu.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/fpu.c [iso-8859-1] Fri May 22 04:51:20 2015 @@ -310,8 +310,7 @@ return TRUE; } - if (FPU_IS_NAN(Value) || !FPU_IS_NORMALIZED(Value) - || (UnbiasedExp < 0) || (UnbiasedExp > 63)) + if (FPU_IS_NAN(Value) || !FPU_IS_NORMALIZED(Value) || (UnbiasedExp >= 63)) { /* Raise an invalid operation exception */ State->FpuStatus.Ie = TRUE; @@ -328,11 +327,31 @@ } } - Bits = 63 - UnbiasedExp; - - /* Calculate the result and the remainder */ - *Result = (LONGLONG)(Value->Mantissa >> Bits); - Remainder = Value->Mantissa & ((1 << Bits) - 1); + if (UnbiasedExp >= 0) + { + Bits = 63 - UnbiasedExp; + + /* Calculate the result and the remainder */ + *Result = (LONGLONG)(Value->Mantissa >> Bits); + Remainder = Value->Mantissa & ((1 << Bits) - 1); + } + else + { + /* The result is zero */ + *Result = 0LL; + + if (UnbiasedExp > -64) + { + Bits = 65 + UnbiasedExp; + Remainder = Value->Mantissa >> (64 - Bits); + } + else + { + /* Too small to even have a remainder */ + Bits = 1; + Remainder = 0ULL; + } + } /* The result must be positive here */ ASSERT(*Result >= 0LL);

1 0

[aandrejevic] 67845: [FAST486] Implement FPREM and FPREM1.
by aandrejevic＠svn.reactos.org 22 May '15

22 May '15

Author: aandrejevic Date: Fri May 22 03:59:24 2015 New Revision: 67845 URL: http://svn.reactos.org/svn/reactos?rev=67845&view=rev Log: [FAST486] Implement FPREM and FPREM1. Modified: trunk/reactos/lib/fast486/fpu.c Modified: trunk/reactos/lib/fast486/fpu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/fast486/fpu.c?rev=6784… ============================================================================== --- trunk/reactos/lib/fast486/fpu.c [iso-8859-1] (original) +++ trunk/reactos/lib/fast486/fpu.c [iso-8859-1] Fri May 22 03:59:24 2015 @@ -1990,9 +1990,46 @@ /* FPREM1 */ case 0x35: { - // TODO: NOT IMPLEMENTED - UNIMPLEMENTED; - + FAST486_FPU_DATA_REG Temp; + LONGLONG Integer; + INT OldRoundingMode = State->FpuControl.Rc; + + if (FPU_GET_TAG(0) == FPU_TAG_EMPTY || FPU_GET_TAG(1) == FPU_TAG_EMPTY) + { + State->FpuStatus.Ie = TRUE; + + if (!State->FpuControl.Im) Fast486FpuException(State); + break; + } + + /* Divide ST0 by ST1 */ + if (!Fast486FpuDivide(State, &FPU_ST(0), &FPU_ST(1), &Temp)) break; + + /* Round the result to the nearest integer */ + if (FPU_ST(0).Exponent < FPU_REAL10_BIAS + 63) + { + State->FpuControl.Rc = FPU_ROUND_NEAREST; + + if (Fast486FpuToInteger(State, &Temp, &Integer)) + { + Fast486FpuFromInteger(State, Integer, &Temp); + State->FpuControl.Rc = OldRoundingMode; + } + else + { + /* Restore the rounding mode and exit */ + State->FpuControl.Rc = OldRoundingMode; + break; + } + } + + /* Multiply the result by ST1 */ + if (!Fast486FpuMultiply(State, &Temp, &FPU_ST(1), &Temp)) break; + + /* Subtract the result from ST0 */ + if (!Fast486FpuSubtract(State, &FPU_ST(0), &Temp, &FPU_ST(0))) break; + + FPU_UPDATE_TAG(0); break; } @@ -2013,9 +2050,46 @@ /* FPREM */ case 0x38: { - // TODO: NOT IMPLEMENTED - UNIMPLEMENTED; - + FAST486_FPU_DATA_REG Temp; + LONGLONG Integer; + INT OldRoundingMode = State->FpuControl.Rc; + + if (FPU_GET_TAG(0) == FPU_TAG_EMPTY || FPU_GET_TAG(1) == FPU_TAG_EMPTY) + { + State->FpuStatus.Ie = TRUE; + + if (!State->FpuControl.Im) Fast486FpuException(State); + break; + } + + /* Divide ST0 by ST1 */ + if (!Fast486FpuDivide(State, &FPU_ST(0), &FPU_ST(1), &Temp)) break; + + /* Round the result to an integer, towards zero */ + if (FPU_ST(0).Exponent < FPU_REAL10_BIAS + 63) + { + State->FpuControl.Rc = FPU_ROUND_DOWN; + + if (Fast486FpuToInteger(State, &Temp, &Integer)) + { + Fast486FpuFromInteger(State, Integer, &Temp); + State->FpuControl.Rc = OldRoundingMode; + } + else + { + /* Restore the rounding mode and exit */ + State->FpuControl.Rc = OldRoundingMode; + break; + } + } + + /* Multiply the result by ST1 */ + if (!Fast486FpuMultiply(State, &Temp, &FPU_ST(1), &Temp)) break; + + /* Subtract the result from ST0 */ + if (!Fast486FpuSubtract(State, &FPU_ST(0), &Temp, &FPU_ST(0))) break; + + FPU_UPDATE_TAG(0); break; }

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
50
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs May 2015