Ros-diffs September 2015

ros-diffs@reactos.org

17 participants
535 discussions

[pschweitzer] 69000: [NTFS] Don't attempt to dereference a null pointer CID 1321987
by pschweitzer＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: pschweitzer Date: Fri Sep 4 15:37:15 2015 New Revision: 69000 URL: http://svn.reactos.org/svn/reactos?rev=69000&view=rev Log: [NTFS] Don't attempt to dereference a null pointer CID 1321987 Modified: trunk/reactos/drivers/filesystems/ntfs/fcb.c Modified: trunk/reactos/drivers/filesystems/ntfs/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/ntfs/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ntfs/fcb.c [iso-8859-1] Fri Sep 4 15:37:15 2015 @@ -414,7 +414,7 @@ pathName[FileName->NameLength] = UNICODE_NULL; } - Size = NtfsGetFileSize(Vcb, Record, Stream, wcslen(Stream), &AllocatedSize); + Size = NtfsGetFileSize(Vcb, Record, (Stream ? Stream : L""), (Stream ? wcslen(Stream) : 0), &AllocatedSize); rcFCB = NtfsCreateFCB(pathName, Stream, Vcb); if (!rcFCB)

1 0

[tfaber] 68999: [BOOTMGFW] - Fix build with RUNTIME_CHECKS (and hopefully STACK_PROTECTOR)
by tfaber＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: tfaber Date: Fri Sep 4 15:33:12 2015 New Revision: 68999 URL: http://svn.reactos.org/svn/reactos?rev=68999&view=rev Log: [BOOTMGFW] - Fix build with RUNTIME_CHECKS (and hopefully STACK_PROTECTOR) Modified: trunk/reactos/boot/environ/CMakeLists.txt Modified: trunk/reactos/boot/environ/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/CMakeLists.tx… ============================================================================== --- trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] Fri Sep 4 15:33:12 2015 @@ -61,6 +61,12 @@ target_link_libraries(bootmgfw bootmgr_common cportlib cmlib rtl libcntpr) +if(STACK_PROTECTOR) + target_link_libraries(bootmgfw gcc_ssp) +elseif(RUNTIME_CHECKS) + target_link_libraries(bootmgfw runtmchk) +endif() + add_dependencies(bootmgfw asm bugcodes) add_cd_file(TARGET bootmgfw FILE ${_bootmgfw_output_file} DESTINATION loader NO_CAB FOR bootcd regtest)

1 0

[tfaber] 68998: [TOOLS] - Fix MSVC warnings for C++ host-tools
by tfaber＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: tfaber Date: Fri Sep 4 15:22:16 2015 New Revision: 68998 URL: http://svn.reactos.org/svn/reactos?rev=68998&view=rev Log: [TOOLS] - Fix MSVC warnings for C++ host-tools Modified: trunk/reactos/tools/CMakeLists.txt trunk/reactos/tools/hhpcomp/CMakeLists.txt Modified: trunk/reactos/tools/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/CMakeLists.txt?rev=6… ============================================================================== --- trunk/reactos/tools/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/tools/CMakeLists.txt [iso-8859-1] Fri Sep 4 15:22:16 2015 @@ -11,6 +11,10 @@ add_executable(mkshelllink mkshelllink/mkshelllink.c) add_executable(obj2bin obj2bin/obj2bin.c) add_executable(spec2def spec2def/spec2def.c) + +if(MSVC) + set_property(SOURCE utf16le/utf16le.cpp APPEND_STRING PROPERTY COMPILE_FLAGS " /EHsc") +endif() add_executable(utf16le utf16le/utf16le.cpp) add_subdirectory(cabman) Modified: trunk/reactos/tools/hhpcomp/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/hhpcomp/CMakeLists.t… ============================================================================== --- trunk/reactos/tools/hhpcomp/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/tools/hhpcomp/CMakeLists.txt [iso-8859-1] Fri Sep 4 15:22:16 2015 @@ -12,5 +12,13 @@ # used by lzx_compress add_definitions(-DNONSLIDE) +if(MSVC) + set_property(SOURCE + hhpcomp.cpp + hhp_reader.cpp + utils.cpp + APPEND_STRING PROPERTY COMPILE_FLAGS " /EHsc") +endif() + add_executable(hhpcomp ${SOURCE}) target_link_libraries(hhpcomp)

1 0

[akhaldi] 68997: [BOOTMGFW] Add missing dependency.
by akhaldi＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: akhaldi Date: Fri Sep 4 14:45:40 2015 New Revision: 68997 URL: http://svn.reactos.org/svn/reactos?rev=68997&view=rev Log: [BOOTMGFW] Add missing dependency. Modified: trunk/reactos/boot/environ/CMakeLists.txt Modified: trunk/reactos/boot/environ/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/CMakeLists.tx… ============================================================================== --- trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] Fri Sep 4 14:45:40 2015 @@ -33,7 +33,7 @@ add_asm_files(bootmgr_common_asm ${BOOTMGR_COMMON_ASM_SOURCE}) add_library(bootmgr_common ${BOOTMGR_COMMON_SOURCE} ${bootmgr_common_asm}) add_pch(bootmgr_common app/bootmgr/bootmgr.h BOOTMGR_COMMON_SOURCE) -#add_dependencies(bootmgr_common bugcodes) +add_dependencies(bootmgr_common bugcodes) list(APPEND BOOTMGR_BASE_SOURCE app/bootmgr/efiemu.c

1 0

[akhaldi] 68996: [BOOTMGFW] Add missing dependency.
by akhaldi＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: akhaldi Date: Fri Sep 4 14:43:01 2015 New Revision: 68996 URL: http://svn.reactos.org/svn/reactos?rev=68996&view=rev Log: [BOOTMGFW] Add missing dependency. Modified: trunk/reactos/boot/environ/CMakeLists.txt Modified: trunk/reactos/boot/environ/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/CMakeLists.tx… ============================================================================== --- trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] Fri Sep 4 14:43:01 2015 @@ -61,7 +61,7 @@ target_link_libraries(bootmgfw bootmgr_common cportlib cmlib rtl libcntpr) -add_dependencies(bootmgfw asm) +add_dependencies(bootmgfw asm bugcodes) add_cd_file(TARGET bootmgfw FILE ${_bootmgfw_output_file} DESTINATION loader NO_CAB FOR bootcd regtest)

1 0

[akhaldi] 68995: [BOOTMGFW] Set the subsystem differently between GCC and MSVC builds.
by akhaldi＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: akhaldi Date: Fri Sep 4 14:40:15 2015 New Revision: 68995 URL: http://svn.reactos.org/svn/reactos?rev=68995&view=rev Log: [BOOTMGFW] Set the subsystem differently between GCC and MSVC builds. Modified: trunk/reactos/boot/environ/CMakeLists.txt Modified: trunk/reactos/boot/environ/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/CMakeLists.tx… ============================================================================== --- trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/boot/environ/CMakeLists.txt [iso-8859-1] Fri Sep 4 14:40:15 2015 @@ -50,7 +50,13 @@ endif() set_image_base(bootmgfw 0x10000) -set_subsystem(bootmgfw 10) + +if(MSVC) + set_subsystem(bootmgfw EFI_APPLICATION) +else() + set_subsystem(bootmgfw 10) +endif() + set_entrypoint(bootmgfw EfiEntry) target_link_libraries(bootmgfw bootmgr_common cportlib cmlib rtl libcntpr)

1 0

[ion] 68994: [TXTSETUP] Still takes 3 commits to get 1 right.
by ion＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: ion Date: Fri Sep 4 14:26:09 2015 New Revision: 68994 URL: http://svn.reactos.org/svn/reactos?rev=68994&view=rev Log: [TXTSETUP] Still takes 3 commits to get 1 right. Modified: trunk/reactos/boot/bootdata/txtsetup.sif Modified: trunk/reactos/boot/bootdata/txtsetup.sif URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif… ============================================================================== --- trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/txtsetup.sif [iso-8859-1] Fri Sep 4 14:26:09 2015 @@ -130,7 +130,7 @@ [SetupData] DefaultPath = \ReactOS OsLoadOptions = "/NOGUIBOOT /NODEBUG" -DbgOsLoadOptions = "/NOGUIBOOT /KDSERIAL /DEBUGPORT=COM1 /FIRSTCHANCE /redirect=com2 /redirectbaudrate=115200" +DbgOsLoadOptions = "/NOGUIBOOT /KDSERIAL /DEBUGPORT=COM1 /FIRSTCHANCE" ;DbgOsLoadOptions = "/SOS /DEBUGPORT=SCREEN" ;DbgOsLoadOptions = "/NOGUIBOOT /DEBUGPORT=BOCHS"

1 0

[ion] 68993: [BOOTMGFW] Try to fix header.
by ion＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: ion Date: Fri Sep 4 14:23:45 2015 New Revision: 68993 URL: http://svn.reactos.org/svn/reactos?rev=68993&view=rev Log: [BOOTMGFW] Try to fix header. Modified: trunk/reactos/boot/environ/include/bl.h Modified: trunk/reactos/boot/environ/include/bl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/bl.h?… ============================================================================== --- trunk/reactos/boot/environ/include/bl.h [iso-8859-1] (original) +++ trunk/reactos/boot/environ/include/bl.h [iso-8859-1] Fri Sep 4 14:23:45 2015 @@ -8,6 +8,19 @@ #ifndef _BL_H #define _BL_H + +/* INCLUDES ******************************************************************/ + +/* C Headers */ +#include <stdlib.h> +#include <stdio.h> +#include <wchar.h> + +/* NT Base Headers */ +#include <ntifs.h> + +/* UEFI Headers */ +#include <Uefi.h> /* DATA STRUCTURES ***********************************************************/

1 0

[ion] 68992: [BOOTMGFW] Nothing to see here. I hope this doesn't break the build.
by ion＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: ion Date: Fri Sep 4 14:16:56 2015 New Revision: 68992 URL: http://svn.reactos.org/svn/reactos?rev=68992&view=rev Log: [BOOTMGFW] Nothing to see here. I hope this doesn't break the build. Added: trunk/reactos/boot/bcd/ (with props) trunk/reactos/boot/bgfx/ (with props) trunk/reactos/boot/environ/ (with props) trunk/reactos/boot/environ/CMakeLists.txt (with props) trunk/reactos/boot/environ/app/ (with props) trunk/reactos/boot/environ/app/bootmgr/ (with props) trunk/reactos/boot/environ/app/bootmgr/bootmgr.c (with props) trunk/reactos/boot/environ/app/bootmgr/bootmgr.h (with props) trunk/reactos/boot/environ/app/bootmgr/efiemu.c (with props) trunk/reactos/boot/environ/include/ (with props) trunk/reactos/boot/environ/include/bl.h (with props) trunk/reactos/boot/environ/include/efi/ (with props) trunk/reactos/boot/environ/include/efi/Base.h (with props) trunk/reactos/boot/environ/include/efi/DevicePath.h (with props) trunk/reactos/boot/environ/include/efi/LoadedImage.h (with props) trunk/reactos/boot/environ/include/efi/ProcessorBind.h (with props) trunk/reactos/boot/environ/include/efi/SimpleTextIn.h (with props) trunk/reactos/boot/environ/include/efi/SimpleTextInEx.h (with props) trunk/reactos/boot/environ/include/efi/SimpleTextOut.h (with props) trunk/reactos/boot/environ/include/efi/Uefi.h (with props) trunk/reactos/boot/environ/include/efi/UefiBaseType.h (with props) trunk/reactos/boot/environ/include/efi/UefiMultiPhase.h (with props) trunk/reactos/boot/environ/include/efi/UefiSpec.h (with props) trunk/reactos/boot/environ/include/efi/WinCertificate.h (with props) trunk/reactos/boot/environ/lib/ (with props) trunk/reactos/boot/environ/lib/arch/ (with props) trunk/reactos/boot/environ/lib/bd/ (with props) trunk/reactos/boot/environ/lib/bootlib.c (with props) trunk/reactos/boot/environ/lib/firmware/ (with props) trunk/reactos/boot/environ/lib/io/ (with props) trunk/reactos/boot/environ/lib/mc/ (with props) trunk/reactos/boot/environ/lib/misc/ (with props) trunk/reactos/boot/environ/lib/misc/util.c (with props) trunk/reactos/boot/environ/lib/mm/ (with props) trunk/reactos/boot/environ/lib/mm/foo.c (with props) trunk/reactos/boot/environ/lib/platform/ (with props) Modified: trunk/reactos/boot/CMakeLists.txt trunk/reactos/boot/bootdata/txtsetup.sif [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/boot/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/CMakeLists.txt?rev=68… Modified: trunk/reactos/boot/bootdata/txtsetup.sif URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif… Added: trunk/reactos/boot/environ/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/CMakeLists.tx… Added: trunk/reactos/boot/environ/app/bootmgr/bootmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/app/bootmgr/b… Added: trunk/reactos/boot/environ/app/bootmgr/bootmgr.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/app/bootmgr/b… Added: trunk/reactos/boot/environ/app/bootmgr/efiemu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/app/bootmgr/e… Added: trunk/reactos/boot/environ/include/bl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/bl.h?… Added: trunk/reactos/boot/environ/include/efi/Base.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/B… Added: trunk/reactos/boot/environ/include/efi/DevicePath.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/D… Added: trunk/reactos/boot/environ/include/efi/LoadedImage.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/L… Added: trunk/reactos/boot/environ/include/efi/ProcessorBind.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/P… Added: trunk/reactos/boot/environ/include/efi/SimpleTextIn.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/S… Added: trunk/reactos/boot/environ/include/efi/SimpleTextInEx.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/S… Added: trunk/reactos/boot/environ/include/efi/SimpleTextOut.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/S… Added: trunk/reactos/boot/environ/include/efi/Uefi.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/U… Added: trunk/reactos/boot/environ/include/efi/UefiBaseType.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/U… Added: trunk/reactos/boot/environ/include/efi/UefiMultiPhase.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/U… Added: trunk/reactos/boot/environ/include/efi/UefiSpec.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/U… Added: trunk/reactos/boot/environ/include/efi/WinCertificate.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/efi/W… Added: trunk/reactos/boot/environ/lib/bootlib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/bootlib.c… Added: trunk/reactos/boot/environ/lib/misc/util.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/misc/util… Added: trunk/reactos/boot/environ/lib/mm/foo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/mm/foo.c?…

1 0

[cfinck] 68991: [SKIPLIST] The Park-Miller Lehmer Random Number Generator only outputs 31 uniformly distributed random bits. Bit 32 is always zero. Fix the code accordingly. This limits the maximum...
by cfinck＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cfinck Date: Fri Sep 4 14:03:00 2015 New Revision: 68991 URL: http://svn.reactos.org/svn/reactos?rev=68991&view=rev Log: [SKIPLIST] The Park-Miller Lehmer Random Number Generator only outputs 31 uniformly distributed random bits. Bit 32 is always zero. Fix the code accordingly. This limits the maximum number of Skiplist levels to 31, but we only use 16 anyway so far. Modified: branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.c branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.h Modified: branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.c URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… ============================================================================== --- branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.c [iso-8859-1] (original) +++ branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.c [iso-8859-1] Fri Sep 4 14:03:00 2015 @@ -28,11 +28,11 @@ DWORD dwLevel = 0; DWORD dwShifted; - // Generate 32 uniformly distributed pseudo-random bits using the Park-Miller Lehmer Minimal Standard Random Number Generator. + // Generate 31 uniformly distributed pseudo-random bits using the Park-Miller Lehmer Minimal Standard Random Number Generator. dwRandom = (DWORD)(((ULONGLONG)dwRandom * 48271UL) % 2147483647UL); - // Shift out (32 - SKIPLIST_LEVELS) bits to the right to have no more than SKIPLIST_LEVELS bits set. - dwShifted = dwRandom >> (32 - SKIPLIST_LEVELS); + // Shift out (31 - SKIPLIST_LEVELS) bits to the right to have no more than SKIPLIST_LEVELS bits set. + dwShifted = dwRandom >> (31 - SKIPLIST_LEVELS); // BitScanForward doesn't operate on a zero input value. if (dwShifted) @@ -42,7 +42,7 @@ BitScanForward(&dwLevel, dwShifted); } - // dwLevel can't have a value higher than 31 this way, so a CHAR is more than enough. + // dwLevel can't have a value higher than 30 this way, so a CHAR is more than enough. return (CHAR)dwLevel; } Modified: branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.h URL: http://svn.reactos.org/svn/reactos/branches/colins-printing-for-freedom/rea… ============================================================================== --- branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.h [iso-8859-1] (original) +++ branches/colins-printing-for-freedom/reactos/lib/skiplist/skiplist.h [iso-8859-1] Fri Sep 4 14:03:00 2015 @@ -8,15 +8,15 @@ #ifndef _REACTOS_SKIPLIST_H #define _REACTOS_SKIPLIST_H -// Define SKIPLIST_LEVELS to a value between 1 and 32 before including this header. +// Define SKIPLIST_LEVELS to a value between 1 and 31 before including this header. // This specifies the maximum number of levels you want your Skiplist to have. // A value of X is recommended for handling up to 2^X elements. #ifndef SKIPLIST_LEVELS -#error Please define SKIPLIST_LEVELS to a value between 1 and 32. +#error Please define SKIPLIST_LEVELS to a value between 1 and 31. #endif C_ASSERT(SKIPLIST_LEVELS >= 1); -C_ASSERT(SKIPLIST_LEVELS <= 32); +C_ASSERT(SKIPLIST_LEVELS <= 31); // Function pointer definitions typedef PVOID (WINAPI *PSKIPLIST_ALLOCATE_ROUTINE)(DWORD);

1 0

← Newer
1
...
40
41
42
43
44
45
46
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2015