Ros-diffs September 2015

ros-diffs@reactos.org

17 participants
535 discussions

[pschweitzer] 68990: [MUP] Fix uninitialized address freeing in case of error in MupGetProviderInformation(), InitializeProvider() CID 1322227 CID 1322240
by pschweitzer＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: pschweitzer Date: Fri Sep 4 13:58:44 2015 New Revision: 68990 URL: http://svn.reactos.org/svn/reactos?rev=68990&view=rev Log: [MUP] Fix uninitialized address freeing in case of error in MupGetProviderInformation(), InitializeProvider() CID 1322227 CID 1322240 Modified: trunk/reactos/drivers/filesystems/mup/mup.c Modified: trunk/reactos/drivers/filesystems/mup/mup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/mu… ============================================================================== --- trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/mup/mup.c [iso-8859-1] Fri Sep 4 13:58:44 2015 @@ -950,6 +950,10 @@ Status = ZwQueryValueKey(KeyHandle, &Value, KeyValueFullInformation, Info, ResultLength, &ResultLength); } + else + { + Info = NULL; + } ZwClose(KeyHandle); @@ -959,6 +963,7 @@ */ if (NT_SUCCESS(Status)) { + ASSERT(Info != NULL); AddUnregisteredProvider((PWSTR)((ULONG_PTR)Info + Info->DataOffset), ProviderOrder); } @@ -1006,11 +1011,17 @@ Status = ZwQueryValueKey(KeyHandle, &ProviderOrder, KeyValueFullInformation, Info, ResultLength, &ResultLength); } + else + { + Info = NULL; + } ZwClose(KeyHandle); if (NT_SUCCESS(Status)) { + ASSERT(Info != NULL); + Providers = (PWSTR)((ULONG_PTR)Info + Info->DataOffset); End = FALSE; ProviderCount = 0;

1 0

[cwittich] 68989: [USBSTOR] fix memory leaks CID 1322134
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 12:05:14 2015 New Revision: 68989 URL: http://svn.reactos.org/svn/reactos?rev=68989&view=rev Log: [USBSTOR] fix memory leaks CID 1322134 Modified: trunk/reactos/drivers/usb/usbstor/scsi.c Modified: trunk/reactos/drivers/usb/usbstor/scsi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/scsi.c… ============================================================================== --- trunk/reactos/drivers/usb/usbstor/scsi.c [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbstor/scsi.c [iso-8859-1] Fri Sep 4 12:05:14 2015 @@ -726,6 +726,8 @@ // // failed to allocate MDL // + FreeItem(Context->cbw); + FreeItem(Context); return STATUS_INSUFFICIENT_RESOURCES; } @@ -755,6 +757,8 @@ // // failed to allocate MDL // + FreeItem(Context->cbw); + FreeItem(Context); return STATUS_INSUFFICIENT_RESOURCES; } @@ -775,6 +779,8 @@ // // failed to allocate MDL // + FreeItem(Context->cbw); + FreeItem(Context); return STATUS_INSUFFICIENT_RESOURCES; }

1 0

[cwittich] 68988: [SHELL32] fix a memory leak CID 1322145
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 11:43:48 2015 New Revision: 68988 URL: http://svn.reactos.org/svn/reactos?rev=68988&view=rev Log: [SHELL32] fix a memory leak CID 1322145 Modified: trunk/reactos/dll/win32/shell32/CQueryAssociations.cpp Modified: trunk/reactos/dll/win32/shell32/CQueryAssociations.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CQueryAs… ============================================================================== --- trunk/reactos/dll/win32/shell32/CQueryAssociations.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CQueryAssociations.cpp [iso-8859-1] Fri Sep 4 11:43:48 2015 @@ -474,8 +474,14 @@ void *data; DWORD size; HRESULT hres = this->GetValue(this->hkeyProgID, edit_flags, &data, &size); - if(FAILED(hres) || !pcbOut) - { + if(FAILED(hres)) + { + return hres; + } + + if (!pcbOut) + { + HeapFree(GetProcessHeap(), 0, data); return hres; }

1 0

[cwittich] 68987: [WIN32SS] fix memory leak in error case CID 716637
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 09:39:08 2015 New Revision: 68987 URL: http://svn.reactos.org/svn/reactos?rev=68987&view=rev Log: [WIN32SS] fix memory leak in error case CID 716637 Modified: trunk/reactos/win32ss/gdi/ntgdi/polyfill.c Modified: trunk/reactos/win32ss/gdi/ntgdi/polyfill.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/polyfill… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/polyfill.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/polyfill.c [iso-8859-1] Fri Sep 4 09:39:08 2015 @@ -616,7 +616,10 @@ //DEBUG_PRINT_ACTIVE_EDGELIST(ActiveHead); if (!ActiveHead) + { + POLYGONFILL_DestroyEdgeList(list); return FALSE; + } pLeft = ActiveHead; pRight = pLeft->pNext;

1 0

[tfaber] 68986: [FASTFAT] - Don't try to free an uninitialized pointer in VfatSetRenameInformation. CID 1250303 - Actually use the dynamically calculated HashTableSize. CID 1237119/1237120/1237121
by tfaber＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: tfaber Date: Fri Sep 4 08:37:01 2015 New Revision: 68986 URL: http://svn.reactos.org/svn/reactos?rev=68986&view=rev Log: [FASTFAT] - Don't try to free an uninitialized pointer in VfatSetRenameInformation. CID 1250303 - Actually use the dynamically calculated HashTableSize. CID 1237119/1237120/1237121 Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c trunk/reactos/drivers/filesystems/fastfat/fsctl.c trunk/reactos/drivers/filesystems/fastfat/vfat.h Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] Fri Sep 4 08:37:01 2015 @@ -529,6 +529,7 @@ RootFCB = RootFileObject->FsContext; } + RtlInitEmptyUnicodeString(&NewName, NULL, 0); ParentFCB = NULL; if (TargetFileObject == NULL) Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Fri Sep 4 08:37:01 2015 @@ -429,7 +429,6 @@ { HashTableSize = 65537; // 65536 = 64 * 1024; } - HashTableSize = FCB_HASH_TABLE_SIZE; DPRINT("VFAT: Recognized volume\n"); Status = IoCreateDevice(VfatGlobalData->DriverObject, ROUND_UP(sizeof (DEVICE_EXTENSION), sizeof(ULONG)) + sizeof(HASHENTRY*) * HashTableSize, Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] Fri Sep 4 08:37:01 2015 @@ -264,8 +264,6 @@ } HASHENTRY; -#define FCB_HASH_TABLE_SIZE 65536 - typedef struct DEVICE_EXTENSION *PDEVICE_EXTENSION; typedef NTSTATUS (*PGET_NEXT_CLUSTER)(PDEVICE_EXTENSION,ULONG,PULONG);

1 0

[cwittich] 68985: [I8042PRT] fix memory leak CID 1322163
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 08:32:00 2015 New Revision: 68985 URL: http://svn.reactos.org/svn/reactos?rev=68985&view=rev Log: [I8042PRT] fix memory leak CID 1322163 Modified: trunk/reactos/drivers/input/i8042prt/hwhacks.c Modified: trunk/reactos/drivers/input/i8042prt/hwhacks.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/hwh… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/hwhacks.c [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/hwhacks.c [iso-8859-1] Fri Sep 4 08:32:00 2015 @@ -260,6 +260,7 @@ if (!NT_SUCCESS(Status)) { DPRINT1("IoWMIOpenBlock failed: 0x%08lx\n", Status); + ExFreePoolWithTag(AllData, 'BTMS'); return; }

1 0

[cwittich] 68984: [SERVMAN] fix memory leak CID 1322153
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 08:29:08 2015 New Revision: 68984 URL: http://svn.reactos.org/svn/reactos?rev=68984&view=rev Log: [SERVMAN] fix memory leak CID 1322153 Modified: trunk/reactos/base/applications/mscutils/servman/progress.c Modified: trunk/reactos/base/applications/mscutils/servman/progress.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/progress.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/progress.c [iso-8859-1] Fri Sep 4 08:29:08 2015 @@ -350,7 +350,10 @@ /* Exit early if the user decided not to stop the dependants */ if (StopDepends == FALSE) + { + HeapFree(GetProcessHeap(), 0, ServiceList); return FALSE; + } } }

1 0

[cwittich] 68983: [DHCPSVC] fix resource leak in error case CID 1248422
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 08:15:11 2015 New Revision: 68983 URL: http://svn.reactos.org/svn/reactos?rev=68983&view=rev Log: [DHCPSVC] fix resource leak in error case CID 1248422 Modified: trunk/reactos/dll/win32/dhcpcsvc/dhcp/adapter.c Modified: trunk/reactos/dll/win32/dhcpcsvc/dhcp/adapter.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dhcpcsvc/dhcp/ad… ============================================================================== --- trunk/reactos/dll/win32/dhcpcsvc/dhcp/adapter.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dhcpcsvc/dhcp/adapter.c [iso-8859-1] Fri Sep 4 08:15:11 2015 @@ -476,6 +476,9 @@ FALSE, NULL); + if (EventHandle == NULL) + return NULL; + ThreadHandle = CreateThread(NULL, 0, AdapterDiscoveryThread, @@ -484,7 +487,10 @@ NULL); if (ThreadHandle == NULL) + { + CloseHandle(EventHandle); return NULL; + } CloseHandle(ThreadHandle);

1 0

[tfaber] 68982: [RSYM] - This is not the typo you are looking for
by tfaber＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: tfaber Date: Fri Sep 4 08:06:17 2015 New Revision: 68982 URL: http://svn.reactos.org/svn/reactos?rev=68982&view=rev Log: [RSYM] - This is not the typo you are looking for Modified: trunk/reactos/tools/rsym/rsym.c Modified: trunk/reactos/tools/rsym/rsym.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rsym/rsym.c?rev=6898… ============================================================================== --- trunk/reactos/tools/rsym/rsym.c [iso-8859-1] (original) +++ trunk/reactos/tools/rsym/rsym.c [iso-8859-1] Fri Sep 4 08:06:17 2015 @@ -125,7 +125,7 @@ if (SymEntry2->SourceLine == 0) { - return +1; + return -1; } if (SymEntry1->SourceLine == 0)

1 0

[cwittich] 68981: [CRT] fix resource leak in error case CID 716561
by cwittich＠svn.reactos.org 04 Sep '15

04 Sep '15

Author: cwittich Date: Fri Sep 4 08:02:53 2015 New Revision: 68981 URL: http://svn.reactos.org/svn/reactos?rev=68981&view=rev Log: [CRT] fix resource leak in error case CID 716561 Modified: trunk/reactos/lib/sdk/crt/math/rand.c Modified: trunk/reactos/lib/sdk/crt/math/rand.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/math/rand.c?re… ============================================================================== --- trunk/reactos/lib/sdk/crt/math/rand.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/math/rand.c [iso-8859-1] Fri Sep 4 08:02:53 2015 @@ -34,15 +34,16 @@ { BOOLEAN (WINAPI *pSystemFunction036)(PVOID, ULONG); // RtlGenRandom HINSTANCE hadvapi32 = LoadLibraryA("advapi32.dll"); + int ret = 0; pSystemFunction036 = (void*)GetProcAddress(hadvapi32, "SystemFunction036"); #if 1 if (!pval || (pSystemFunction036 && !pSystemFunction036(pval, sizeof(*pval)))) { _invalid_parameter(NULL,_CRT_WIDE("rand_s"),_CRT_WIDE(__FILE__),__LINE__, 0); *_errno() = EINVAL; - return EINVAL; + ret = EINVAL; } #endif if(hadvapi32) FreeLibrary(hadvapi32); - return 0; + return ret; }

1 0

← Newer
1
...
41
42
43
44
45
46
47
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2015