Ros-diffs November 2016

ros-diffs@reactos.org

15 participants
317 discussions

[tfaber] 73210: [SHELL32_APITEST] - Don't compare a pointer to S_OK CORE-11794
by tfaber＠svn.reactos.org 12 Nov '16

12 Nov '16

Author: tfaber Date: Sat Nov 12 12:43:02 2016 New Revision: 73210 URL: http://svn.reactos.org/svn/reactos?rev=73210&view=rev Log: [SHELL32_APITEST] - Don't compare a pointer to S_OK CORE-11794 Modified: trunk/rostests/apitests/shell32/menu.cpp Modified: trunk/rostests/apitests/shell32/menu.cpp URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/menu.cpp… ============================================================================== --- trunk/rostests/apitests/shell32/menu.cpp [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/menu.cpp [iso-8859-1] Sat Nov 12 12:43:02 2016 @@ -257,7 +257,7 @@ struct _test_info *result = &m_results[m_iCallback-1]; - ok(psmd != S_OK, "Got NULL psmd\n"); + ok(psmd != NULL, "Got NULL psmd\n"); ok(m_iTest == result->iTest, "Wrong test number (%d not %d)\n", m_iTest, result->iTest); ok(result->uMsg == uMsg, "%d: Got wrong uMsg (%d instead of %d)\n", m_iCallback, uMsg, result->uMsg);

1 0

[tfaber] 73209: [MSWSOCK] - Remove broken 'inline' specifiers CORE-11794
by tfaber＠svn.reactos.org 12 Nov '16

12 Nov '16

Author: tfaber Date: Sat Nov 12 12:23:49 2016 New Revision: 73209 URL: http://svn.reactos.org/svn/reactos?rev=73209&view=rev Log: [MSWSOCK] - Remove broken 'inline' specifiers CORE-11794 Modified: trunk/reactos/dll/win32/mswsock/mswhelper.c trunk/reactos/dll/win32/mswsock/mswhelper.h Modified: trunk/reactos/dll/win32/mswsock/mswhelper.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mswsock/mswhelpe… ============================================================================== --- trunk/reactos/dll/win32/mswsock/mswhelper.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mswsock/mswhelper.c [iso-8859-1] Sat Nov 12 12:23:49 2016 @@ -47,7 +47,6 @@ return TRUE; } -inline BYTE* mswBufferEndPtr(_Inout_ PMSW_BUFFER mswBuf) { Modified: trunk/reactos/dll/win32/mswsock/mswhelper.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mswsock/mswhelpe… ============================================================================== --- trunk/reactos/dll/win32/mswsock/mswhelper.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mswsock/mswhelper.h [iso-8859-1] Sat Nov 12 12:23:49 2016 @@ -17,7 +17,6 @@ _In_ BYTE* buffer, _In_ DWORD bufferSize); -inline BOOL mswBufferCheck( _Inout_ PMSW_BUFFER mswBuf, @@ -28,7 +27,6 @@ _Inout_ PMSW_BUFFER mswBuf, _In_ DWORD count); -inline BYTE* mswBufferEndPtr( _Inout_ PMSW_BUFFER mswBuf);

1 0

[pschweitzer] 73208: [SNDREC32] Don't double free buffers in case of failure
by pschweitzer＠svn.reactos.org 12 Nov '16

12 Nov '16

Author: pschweitzer Date: Sat Nov 12 09:24:09 2016 New Revision: 73208 URL: http://svn.reactos.org/svn/reactos?rev=73208&view=rev Log: [SNDREC32] Don't double free buffers in case of failure Modified: trunk/reactos/base/applications/sndrec32/audio_resampler_acm.cpp Modified: trunk/reactos/base/applications/sndrec32/audio_resampler_acm.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndrec32… ============================================================================== --- trunk/reactos/base/applications/sndrec32/audio_resampler_acm.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/sndrec32/audio_resampler_acm.cpp [iso-8859-1] Sat Nov 12 09:24:09 2016 @@ -126,10 +126,16 @@ { /* Free buffer memory */ if (acm_header.pbSrc != 0) + { delete[] acm_header.pbSrc; + acm_header.pbSrc = 0; + } if (acm_header.pbDst != 0) + { delete[] acm_header.pbDst; + acm_header.pbDst = 0; + } /* Re-init structures */ init_(); @@ -147,10 +153,16 @@ { /* Free buffer memory */ if (acm_header.pbSrc != 0) + { delete[] acm_header.pbSrc; + acm_header.pbSrc = 0; + } if (acm_header.pbDst != 0) + { delete[] acm_header.pbDst; + acm_header.pbDst = 0; + } /* Re-init structures */ init_();

1 0

[hbelusca] 73207: [EVENTVWR]: Fix translation for "Information" event type: it is really in singular, not plural.
by hbelusca＠svn.reactos.org 12 Nov '16

12 Nov '16

Author: hbelusca Date: Sat Nov 12 01:29:05 2016 New Revision: 73207 URL: http://svn.reactos.org/svn/reactos?rev=73207&view=rev Log: [EVENTVWR]: Fix translation for "Information" event type: it is really in singular, not plural. Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc [iso-8859-1] Sat Nov 12 01:29:05 2016 @@ -148,7 +148,7 @@ BEGIN IDS_EVENTLOG_ERROR_TYPE "Fehler" IDS_EVENTLOG_WARNING_TYPE "Warnung" - IDS_EVENTLOG_INFORMATION_TYPE "Informationen" + IDS_EVENTLOG_INFORMATION_TYPE "Information" IDS_EVENTLOG_AUDIT_SUCCESS "Audit Erfolgreich" IDS_EVENTLOG_AUDIT_FAILURE "Audit Fehlgeschlagen" IDS_EVENTLOG_SUCCESS "Erfolgreich" Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc [iso-8859-1] Sat Nov 12 01:29:05 2016 @@ -148,7 +148,7 @@ BEGIN IDS_EVENTLOG_ERROR_TYPE "Erreur" IDS_EVENTLOG_WARNING_TYPE "Avertissement" - IDS_EVENTLOG_INFORMATION_TYPE "Informations" + IDS_EVENTLOG_INFORMATION_TYPE "Information" IDS_EVENTLOG_AUDIT_SUCCESS "SuccÃ¨s de l'audit" IDS_EVENTLOG_AUDIT_FAILURE "Ãchec de l'audit" IDS_EVENTLOG_SUCCESS "SuccÃ¨s"

1 0

[hbelusca] 73206: [MSVCRT]: Implement and export _wtof, based on Wine and existing code; patch by Amine Khaldi. CORE-12335 #resolve CORE-9312 #comment Please retest with r73206
by hbelusca＠svn.reactos.org 11 Nov '16

11 Nov '16

Author: hbelusca Date: Fri Nov 11 23:32:29 2016 New Revision: 73206 URL: http://svn.reactos.org/svn/reactos?rev=73206&view=rev Log: [MSVCRT]: Implement and export _wtof, based on Wine and existing code; patch by Amine Khaldi. CORE-12335 #resolve CORE-9312 #comment Please retest with r73206 Added: trunk/reactos/sdk/lib/crt/string/wtof.c (with props) Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec trunk/reactos/sdk/lib/crt/crt.cmake Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.sp… ============================================================================== --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Fri Nov 11 23:32:29 2016 @@ -761,7 +761,7 @@ @ cdecl _wsystem(wstr) @ cdecl _wtempnam(wstr wstr) @ cdecl _wtmpnam(ptr) -# @ cdecl _wtof(wstr) +@ cdecl _wtof(wstr) @ cdecl _wtoi(wstr) @ cdecl _wtoi64(wstr) @ cdecl _wtol(wstr) Modified: trunk/reactos/sdk/lib/crt/crt.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/crt/crt.cmake?rev=… ============================================================================== --- trunk/reactos/sdk/lib/crt/crt.cmake [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/crt/crt.cmake [iso-8859-1] Fri Nov 11 23:32:29 2016 @@ -305,6 +305,7 @@ string/wcstombs_s.c string/wcstoul.c string/wctype.c + string/wtof.c string/wtoi.c string/wtoi64.c string/wtol.c Added: trunk/reactos/sdk/lib/crt/string/wtof.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/crt/string/wtof.c?… ============================================================================== --- trunk/reactos/sdk/lib/crt/string/wtof.c (added) +++ trunk/reactos/sdk/lib/crt/string/wtof.c [iso-8859-1] Fri Nov 11 23:32:29 2016 @@ -0,0 +1,10 @@ +#include <precomp.h> + +/* + * @implemented + */ +double +_wtof(const wchar_t *str) +{ + return wcstod(str, 0); +} Propchange: trunk/reactos/sdk/lib/crt/string/wtof.c ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[hbelusca] 73205: [MSAFD] - In C, void functions should better have 'VOID' mentioned in their prototypes. - Simplify GetCurrentTimeInSeconds code.
by hbelusca＠svn.reactos.org 11 Nov '16

11 Nov '16

Author: hbelusca Date: Fri Nov 11 21:37:09 2016 New Revision: 73205 URL: http://svn.reactos.org/svn/reactos?rev=73205&view=rev Log: [MSAFD] - In C, void functions should better have 'VOID' mentioned in their prototypes. - Simplify GetCurrentTimeInSeconds code. Modified: trunk/reactos/dll/win32/msafd/misc/dllmain.c Modified: trunk/reactos/dll/win32/msafd/misc/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msafd/misc/dllma… ============================================================================== --- trunk/reactos/dll/win32/msafd/misc/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msafd/misc/dllmain.c [iso-8859-1] Fri Nov 11 21:37:09 2016 @@ -1321,18 +1321,18 @@ } DWORD -GetCurrentTimeInSeconds() +GetCurrentTimeInSeconds(VOID) { - FILETIME Time; - FILETIME Adjustment; - ULARGE_INTEGER lTime, lAdj; - SYSTEMTIME st = { 1970,1,0,1,0,0,0 }; - SystemTimeToFileTime(&st, &Adjustment); - memcpy(&lAdj, &Adjustment, sizeof(lAdj)); - GetSystemTimeAsFileTime(&Time); - memcpy(&lTime, &Time, sizeof(lTime)); - lTime.QuadPart -= lAdj.QuadPart; - return (DWORD)(lTime.QuadPart / 10000000LLU); + SYSTEMTIME st1970 = { 1970, 1, 0, 1, 0, 0, 0, 0 }; + union + { + FILETIME ft; + ULONGLONG ll; + } u1970, Time; + + GetSystemTimeAsFileTime(&Time.ft); + SystemTimeToFileTime(&st1970, &u1970.ft); + return (DWORD)((Time.ll - u1970.ll) / 10000000ULL); } SOCKET

1 0

[hbelusca] 73204: [MSAFD]: Addendum to r73203.
by hbelusca＠svn.reactos.org 11 Nov '16

11 Nov '16

Author: hbelusca Date: Fri Nov 11 21:25:02 2016 New Revision: 73204 URL: http://svn.reactos.org/svn/reactos?rev=73204&view=rev Log: [MSAFD]: Addendum to r73203. Modified: trunk/reactos/dll/win32/msafd/misc/dllmain.c Modified: trunk/reactos/dll/win32/msafd/misc/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msafd/misc/dllma… ============================================================================== --- trunk/reactos/dll/win32/msafd/misc/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msafd/misc/dllmain.c [iso-8859-1] Fri Nov 11 21:25:02 2016 @@ -2056,7 +2056,7 @@ { IO_STATUS_BLOCK IOSB; ULONG TdiAddressSize; - PTDI_ADDRESS_INFO TdiAddress; + PTDI_ADDRESS_INFO TdiAddress; PTRANSPORT_ADDRESS SocketAddress; PSOCKET_INFORMATION Socket = NULL; NTSTATUS Status; @@ -2087,7 +2087,7 @@ /* Allocate a buffer for the address */ TdiAddressSize = - sizeof(TRANSPORT_ADDRESS) + Socket->SharedData->SizeOfLocalAddress; + sizeof(TRANSPORT_ADDRESS) + Socket->SharedData->SizeOfLocalAddress; TdiAddress = HeapAlloc(GlobalHeap, 0, TdiAddressSize); if ( TdiAddress == NULL ) @@ -3877,5 +3877,3 @@ } /* EOF */ - -

1 0

[hbelusca] 73203: [MSAFD]: Convert tabs to spaces.
by hbelusca＠svn.reactos.org 11 Nov '16

11 Nov '16

Author: hbelusca Date: Fri Nov 11 21:19:13 2016 New Revision: 73203 URL: http://svn.reactos.org/svn/reactos?rev=73203&view=rev Log: [MSAFD]: Convert tabs to spaces. Modified: trunk/reactos/dll/win32/msafd/include/helpers.h Modified: trunk/reactos/dll/win32/msafd/include/helpers.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msafd/include/he… ============================================================================== --- trunk/reactos/dll/win32/msafd/include/helpers.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msafd/include/helpers.h [iso-8859-1] Fri Nov 11 21:19:13 2016 @@ -10,62 +10,62 @@ //#include <msafd.h> typedef struct _HELPER_DATA { - LIST_ENTRY Helpers; - LONG RefCount; - HANDLE hInstance; - INT MinWSAddressLength; - INT MaxWSAddressLength; - INT MinTDIAddressLength; - INT MaxTDIAddressLength; - BOOLEAN UseDelayedAcceptance; - PWINSOCK_MAPPING Mapping; - PWSH_OPEN_SOCKET WSHOpenSocket; - PWSH_OPEN_SOCKET2 WSHOpenSocket2; - PWSH_JOIN_LEAF WSHJoinLeaf; - PWSH_NOTIFY WSHNotify; - PWSH_GET_SOCKET_INFORMATION WSHGetSocketInformation; - PWSH_SET_SOCKET_INFORMATION WSHSetSocketInformation; - PWSH_GET_SOCKADDR_TYPE WSHGetSockaddrType; - PWSH_GET_WILDCARD_SOCKADDR WSHGetWildcardSockaddr; - PWSH_GET_BROADCAST_SOCKADDR WSHGetBroadcastSockaddr; - PWSH_ADDRESS_TO_STRING WSHAddressToString; - PWSH_STRING_TO_ADDRESS WSHStringToAddress; - PWSH_IOCTL WSHIoctl; - WCHAR TransportName[1]; + LIST_ENTRY Helpers; + LONG RefCount; + HANDLE hInstance; + INT MinWSAddressLength; + INT MaxWSAddressLength; + INT MinTDIAddressLength; + INT MaxTDIAddressLength; + BOOLEAN UseDelayedAcceptance; + PWINSOCK_MAPPING Mapping; + PWSH_OPEN_SOCKET WSHOpenSocket; + PWSH_OPEN_SOCKET2 WSHOpenSocket2; + PWSH_JOIN_LEAF WSHJoinLeaf; + PWSH_NOTIFY WSHNotify; + PWSH_GET_SOCKET_INFORMATION WSHGetSocketInformation; + PWSH_SET_SOCKET_INFORMATION WSHSetSocketInformation; + PWSH_GET_SOCKADDR_TYPE WSHGetSockaddrType; + PWSH_GET_WILDCARD_SOCKADDR WSHGetWildcardSockaddr; + PWSH_GET_BROADCAST_SOCKADDR WSHGetBroadcastSockaddr; + PWSH_ADDRESS_TO_STRING WSHAddressToString; + PWSH_STRING_TO_ADDRESS WSHStringToAddress; + PWSH_IOCTL WSHIoctl; + WCHAR TransportName[1]; } HELPER_DATA, *PHELPER_DATA; int SockLoadHelperDll( - PWSTR TransportName, - PWINSOCK_MAPPING Mapping, - PHELPER_DATA *HelperDllData + PWSTR TransportName, + PWINSOCK_MAPPING Mapping, + PHELPER_DATA *HelperDllData ); int SockLoadTransportMapping( - PWSTR TransportName, - PWINSOCK_MAPPING *Mapping + PWSTR TransportName, + PWINSOCK_MAPPING *Mapping ); int SockLoadTransportList( - PWSTR *TransportList + PWSTR *TransportList ); BOOL SockIsTripleInMapping( - PWINSOCK_MAPPING Mapping, - INT AddressFamily, - INT SocketType, - INT Protocol + PWINSOCK_MAPPING Mapping, + INT AddressFamily, + INT SocketType, + INT Protocol ); int SockGetTdiName( - PINT AddressFamily, - PINT SocketType, - PINT Protocol, - GROUP Group, - DWORD Flags, - PUNICODE_STRING TransportName, - PVOID *HelperDllContext, - PHELPER_DATA *HelperDllData, - PDWORD Events + PINT AddressFamily, + PINT SocketType, + PINT Protocol, + GROUP Group, + DWORD Flags, + PUNICODE_STRING TransportName, + PVOID *HelperDllContext, + PHELPER_DATA *HelperDllData, + PDWORD Events ); #endif /* __HELPERS_H */

1 0

[pschweitzer] 73202: [NTOSKRNL] Don't redefine RTL_NUMBER_OF
by pschweitzer＠svn.reactos.org 11 Nov '16

11 Nov '16

Author: pschweitzer Date: Fri Nov 11 18:16:43 2016 New Revision: 73202 URL: http://svn.reactos.org/svn/reactos?rev=73202&view=rev Log: [NTOSKRNL] Don't redefine RTL_NUMBER_OF Modified: trunk/reactos/ntoskrnl/kdbg/kdb.h trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/kdbg/kdb.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kdbg/kdb.h?rev=73… ============================================================================== --- trunk/reactos/ntoskrnl/kdbg/kdb.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kdbg/kdb.h [iso-8859-1] Fri Nov 11 18:16:43 2016 @@ -1,10 +1,6 @@ #pragma once /* DEFINES *******************************************************************/ - -#ifndef RTL_NUMBER_OF -# define RTL_NUMBER_OF(x) (sizeof(x) / sizeof((x)[0])) -#endif /* formerly located in kdbg/kdb_symbols.c */ #define TAG_KDBS 'SBDK' Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Fri Nov 11 18:16:43 2016 @@ -3152,11 +3152,6 @@ IN PEXEFMT_CB_READ_FILE ReadFileCb, IN PEXEFMT_CB_ALLOCATE_SEGMENTS AllocateSegmentsCb ); - -/* TODO: this is a standard DDK/PSDK macro */ -#ifndef RTL_NUMBER_OF -#define RTL_NUMBER_OF(ARR_) (sizeof(ARR_) / sizeof((ARR_)[0])) -#endif static PEXEFMT_LOADER ExeFmtpLoaders[] = {

1 0

[cwittich] 73201: [PSDK] small fixes for dns headers
by cwittich＠svn.reactos.org 11 Nov '16

11 Nov '16

Author: cwittich Date: Fri Nov 11 14:21:55 2016 New Revision: 73201 URL: http://svn.reactos.org/svn/reactos?rev=73201&view=rev Log: [PSDK] small fixes for dns headers Modified: trunk/reactos/sdk/include/psdk/windns.h trunk/reactos/sdk/include/reactos/idl/dnsrslvr.idl Modified: trunk/reactos/sdk/include/psdk/windns.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/psdk/windns.h?… ============================================================================== --- trunk/reactos/sdk/include/psdk/windns.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/psdk/windns.h [iso-8859-1] Fri Nov 11 14:21:55 2016 @@ -626,6 +626,7 @@ DNS_WINSR_DATAW WINSR, WinsR, NBSTAT, Nbstat; } Data; } DNS_RECORDW, *PDNS_RECORDW; +#endif #ifdef UNICODE #define DNS_RECORD DNS_RECORDW @@ -633,8 +634,6 @@ #else #define DNS_RECORD DNS_RECORDA #define PDNS_RECORD PDNS_RECORDA -#endif - #endif typedef struct _DnsRRSet { Modified: trunk/reactos/sdk/include/reactos/idl/dnsrslvr.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/reactos/idl/dn… ============================================================================== --- trunk/reactos/sdk/include/reactos/idl/dnsrslvr.idl [iso-8859-1] (original) +++ trunk/reactos/sdk/include/reactos/idl/dnsrslvr.idl [iso-8859-1] Fri Nov 11 14:21:55 2016 @@ -3,6 +3,8 @@ */ #include <ms-dtyp.idl> + +#define UNICODE #include <sal.h> #include <windns.h> @@ -48,7 +50,7 @@ [in] WORD wType, [in] DWORD Flags, [in][out] DWORD *dwRecords, - [out][ref] _DnsRecordW** ppResultRecords); + [out][ref] DNS_RECORDW** ppResultRecords); /* Function: 0x08 */ /* R_ResolverEnumCache */

1 0

← Newer
1
...
18
19
20
21
22
23
24
...
32
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2016