Ros-diffs November 2016

ros-diffs@reactos.org

15 participants
317 discussions

[tfaber] 73190: [NTDLL_APITEST] - Add tests for RtlIsNameLegalDOS8Dot3 and RtlUpcaseUnicodeStringToCountedOemString with the ® sign. CORE-8617

by tfaber＠svn.reactos.org

Author: tfaber Date: Thu Nov 10 10:18:25 2016 New Revision: 73190 URL: http://svn.reactos.org/svn/reactos?rev=73190&view=rev Log: [NTDLL_APITEST] - Add tests for RtlIsNameLegalDOS8Dot3 and RtlUpcaseUnicodeStringToCountedOemString with the ® sign. CORE-8617 Added: trunk/rostests/apitests/ntdll/RtlIsNameLegalDOS8Dot3.c (with props) trunk/rostests/apitests/ntdll/RtlUpcaseUnicodeStringToCountedOemString.c (with props) Modified: trunk/rostests/apitests/ntdll/CMakeLists.txt trunk/rostests/apitests/ntdll/testlist.c Modified: trunk/rostests/apitests/ntdll/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/CMakeLists… ============================================================================== --- trunk/rostests/apitests/ntdll/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/CMakeLists.txt [iso-8859-1] Thu Nov 10 10:18:25 2016 @@ -40,8 +40,10 @@ RtlGetLongestNtPathLength.c RtlImageRvaToVa.c RtlInitializeBitMap.c + RtlIsNameLegalDOS8Dot3.c RtlMemoryStream.c RtlReAllocateHeap.c + RtlUpcaseUnicodeStringToCountedOemString.c StackOverflow.c SystemInfo.c Timer.c Added: trunk/rostests/apitests/ntdll/RtlIsNameLegalDOS8Dot3.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/RtlIsNameL… ============================================================================== --- trunk/rostests/apitests/ntdll/RtlIsNameLegalDOS8Dot3.c (added) +++ trunk/rostests/apitests/ntdll/RtlIsNameLegalDOS8Dot3.c [iso-8859-1] Thu Nov 10 10:18:25 2016 @@ -0,0 +1,35 @@ +/* + * PROJECT: ReactOS API tests + * LICENSE: LGPLv2.1+ - See COPYING.LIB in the top level directory + * PURPOSE: Test for RtlIsNameLegalDOS8Dot3 + * PROGRAMMER: Thomas Faber <thomas.faber(a)reactos.org> + */ + +#include <apitest.h> + +#define WIN32_NO_STATUS +#include <ndk/rtlfuncs.h> + +START_TEST(RtlIsNameLegalDOS8Dot3) +{ + UNICODE_STRING Name; + CHAR OemNameBuffer[13]; + OEM_STRING OemName; + BOOLEAN NameContainsSpaces; + BOOLEAN IsLegal; + + RtlInitUnicodeString(&Name, L"\x00ae"); + RtlFillMemory(OemNameBuffer, sizeof(OemNameBuffer), 0x55); + OemName.Buffer = OemNameBuffer; + OemName.Length = 0; + OemName.MaximumLength = sizeof(OemNameBuffer); + NameContainsSpaces = 0x55; + IsLegal = RtlIsNameLegalDOS8Dot3(&Name, &OemName, &NameContainsSpaces); + ok(IsLegal == TRUE, "IsLegal = %u\n", IsLegal); + ok(NameContainsSpaces == FALSE, "NameContainsSpaces = %u\n", NameContainsSpaces); + ok(OemName.Length == 1, "OemName.Length = %u\n", OemName.Length); + ok(OemNameBuffer[0] == 'R', "OemNameBuffer[0] = 0x%x\n", OemNameBuffer[0]); + ok(OemNameBuffer[1] == 0x55, "OemNameBuffer[1] = 0x%x\n", OemNameBuffer[1]); + ok(OemNameBuffer[2] == 0x55, "OemNameBuffer[2] = 0x%x\n", OemNameBuffer[2]); + +} Propchange: trunk/rostests/apitests/ntdll/RtlIsNameLegalDOS8Dot3.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/rostests/apitests/ntdll/RtlUpcaseUnicodeStringToCountedOemString.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/RtlUpcaseU… ============================================================================== --- trunk/rostests/apitests/ntdll/RtlUpcaseUnicodeStringToCountedOemString.c (added) +++ trunk/rostests/apitests/ntdll/RtlUpcaseUnicodeStringToCountedOemString.c [iso-8859-1] Thu Nov 10 10:18:25 2016 @@ -0,0 +1,31 @@ +/* + * PROJECT: ReactOS API tests + * LICENSE: LGPLv2.1+ - See COPYING.LIB in the top level directory + * PURPOSE: Test for RtlUpcaseUnicodeStringToCountedOemString + * PROGRAMMER: Thomas Faber <thomas.faber(a)reactos.org> + */ + +#include <apitest.h> + +#define WIN32_NO_STATUS +#include <ndk/rtlfuncs.h> + +START_TEST(RtlUpcaseUnicodeStringToCountedOemString) +{ + NTSTATUS Status; + UNICODE_STRING Name; + CHAR OemNameBuffer[13]; + OEM_STRING OemName; + + RtlInitUnicodeString(&Name, L"\x00ae"); + RtlFillMemory(OemNameBuffer, sizeof(OemNameBuffer), 0x55); + OemName.Buffer = OemNameBuffer; + OemName.Length = 0; + OemName.MaximumLength = sizeof(OemNameBuffer); + Status = RtlUpcaseUnicodeStringToCountedOemString(&OemName, &Name, FALSE); + ok(Status == STATUS_SUCCESS, "Status = 0x%lx\n", Status); + ok(OemName.Length == 1, "OemName.Length = %u\n", OemName.Length); + ok(OemNameBuffer[0] == 'R', "OemNameBuffer[0] = 0x%x\n", OemNameBuffer[0]); + ok(OemNameBuffer[1] == 0x55, "OemNameBuffer[1] = 0x%x\n", OemNameBuffer[1]); + ok(OemNameBuffer[2] == 0x55, "OemNameBuffer[2] = 0x%x\n", OemNameBuffer[2]); +} Propchange: trunk/rostests/apitests/ntdll/RtlUpcaseUnicodeStringToCountedOemString.c ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/rostests/apitests/ntdll/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/testlist.c… ============================================================================== --- trunk/rostests/apitests/ntdll/testlist.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/testlist.c [iso-8859-1] Thu Nov 10 10:18:25 2016 @@ -44,8 +44,10 @@ extern void func_RtlGetLongestNtPathLength(void); extern void func_RtlImageRvaToVa(void); extern void func_RtlInitializeBitMap(void); +extern void func_RtlIsNameLegalDOS8Dot3(void); extern void func_RtlMemoryStream(void); extern void func_RtlReAllocateHeap(void); +extern void func_RtlUpcaseUnicodeStringToCountedOemString(void); extern void func_StackOverflow(void); extern void func_TimerResolution(void); @@ -92,8 +94,10 @@ { "RtlGetLongestNtPathLength", func_RtlGetLongestNtPathLength }, { "RtlImageRvaToVa", func_RtlImageRvaToVa }, { "RtlInitializeBitMap", func_RtlInitializeBitMap }, + { "RtlIsNameLegalDOS8Dot3", func_RtlIsNameLegalDOS8Dot3 }, { "RtlMemoryStream", func_RtlMemoryStream }, { "RtlReAllocateHeap", func_RtlReAllocateHeap }, + { "RtlUpcaseUnicodeStringToCountedOemString", func_RtlUpcaseUnicodeStringToCountedOemString }, { "StackOverflow", func_StackOverflow }, { "TimerResolution", func_TimerResolution },

8 years, 1 month

[gadamopoulos] 73189: [SHELL32] - CStartMenu: Add missing checks for failure and make some checks noisy. CORE-12300

by gadamopoulos＠svn.reactos.org

Author: gadamopoulos Date: Thu Nov 10 09:34:14 2016 New Revision: 73189 URL: http://svn.reactos.org/svn/reactos?rev=73189&view=rev Log: [SHELL32] - CStartMenu: Add missing checks for failure and make some checks noisy. CORE-12300 Modified: trunk/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp Modified: trunk/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shellmen… ============================================================================== --- trunk/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shellmenu/CStartMenu.cpp [iso-8859-1] Thu Nov 10 09:34:14 2016 @@ -167,6 +167,8 @@ return hr; hr = pShellMenu->Initialize(this, 0, ANCESTORDEFAULT, SMINIT_VERTICAL); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; switch (psmd->uId) { @@ -188,11 +190,22 @@ LPITEMIDLIST pidlStartMenu; IShellFolder *psfDestop; hr = SHGetFolderLocation(NULL, csidl, 0, 0, &pidlStartMenu); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + hr = SHGetDesktopFolder(&psfDestop); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + hr = psfDestop->BindToObject(pidlStartMenu, NULL, IID_PPV_ARG(IShellFolder, &psfStartMenu)); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; } hr = pShellMenu->SetShellFolder(psfStartMenu, NULL, NULL, 0); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + } else { @@ -202,6 +215,8 @@ if (GetMenuItemInfoW(psmd->hmenu, psmd->uId, FALSE, &mii)) { hr = pShellMenu->SetMenu(mii.hSubMenu, NULL, SMSET_BOTTOM); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; } } return pShellMenu->QueryInterface(iid, pv); @@ -475,7 +490,7 @@ /* psf is a merged folder, so now we want to get the pidl of the programs item from the merged folder */ { hr = SHGetSpecialFolderLocation(NULL, CSIDL_PROGRAMS, &pidlProgramsAbsolute); - if (FAILED(hr)) + if (FAILED_UNEXPECTEDLY(hr)) { WARN("USER Programs folder not found."); hr = SHGetSpecialFolderLocation(NULL, CSIDL_COMMON_PROGRAMS, &pidlProgramsAbsolute); @@ -489,11 +504,11 @@ TCHAR szDisplayName[MAX_PATH]; hr = SHBindToParent(pidlProgramsAbsolute, IID_PPV_ARG(IShellFolder, &psfParent), &pcidlPrograms); - if (FAILED(hr)) + if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = psfParent->GetDisplayNameOf(pcidlPrograms, SHGDN_FORPARSING | SHGDN_INFOLDER, &str); - if (FAILED(hr)) + if (FAILED_UNEXPECTEDLY(hr)) return hr; StrRetToBuf(&str, pcidlPrograms, szDisplayName, _countof(szDisplayName)); @@ -501,7 +516,7 @@ /* We got the display name from the fs folder and we parse it with the merged folder here */ hr = psf->ParseDisplayName(NULL, NULL, szDisplayName, NULL, &pidlPrograms, NULL); - if (FAILED(hr)) + if (FAILED_UNEXPECTEDLY(hr)) return hr; }

8 years, 1 month

[gadamopoulos] 73188: [SHELL32] - CMenuBand: Don't accept a NULL shell folder in SetShellFolder. Should fix a test and possibly CORE-12300.

by gadamopoulos＠svn.reactos.org

Author: gadamopoulos Date: Thu Nov 10 08:10:28 2016 New Revision: 73188 URL: http://svn.reactos.org/svn/reactos?rev=73188&view=rev Log: [SHELL32] - CMenuBand: Don't accept a NULL shell folder in SetShellFolder. Should fix a test and possibly CORE-12300. Modified: trunk/reactos/dll/win32/shell32/shellmenu/CMenuBand.cpp Modified: trunk/reactos/dll/win32/shell32/shellmenu/CMenuBand.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shellmen… ============================================================================== --- trunk/reactos/dll/win32/shell32/shellmenu/CMenuBand.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shellmenu/CMenuBand.cpp [iso-8859-1] Thu Nov 10 08:10:28 2016 @@ -672,6 +672,9 @@ HRESULT STDMETHODCALLTYPE CMenuBand::SetShellFolder(IShellFolder *psf, LPCITEMIDLIST pidlFolder, HKEY hKey, DWORD dwFlags) { + if (!psf) + return E_INVALIDARG; + if (m_SFToolbar == NULL) { m_SFToolbar = new CMenuSFToolbar(this);

8 years, 1 month

[gadamopoulos] 73187: [SHELL32] - Make some checks for failure in CDefView and CDefaultContextMenu noisy.

by gadamopoulos＠svn.reactos.org

Author: gadamopoulos Date: Thu Nov 10 08:05:13 2016 New Revision: 73187 URL: http://svn.reactos.org/svn/reactos?rev=73187&view=rev Log: [SHELL32] - Make some checks for failure in CDefView and CDefaultContextMenu noisy. Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp trunk/reactos/dll/win32/shell32/CDefaultContextMenu.cpp trunk/reactos/dll/win32/shell32/folders/CPrinterFolder.cpp Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CDefView… ============================================================================== --- trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] Thu Nov 10 08:05:13 2016 @@ -1212,7 +1212,11 @@ if (GetKeyState(VK_CONTROL) & 0x8000) cmi.fMask |= CMIC_MASK_CONTROL_DOWN; - return m_pCM->InvokeCommand(&cmi); + HRESULT hr = m_pCM->InvokeCommand(&cmi); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + return S_OK; } /********************************************************** @@ -1237,13 +1241,13 @@ return E_FAIL; hResult = GetItemObject(SVGIO_SELECTION, IID_PPV_ARG(IContextMenu, &m_pCM)); - if (FAILED(hResult)) + if (FAILED_UNEXPECTEDLY(hResult)) goto cleanup; IUnknown_SetSite(m_pCM, (IShellView *)this); hResult = m_pCM->QueryContextMenu(hMenu, 0, 0x20, 0x7fff, CMF_DEFAULTONLY); - if (FAILED(hResult)) + if (FAILED_UNEXPECTEDLY(hResult)) goto cleanup; uCommand = GetMenuDefaultItem(hMenu, FALSE, 0); @@ -1290,13 +1294,13 @@ m_cidl = m_ListView.GetSelectedCount(); hResult = GetItemObject( m_cidl ? SVGIO_SELECTION : SVGIO_BACKGROUND, IID_PPV_ARG(IContextMenu, &m_pCM)); - if (FAILED( hResult)) + if (FAILED_UNEXPECTEDLY(hResult)) goto cleanup; IUnknown_SetSite(m_pCM, (IShellView *)this); hResult = m_pCM->QueryContextMenu(m_hContextMenu, 0, FCIDM_SHVIEWFIRST, FCIDM_SHVIEWLAST, CMF_NORMAL); - if (FAILED( hResult)) + if (FAILED_UNEXPECTEDLY(hResult)) goto cleanup; uCommand = TrackPopupMenu(m_hContextMenu, @@ -1336,13 +1340,13 @@ return 0; hResult = GetItemObject( bUseSelection ? SVGIO_SELECTION : SVGIO_BACKGROUND, IID_PPV_ARG(IContextMenu, &m_pCM)); - if (FAILED( hResult)) + if (FAILED_UNEXPECTEDLY( hResult)) goto cleanup; IUnknown_SetSite(m_pCM, (IShellView *)this); hResult = m_pCM->QueryContextMenu(hMenu, 0, FCIDM_SHVIEWFIRST, FCIDM_SHVIEWLAST, CMF_NORMAL); - if (FAILED( hResult)) + if (FAILED_UNEXPECTEDLY( hResult)) goto cleanup; InvokeContextMenuCommand(uCommand); @@ -1688,11 +1692,8 @@ if (m_pSF2Parent) { SHELLDETAILS sd; - if (FAILED(m_pSF2Parent->GetDetailsOf(pidl, lpdi->item.iSubItem, &sd))) - { - FIXME("failed to get details\n"); + if (FAILED_UNEXPECTEDLY(m_pSF2Parent->GetDetailsOf(pidl, lpdi->item.iSubItem, &sd))) break; - } if (lpnmh->code == LVN_GETDISPINFOA) { @@ -2228,7 +2229,7 @@ IContextMenu* pcm; hr = CDefFolderMenu_Create2(NULL, NULL, 0, NULL, m_pSFParent, NULL, 0, NULL, &pcm); - if (FAILED(hr)) + if (FAILED_UNEXPECTEDLY(hr)) return hr; *ppvOut = pcm; } @@ -2238,9 +2239,7 @@ { hr = CDefViewDual_Constructor(riid, (LPVOID*)&m_pShellFolderViewDual); if (FAILED_UNEXPECTEDLY(hr)) - { return hr; - } } hr = m_pShellFolderViewDual->QueryInterface(riid, ppvOut); } @@ -2249,6 +2248,8 @@ case SVGIO_SELECTION: GetSelections(); hr = m_pSFParent->GetUIObjectOf(m_hWnd, m_cidl, m_apidl, riid, 0, ppvOut); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; break; } Modified: trunk/reactos/dll/win32/shell32/CDefaultContextMenu.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CDefault… ============================================================================== --- trunk/reactos/dll/win32/shell32/CDefaultContextMenu.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CDefaultContextMenu.cpp [iso-8859-1] Thu Nov 10 08:05:13 2016 @@ -360,9 +360,7 @@ PDynamicShellEntry pEntry = (DynamicShellEntry *)HeapAlloc(GetProcessHeap(), 0, sizeof(DynamicShellEntry)); if (!pEntry) - { return E_OUTOFMEMORY; - } pEntry->iIdCmdFirst = 0; pEntry->pNext = NULL; @@ -829,7 +827,11 @@ if (FAILED_UNEXPECTEDLY(hr)) return hr; - return psv->Refresh(); + hr = psv->Refresh(); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + return S_OK; } HRESULT CDefaultContextMenu::DoPaste(LPCMINVOKECOMMANDINFO lpcmi, BOOL bLink) @@ -932,7 +934,11 @@ m_pDataObj->SetData(&formatetc, &medium, TRUE); } - return OleSetClipboard(m_pDataObj); + HRESULT hr = OleSetClipboard(m_pDataObj); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + return S_OK; } HRESULT CDefaultContextMenu::DoRename(LPCMINVOKECOMMANDINFO lpcmi) @@ -954,7 +960,10 @@ return hr; SVSIF selFlags = SVSI_DESELECTOTHERS | SVSI_EDIT | SVSI_ENSUREVISIBLE | SVSI_FOCUSED | SVSI_SELECT; - lpSV->SelectItem(m_apidl[0], selFlags); + hr = lpSV->SelectItem(m_apidl[0], selFlags); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + return S_OK; } @@ -1115,10 +1124,12 @@ hr = psv->SelectItem(pidlNewItem, SVSI_DESELECTOTHERS | SVSI_EDIT | SVSI_ENSUREVISIBLE | SVSI_FOCUSED | SVSI_SELECT); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; SHFree(pidl); - return hr; + return S_OK; } PDynamicShellEntry CDefaultContextMenu::GetDynamicEntry(UINT idCmd) @@ -1216,7 +1227,7 @@ /* Try to get the flag from the verb */ hr = StringCbPrintfW(wszKey, sizeof(wszKey), L"shell\\%s", pEntry->szVerb); - if (!SUCCEEDED(hr)) + if (FAILED_UNEXPECTEDLY(hr)) return 0; cbVerb = sizeof(wFlags); @@ -1650,7 +1661,11 @@ if (!pdcm->aKeys && pdcm->cidl) HackFillKeys((DEFCONTEXTMENU *)pdcm, hkeyHack); - return CDefaultContextMenu_CreateInstance(pdcm, riid, ppv); + HRESULT hr = CDefaultContextMenu_CreateInstance(pdcm, riid, ppv); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + return S_OK; } /************************************************************************* @@ -1683,6 +1698,8 @@ pdcm.aKeys = ahkeyClsKeys; HRESULT hr = SHCreateDefaultContextMenu(&pdcm, IID_PPV_ARG(IContextMenu, ppcm)); - return hr; -} - + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + return S_OK; +} Modified: trunk/reactos/dll/win32/shell32/folders/CPrinterFolder.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/folders/… ============================================================================== --- trunk/reactos/dll/win32/shell32/folders/CPrinterFolder.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/folders/CPrinterFolder.cpp [iso-8859-1] Thu Nov 10 08:05:13 2016 @@ -54,8 +54,8 @@ { CComPtr<IDefaultExtractIconInit> initIcon; HRESULT hr = SHCreateDefaultExtractIcon(IID_PPV_ARG(IDefaultExtractIconInit,&initIcon)); - if (FAILED(hr)) - return NULL; + if (FAILED_UNEXPECTEDLY(hr)) + return hr; /* FIXME: other icons for default, network, print to file */ initIcon->SetNormalIcon(swShell32Name, -IDI_SHELL_PRINTER);

8 years, 1 month

[mjansen] 73186: and of course also rename the test itself...

by mjansen＠svn.reactos.org

Author: mjansen Date: Wed Nov 9 23:23:50 2016 New Revision: 73186 URL: http://svn.reactos.org/svn/reactos?rev=73186&view=rev Log: and of course also rename the test itself... Modified: trunk/rostests/apitests/shell32/ShellExecuteEx.cpp trunk/rostests/apitests/shell32/testlist.c Modified: trunk/rostests/apitests/shell32/ShellExecuteEx.cpp URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/ShellExe… ============================================================================== --- trunk/rostests/apitests/shell32/ShellExecuteEx.cpp [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/ShellExecuteEx.cpp [iso-8859-1] Wed Nov 9 23:23:50 2016 @@ -84,7 +84,7 @@ } } -START_TEST(shlexec) +START_TEST(ShellExecuteEx) { ok_ShellExecuteEx(L"iexplore", TRUE); ok_ShellExecuteEx(L"iexplore.exe", TRUE); Modified: trunk/rostests/apitests/shell32/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/testlist… ============================================================================== --- trunk/rostests/apitests/shell32/testlist.c [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/testlist.c [iso-8859-1] Wed Nov 9 23:23:50 2016 @@ -7,8 +7,8 @@ extern void func_CShellDesktop(void); extern void func_CShellLink(void); extern void func_menu(void); +extern void func_ShellExecuteEx(void); extern void func_SHParseDisplayName(void); -extern void func_shlexec(void); const struct test winetest_testlist[] = { @@ -16,7 +16,7 @@ { "CShellDesktop", func_CShellDesktop }, { "CShellLink", func_CShellLink }, { "menu", func_menu }, + { "ShellExecuteEx", func_ShellExecuteEx }, { "SHParseDisplayName", func_SHParseDisplayName }, - { "shlexec", func_shlexec }, { 0, 0 } };

8 years, 1 month

[mjansen] 73185: Rename shlexec.cpp to ShellExecuteEx.cpp as suggested by Thomas.

by mjansen＠svn.reactos.org

Author: mjansen Date: Wed Nov 9 23:18:23 2016 New Revision: 73185 URL: http://svn.reactos.org/svn/reactos?rev=73185&view=rev Log: Rename shlexec.cpp to ShellExecuteEx.cpp as suggested by Thomas. Added: trunk/rostests/apitests/shell32/ShellExecuteEx.cpp - copied unchanged from r73184, trunk/rostests/apitests/shell32/shlexec.cpp Removed: trunk/rostests/apitests/shell32/shlexec.cpp Modified: trunk/rostests/apitests/shell32/CMakeLists.txt Modified: trunk/rostests/apitests/shell32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/CMakeLis… ============================================================================== --- trunk/rostests/apitests/shell32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/CMakeLists.txt [iso-8859-1] Wed Nov 9 23:18:23 2016 @@ -8,9 +8,9 @@ CShellDesktop.cpp CShellLink.cpp menu.cpp + ShellExecuteEx.cpp shelltest.cpp SHParseDisplayName.cpp - shlexec.cpp testlist.c) target_link_libraries(shell32_apitest wine uuid ${PSEH_LIB}) set_module_type(shell32_apitest win32cui) Removed: trunk/rostests/apitests/shell32/shlexec.cpp URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/shlexec.… ============================================================================== --- trunk/rostests/apitests/shell32/shlexec.cpp [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/shlexec.cpp (removed) @@ -1,105 +0,0 @@ -/* - * PROJECT: ReactOS api tests - * LICENSE: GPLv2+ - See COPYING in the top level directory - * PURPOSE: Testing ShellExecuteEx - * PROGRAMMER: Yaroslav Veremenko <yaroslav(a)veremenko.info> - */ - - -#include "shelltest.h" - - - -#define ok_ShellExecuteEx (winetest_set_location(__FILE__, __LINE__), 0) ? (void)0 : TestShellExecuteEx - -static -BOOL -CreateAppPathRegKey(const WCHAR* Name) -{ - HKEY RegistryKey; - LONG Result; - WCHAR Buffer[1024]; - WCHAR KeyValue[1024]; - DWORD Length = sizeof(KeyValue); - DWORD Disposition; - - wcscpy(Buffer, L"Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\"); - wcscat(Buffer, L"IEXPLORE.EXE"); - Result = RegOpenKeyExW(HKEY_LOCAL_MACHINE, Buffer, 0, KEY_READ, &RegistryKey); - if (Result != ERROR_SUCCESS) trace("Could not open iexplore.exe key. Status: %lu\n", Result); - if (Result) goto end; - Result = RegQueryValueExW(RegistryKey, NULL, NULL, NULL, (LPBYTE)KeyValue, &Length); - if (Result != ERROR_SUCCESS) trace("Could not read iexplore.exe key. Status: %lu\n", Result); - if (Result) goto end; - RegCloseKey(RegistryKey); - - wcscpy(Buffer, L"Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\"); - wcscat(Buffer, Name); - Result = RegCreateKeyExW(HKEY_LOCAL_MACHINE, Buffer, 0, NULL, - 0, KEY_WRITE, NULL, &RegistryKey, &Disposition); - if (Result != ERROR_SUCCESS) trace("Could not create test key. Status: %lu\n", Result); - if (Result) goto end; - Result = RegSetValueW(RegistryKey, NULL, REG_SZ, KeyValue, 0); - if (Result != ERROR_SUCCESS) trace("Could not set value of the test key. Status: %lu\n", Result); - if (Result) goto end; - RegCloseKey(RegistryKey); -end: - if (RegistryKey) RegCloseKey(RegistryKey); - return Result == ERROR_SUCCESS; -} - -static -VOID -DeleteAppPathRegKey(const WCHAR* Name) -{ - LONG Result; - WCHAR Buffer[1024]; - wcscpy(Buffer, L"Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\"); - wcscat(Buffer, Name); - Result = RegDeleteKeyW(HKEY_LOCAL_MACHINE, Buffer); - if (Result != ERROR_SUCCESS) trace("Could not remove the test key. Status: %lu\n", Result); -} - -static -VOID -TestShellExecuteEx(const WCHAR* Name, BOOL ExpectedResult) -{ - SHELLEXECUTEINFOW ShellExecInfo; - BOOL Result; - ZeroMemory(&ShellExecInfo, sizeof(ShellExecInfo)); - ShellExecInfo.cbSize = sizeof(ShellExecInfo); - ShellExecInfo.fMask = SEE_MASK_NOCLOSEPROCESS | SEE_MASK_FLAG_NO_UI; - ShellExecInfo.hwnd = NULL; - ShellExecInfo.nShow = SW_SHOWNORMAL; - ShellExecInfo.lpFile = Name; - ShellExecInfo.lpDirectory = NULL; - Result = ShellExecuteExW(&ShellExecInfo); - ok(Result == ExpectedResult, "ShellExecuteEx lpFile %s failed. Error: %lu\n", wine_dbgstr_w(Name), GetLastError()); - if (ShellExecInfo.hProcess) - { - Result = TerminateProcess(ShellExecInfo.hProcess, 0); - if (!Result) trace("Terminate process failed. Error: %lu\n", GetLastError()); - WaitForSingleObject(ShellExecInfo.hProcess, INFINITE); - CloseHandle(ShellExecInfo.hProcess); - } -} - -START_TEST(shlexec) -{ - ok_ShellExecuteEx(L"iexplore", TRUE); - ok_ShellExecuteEx(L"iexplore.exe", TRUE); - - if (CreateAppPathRegKey(L"iexplore.bat")) - { - ok_ShellExecuteEx(L"iexplore.bat", TRUE); - ok_ShellExecuteEx(L"iexplore.bat.exe", FALSE); - DeleteAppPathRegKey(L"iexplore.bat"); - } - - if (CreateAppPathRegKey(L"iexplore.bat.exe")) - { - ok_ShellExecuteEx(L"iexplore.bat", FALSE); - ok_ShellExecuteEx(L"iexplore.bat.exe", TRUE); - DeleteAppPathRegKey(L"iexplore.bat.exe"); - } -}

8 years, 1 month

[tfaber] 73184: [PROPSYS_WINETEST] - Fix VS2010 build

by tfaber＠svn.reactos.org

Author: tfaber Date: Wed Nov 9 22:55:16 2016 New Revision: 73184 URL: http://svn.reactos.org/svn/reactos?rev=73184&view=rev Log: [PROPSYS_WINETEST] - Fix VS2010 build Modified: trunk/rostests/winetests/propsys/propsys.c Modified: trunk/rostests/winetests/propsys/propsys.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/propsys/propsys… ============================================================================== --- trunk/rostests/winetests/propsys/propsys.c [iso-8859-1] (original) +++ trunk/rostests/winetests/propsys/propsys.c [iso-8859-1] Wed Nov 9 22:55:16 2016 @@ -353,7 +353,7 @@ } testcases[] = { {NULL, NULL, E_POINTER}, - {NULL, &out, E_POINTER, out_init}, + {NULL, &out, E_POINTER, {GUID_MEMBERS(out_init.fmtid), out_init.pid}}, {emptyW, NULL, E_POINTER}, {emptyW, &out, E_INVALIDARG, {GUID_MEMBERS(GUID_NULL), 0}}, {fmtid_clsidW, &out, E_INVALIDARG, {GUID_MEMBERS(GUID_NULL), 0}},

8 years, 1 month

[mjansen] 73183: addendum to r73180 (aka, fix the build)

by mjansen＠svn.reactos.org

Author: mjansen Date: Wed Nov 9 22:24:42 2016 New Revision: 73183 URL: http://svn.reactos.org/svn/reactos?rev=73183&view=rev Log: addendum to r73180 (aka, fix the build) Modified: trunk/rostests/apitests/shell32/shlexec.cpp Modified: trunk/rostests/apitests/shell32/shlexec.cpp URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/shell32/shlexec.… ============================================================================== --- trunk/rostests/apitests/shell32/shlexec.cpp [iso-8859-1] (original) +++ trunk/rostests/apitests/shell32/shlexec.cpp [iso-8859-1] Wed Nov 9 22:24:42 2016 @@ -26,10 +26,10 @@ wcscpy(Buffer, L"Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\"); wcscat(Buffer, L"IEXPLORE.EXE"); Result = RegOpenKeyExW(HKEY_LOCAL_MACHINE, Buffer, 0, KEY_READ, &RegistryKey); - if (Result != ERROR_SUCCESS) trace("Could not open iexplore.exe key. Status: %d\n", Result); + if (Result != ERROR_SUCCESS) trace("Could not open iexplore.exe key. Status: %lu\n", Result); if (Result) goto end; Result = RegQueryValueExW(RegistryKey, NULL, NULL, NULL, (LPBYTE)KeyValue, &Length); - if (Result != ERROR_SUCCESS) trace("Could not read iexplore.exe key. Status: %d\n", Result); + if (Result != ERROR_SUCCESS) trace("Could not read iexplore.exe key. Status: %lu\n", Result); if (Result) goto end; RegCloseKey(RegistryKey); @@ -37,10 +37,10 @@ wcscat(Buffer, Name); Result = RegCreateKeyExW(HKEY_LOCAL_MACHINE, Buffer, 0, NULL, 0, KEY_WRITE, NULL, &RegistryKey, &Disposition); - if (Result != ERROR_SUCCESS) trace("Could not create test key. Status: %d\n", Result); + if (Result != ERROR_SUCCESS) trace("Could not create test key. Status: %lu\n", Result); if (Result) goto end; Result = RegSetValueW(RegistryKey, NULL, REG_SZ, KeyValue, 0); - if (Result != ERROR_SUCCESS) trace("Could not set value of the test key. Status: %d\n", Result); + if (Result != ERROR_SUCCESS) trace("Could not set value of the test key. Status: %lu\n", Result); if (Result) goto end; RegCloseKey(RegistryKey); end: @@ -57,7 +57,7 @@ wcscpy(Buffer, L"Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\"); wcscat(Buffer, Name); Result = RegDeleteKeyW(HKEY_LOCAL_MACHINE, Buffer); - if (Result != ERROR_SUCCESS) trace("Could not remove the test key. Status: %d\n", Result); + if (Result != ERROR_SUCCESS) trace("Could not remove the test key. Status: %lu\n", Result); } static @@ -74,11 +74,11 @@ ShellExecInfo.lpFile = Name; ShellExecInfo.lpDirectory = NULL; Result = ShellExecuteExW(&ShellExecInfo); - ok(Result == ExpectedResult, "ShellExecuteEx lpFile %s failed. Error: %d\n", wine_dbgstr_w(Name), GetLastError()); + ok(Result == ExpectedResult, "ShellExecuteEx lpFile %s failed. Error: %lu\n", wine_dbgstr_w(Name), GetLastError()); if (ShellExecInfo.hProcess) { Result = TerminateProcess(ShellExecInfo.hProcess, 0); - if (!Result) trace("Terminate process failed. Error: %d\n", GetLastError()); + if (!Result) trace("Terminate process failed. Error: %lu\n", GetLastError()); WaitForSingleObject(ShellExecInfo.hProcess, INFINITE); CloseHandle(ShellExecInfo.hProcess); }

8 years, 1 month

[mjansen] 73182: [SHELL32] Automatically add the .exe extension for App Paths in ShellExecuteEx. Patch by Yaroslav Veremenko. CORE-12049

by mjansen＠svn.reactos.org

Author: mjansen Date: Wed Nov 9 22:18:33 2016 New Revision: 73182 URL: http://svn.reactos.org/svn/reactos?rev=73182&view=rev Log: [SHELL32] Automatically add the .exe extension for App Paths in ShellExecuteEx. Patch by Yaroslav Veremenko. CORE-12049 Modified: trunk/reactos/dll/win32/shell32/shlexec.cpp Modified: trunk/reactos/dll/win32/shell32/shlexec.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shlexec.… ============================================================================== --- trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] Wed Nov 9 22:18:33 2016 @@ -576,7 +576,15 @@ wcscpy(buffer, L"Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\"); wcscat(buffer, szName); res = RegOpenKeyExW(HKEY_LOCAL_MACHINE, buffer, 0, KEY_READ, &hkApp); - if (res) goto end; + if (res) + { + // Add ".exe" extension, if extension does not exists + if (PathAddExtensionW(buffer, wszExe)) + { + res = RegOpenKeyExW(HKEY_LOCAL_MACHINE, buffer, 0, KEY_READ, &hkApp); + } + if (res) goto end; + } len = MAX_PATH * sizeof(WCHAR); res = RegQueryValueW(hkApp, NULL, lpResult, &len);

8 years, 1 month

[hbelusca] 73181: [EVENTVWR]: Adjust some menu keyboard shortcuts.

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Wed Nov 9 22:14:20 2016 New Revision: 73181 URL: http://svn.reactos.org/svn/reactos?rev=73181&view=rev Log: [EVENTVWR]: Adjust some menu keyboard shortcuts. Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/bg-BG.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/cs-CZ.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/el-GR.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/en-US.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/es-ES.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/he-IL.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/it-IT.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/ja-JP.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/ko-KR.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/no-NO.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/pl-PL.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/pt-BR.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/ro-RO.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/ru-RU.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/sk-SK.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/sq-AL.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/sv-SE.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/tr-TR.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/uk-UA.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-CN.rc trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-TW.rc Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/bg-BG.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -6,7 +6,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/cs-CZ.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/cs-CZ.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -6,7 +6,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "&Odstranit udÃ¡losti", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/de-DE.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,9 +8,9 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR - MENUITEM "Alle E&reignisse lÃ¶schen", IDM_CLEAR_EVENTS + MENUITEM "&Alle Ereignisse lÃ¶schen", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG MENUITEM "Log Se&ttings...", IDM_EVENTLOG_SETTINGS MENUITEM SEPARATOR Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/el-GR.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/en-US.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -14,7 +14,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/es-ES.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "&Borrar todos los eventos", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/fr-FR.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -6,15 +6,15 @@ BEGIN POPUP "&Journal" BEGIN - MENUITEM "Ouvrir...", IDM_OPEN_EVENTLOG + MENUITEM "&Ouvrir...", IDM_OPEN_EVENTLOG MENUITEM "Enregistrer le fichier journal &sous...", IDM_SAVE_EVENTLOG - MENUITEM "Fermer", IDM_CLOSE_EVENTLOG + MENUITEM "&Fermer", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "&Effacer tous les Ã©vÃ©nements", IDM_CLEAR_EVENTS MENUITEM "&Renommer\tF2", IDM_RENAME_EVENTLOG - MENUITEM "PropriÃ©tÃ©s du &Journal...", IDM_EVENTLOG_SETTINGS + MENUITEM "&PropriÃ©tÃ©s du Journal...", IDM_EVENTLOG_SETTINGS MENUITEM SEPARATOR - MENUITEM "Quitter", IDM_EXIT + MENUITEM "&Quitter", IDM_EXIT END POPUP "&Affichage" BEGIN Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/he-IL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/he-IL.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/it-IT.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/ja-JP.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/ja-JP.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "Open...(&O)", IDM_OPEN_EVENTLOG MENUITEM "Save Event Log as...(&E)", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "Clear all Events (&L)", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/ko-KR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/ko-KR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/ko-KR.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,10 +8,10 @@ BEGIN MENUITEM "Open...(&O)", IDM_OPEN_EVENTLOG MENUITEM "Save Event Log as...(&E)", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "Close(&C)", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS - MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG + MENUITEM "Rename(&R)\tF2", IDM_RENAME_EVENTLOG MENUITEM "Log Se&ttings...", IDM_EVENTLOG_SETTINGS MENUITEM SEPARATOR MENUITEM "ì¢ë£(&X)", IDM_EXIT Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/no-NO.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -6,7 +6,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/pl-PL.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -10,7 +10,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "W&yczyÅÄ wszystkie zdarzenia", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/pt-BR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/pt-BR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/pt-BR.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/ro-RO.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -11,7 +11,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "&PÄstrare jurnal de evenimente caâ¦", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "ÃnlÄt&urÄ toate evenimentele", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/ru-RU.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&ÐÑÐºÑÑÑÑ...", IDM_OPEN_EVENTLOG MENUITEM "Ð¡Ð¾ÑÑÐ°Ð½Ð¸ÑÑ &Ð¶ÑÑÐ½Ð°Ð» ÑÐ¾Ð±ÑÑÐ¸Ð¹ ÐºÐ°Ðº...", IDM_SAVE_EVENTLOG - MENUITEM "ÐÐ°ÐºÑÑÑÑ", IDM_CLOSE_EVENTLOG + MENUITEM "&ÐÐ°ÐºÑÑÑÑ", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "ÐÑÐ¸ÑÑÐ¸ÑÑ &Ð²ÑÐµ ÑÐ¾Ð±ÑÑÐ¸Ñ", IDM_CLEAR_EVENTS MENUITEM "&ÐÐµÑÐµÐ¸Ð¼ÐµÐ½Ð¾Ð²Ð°ÑÑ\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/sk-SK.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -11,7 +11,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/sq-AL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/sq-AL.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -14,7 +14,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/sv-SE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/sv-SE.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/tr-TR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/tr-TR.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -14,7 +14,7 @@ BEGIN MENUITEM "&AÃ§...", IDM_OPEN_EVENTLOG MENUITEM "&Olay KaydÄ±nÄ± AyrÄ± Sakla...", IDM_SAVE_EVENTLOG - MENUITEM "Kapat", IDM_CLOSE_EVENTLOG + MENUITEM "Ka&pat", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "&TÃ¼m OlaylarÄ± Sil", IDM_CLEAR_EVENTS MENUITEM "&Yeniden AlandÄ±r\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/uk-UA.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,7 +8,7 @@ BEGIN MENUITEM "&Open...", IDM_OPEN_EVENTLOG MENUITEM "Save &Event Log as...", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "&Close", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "C&lear all Events", IDM_CLEAR_EVENTS MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-CN.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,10 +8,10 @@ BEGIN MENUITEM "Open...(&O)", IDM_OPEN_EVENTLOG MENUITEM "Save Event Log as...(&E)", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "Close(&C)", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "æ¸é¤ææäºä»¶(&L)", IDM_CLEAR_EVENTS - MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG + MENUITEM "Rename(&R)\tF2", IDM_RENAME_EVENTLOG MENUITEM "Log Settings...(&T)", IDM_EVENTLOG_SETTINGS MENUITEM SEPARATOR MENUITEM "éåº(&X)", IDM_EXIT Modified: trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-TW.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-TW.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/eventvwr/lang/zh-TW.rc [iso-8859-1] Wed Nov 9 22:14:20 2016 @@ -8,10 +8,10 @@ BEGIN MENUITEM "Open...(&O)", IDM_OPEN_EVENTLOG MENUITEM "Save Event Log as...(&E)", IDM_SAVE_EVENTLOG - MENUITEM "Close", IDM_CLOSE_EVENTLOG + MENUITEM "Close(&C)", IDM_CLOSE_EVENTLOG MENUITEM SEPARATOR MENUITEM "æ¸é¤ææäºä»¶(&L)", IDM_CLEAR_EVENTS - MENUITEM "&Rename\tF2", IDM_RENAME_EVENTLOG + MENUITEM "Rename(&R)\tF2", IDM_RENAME_EVENTLOG MENUITEM "Log Settings...(&T)", IDM_EVENTLOG_SETTINGS MENUITEM SEPARATOR MENUITEM "éåº(&X)", IDM_EXIT

8 years, 1 month

← Newer
1
...
20
21
22
23
24
25
26
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2016