Ros-diffs November 2016

ros-diffs@reactos.org

15 participants
317 discussions

[gadamopoulos] 73160: [SHELL32] - SHOpenFolderAndSelectItems: Take into account buggy applications like firefox that like to pass full pidls in a PCUITEMID_CHILD_ARRAY.
by gadamopoulos＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: gadamopoulos Date: Sun Nov 6 22:25:02 2016 New Revision: 73160 URL: http://svn.reactos.org/svn/reactos?rev=73160&view=rev Log: [SHELL32] - SHOpenFolderAndSelectItems: Take into account buggy applications like firefox that like to pass full pidls in a PCUITEMID_CHILD_ARRAY. Modified: trunk/reactos/dll/win32/shell32/shlfolder.cpp Modified: trunk/reactos/dll/win32/shell32/shlfolder.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shlfolde… ============================================================================== --- trunk/reactos/dll/win32/shell32/shlfolder.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shlfolder.cpp [iso-8859-1] Sun Nov 6 22:25:02 2016 @@ -528,9 +528,21 @@ ERR("SHOpenFolderAndSelectItems() is hackplemented\n"); PCIDLIST_ABSOLUTE pidlItem; if (cidl) - pidlItem = ILCombine(pidlFolder, apidl[0]); + { + /* Firefox sends a full pidl here dispite the fact it is a PCUITEMID_CHILD_ARRAY -_- */ + if (ILGetNext(apidl[0]) != NULL) + { + pidlItem = apidl[0]; + } + else + { + pidlItem = ILCombine(pidlFolder, apidl[0]); + } + } else + { pidlItem = pidlFolder; + } CComPtr<IShellFolder> psfDesktop;

1 0

[gadamopoulos] 73159: [SHELL32] - Hackplement SHOpenFolderAndSelectItems by using the /select parameter of explorer.exe and selecting only the first of the requested items. - Implement the "Find Ta...
by gadamopoulos＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: gadamopoulos Date: Sun Nov 6 21:51:46 2016 New Revision: 73159 URL: http://svn.reactos.org/svn/reactos?rev=73159&view=rev Log: [SHELL32] - Hackplement SHOpenFolderAndSelectItems by using the /select parameter of explorer.exe and selecting only the first of the requested items. - Implement the "Find Target" button in the properties dialog of shortcuts to use SHOpenFolderAndSelectItems so as we can test it. Based on the patch of Joachim Henze (reactosfanboy). CORE-9367 Modified: trunk/reactos/dll/win32/shell32/CShellLink.cpp trunk/reactos/dll/win32/shell32/shlfolder.cpp Modified: trunk/reactos/dll/win32/shell32/CShellLink.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CShellLi… ============================================================================== --- trunk/reactos/dll/win32/shell32/CShellLink.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CShellLink.cpp [iso-8859-1] Sun Nov 6 21:51:46 2016 @@ -1975,6 +1975,13 @@ return FALSE; } +EXTERN_C HRESULT +WINAPI +SHOpenFolderAndSelectItems(LPITEMIDLIST pidlFolder, + UINT cidl, + PCUITEMID_CHILD_ARRAY apidl, + DWORD dwFlags); + /************************************************************************** * SH_ShellLinkDlgProc * @@ -2108,6 +2115,7 @@ switch(LOWORD(wParam)) { case 14020: + SHOpenFolderAndSelectItems(pThis->pPidl, 0, NULL, 0); /// /// FIXME /// open target directory Modified: trunk/reactos/dll/win32/shell32/shlfolder.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shlfolde… ============================================================================== --- trunk/reactos/dll/win32/shell32/shlfolder.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shlfolder.cpp [iso-8859-1] Sun Nov 6 21:51:46 2016 @@ -252,7 +252,7 @@ ERR("Binding to file is unimplemented\n"); return HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND); } - if (!_ILIsFolder(pidlComplete) && !_ILIsDrive(pidlComplete)) + if (!_ILIsFolder(pidlComplete)) { ERR("Got an unknown type of pidl!\n"); return E_FAIL; @@ -525,6 +525,42 @@ PCUITEMID_CHILD_ARRAY apidl, DWORD dwFlags) { - FIXME("SHOpenFolderAndSelectItems() stub\n"); - return E_NOTIMPL; -} + ERR("SHOpenFolderAndSelectItems() is hackplemented\n"); + PCIDLIST_ABSOLUTE pidlItem; + if (cidl) + pidlItem = ILCombine(pidlFolder, apidl[0]); + else + pidlItem = pidlFolder; + + CComPtr<IShellFolder> psfDesktop; + + HRESULT hr = SHGetDesktopFolder(&psfDesktop); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + STRRET strret; + hr = psfDesktop->GetDisplayNameOf(pidlItem, SHGDN_FORPARSING, &strret); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + WCHAR wszBuf[MAX_PATH]; + hr = StrRetToBufW(&strret, pidlItem, wszBuf, _countof(wszBuf)); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + WCHAR wszParams[MAX_PATH]; + wcscpy(wszParams, L"/select,"); + wcscat(wszParams, wszBuf); + + SHELLEXECUTEINFOW sei; + memset(&sei, 0, sizeof sei); + sei.cbSize = sizeof sei; + sei.fMask = SEE_MASK_WAITFORINPUTIDLE; + sei.lpFile = L"explorer.exe"; + sei.lpParameters = wszParams; + + if (ShellExecuteExW(&sei)) + return S_OK; + else + return E_FAIL; +}

1 0

[gadamopoulos] 73158: [SHELL32] - CDefView: Correct the check for SVSI_EDIT because SVSI_EDIT implies SVSI_SELECT. This actualyl fixes SVSI_SELECT to not cause a rename. [BROWSEUI] - ExplorerMessag...
by gadamopoulos＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: gadamopoulos Date: Sun Nov 6 20:47:21 2016 New Revision: 73158 URL: http://svn.reactos.org/svn/reactos?rev=73158&view=rev Log: [SHELL32] - CDefView: Correct the check for SVSI_EDIT because SVSI_EDIT implies SVSI_SELECT. This actualyl fixes SVSI_SELECT to not cause a rename. [BROWSEUI] - ExplorerMessageLoop: Implement the /select parameter for explorer. Modified: trunk/reactos/dll/win32/browseui/desktopipc.cpp trunk/reactos/dll/win32/shell32/CDefView.cpp Modified: trunk/reactos/dll/win32/browseui/desktopipc.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/desktop… ============================================================================== --- trunk/reactos/dll/win32/browseui/desktopipc.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/desktopipc.cpp [iso-8859-1] Sun Nov 6 20:47:21 2016 @@ -357,13 +357,39 @@ if (parameters && parameters->offsetF8) parameters->offsetF8->AddRef(); + /* Handle /e parameter */ UINT wFlags = 0; if ((parameters->dwFlags & SH_EXPLORER_CMDLINE_FLAG_E)) wFlags |= SBSP_EXPLOREMODE; + /* Handle /select parameter */ + PUITEMID_CHILD pidlSelect = NULL; + if ((parameters->dwFlags & SH_EXPLORER_CMDLINE_FLAG_SELECT) && + (ILGetNext(parameters->directoryPIDL) != NULL)) + { + pidlSelect = ILClone(ILFindLastID(parameters->directoryPIDL)); + ILRemoveLastID(parameters->directoryPIDL); + } + hResult = CShellBrowser_CreateInstance(parameters->directoryPIDL, wFlags, IID_PPV_ARG(IBrowserService2, &browser)); if (FAILED_UNEXPECTEDLY(hResult)) return hResult; + + if (pidlSelect != NULL) + { + CComPtr<IShellBrowser> pisb; + hResult = browser->QueryInterface(IID_PPV_ARG(IShellBrowser, &pisb)); + if (SUCCEEDED(hResult)) + { + CComPtr<IShellView> shellView; + hResult = pisb->QueryActiveShellView(&shellView); + if (SUCCEEDED(hResult)) + { + shellView->SelectItem(pidlSelect, SVSI_SELECT|SVSI_ENSUREVISIBLE); + } + } + ILFree(pidlSelect); + } while ((Ret = GetMessage(&Msg, NULL, 0, 0)) != 0) { Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CDefView… ============================================================================== --- trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] Sun Nov 6 20:47:21 2016 @@ -2203,7 +2203,7 @@ lvItem.iItem++; } - if(uFlags & SVSI_EDIT) + if((uFlags & SVSI_EDIT) == SVSI_EDIT) m_ListView.EditLabel(i); return S_OK;

1 0

[gadamopoulos] 73157: [SHELL32] - CDesktopBrowser: The flags that SHOpenNewFrame takes are the same that SHExplorerParseCmdLine returns, not the SBSP_ ones. [BROWSEUI] - Move the hack to fill the p...
by gadamopoulos＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: gadamopoulos Date: Sun Nov 6 20:13:17 2016 New Revision: 73157 URL: http://svn.reactos.org/svn/reactos?rev=73157&view=rev Log: [SHELL32] - CDesktopBrowser: The flags that SHOpenNewFrame takes are the same that SHExplorerParseCmdLine returns, not the SBSP_ ones. [BROWSEUI] - Move the hack to fill the parsed pidl if none was found to SHCreateFromDesktop. - Convert the SH_EXPLORER_CMDLINE_FLAG_E flag to a SBSP_EXPLOREMODE and pass it to the CShellBrowser. Modified: trunk/reactos/dll/win32/browseui/desktopipc.cpp trunk/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp Modified: trunk/reactos/dll/win32/browseui/desktopipc.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/desktop… ============================================================================== --- trunk/reactos/dll/win32/browseui/desktopipc.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/desktopipc.cpp [iso-8859-1] Sun Nov 6 20:13:17 2016 @@ -357,13 +357,11 @@ if (parameters && parameters->offsetF8) parameters->offsetF8->AddRef(); - // HACK! This shouldn't happen! SHExplorerParseCmdLine needs fixing. - if (!parameters->directoryPIDL) - { - SHGetFolderLocation(NULL, CSIDL_PERSONAL, NULL, NULL, &parameters->directoryPIDL); - } - - hResult = CShellBrowser_CreateInstance(parameters->directoryPIDL, parameters->dwFlags, IID_PPV_ARG(IBrowserService2, &browser)); + UINT wFlags = 0; + if ((parameters->dwFlags & SH_EXPLORER_CMDLINE_FLAG_E)) + wFlags |= SBSP_EXPLOREMODE; + + hResult = CShellBrowser_CreateInstance(parameters->directoryPIDL, wFlags, IID_PPV_ARG(IBrowserService2, &browser)); if (FAILED_UNEXPECTEDLY(hResult)) return hResult; @@ -609,6 +607,12 @@ } } + // HACK! This shouldn't happen! SHExplorerParseCmdLine needs fixing. + if (!pidl) + { + SHGetFolderLocation(NULL, CSIDL_PERSONAL, NULL, NULL, &pidl); + } + parameters->directoryPIDL = pidl; // Try to find the owner of the idlist, if we aren't running /SEPARATE Modified: trunk/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shelldes… ============================================================================== --- trunk/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shelldesktop/CDesktopBrowser.cpp [iso-8859-1] Sun Nov 6 20:13:17 2016 @@ -284,7 +284,8 @@ * find an open shell window that shows the requested pidl and activate it */ - return SHOpenNewFrame((LPITEMIDLIST)pidl, NULL, 0, wFlags); + DWORD dwFlags = ((wFlags & SBSP_EXPLOREMODE) != 0) ? SH_EXPLORER_CMDLINE_FLAG_E : 0; + return SHOpenNewFrame((LPITEMIDLIST)pidl, NULL, 0, dwFlags); } HRESULT STDMETHODCALLTYPE CDesktopBrowser::GetViewStateStream(DWORD grfMode, IStream **ppStrm)

1 0

[gadamopoulos] 73156: [COM_APITEST] - The new interfaces are not registered in the registry - Add a few interfaces that were discovered for CLSID_Printers and CLSID_QueryAssociations.
by gadamopoulos＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: gadamopoulos Date: Sun Nov 6 18:04:58 2016 New Revision: 73156 URL: http://svn.reactos.org/svn/reactos?rev=73156&view=rev Log: [COM_APITEST] - The new interfaces are not registered in the registry - Add a few interfaces that were discovered for CLSID_Printers and CLSID_QueryAssociations. Modified: trunk/rostests/apitests/com/com_apitest.c trunk/rostests/apitests/com/shell32.c Modified: trunk/rostests/apitests/com/com_apitest.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/com/com_apitest.… ============================================================================== --- trunk/rostests/apitests/com/com_apitest.c [iso-8859-1] (original) +++ trunk/rostests/apitests/com/com_apitest.c [iso-8859-1] Sun Nov 6 18:04:58 2016 @@ -267,7 +267,7 @@ { ID_NAME(IID_IResolveShellLink) }, { ID_NAME(IID_IRpcOptions), TRUE }, { ID_NAME(IID_IRunnableObject) }, - { ID_NAME(IID_ISLTracker) }, + { ID_NAME(IID_ISLTracker), TRUE }, { ID_NAME(IID_IScriptErrorList) }, { ID_NAME(IID_ISearch) }, { ID_NAME(IID_ISearchAssistantOC) }, @@ -403,58 +403,58 @@ { ID_NAME(CLSID_ShellDesktop), TRUE }, - { ID_NAME(IID_IAggregateFilterCondition) }, - { ID_NAME(IID_IAliasRegistrationCallback) }, - { ID_NAME(IID_IAssociationArrayInitialize) }, - { ID_NAME(IID_IAssociationList) }, - { ID_NAME(IID_IBackReferencedObject) }, - { ID_NAME(IID_IBasePropPage) }, - { ID_NAME(IID_ICommonLayoutDefinition) }, - { ID_NAME(IID_IControlPanelEnumerator) }, - { ID_NAME(IID_IDelegateHostItemContainer) }, - { ID_NAME(IID_IDrawPropertyControl) }, - { ID_NAME(IID_IEnumAssociationElements) }, - { ID_NAME(IID_IEnumerateAssociationElements) }, - { ID_NAME(IID_IExecuteCommand) }, - { ID_NAME(IID_IFilterCondition) }, - { ID_NAME(IID_IFolderNotify) }, - { ID_NAME(IID_IFolderProperties) }, - { ID_NAME(IID_IFolderType) }, - { ID_NAME(IID_IFolderWithSearchRoot) }, - { ID_NAME(IID_IFrameLayoutDefinition) }, - { ID_NAME(IID_IItemFilter) }, - { ID_NAME(IID_IItemFilterOwner) }, - { ID_NAME(IID_ILocalizableItemParent) }, - { ID_NAME(IID_INewItemAdvisor) }, - { ID_NAME(IID_IObjectWithAssociationElement) }, - { ID_NAME(IID_IObjectWithAssociationList) }, - { ID_NAME(IID_IObjectWithQuerySource) }, - { ID_NAME(IID_IObjectWithSelection) }, - { ID_NAME(IID_IPersistString2) }, - { ID_NAME(IID_IPrinterFolder) }, - { ID_NAME(IID_IPropertyControl) }, - { ID_NAME(IID_IPropertyControlBase) }, - { ID_NAME(IID_IPropertyControlSite) }, - { ID_NAME(IID_IRegItemCustomAttributes) }, - { ID_NAME(IID_IRegItemCustomEnumerator) }, - { ID_NAME(IID_IRegItemFolder) }, - { ID_NAME(IID_IRootAndRelativeParsingFolder) }, - { ID_NAME(IID_IScope) }, - { ID_NAME(IID_IScopeItem) }, - { ID_NAME(IID_IShellBrowserServce) }, - { ID_NAME(IID_IShellFolder3) }, - { ID_NAME(IID_ITaskCondition) }, - { ID_NAME(IID_ITaskConditionCombiner) }, - { ID_NAME(IID_ITaskConditionInit) }, - { ID_NAME(IID_ITransferProvider) }, - { ID_NAME(IID_IUserEventTimer) }, - { ID_NAME(IID_IUserEventTimerCallback) }, - { ID_NAME(IID_IAssociationArrayOld) }, - { ID_NAME(IID_IAssociationArray) }, - { ID_NAME(IID_IDriveFolderExtOld) }, - { ID_NAME(IID_IDriveFolderExt) }, - { ID_NAME(IID_IPinnedListOld) }, - { ID_NAME(IID_IPinnedList) } + { ID_NAME(IID_IAggregateFilterCondition), TRUE }, + { ID_NAME(IID_IAliasRegistrationCallback), TRUE }, + { ID_NAME(IID_IAssociationArrayInitialize), TRUE }, + { ID_NAME(IID_IAssociationList), TRUE }, + { ID_NAME(IID_IBackReferencedObject), TRUE }, + { ID_NAME(IID_IBasePropPage), TRUE }, + { ID_NAME(IID_ICommonLayoutDefinition), TRUE }, + { ID_NAME(IID_IControlPanelEnumerator), TRUE }, + { ID_NAME(IID_IDelegateHostItemContainer), TRUE }, + { ID_NAME(IID_IDrawPropertyControl), TRUE }, + { ID_NAME(IID_IEnumAssociationElements), TRUE }, + { ID_NAME(IID_IEnumerateAssociationElements),TRUE }, + { ID_NAME(IID_IExecuteCommand), TRUE }, + { ID_NAME(IID_IFilterCondition), TRUE }, + { ID_NAME(IID_IFolderNotify), TRUE }, + { ID_NAME(IID_IFolderProperties), TRUE }, + { ID_NAME(IID_IFolderType), TRUE }, + { ID_NAME(IID_IFolderWithSearchRoot), TRUE }, + { ID_NAME(IID_IFrameLayoutDefinition), TRUE }, + { ID_NAME(IID_IItemFilter), TRUE }, + { ID_NAME(IID_IItemFilterOwner), TRUE }, + { ID_NAME(IID_ILocalizableItemParent), TRUE }, + { ID_NAME(IID_INewItemAdvisor), TRUE }, + { ID_NAME(IID_IObjectWithAssociationElement),TRUE }, + { ID_NAME(IID_IObjectWithAssociationList), TRUE }, + { ID_NAME(IID_IObjectWithQuerySource), TRUE }, + { ID_NAME(IID_IObjectWithSelection), TRUE }, + { ID_NAME(IID_IPersistString2), TRUE }, + { ID_NAME(IID_IPrinterFolder), TRUE }, + { ID_NAME(IID_IPropertyControl), TRUE }, + { ID_NAME(IID_IPropertyControlBase), TRUE }, + { ID_NAME(IID_IPropertyControlSite), TRUE }, + { ID_NAME(IID_IRegItemCustomAttributes), TRUE }, + { ID_NAME(IID_IRegItemCustomEnumerator), TRUE }, + { ID_NAME(IID_IRegItemFolder), TRUE }, + { ID_NAME(IID_IRootAndRelativeParsingFolder),TRUE }, + { ID_NAME(IID_IScope), TRUE }, + { ID_NAME(IID_IScopeItem), TRUE }, + { ID_NAME(IID_IShellBrowserServce), TRUE }, + { ID_NAME(IID_IShellFolder3), TRUE }, + { ID_NAME(IID_ITaskCondition), TRUE }, + { ID_NAME(IID_ITaskConditionCombiner), TRUE }, + { ID_NAME(IID_ITaskConditionInit), TRUE }, + { ID_NAME(IID_ITransferProvider), TRUE }, + { ID_NAME(IID_IUserEventTimer), TRUE }, + { ID_NAME(IID_IUserEventTimerCallback), TRUE }, + { ID_NAME(IID_IAssociationArrayOld), TRUE }, + { ID_NAME(IID_IAssociationArray), TRUE }, + { ID_NAME(IID_IDriveFolderExtOld), TRUE }, + { ID_NAME(IID_IDriveFolderExt), TRUE }, + { ID_NAME(IID_IPinnedListOld), TRUE }, + { ID_NAME(IID_IPinnedList), TRUE } }; static const INT KnownInterfaceCount = RTL_NUMBER_OF(KnownInterfaces); Modified: trunk/rostests/apitests/com/shell32.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/com/shell32.c?re… ============================================================================== --- trunk/rostests/apitests/com/shell32.c [iso-8859-1] (original) +++ trunk/rostests/apitests/com/shell32.c [iso-8859-1] Sun Nov 6 18:04:58 2016 @@ -363,6 +363,7 @@ ID_NAME(CLSID_Printers), { { -0xc, &IID_IRemoteComputer }, + { -0x4, &IID_IFolderNotify }, { 0x0, &IID_IShellFolder2 }, { 0x0, &IID_IShellFolder }, { 0x0, &IID_IUnknown }, @@ -376,7 +377,9 @@ { ID_NAME(CLSID_QueryAssociations), { - { 0x0, &IID_IUnknown }, + { 0x0, &IID_IAssociationArrayOld }, + { 0x0, &IID_IUnknown }, + { 0x4, &IID_IAssociationArrayInitialize }, { 0x8, &IID_IQueryAssociations }, } },

1 0

[gadamopoulos] 73155: [COM_APITEST] - Test for the undocumented interfaces that were added recently.
by gadamopoulos＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: gadamopoulos Date: Sun Nov 6 17:17:57 2016 New Revision: 73155 URL: http://svn.reactos.org/svn/reactos?rev=73155&view=rev Log: [COM_APITEST] - Test for the undocumented interfaces that were added recently. Modified: trunk/rostests/apitests/com/com_apitest.c Modified: trunk/rostests/apitests/com/com_apitest.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/com/com_apitest.… ============================================================================== --- trunk/rostests/apitests/com/com_apitest.c [iso-8859-1] (original) +++ trunk/rostests/apitests/com/com_apitest.c [iso-8859-1] Sun Nov 6 17:17:57 2016 @@ -401,7 +401,60 @@ { ID_NAME(IID_FolderItemVerb) }, { ID_NAME(IID_FolderItemVerbs) }, - { ID_NAME(CLSID_ShellDesktop), TRUE } + { ID_NAME(CLSID_ShellDesktop), TRUE }, + + { ID_NAME(IID_IAggregateFilterCondition) }, + { ID_NAME(IID_IAliasRegistrationCallback) }, + { ID_NAME(IID_IAssociationArrayInitialize) }, + { ID_NAME(IID_IAssociationList) }, + { ID_NAME(IID_IBackReferencedObject) }, + { ID_NAME(IID_IBasePropPage) }, + { ID_NAME(IID_ICommonLayoutDefinition) }, + { ID_NAME(IID_IControlPanelEnumerator) }, + { ID_NAME(IID_IDelegateHostItemContainer) }, + { ID_NAME(IID_IDrawPropertyControl) }, + { ID_NAME(IID_IEnumAssociationElements) }, + { ID_NAME(IID_IEnumerateAssociationElements) }, + { ID_NAME(IID_IExecuteCommand) }, + { ID_NAME(IID_IFilterCondition) }, + { ID_NAME(IID_IFolderNotify) }, + { ID_NAME(IID_IFolderProperties) }, + { ID_NAME(IID_IFolderType) }, + { ID_NAME(IID_IFolderWithSearchRoot) }, + { ID_NAME(IID_IFrameLayoutDefinition) }, + { ID_NAME(IID_IItemFilter) }, + { ID_NAME(IID_IItemFilterOwner) }, + { ID_NAME(IID_ILocalizableItemParent) }, + { ID_NAME(IID_INewItemAdvisor) }, + { ID_NAME(IID_IObjectWithAssociationElement) }, + { ID_NAME(IID_IObjectWithAssociationList) }, + { ID_NAME(IID_IObjectWithQuerySource) }, + { ID_NAME(IID_IObjectWithSelection) }, + { ID_NAME(IID_IPersistString2) }, + { ID_NAME(IID_IPrinterFolder) }, + { ID_NAME(IID_IPropertyControl) }, + { ID_NAME(IID_IPropertyControlBase) }, + { ID_NAME(IID_IPropertyControlSite) }, + { ID_NAME(IID_IRegItemCustomAttributes) }, + { ID_NAME(IID_IRegItemCustomEnumerator) }, + { ID_NAME(IID_IRegItemFolder) }, + { ID_NAME(IID_IRootAndRelativeParsingFolder) }, + { ID_NAME(IID_IScope) }, + { ID_NAME(IID_IScopeItem) }, + { ID_NAME(IID_IShellBrowserServce) }, + { ID_NAME(IID_IShellFolder3) }, + { ID_NAME(IID_ITaskCondition) }, + { ID_NAME(IID_ITaskConditionCombiner) }, + { ID_NAME(IID_ITaskConditionInit) }, + { ID_NAME(IID_ITransferProvider) }, + { ID_NAME(IID_IUserEventTimer) }, + { ID_NAME(IID_IUserEventTimerCallback) }, + { ID_NAME(IID_IAssociationArrayOld) }, + { ID_NAME(IID_IAssociationArray) }, + { ID_NAME(IID_IDriveFolderExtOld) }, + { ID_NAME(IID_IDriveFolderExt) }, + { ID_NAME(IID_IPinnedListOld) }, + { ID_NAME(IID_IPinnedList) } }; static const INT KnownInterfaceCount = RTL_NUMBER_OF(KnownInterfaces);

1 0

[gadamopoulos] 73154: [SHLGUID_UNDOC.H] -Add several undocumented interfaces taken from http://www.geoffchappell.com/studies/windows/shell/shell32/interfaces/index.htm
by gadamopoulos＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: gadamopoulos Date: Sun Nov 6 15:47:35 2016 New Revision: 73154 URL: http://svn.reactos.org/svn/reactos?rev=73154&view=rev Log: [SHLGUID_UNDOC.H] -Add several undocumented interfaces taken from http://www.geoffchappell.com/studies/windows/shell/shell32/interfaces/index… Modified: trunk/reactos/sdk/include/reactos/shlguid_undoc.h Modified: trunk/reactos/sdk/include/reactos/shlguid_undoc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/reactos/shlgui… ============================================================================== --- trunk/reactos/sdk/include/reactos/shlguid_undoc.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/reactos/shlguid_undoc.h [iso-8859-1] Sun Nov 6 15:47:35 2016 @@ -135,6 +135,60 @@ DEFINE_GUID(CLSID_BackgroundTaskScheduler, 0x603D3800, 0xBD81, 0x11d0, 0xA3, 0xA5, 0x00, 0xC0, 0x4F, 0xD7, 0x06, 0xEC); DEFINE_GUID(CLSID_SharedTaskScheduler, 0x603D3801, 0xBD81, 0x11d0, 0xA3, 0xA5, 0x00, 0xC0, 0x4F, 0xD7, 0x06, 0xEC); +/* The following list of interfaces was taken from here: http://www.geoffchappell.com/studies/windows/shell/shell32/interfaces/index… */ +DEFINE_GUID(IID_IAggregateFilterCondition, 0x86228AA3, 0xA736, 0x4733, 0xBD, 0x8A, 0x10, 0xA8, 0x3C, 0x69, 0xBF, 0x84); +DEFINE_GUID(IID_IAliasRegistrationCallback,0xF6D2D333, 0xBEC1, 0x4194, 0x8A, 0x6E, 0x8A, 0xBA, 0xD0, 0x0F, 0x8D, 0xCF); +DEFINE_GUID(IID_IAssociationArrayInitialize,0xEE9165BF,0xA4D9, 0x474B, 0x82, 0x36, 0x67, 0x35, 0xCB, 0x7E, 0x28, 0xB6); +DEFINE_GUID(IID_IAssociationList, 0xDC8F8556, 0xEFBD, 0x4EFA, 0x8B, 0x64, 0xBB, 0xA8, 0x4B, 0x4E, 0xCD, 0x7F); +DEFINE_GUID(IID_IBackReferencedObject, 0xC938B119, 0xD3AD, 0x4D02, 0xB5, 0xEE, 0x16, 0x4C, 0x2E, 0xC8, 0x16, 0x0E); +DEFINE_GUID(IID_IBasePropPage, 0xB34E525B, 0x9EB4, 0x433B, 0x8E, 0x0F, 0x01, 0x9C, 0x4F, 0x21, 0xD7, 0xE7); +DEFINE_GUID(IID_ICommonLayoutDefinition, 0xD72FF553, 0xAE8F, 0x4DAE, 0x9E, 0xE8, 0x83, 0x3A, 0x9E, 0x02, 0x5C, 0xB0); +DEFINE_GUID(IID_IControlPanelEnumerator, 0xCE247F0D, 0x2579, 0x4BA8, 0xB3, 0x93, 0x29, 0xA4, 0x3D, 0x88, 0xEB, 0x31); +DEFINE_GUID(IID_IDelegateHostItemContainer,0x02468693, 0xE7E5, 0x4C6B, 0x99, 0x95, 0x64, 0xCE, 0x5F, 0x51, 0xCE, 0xC4); +DEFINE_GUID(IID_IDrawPropertyControl, 0xE6DFF6FD, 0xBCD5, 0x4162, 0x9C, 0x65, 0xA3, 0xB1, 0x8C, 0x61, 0x6F, 0xDB); +DEFINE_GUID(IID_IEnumAssociationElements, 0xA6B0FB57, 0x7523, 0x4439, 0x94, 0x25, 0xEB, 0xE9, 0x98, 0x23, 0xB8, 0x28); +DEFINE_GUID(IID_IEnumerateAssociationElements,0x7513A16E,0xCF00,0x4817,0xA8, 0x90, 0xA2, 0x3C, 0x60, 0x8F, 0xE7, 0xB7); +DEFINE_GUID(IID_IExecuteCommand, 0x7F9185B0, 0xCB92, 0x43C5, 0x80, 0xA9, 0x92, 0x27, 0x7A, 0x4F, 0x7B, 0x54); +DEFINE_GUID(IID_IFilterCondition, 0xFCA2857D, 0x1760, 0x4AD3, 0x8C, 0x63, 0xC9, 0xB6, 0x02, 0xFC, 0xBA, 0xEA); +DEFINE_GUID(IID_IFolderNotify, 0x0FF22D71, 0x5172, 0x11D1, 0xA9, 0xC6, 0x08, 0x00, 0x36, 0xAF, 0x3F, 0x03); +DEFINE_GUID(IID_IFolderProperties, 0x7361EE29, 0x5BAD, 0x459D, 0xA9, 0xF5, 0xF6, 0x55, 0x06, 0x89, 0x82, 0xF0); +DEFINE_GUID(IID_IFolderType, 0x053B4A86, 0x0DC9, 0x40A3, 0xB7, 0xED, 0xBC, 0x6A, 0x2E, 0x95, 0x1F, 0x48); +DEFINE_GUID(IID_IFolderWithSearchRoot, 0x4CA18419, 0x902A, 0x4F03, 0x8D, 0xB4, 0xB2, 0x4D, 0x21, 0x8A, 0xC5, 0xAA); +DEFINE_GUID(IID_IFrameLayoutDefinition, 0x176C11B1, 0x4302, 0x4164, 0x84, 0x30, 0xD5, 0xA9, 0xF0, 0xEE, 0xAC, 0xDB); +DEFINE_GUID(IID_IItemFilter, 0x7FCBEB25, 0xED60, 0x45C9, 0x9F, 0x5E, 0x57, 0xB4, 0x84, 0x93, 0xC4, 0xDD); +DEFINE_GUID(IID_IItemFilterOwner, 0x7E1AF054, 0x83A6, 0x47FC, 0xAB, 0x27, 0xA5, 0x8A, 0xE8, 0xD9, 0xC7, 0x05); +DEFINE_GUID(IID_ILocalizableItemParent, 0x148BCE7A, 0x0D60, 0x4254, 0x81, 0x3F, 0xA4, 0xE4, 0xEA, 0x46, 0xDF, 0x3F); +DEFINE_GUID(IID_INewItemAdvisor, 0x24D16EE5, 0x10F5, 0x4DE3, 0x87, 0x66, 0xD2, 0x37, 0x79, 0xBA, 0x7A, 0x6D); +DEFINE_GUID(IID_IObjectWithAssociationElement,0xE157C3A1,0xA532,0x4DE2,0x94, 0x80, 0x14, 0x52, 0xB7, 0x42, 0x6E, 0xEE); +DEFINE_GUID(IID_IObjectWithAssociationList,0xE6FFBB28, 0xBB79, 0x43B9, 0xA7, 0xBC, 0x6B, 0x57, 0x41, 0x0C, 0x81, 0x08); +DEFINE_GUID(IID_IObjectWithQuerySource, 0xB3DCB623, 0x4280, 0x4EB1, 0x84, 0xB3, 0x8D, 0x07, 0xE8, 0x4F, 0x29, 0x9A); +DEFINE_GUID(IID_IObjectWithSelection, 0x1C9CD5BB, 0x98E9, 0x4491, 0xA6, 0x0F, 0x31, 0xAA, 0xCC, 0x72, 0xB8, 0x3C); +DEFINE_GUID(IID_IPersistString2, 0x3C44BA76, 0xDE0E, 0x4049, 0xB6, 0xE4, 0x6B, 0x31, 0xA5, 0x26, 0x27, 0x07); +DEFINE_GUID(IID_IPrinterFolder, 0xEF99ABD4, 0x5B8D, 0x11D1, 0xA9, 0xC8, 0x00, 0x80, 0x36, 0xAF, 0x3F, 0x03); +DEFINE_GUID(IID_IPropertyControl, 0x5E82A4DD, 0x9561, 0x476A, 0x86, 0x34, 0x1B, 0xEB, 0xAC, 0xBA, 0x4A, 0x38); +DEFINE_GUID(IID_IPropertyControlBase, 0x6E71A510, 0x732A, 0x4557, 0x95, 0x96, 0xA8, 0x27, 0xE3, 0x6D, 0xAF, 0x8F); +DEFINE_GUID(IID_IPropertyControlSite, 0x61AD7F6B, 0xDD60, 0x4E95, 0xB7, 0x2B, 0xF2, 0xA2, 0x5C, 0x3A, 0xCF, 0xF6); +DEFINE_GUID(IID_IRegItemCustomAttributes, 0xD730309E, 0x9C53, 0x47B0, 0x93, 0x97, 0x9D, 0x85, 0x2C, 0xB7, 0x17, 0x45); +DEFINE_GUID(IID_IRegItemCustomEnumerator, 0x8DE4E39D, 0x921D, 0x410C, 0x84, 0x67, 0xD9, 0x92, 0xB8, 0x48, 0x9D, 0x72); +DEFINE_GUID(IID_IRegItemFolder, 0x81075FEB, 0x0A85, 0x439B, 0xB2, 0x5B, 0xE9, 0x53, 0x4A, 0xDF, 0x98, 0x11); +DEFINE_GUID(IID_IRootAndRelativeParsingFolder,0x52B14A6A,0x58F1,0x45BD,0xB0, 0x0A, 0xDC, 0xE7, 0x40, 0x3D, 0x95, 0x1E); +DEFINE_GUID(IID_IScope, 0xDD8B42D6, 0x8162, 0x44B0, 0x8C, 0x27, 0x14, 0x71, 0x33, 0x18, 0xA0, 0xC6); +DEFINE_GUID(IID_IScopeItem, 0x0A4E5B7D, 0x99E1, 0x4700, 0x93, 0xB1, 0x89, 0x52, 0x5E, 0xAD, 0xD0, 0x90); +DEFINE_GUID(IID_IShellBrowserServce, 0xDFBC7E30, 0xF9E5, 0x455F, 0x88, 0xF8, 0xFA, 0x98, 0xC1, 0xE4, 0x94, 0xCA); +DEFINE_GUID(IID_IShellFolder3, 0x2EC06C64, 0x1296, 0x4F53, 0x89, 0xE5, 0xEC, 0xCE, 0x4E, 0xFC, 0x21, 0x89); +DEFINE_GUID(IID_ITaskCondition, 0x8419D6C6, 0x78C6, 0x4AAF, 0xB4, 0xEB, 0x29, 0x1B, 0x43, 0x37, 0x4A, 0xED); +DEFINE_GUID(IID_ITaskConditionCombiner, 0xD65AC459, 0x1187, 0x4C71, 0x88, 0x82, 0xDE, 0x09, 0x47, 0x23, 0x95, 0x29); +DEFINE_GUID(IID_ITaskConditionInit, 0xD2BF5114, 0x3F4B, 0x4A63, 0x87, 0x32, 0x67, 0x01, 0x85, 0x74, 0xB6, 0xB3); +DEFINE_GUID(IID_ITransferProvider, 0xF174B783, 0x3F7F, 0x4D97, 0x9F, 0x17, 0xEA, 0x82, 0xFE, 0xC9, 0x3B, 0x4A); +DEFINE_GUID(IID_IUserEventTimer, 0x0F504B94, 0x6E42, 0x42E6, 0x99, 0xE0, 0xE2, 0x0F, 0xAF, 0xE5, 0x2A, 0xB4); +DEFINE_GUID(IID_IUserEventTimerCallback, 0xE9EAD8E6, 0x2A25, 0x410E, 0x9B, 0x58, 0xA9, 0xFB, 0xEF, 0x1D, 0xD1, 0xA2); +DEFINE_GUID(IID_IAssociationArrayOld, 0x3B877E3C, 0x67DE, 0x4F9A, 0xB2, 0x9B, 0x17, 0xD0, 0xA1, 0x52, 0x1C, 0x6A); /*original*/ +DEFINE_GUID(IID_IAssociationArray, 0x19ADBAFD, 0x1C5F, 0x4FC7, 0x94, 0xEE, 0x84, 0x67, 0x02, 0xDF, 0xB5, 0x8B); /*revised*/ +DEFINE_GUID(IID_IDriveFolderExtOld, 0x98467961, 0x4F27, 0x4A1F, 0x96, 0x29, 0x22, 0xB0, 0x6D, 0x0B, 0x5C, 0xCB); /*Original*/ +DEFINE_GUID(IID_IDriveFolderExt, 0x3EC36F3E, 0x5BA3, 0x4C3D, 0xBF, 0x39, 0x10, 0xF7, 0x6C, 0x3F, 0x7C, 0xC6); /*Revised*/ +DEFINE_GUID(IID_IPinnedListOld, 0xC3C6EB6D, 0xC837, 0x4EAE, 0xB1, 0x72, 0x5F, 0xEC, 0x52, 0xA2, 0xA4, 0xFD); /*version 6.0*/ +DEFINE_GUID(IID_IPinnedList, 0xBBD20037, 0xBC0E, 0x42F1, 0x91, 0x3F, 0xE2, 0x93, 0x6B, 0xB0, 0xEA, 0x0C); /*version 6.1*/ + #define CGID_IExplorerToolbar IID_IExplorerToolbar #define SID_IExplorerToolbar IID_IExplorerToolbar #define SID_ITargetFrame2 IID_ITargetFrame2

1 0

[tfaber] 73153: [KMTESTS] - Complete IRPs with STATUS_INVALID_DEVICE_REQUEST by default. CORE-12295 #resolve
by tfaber＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: tfaber Date: Sun Nov 6 15:26:39 2016 New Revision: 73153 URL: http://svn.reactos.org/svn/reactos?rev=73153&view=rev Log: [KMTESTS] - Complete IRPs with STATUS_INVALID_DEVICE_REQUEST by default. CORE-12295 #resolve Modified: trunk/rostests/kmtests/kmtest_drv/kmtest_standalone.c Modified: trunk/rostests/kmtests/kmtest_drv/kmtest_standalone.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/kmtest_drv/kmtest… ============================================================================== --- trunk/rostests/kmtests/kmtest_drv/kmtest_standalone.c [iso-8859-1] (original) +++ trunk/rostests/kmtests/kmtest_drv/kmtest_standalone.c [iso-8859-1] Sun Nov 6 15:26:39 2016 @@ -306,7 +306,7 @@ IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { - NTSTATUS Status = STATUS_SUCCESS; + NTSTATUS Status = STATUS_INVALID_DEVICE_REQUEST; PIO_STACK_LOCATION IoStackLocation; int i; @@ -328,6 +328,12 @@ if (IoStackLocation->MajorFunction == IRP_MJ_DEVICE_CONTROL || IoStackLocation->MajorFunction == IRP_MJ_INTERNAL_DEVICE_CONTROL) return DeviceControlHandler(DeviceObject, Irp, IoStackLocation); + + /* Return success for create, close, and cleanup */ + if (IoStackLocation->MajorFunction == IRP_MJ_CREATE || + IoStackLocation->MajorFunction == IRP_MJ_CLOSE || + IoStackLocation->MajorFunction == IRP_MJ_CLEANUP) + Status = STATUS_SUCCESS; /* default handler */ Irp->IoStatus.Status = Status;

1 0

[hbelusca] 73152: [EVTLIB]: Don't spam the log with "add new record" lines.
by hbelusca＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: hbelusca Date: Sun Nov 6 15:26:20 2016 New Revision: 73152 URL: http://svn.reactos.org/svn/reactos?rev=73152&view=rev Log: [EVTLIB]: Don't spam the log with "add new record" lines. Modified: trunk/reactos/sdk/lib/evtlib/evtlib.c Modified: trunk/reactos/sdk/lib/evtlib/evtlib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/evtlib/evtlib.c?re… ============================================================================== --- trunk/reactos/sdk/lib/evtlib/evtlib.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/evtlib/evtlib.c [iso-8859-1] Sun Nov 6 15:26:20 2016 @@ -798,7 +798,7 @@ break; } - EVTLTRACE1("Add new record %d @ offset 0x%x\n", pRecBuf->RecordNumber, FileOffset.QuadPart); + EVTLTRACE("Add new record %d @ offset 0x%x\n", pRecBuf->RecordNumber, FileOffset.QuadPart); RecordNumber++;

1 0

[tfaber] 73151: [MKISOFS] - Fix build with VS2010 and 2012 CORE-11988
by tfaber＠svn.reactos.org 06 Nov '16

06 Nov '16

Author: tfaber Date: Sun Nov 6 14:57:13 2016 New Revision: 73151 URL: http://svn.reactos.org/svn/reactos?rev=73151&view=rev Log: [MKISOFS] - Fix build with VS2010 and 2012 CORE-11988 Modified: trunk/reactos/sdk/tools/mkisofs/reactos/xconfig.h Modified: trunk/reactos/sdk/tools/mkisofs/reactos/xconfig.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/tools/mkisofs/reactos/… ============================================================================== --- trunk/reactos/sdk/tools/mkisofs/reactos/xconfig.h [iso-8859-1] (original) +++ trunk/reactos/sdk/tools/mkisofs/reactos/xconfig.h [iso-8859-1] Sun Nov 6 14:57:13 2016 @@ -35,7 +35,10 @@ #define HAVE_IO_H 1 #endif +#if !defined(_MSC_VER) || _MSC_VER >= 1800 #define HAVE_INTTYPES_H 1 +#endif + #define HAVE_STDINT_H 1 #ifndef _WIN32 @@ -77,12 +80,16 @@ #endif #define HAVE_TIME 1 +#if !defined(_MSC_VER) || _MSC_VER >= 1800 #define HAVE_VA_COPY 1 +#endif #define HAVE_ECVT 1 #define HAVE_FCVT 1 #define HAVE_GCVT 1 +#if !defined(_MSC_VER) || _MSC_VER >= 1800 #define HAVE_C99_ISINF 1 #define HAVE_C99_ISNAN 1 +#endif #define HAVE_SNPRINTF 1 #if defined(_MSC_VER) && _MSC_VER < 1900

1 0

← Newer
1
...
23
24
25
26
27
28
29
...
32
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2016