Ros-diffs August 2016

ros-diffs@reactos.org

20 participants
462 discussions

[tfaber] 72138: [NTOS:MM][USER32] - Correctly handle/avoid C99-style inline semantics CORE-11794

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 15:04:08 2016 New Revision: 72138 URL: http://svn.reactos.org/svn/reactos?rev=72138&view=rev Log: [NTOS:MM][USER32] - Correctly handle/avoid C99-style inline semantics CORE-11794 Modified: trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c trunk/reactos/win32ss/user/user32/include/ntwrapper.h Modified: trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] Sat Aug 6 15:04:08 2016 @@ -16,8 +16,8 @@ #define MODULE_INVOLVED_IN_ARM3 #include <mm/ARM3/miarm.h> -/* GCC's incompetence strikes again */ -__inline +static +inline VOID sprintf_nt(IN PCHAR Buffer, IN PCHAR Format, Modified: trunk/reactos/win32ss/user/user32/include/ntwrapper.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/includ… ============================================================================== --- trunk/reactos/win32ss/user/user32/include/ntwrapper.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/include/ntwrapper.h [iso-8859-1] Sat Aug 6 15:04:08 2016 @@ -1,7 +1,7 @@ #pragma once #if defined(__GNUC__) -#define EXTINLINE extern inline __attribute__((always_inline)) +#define EXTINLINE extern inline __attribute__((always_inline)) __attribute__((gnu_inline)) #elif defined(_MSC_VER) #define EXTINLINE extern __forceinline #else

8 years, 4 months

[tfaber] 72137: [WS2_32_NEW] - Fix always true conditions in ComputeQuerySetSize CORE-11799

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 12:58:32 2016 New Revision: 72137 URL: http://svn.reactos.org/svn/reactos?rev=72137&view=rev Log: [WS2_32_NEW] - Fix always true conditions in ComputeQuerySetSize CORE-11799 Modified: trunk/reactos/dll/win32/ws2_32_new/src/qshelpr.c Modified: trunk/reactos/dll/win32/ws2_32_new/src/qshelpr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ws2_32_new/src/q… ============================================================================== --- trunk/reactos/dll/win32/ws2_32_new/src/qshelpr.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ws2_32_new/src/qshelpr.c [iso-8859-1] Sat Aug 6 12:58:32 2016 @@ -201,14 +201,14 @@ for (i = 0; i < AnsiSet->dwNumberOfCsAddrs; i++) { /* Check for local sockaddr */ - if (&AnsiSet->lpcsaBuffer[i].LocalAddr) + if (AnsiSet->lpcsaBuffer[i].LocalAddr.lpSockaddr) { /* Align the current size and add the sockaddr's length */ Size = (Size + 3) & ~3; Size += AnsiSet->lpcsaBuffer[i].LocalAddr.iSockaddrLength; } /* Check for remote sockaddr */ - if (&AnsiSet->lpcsaBuffer[i].RemoteAddr) + if (AnsiSet->lpcsaBuffer[i].RemoteAddr.lpSockaddr) { /* Align the current size and add the sockaddr's length */ Size = (Size + 3) & ~3;

8 years, 4 months

[pschweitzer] 72136: [FASTFAT] Properly check for opened handles in subdirectories when we're about to rename a directory. This helps reducing corruption where some renaming operations were allowed...

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Aug 6 12:25:47 2016 New Revision: 72136 URL: http://svn.reactos.org/svn/reactos?rev=72136&view=rev Log: [FASTFAT] Properly check for opened handles in subdirectories when we're about to rename a directory. This helps reducing corruption where some renaming operations were allowed whereas they shouldn't have been. CORE-11377 CORE-11426 Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] Sat Aug 6 12:25:47 2016 @@ -458,6 +458,35 @@ return Status; } +static +BOOLEAN +IsThereAChildOpened(PVFATFCB FCB) +{ + PLIST_ENTRY Entry; + PVFATFCB VolFCB; + + for (Entry = FCB->ParentListHead.Flink; Entry != &FCB->ParentListHead; Entry = Entry->Flink) + { + VolFCB = CONTAINING_RECORD(Entry, VFATFCB, ParentListEntry); + if (VolFCB->OpenHandleCount != 0) + { + ASSERT(VolFCB->parentFcb == FCB); + DPRINT1("At least one children file opened! %wZ (%u, %u)\n", &VolFCB->PathNameU, VolFCB->RefCount, VolFCB->OpenHandleCount); + return TRUE; + } + + if (vfatFCBIsDirectory(VolFCB) && !IsListEmpty(&VolFCB->ParentListHead)) + { + if (IsThereAChildOpened(VolFCB)) + { + return TRUE; + } + } + } + + return FALSE; +} + /* * FUNCTION: Set the file name information */ @@ -706,20 +735,11 @@ if (vfatFCBIsDirectory(FCB) && !IsListEmpty(&FCB->ParentListHead)) { - PLIST_ENTRY Entry; - PVFATFCB VolFCB; - - for (Entry = FCB->ParentListHead.Flink; Entry != &FCB->ParentListHead; Entry = Entry->Flink) - { - VolFCB = CONTAINING_RECORD(Entry, VFATFCB, ParentListEntry); - if (VolFCB->OpenHandleCount != 0) - { - ASSERT(VolFCB->parentFCB == FCB); - DPRINT1("At least one children file opened! %wZ (%u, %u)\n", &VolFCB->PathNameU, VolFCB->RefCount, VolFCB->OpenHandleCount); - Status = STATUS_ACCESS_DENIED; - ASSERT(OldReferences == FCB->parentFcb->RefCount); - goto Cleanup; - } + if (IsThereAChildOpened(FCB)) + { + Status = STATUS_ACCESS_DENIED; + ASSERT(OldReferences == FCB->parentFcb->RefCount); + goto Cleanup; } }

8 years, 4 months

[tfaber] 72135: [SYSDM] - Less ambiguously check the return value of DialogBoxParam CORE-11794

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 12:15:16 2016 New Revision: 72135 URL: http://svn.reactos.org/svn/reactos?rev=72135&view=rev Log: [SYSDM] - Less ambiguously check the return value of DialogBoxParam CORE-11794 Modified: trunk/reactos/dll/cpl/sysdm/environment.c Modified: trunk/reactos/dll/cpl/sysdm/environment.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/environment.… ============================================================================== --- trunk/reactos/dll/cpl/sysdm/environment.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/sysdm/environment.c [iso-8859-1] Sat Aug 6 12:15:16 2016 @@ -353,11 +353,11 @@ VarData = GlobalAlloc(GPTR, sizeof(VARIABLE_DATA)); - if (!DialogBoxParam(hApplet, - MAKEINTRESOURCE(IDD_EDIT_VARIABLE), - hwndDlg, - (DLGPROC)EditVariableDlgProc, - (LPARAM)VarData) > 0) + if (DialogBoxParam(hApplet, + MAKEINTRESOURCE(IDD_EDIT_VARIABLE), + hwndDlg, + EditVariableDlgProc, + (LPARAM)VarData) <= 0) { if (VarData->lpName != NULL) GlobalFree(VarData->lpName); @@ -412,7 +412,7 @@ if (DialogBoxParam(hApplet, MAKEINTRESOURCE(IDD_EDIT_VARIABLE), hwndDlg, - (DLGPROC)EditVariableDlgProc, + EditVariableDlgProc, (LPARAM)VarData) > 0) { ListView_SetItemText(hwndListView, iItem, 0, VarData->lpName);

8 years, 4 months

[tfaber] 72134: [WIN32K:NTUSER] - Add some missing VOIDs CORE-11799

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 12:07:54 2016 New Revision: 72134 URL: http://svn.reactos.org/svn/reactos?rev=72134&view=rev Log: [WIN32K:NTUSER] - Add some missing VOIDs CORE-11799 Modified: trunk/reactos/win32ss/user/ntuser/desktop.h trunk/reactos/win32ss/user/ntuser/winsta.h Modified: trunk/reactos/win32ss/user/ntuser/desktop.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/deskto… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/desktop.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/desktop.h [iso-8859-1] Sat Aug 6 12:07:54 2016 @@ -316,6 +316,6 @@ BOOL FASTCALL IntPaintDesktop(HDC); BOOL FASTCALL DesktopWindowProc(PWND, UINT, WPARAM, LPARAM, LRESULT *); BOOL FASTCALL UserMessageWindowProc(PWND pwnd, UINT Msg, WPARAM wParam, LPARAM lParam, LRESULT *lResult); -VOID NTAPI DesktopThreadMain(); +VOID NTAPI DesktopThreadMain(VOID); /* EOF */ Modified: trunk/reactos/win32ss/user/ntuser/winsta.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/winsta… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/winsta.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/winsta.h [iso-8859-1] Sat Aug 6 12:07:54 2016 @@ -81,7 +81,7 @@ NTSTATUS NTAPI -UserCreateWinstaDirectory(); +UserCreateWinstaDirectory(VOID); NTSTATUS APIENTRY

8 years, 4 months

[akhaldi] 72133: [INCLUDE/CRT] Correct _wctime and _wctime_s when _USE_32BIT_TIME_T is defined. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 10:35:53 2016 New Revision: 72133 URL: http://svn.reactos.org/svn/reactos?rev=72133&view=rev Log: [INCLUDE/CRT] Correct _wctime and _wctime_s when _USE_32BIT_TIME_T is defined. CORE-11799 Modified: trunk/reactos/sdk/include/crt/time.h Modified: trunk/reactos/sdk/include/crt/time.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/crt/time.h?rev… ============================================================================== --- trunk/reactos/sdk/include/crt/time.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/crt/time.h [iso-8859-1] Sat Aug 6 10:35:53 2016 @@ -387,8 +387,8 @@ #define _INC_WTIME_INL #ifdef _USE_32BIT_TIME_T /* Do it like this to be compatible to msvcrt.dll on 32 bit windows XP and before */ -__CRT_INLINE wchar_t *__cdecl _wctime32(const time_t *_Time) { return _wctime(_Time); } -__CRT_INLINE errno_t __cdecl _wctime32_s(wchar_t *_Buffer, size_t _SizeInWords,const __time32_t *_Time) { return _wctime32_s(_Buffer, _SizeInWords, _Time); } +__CRT_INLINE wchar_t *__cdecl _wctime(const time_t *_Time) { return _wctime32(_Time); } +__CRT_INLINE errno_t __cdecl _wctime_s(wchar_t *_Buffer, size_t _SizeInWords,const __time32_t *_Time) { return _wctime32_s(_Buffer, _SizeInWords, _Time); } #else __CRT_INLINE wchar_t *__cdecl _wctime(const time_t *_Time) { return _wctime64(_Time); } __CRT_INLINE errno_t __cdecl _wctime_s(wchar_t *_Buffer, size_t _SizeInWords,const time_t *_Time) { return _wctime64_s(_Buffer, _SizeInWords, _Time); }

8 years, 4 months

[akhaldi] 72132: [CRT] Correct some types. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 10:18:08 2016 New Revision: 72132 URL: http://svn.reactos.org/svn/reactos?rev=72132&view=rev Log: [CRT] Correct some types. CORE-11799 Modified: trunk/reactos/sdk/lib/crt/float/i386/cntrlfp.c trunk/reactos/sdk/lib/crt/float/i386/fpreset.c trunk/reactos/sdk/lib/crt/float/i386/statfp.c Modified: trunk/reactos/sdk/lib/crt/float/i386/cntrlfp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/crt/float/i386/cnt… ============================================================================== --- trunk/reactos/sdk/lib/crt/float/i386/cntrlfp.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/crt/float/i386/cntrlfp.c [iso-8859-1] Sat Aug 6 10:18:08 2016 @@ -42,7 +42,7 @@ */ unsigned int CDECL _control87(unsigned int newval, unsigned int mask) { - unsigned int fpword = 0; + unsigned short fpword = 0; unsigned int flags = 0; TRACE("(%08x, %08x): Called\n", newval, mask); Modified: trunk/reactos/sdk/lib/crt/float/i386/fpreset.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/crt/float/i386/fpr… ============================================================================== --- trunk/reactos/sdk/lib/crt/float/i386/fpreset.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/crt/float/i386/fpreset.c [iso-8859-1] Sat Aug 6 10:18:08 2016 @@ -12,7 +12,7 @@ */ void CDECL _fpreset(void) { - const unsigned int x86_cw = 0x27f; + const unsigned short x86_cw = 0x27f; #ifdef _MSC_VER __asm { fninit } __asm { fldcw [x86_cw] } Modified: trunk/reactos/sdk/lib/crt/float/i386/statfp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/crt/float/i386/sta… ============================================================================== --- trunk/reactos/sdk/lib/crt/float/i386/statfp.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/crt/float/i386/statfp.c [iso-8859-1] Sat Aug 6 10:18:08 2016 @@ -25,7 +25,7 @@ unsigned int CDECL _statusfp(void) { unsigned int retVal = 0; - unsigned int fpword; + unsigned short fpword; #ifdef _M_AMD64 fpword = _mm_getcsr();

8 years, 4 months

[akhaldi] 72131: [WIN32DLLS] We don't need mingwex for these modules anymore. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 09:53:47 2016 New Revision: 72131 URL: http://svn.reactos.org/svn/reactos?rev=72131&view=rev Log: [WIN32DLLS] We don't need mingwex for these modules anymore. CORE-11799 Modified: trunk/reactos/dll/win32/beepmidi/CMakeLists.txt trunk/reactos/dll/win32/gdiplus/CMakeLists.txt trunk/reactos/dll/win32/mshtml/CMakeLists.txt trunk/reactos/dll/win32/oleaut32/CMakeLists.txt trunk/reactos/dll/win32/wdmaud.drv/CMakeLists.txt trunk/reactos/dll/win32/winemp3.acm/CMakeLists.txt Modified: trunk/reactos/dll/win32/beepmidi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/beepmidi/CMakeLi… ============================================================================== --- trunk/reactos/dll/win32/beepmidi/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/beepmidi/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:53:47 2016 @@ -6,11 +6,6 @@ ${CMAKE_CURRENT_BINARY_DIR}/beepmidi.def) add_library(beepmidi SHARED ${SOURCE}) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(beepmidi mingwex) -endif() - set_module_type(beepmidi win32dll UNICODE) add_importlibs(beepmidi winmm msvcrt kernel32 ntdll) add_cd_file(TARGET beepmidi DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/win32/gdiplus/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdiplus/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/gdiplus/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/gdiplus/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:53:47 2016 @@ -32,11 +32,6 @@ set_module_type(gdiplus win32dll) target_link_libraries(gdiplus wine) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(gdiplus mingwex) -endif() - add_delay_importlibs(gdiplus windowscodecs) add_importlibs(gdiplus msvcrt shlwapi oleaut32 ole32 user32 gdi32 kernel32 ntdll) add_pch(gdiplus gdiplus_private.h SOURCE) Modified: trunk/reactos/dll/win32/mshtml/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/mshtml/CMakeList… ============================================================================== --- trunk/reactos/dll/win32/mshtml/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/mshtml/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:53:47 2016 @@ -105,11 +105,6 @@ set_source_files_properties(rsrc.rc PROPERTIES OBJECT_DEPENDS "${mshtml_rc_deps}") set_module_type(mshtml win32dll) target_link_libraries(mshtml uuid wine strmiids oldnames) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(mshtml mingwex) -endif() - add_delay_importlibs(mshtml wininet) add_importlibs(mshtml urlmon shlwapi shell32 ole32 oleaut32 user32 gdi32 advapi32 msvcrt kernel32 ntdll) add_dependencies(mshtml mshtml_nsiface_header) Modified: trunk/reactos/dll/win32/oleaut32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/CMakeLi… ============================================================================== --- trunk/reactos/dll/win32/oleaut32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oleaut32/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:53:47 2016 @@ -47,12 +47,6 @@ ${CMAKE_CURRENT_BINARY_DIR}/oleaut32_ocidl_p.c ${CMAKE_CURRENT_BINARY_DIR}/oleaut32.def) -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(oleaut32 mingwex) - #FIXME: http://llvm.org/bugs/show_bug.cgi?id=19027 - set_property(SOURCE vartype.c APPEND_STRING PROPERTY COMPILE_FLAGS " -no-integrated-as") -endif() - add_idl_headers(oleaut32_idlheader oleaut32_oaidl.idl) add_dependencies(oleaut32 oleaut32_idlheader) set_module_type(oleaut32 win32dll) Modified: trunk/reactos/dll/win32/wdmaud.drv/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wdmaud.drv/CMake… ============================================================================== --- trunk/reactos/dll/win32/wdmaud.drv/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wdmaud.drv/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:53:47 2016 @@ -22,11 +22,6 @@ set_module_type(wdmaud.drv win32dll UNICODE) set_target_properties(wdmaud.drv PROPERTIES SUFFIX "") target_link_libraries(wdmaud.drv mmebuddy libsamplerate mmixer) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(wdmaud.drv mingwex) -endif() - add_importlibs(wdmaud.drv user32 winmm advapi32 msvcrt setupapi ksuser kernel32 ntdll) add_pch(wdmaud.drv wdmaud.h SOURCE) add_cd_file(TARGET wdmaud.drv DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/win32/winemp3.acm/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/winemp3.acm/CMak… ============================================================================== --- trunk/reactos/dll/win32/winemp3.acm/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/winemp3.acm/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:53:47 2016 @@ -16,10 +16,5 @@ set_module_type(winemp3.acm win32dll) set_target_properties(winemp3.acm PROPERTIES SUFFIX "") target_link_libraries(winemp3.acm wine libmpg123 oldnames) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(winemp3.acm mingwex) -endif() - add_importlibs(winemp3.acm winmm user32 msvcrt kernel32 ntdll) add_cd_file(TARGET winemp3.acm DESTINATION reactos/system32 FOR all)

8 years, 4 months

[akhaldi] 72130: [NTOS:MM] Add some missing VOIDs. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 09:34:39 2016 New Revision: 72130 URL: http://svn.reactos.org/svn/reactos?rev=72130&view=rev Log: [NTOS:MM] Add some missing VOIDs. CORE-11799 Modified: trunk/reactos/ntoskrnl/mm/ARM3/miarm.h trunk/reactos/ntoskrnl/mm/ARM3/special.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/miarm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/miarm.h?r… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/miarm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/miarm.h [iso-8859-1] Sat Aug 6 09:34:39 2016 @@ -1663,7 +1663,7 @@ VOID NTAPI -MiInitializeSessionSpaceLayout(); +MiInitializeSessionSpaceLayout(VOID); NTSTATUS NTAPI Modified: trunk/reactos/ntoskrnl/mm/ARM3/special.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/special.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/special.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/special.c [iso-8859-1] Sat Aug 6 09:34:39 2016 @@ -70,7 +70,7 @@ /* PRIVATE FUNCTIONS **********************************************************/ -VOID NTAPI MiTestSpecialPool(); +VOID NTAPI MiTestSpecialPool(VOID); BOOLEAN NTAPI

8 years, 4 months

[akhaldi] 72129: [DIRECTX/WINE] We don't need mingwex for these anymore. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 09:32:45 2016 New Revision: 72129 URL: http://svn.reactos.org/svn/reactos?rev=72129&view=rev Log: [DIRECTX/WINE] We don't need mingwex for these anymore. CORE-11799 Modified: trunk/reactos/dll/directx/wine/d3drm/CMakeLists.txt trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt trunk/reactos/dll/directx/wine/dsound/CMakeLists.txt trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt Modified: trunk/reactos/dll/directx/wine/d3drm/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3drm/CMa… ============================================================================== --- trunk/reactos/dll/directx/wine/d3drm/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3drm/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:32:45 2016 @@ -25,11 +25,6 @@ set_module_type(d3drm win32dll UNICODE) target_link_libraries(d3drm dxguid uuid wine) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(d3drm mingwex) -endif() - add_importlibs(d3drm ddraw d3dxof msvcrt kernel32 ntdll) add_pch(d3drm d3drm_private.h SOURCE) add_cd_file(TARGET d3drm DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dx9_36/… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:32:45 2016 @@ -33,11 +33,6 @@ set_module_type(d3dx9_36 win32dll) add_dependencies(d3dx9_36 d3d_idl_headers) target_link_libraries(d3dx9_36 dxguid wine) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(d3dx9_36 mingwex) -endif() - add_importlibs(d3dx9_36 d3dcompiler_43 d3dxof d3dwine user32 ole32 gdi32 msvcrt kernel32 ntdll) add_pch(d3dx9_36 d3dx9_36_private.h SOURCE) add_cd_file(TARGET d3dx9_36 DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/directx/wine/dsound/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/dsound/CM… ============================================================================== --- trunk/reactos/dll/directx/wine/dsound/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/dsound/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:32:45 2016 @@ -24,10 +24,5 @@ set_module_type(dsound win32dll) target_link_libraries(dsound dxguid uuid wine) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(dsound mingwex) -endif() - add_importlibs(dsound winmm advapi32 msvcrt kernel32 ntdll) add_cd_file(TARGET dsound DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/wined3d/C… ============================================================================== --- trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/wined3d/CMakeLists.txt [iso-8859-1] Sat Aug 6 09:32:45 2016 @@ -50,11 +50,6 @@ set_module_type(d3dwine win32dll) target_link_libraries(d3dwine wine) - -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(d3dwine mingwex) -endif() - add_importlibs(d3dwine user32 opengl32 gdi32 advapi32 msvcrt kernel32 ntdll) add_pch(d3dwine wined3d_private.h SOURCE) add_cd_file(TARGET d3dwine DESTINATION reactos/system32 FOR all)

8 years, 4 months

← Newer
1
...
37
38
39
40
41
42
43
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2016