Ros-diffs August 2016

ros-diffs@reactos.org

20 participants
462 discussions

[akhaldi] 72128: [NTOS:PNPMGR] Mark IopReportTargetDeviceChangeAsyncWorker as stdcall and remove the PWORKER_THREAD_ROUTINE cast. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 09:11:08 2016 New Revision: 72128 URL: http://svn.reactos.org/svn/reactos?rev=72128&view=rev Log: [NTOS:PNPMGR] Mark IopReportTargetDeviceChangeAsyncWorker as stdcall and remove the PWORKER_THREAD_ROUTINE cast. CORE-11799 Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnprepo… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/pnpreport.c [iso-8859-1] Sat Aug 6 09:11:08 2016 @@ -108,6 +108,7 @@ } VOID +NTAPI IopReportTargetDeviceChangeAsyncWorker(PVOID Context) { PINTERNAL_WORK_QUEUE_ITEM Item; @@ -509,7 +510,7 @@ Item->PhysicalDeviceObject = PhysicalDeviceObject; Item->Callback = Callback; Item->Context = Context; - ExInitializeWorkItem(&(Item->WorkItem), (PWORKER_THREAD_ROUTINE)IopReportTargetDeviceChangeAsyncWorker, Item); + ExInitializeWorkItem(&(Item->WorkItem), IopReportTargetDeviceChangeAsyncWorker, Item); /* Finally, queue the item, our work here is done */ ExQueueWorkItem(&(Item->WorkItem), DelayedWorkQueue);

8 years, 4 months

[tfaber] 72127: [NTOS:MM] - Correctly check for overflow in PeFmtCreateSection CORE-11794

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 09:07:03 2016 New Revision: 72127 URL: http://svn.reactos.org/svn/reactos?rev=72127&view=rev Log: [NTOS:MM] - Correctly check for overflow in PeFmtCreateSection CORE-11794 Modified: trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Sat Aug 6 09:07:03 2016 @@ -208,6 +208,7 @@ SIZE_T nPrevVirtualEndOfSegment = 0; ULONG nFileSizeOfHeaders = 0; ULONG i; + ULONG AlignedLength; ASSERT(FileHeader); ASSERT(FileHeaderSize > 0); @@ -755,10 +756,11 @@ else pssSegments[i].Length.QuadPart = pishSectionHeaders[i].Misc.VirtualSize; - pssSegments[i].Length.LowPart = ALIGN_UP_BY(pssSegments[i].Length.LowPart, nSectionAlignment); - /* FIXME: always false */ - if (pssSegments[i].Length.QuadPart < pssSegments[i].Length.QuadPart) + AlignedLength = ALIGN_UP_BY(pssSegments[i].Length.LowPart, nSectionAlignment); + if(AlignedLength < pssSegments[i].Length.LowPart) DIE(("Cannot align the virtual size of section %u\n", i)); + + pssSegments[i].Length.LowPart = AlignedLength; if(pssSegments[i].Length.QuadPart == 0) DIE(("Virtual size of section %u is null\n", i));

8 years, 4 months

[pschweitzer] 72126: [FASTFAT] Don't mess with parentless FCB. Dedicated to Thomas :-). CORE-11377 CORE-11426

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Aug 6 08:57:47 2016 New Revision: 72126 URL: http://svn.reactos.org/svn/reactos?rev=72126&view=rev Log: [FASTFAT] Don't mess with parentless FCB. Dedicated to Thomas :-). CORE-11377 CORE-11426 Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Sat Aug 6 08:57:47 2016 @@ -268,11 +268,15 @@ PVFATFCB pFCB) { FsRtlUninitializeFileLock(&pFCB->FileLock); + if (!vfatFCBIsRoot(pFCB) && + !BooleanFlagOn(pFCB->Flags, FCB_IS_FAT) && !BooleanFlagOn(pFCB->Flags, FCB_IS_VOLUME)) + { + RemoveEntryList(&pFCB->ParentListEntry); + } ExFreePool(pFCB->PathNameBuffer); ExDeleteResourceLite(&pFCB->PagingIoResource); ExDeleteResourceLite(&pFCB->MainResource); ExFreeToNPagedLookasideList(&VfatGlobalData->FcbLookasideList, pFCB); - RemoveEntryList(&pFCB->ParentListEntry); ASSERT(IsListEmpty(&pFCB->ParentListHead)); }

8 years, 4 months

[pschweitzer] 72125: [FASTFAT] Addendum to r72124

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Aug 6 08:32:17 2016 New Revision: 72125 URL: http://svn.reactos.org/svn/reactos?rev=72125&view=rev Log: [FASTFAT] Addendum to r72124 Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/vfat.h [iso-8859-1] Sat Aug 6 08:32:17 2016 @@ -386,8 +386,14 @@ /* List of FCB's for this volume */ LIST_ENTRY FcbListEntry; + /* List of FCB's for the parent */ + LIST_ENTRY ParentListEntry; + /* pointer to the parent fcb */ struct _VFATFCB *parentFcb; + + /* List for the children */ + LIST_ENTRY ParentListHead; /* Flags for the fcb */ ULONG Flags;

8 years, 4 months

[pschweitzer] 72124: [FASTFAT] Track child FCB in parent FCB to allow browsing them in case it's needed. This allows fixing a FIXME and offering better performances when renaming a directory. CORE-...

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Aug 6 08:30:30 2016 New Revision: 72124 URL: http://svn.reactos.org/svn/reactos?rev=72124&view=rev Log: [FASTFAT] Track child FCB in parent FCB to allow browsing them in case it's needed. This allows fixing a FIXME and offering better performances when renaming a directory. CORE-11377 CORE-11426 Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c trunk/reactos/drivers/filesystems/fastfat/finfo.c Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Sat Aug 6 08:30:30 2016 @@ -153,6 +153,7 @@ rcFCB->RFCB.PagingIoResource = &rcFCB->PagingIoResource; rcFCB->RFCB.Resource = &rcFCB->MainResource; rcFCB->RFCB.IsFastIoPossible = FastIoIsNotPossible; + InitializeListHead(&rcFCB->ParentListHead); return rcFCB; } @@ -271,6 +272,8 @@ ExDeleteResourceLite(&pFCB->PagingIoResource); ExDeleteResourceLite(&pFCB->MainResource); ExFreeToNPagedLookasideList(&VfatGlobalData->FcbLookasideList, pFCB); + RemoveEntryList(&pFCB->ParentListEntry); + ASSERT(IsListEmpty(&pFCB->ParentListHead)); } BOOLEAN @@ -455,6 +458,7 @@ /* Save old parent */ OldParent = Fcb->parentFcb; + RemoveEntryList(&Fcb->ParentListEntry); /* Reinit FCB */ vfatInitFCBFromDirEntry(pVCB, Fcb, DirContext); @@ -464,6 +468,7 @@ CcFlushCache(&Fcb->SectionObjectPointers, NULL, 0, NULL); } Fcb->parentFcb = ParentFcb; + InsertTailList(&ParentFcb->ParentListHead, &Fcb->ParentListEntry); vfatAddFCBToTable(pVCB, Fcb); /* If we moved across directories, dereference our old parent @@ -673,6 +678,7 @@ vfatFCBInitializeCacheFromVolume(vcb, rcFCB); } rcFCB->parentFcb = directoryFCB; + InsertTailList(&directoryFCB->ParentListHead, &rcFCB->ParentListEntry); vfatAddFCBToTable(vcb, rcFCB); *fileFCB = rcFCB; Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] Sat Aug 6 08:30:30 2016 @@ -704,19 +704,17 @@ vfatSplitPathName(&NewName, &NewPath, &NewFile); DPRINT("New dir: %wZ, New file: %wZ\n", &NewPath, &NewFile); - /* FIXME: Do it in a more efficient way, like linking FCBs to their parent FCB so that we browse less FCBs - * Note: The FIXME is the way MS FastFAT seems to do it - */ - if (vfatFCBIsDirectory(FCB)) + if (vfatFCBIsDirectory(FCB) && !IsListEmpty(&FCB->ParentListHead)) { PLIST_ENTRY Entry; PVFATFCB VolFCB; - for (Entry = DeviceExt->FcbListHead.Flink; Entry != &DeviceExt->FcbListHead; Entry = Entry->Flink) - { - VolFCB = CONTAINING_RECORD(Entry, VFATFCB, FcbListEntry); - if (VolFCB->parentFcb == FCB && VolFCB->OpenHandleCount != 0) - { + for (Entry = FCB->ParentListHead.Flink; Entry != &FCB->ParentListHead; Entry = Entry->Flink) + { + VolFCB = CONTAINING_RECORD(Entry, VFATFCB, ParentListEntry); + if (VolFCB->OpenHandleCount != 0) + { + ASSERT(VolFCB->parentFCB == FCB); DPRINT1("At least one children file opened! %wZ (%u, %u)\n", &VolFCB->PathNameU, VolFCB->RefCount, VolFCB->OpenHandleCount); Status = STATUS_ACCESS_DENIED; ASSERT(OldReferences == FCB->parentFcb->RefCount);

8 years, 4 months

[akhaldi] 72123: [CALC] We don't need mingwex anymore. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 08:26:54 2016 New Revision: 72123 URL: http://svn.reactos.org/svn/reactos?rev=72123&view=rev Log: [CALC] We don't need mingwex anymore. CORE-11799 Modified: trunk/reactos/base/applications/calc/CMakeLists.txt Modified: trunk/reactos/base/applications/calc/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/calc/CMa… ============================================================================== --- trunk/reactos/base/applications/calc/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/calc/CMakeLists.txt [iso-8859-1] Sat Aug 6 08:26:54 2016 @@ -15,9 +15,7 @@ set_module_type(calc win32gui UNICODE) add_importlibs(calc advapi32 user32 shell32 gdi32 msvcrt kernel32) -if(CMAKE_C_COMPILER_ID STREQUAL "Clang") - target_link_libraries(calc mingwex) -elseif(MSVC) +if(MSVC) add_importlibs(calc ntdll) endif()

8 years, 4 months

[akhaldi] 72122: [NTDLL] Add missing VOID. CORE-11799

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Sat Aug 6 08:18:11 2016 New Revision: 72122 URL: http://svn.reactos.org/svn/reactos?rev=72122&view=rev Log: [NTDLL] Add missing VOID. CORE-11799 Modified: trunk/reactos/dll/ntdll/include/ntdllp.h Modified: trunk/reactos/dll/ntdll/include/ntdllp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/include/ntdllp.h… ============================================================================== --- trunk/reactos/dll/ntdll/include/ntdllp.h [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/include/ntdllp.h [iso-8859-1] Sat Aug 6 08:18:11 2016 @@ -59,7 +59,7 @@ NTSTATUS NTAPI LdrpInitializeProcess(PCONTEXT Context, PVOID SystemArgument1); VOID NTAPI LdrpInitFailure(NTSTATUS Status); VOID NTAPI LdrpValidateImageForMp(IN PLDR_DATA_TABLE_ENTRY LdrDataTableEntry); -VOID NTAPI LdrpEnsureLoaderLockIsHeld(); +VOID NTAPI LdrpEnsureLoaderLockIsHeld(VOID); /* ldrpe.c */ NTSTATUS @@ -105,7 +105,7 @@ IN ULONG Flags); ULONG NTAPI -LdrpClearLoadInProgress(); +LdrpClearLoadInProgress(VOID); NTSTATUS NTAPI

8 years, 4 months

[tfaber] 72121: [ARP] - Do not return failure after successful operations CORE-11794

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 07:57:51 2016 New Revision: 72121 URL: http://svn.reactos.org/svn/reactos?rev=72121&view=rev Log: [ARP] - Do not return failure after successful operations CORE-11794 Modified: trunk/reactos/base/applications/network/arp/arp.c Modified: trunk/reactos/base/applications/network/arp/arp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/arp/arp.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/arp/arp.c [iso-8859-1] Sat Aug 6 07:57:51 2016 @@ -568,24 +568,30 @@ else if ((argc == 5) && ((strcmp(argv[3], "-N")) == 0)) DisplayArpEntries(argv[2], argv[4]); else + { Usage(); return EXIT_FAILURE; + } break; case 'd': if (argc == 3) Deletehost(argv[2], NULL); else if (argc == 4) Deletehost(argv[2], argv[3]); else + { Usage(); return EXIT_FAILURE; + } break; case 's': if (argc == 4) Addhost(argv[2], argv[3], NULL); else if (argc == 5) Addhost(argv[2], argv[3], argv[4]); else + { Usage(); return EXIT_FAILURE; + } break; default: Usage();

8 years, 4 months

[tfaber] 72120: [CMD][UXTHEME] - Clarify misleading indentation CORE-11794

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 07:08:52 2016 New Revision: 72120 URL: http://svn.reactos.org/svn/reactos?rev=72120&view=rev Log: [CMD][UXTHEME] - Clarify misleading indentation CORE-11794 Modified: trunk/reactos/base/shell/cmd/copy.c trunk/reactos/dll/win32/uxtheme/system.c Modified: trunk/reactos/base/shell/cmd/copy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/copy.c?rev=… ============================================================================== --- trunk/reactos/base/shell/cmd/copy.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/copy.c [iso-8859-1] Sat Aug 6 07:08:52 2016 @@ -481,13 +481,15 @@ case _T('-'): if (_tcslen(arg[i]) >= 3) + { if (_totupper(arg[i][2]) == _T('Y')) { dwFlags &= ~COPY_NO_PROMPT; dwFlags |= COPY_PROMPT; } - - break; + } + + break; case _T('Z'): dwFlags |= COPY_RESTART; Modified: trunk/reactos/dll/win32/uxtheme/system.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/uxtheme/system.c… ============================================================================== --- trunk/reactos/dll/win32/uxtheme/system.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/uxtheme/system.c [iso-8859-1] Sat Aug 6 07:08:52 2016 @@ -797,7 +797,7 @@ HRESULT WINAPI SetWindowTheme(HWND hwnd, LPCWSTR pszSubAppName, LPCWSTR pszSubIdList) { - HRESULT hr; + HRESULT hr; TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName), debugstr_w(pszSubIdList)); @@ -812,7 +812,7 @@ if (!SUCCEEDED(hr)) return hr; - UXTHEME_broadcast_msg (hwnd, WM_THEMECHANGED); + UXTHEME_broadcast_msg (hwnd, WM_THEMECHANGED); return hr; }

8 years, 4 months

[tfaber] 72119: [CRT] - Apply Wine commit b7f6362d (msvcrt: Use the correct object type for __non_rtti_object exceptions.) by Alexandre Julliard CORE-11794

by tfaber＠svn.reactos.org

Author: tfaber Date: Sat Aug 6 06:52:41 2016 New Revision: 72119 URL: http://svn.reactos.org/svn/reactos?rev=72119&view=rev Log: [CRT] - Apply Wine commit b7f6362d (msvcrt: Use the correct object type for __non_rtti_object exceptions.) by Alexandre Julliard CORE-11794 Modified: trunk/reactos/sdk/lib/crt/except/cpp.c Modified: trunk/reactos/sdk/lib/crt/except/cpp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/crt/except/cpp.c?r… ============================================================================== --- trunk/reactos/sdk/lib/crt/except/cpp.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/crt/except/cpp.c [iso-8859-1] Sat Aug 6 06:52:41 2016 @@ -1134,7 +1134,7 @@ { __non_rtti_object e; MSVCRT___non_rtti_object_ctor( &e, "Bad read pointer - no RTTI data!" ); - _CxxThrowException( &e, &bad_typeid_exception_type ); + _CxxThrowException( &e, &__non_rtti_object_exception_type ); return NULL; } __ENDTRY @@ -1219,7 +1219,7 @@ { __non_rtti_object e; MSVCRT___non_rtti_object_ctor( &e, "Access violation - no RTTI data!" ); - _CxxThrowException( &e, &bad_typeid_exception_type ); + _CxxThrowException( &e, &__non_rtti_object_exception_type ); return NULL; } __ENDTRY @@ -1258,7 +1258,7 @@ { __non_rtti_object e; MSVCRT___non_rtti_object_ctor( &e, "Access violation - no RTTI data!" ); - _CxxThrowException( &e, &bad_typeid_exception_type ); + _CxxThrowException( &e, &__non_rtti_object_exception_type ); return NULL; } __ENDTRY

8 years, 4 months

← Newer
1
...
38
39
40
41
42
43
44
...
47
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2016