Ros-diffs September 2018

ros-diffs@reactos.org

24 participants
223 discussions

01/01: [DBGHELP] Prevent crashing on a malformed PE file. CORE-15030
by Mark Jansen 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=25d143dd2089e1535ff31… commit 25d143dd2089e1535ff31d07098a5fd18bde890a Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Wed Sep 12 21:30:49 2018 +0200 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Wed Sep 12 21:30:49 2018 +0200 [DBGHELP] Prevent crashing on a malformed PE file. CORE-15030 --- dll/win32/dbghelp/pe_module.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dll/win32/dbghelp/pe_module.c b/dll/win32/dbghelp/pe_module.c index b629213d76..376a780653 100644 --- a/dll/win32/dbghelp/pe_module.c +++ b/dll/win32/dbghelp/pe_module.c @@ -615,6 +615,15 @@ static BOOL pe_load_msc_debug_info(const struct process* pcs, struct module* mod dbg = RtlImageRvaToVa(nth, mapping, dir->VirtualAddress, NULL); +#ifdef __REACTOS__ + if (!dbg) + { + ERR("Debug directory not found in module %s\n", + debugstr_w(module->module.ModuleName)); + goto done; + } +#endif + /* Parse debug directory */ if (nth->FileHeader.Characteristics & IMAGE_FILE_DEBUG_STRIPPED) {

1 0

01/01: [NETAPI32] Remove the obsolete file group.c
by Eric Kohl 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ee4ee2fc1db4baf16f87a… commit ee4ee2fc1db4baf16f87a28cf2378d983dc7e18c Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Wed Sep 12 17:53:49 2018 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Wed Sep 12 17:53:49 2018 +0200 [NETAPI32] Remove the obsolete file group.c --- dll/win32/netapi32/CMakeLists.txt | 1 - dll/win32/netapi32/group.c | 25 ------------------------- 2 files changed, 26 deletions(-) diff --git a/dll/win32/netapi32/CMakeLists.txt b/dll/win32/netapi32/CMakeLists.txt index d714bb24b8..dab40b16eb 100644 --- a/dll/win32/netapi32/CMakeLists.txt +++ b/dll/win32/netapi32/CMakeLists.txt @@ -20,7 +20,6 @@ list(APPEND SOURCE dfs.c display.c dssetup.c - group.c group_new.c local_group.c misc.c diff --git a/dll/win32/netapi32/group.c b/dll/win32/netapi32/group.c deleted file mode 100644 index e6300f2bb2..0000000000 --- a/dll/win32/netapi32/group.c +++ /dev/null @@ -1,25 +0,0 @@ -/* - * Copyright 2002 Andriy Palamarchuk - * - * netapi32 access functions - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ - -#include "netapi32.h" - -WINE_DEFAULT_DEBUG_CHANNEL(netapi32); - -/* EOF */

1 0

01/01: [NETAPI32] Rename ENUM_CONTEXT to GROUP_ENUM_CONEXT and fix a use of the wrong type
by Eric Kohl 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=221cdeafe281ce4d239f6… commit 221cdeafe281ce4d239f6374ef1cefabea9918f0 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Wed Sep 12 17:38:18 2018 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Wed Sep 12 17:38:18 2018 +0200 [NETAPI32] Rename ENUM_CONTEXT to GROUP_ENUM_CONEXT and fix a use of the wrong type --- dll/win32/netapi32/group_new.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dll/win32/netapi32/group_new.c b/dll/win32/netapi32/group_new.c index d93589e294..9c3234abe5 100644 --- a/dll/win32/netapi32/group_new.c +++ b/dll/win32/netapi32/group_new.c @@ -18,7 +18,7 @@ typedef enum _ENUM_PHASE DonePhase } ENUM_PHASE; -typedef struct _ENUM_CONTEXT +typedef struct _GROUP_ENUM_CONTEXT { SAM_HANDLE ServerHandle; SAM_HANDLE DomainHandle; @@ -30,7 +30,7 @@ typedef struct _ENUM_CONTEXT ULONG Returned; ULONG Index; ENUM_PHASE Phase; -} ENUM_CONTEXT, *PENUM_CONTEXT; +} GROUP_ENUM_CONTEXT, *PGROUP_ENUM_CONTEXT; typedef struct _USER_ENUM_CONTEXT { @@ -785,7 +785,7 @@ NetGroupEnum( { UNICODE_STRING ServerName; PSAM_RID_ENUMERATION CurrentGroup; - PENUM_CONTEXT EnumContext = NULL; + PGROUP_ENUM_CONTEXT EnumContext = NULL; ULONG i; SAM_HANDLE GroupHandle = NULL; PGROUP_GENERAL_INFORMATION GroupInfo = NULL; @@ -805,11 +805,11 @@ NetGroupEnum( if (resume_handle != NULL && *resume_handle != 0) { - EnumContext = (PENUM_CONTEXT)*resume_handle; + EnumContext = (PGROUP_ENUM_CONTEXT)*resume_handle; } else { - ApiStatus = NetApiBufferAllocate(sizeof(ENUM_CONTEXT), (PVOID*)&EnumContext); + ApiStatus = NetApiBufferAllocate(sizeof(GROUP_ENUM_CONTEXT), (PVOID*)&EnumContext); if (ApiStatus != NERR_Success) goto done; @@ -1164,7 +1164,7 @@ NetGroupGetUsers( } else { - ApiStatus = NetApiBufferAllocate(sizeof(ENUM_CONTEXT), (PVOID*)&EnumContext); + ApiStatus = NetApiBufferAllocate(sizeof(USER_ENUM_CONTEXT), (PVOID*)&EnumContext); if (ApiStatus != NERR_Success) goto done;

1 0

01/01: [NETAPI32] Implement NetGroupSetUsers
by Eric Kohl 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4d9425d1234eea68c6411… commit 4d9425d1234eea68c6411d1ed3eeae1d2297fe38 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Wed Sep 12 17:11:52 2018 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Wed Sep 12 17:11:52 2018 +0200 [NETAPI32] Implement NetGroupSetUsers --- dll/win32/netapi32/group.c | 18 ---- dll/win32/netapi32/group_new.c | 227 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 227 insertions(+), 18 deletions(-) diff --git a/dll/win32/netapi32/group.c b/dll/win32/netapi32/group.c index b252111b3c..e6300f2bb2 100644 --- a/dll/win32/netapi32/group.c +++ b/dll/win32/netapi32/group.c @@ -22,22 +22,4 @@ WINE_DEFAULT_DEBUG_CHANNEL(netapi32); - -/************************************************************ - * NetGroupSetUsers (NETAPI32.@) - * - */ -NET_API_STATUS -WINAPI -NetGroupSetUsers(IN LPCWSTR servername, - IN LPCWSTR groupname, - IN DWORD level, - IN LPBYTE buf, - IN DWORD totalentries) -{ - FIXME("(%s, %s, %d, %p, %d) stub!\n", debugstr_w(servername), - debugstr_w(groupname), level, buf, totalentries); - return ERROR_ACCESS_DENIED; -} - /* EOF */ diff --git a/dll/win32/netapi32/group_new.c b/dll/win32/netapi32/group_new.c index dbf5a3bdf6..d93589e294 100644 --- a/dll/win32/netapi32/group_new.c +++ b/dll/win32/netapi32/group_new.c @@ -1626,4 +1626,231 @@ done: return ApiStatus; } + +NET_API_STATUS +WINAPI +NetGroupSetUsers( + _In_opt_ LPCWSTR servername, + _In_ LPCWSTR groupname, + _In_ DWORD level, + _In_ LPBYTE buf, + _In_ DWORD totalentries) +{ + UNICODE_STRING ServerName; + UNICODE_STRING GroupName; + SAM_HANDLE ServerHandle = NULL; + SAM_HANDLE DomainHandle = NULL; + SAM_HANDLE GroupHandle = NULL; + ULONG OldMemberCount = 0; + PULONG OldMemberIDs = NULL; + PULONG OldAttributes = NULL; + PUNICODE_STRING NamesArray = NULL; + PGROUP_USERS_INFO_0 UserInfo0; + PGROUP_USERS_INFO_1 UserInfo1; + PULONG NewMemberIDs = NULL; + PSID_NAME_USE NewMemberUse = NULL; + ULONG i, j; + BOOL Found; + NET_API_STATUS ApiStatus = NERR_Success; + NTSTATUS Status = STATUS_SUCCESS; + + TRACE("NetGroupSetUsers(%s, %s, %d, %p, %d) stub!\n", + debugstr_w(servername), debugstr_w(groupname), level, buf, totalentries); + + if (servername != NULL) + RtlInitUnicodeString(&ServerName, servername); + + RtlInitUnicodeString(&GroupName, groupname); + + /* Connect to the SAM Server */ + Status = SamConnect((servername != NULL) ? &ServerName : NULL, + &ServerHandle, + SAM_SERVER_CONNECT | SAM_SERVER_LOOKUP_DOMAIN, + NULL); + if (!NT_SUCCESS(Status)) + { + ERR("SamConnect failed (Status %08lx)\n", Status); + ApiStatus = NetpNtStatusToApiStatus(Status); + goto done; + } + + /* Open the Acount Domain */ + Status = OpenAccountDomain(ServerHandle, + (servername != NULL) ? &ServerName : NULL, + DOMAIN_LOOKUP, + &DomainHandle); + if (!NT_SUCCESS(Status)) + { + ERR("OpenAccountDomain failed (Status %08lx)\n", Status); + ApiStatus = NetpNtStatusToApiStatus(Status); + goto done; + } + + /* Open the group account in the account domain */ + ApiStatus = OpenGroupByName(DomainHandle, + &GroupName, + GROUP_LIST_MEMBERS | GROUP_ADD_MEMBER | GROUP_REMOVE_MEMBER, + &GroupHandle, + NULL); + if (ApiStatus != NERR_Success) + { + ERR("OpenGroupByName failed (ApiStatus %lu)\n", ApiStatus); + if (ApiStatus == ERROR_NONE_MAPPED) + ApiStatus = NERR_GroupNotFound; + goto done; + } + + /* Get the group members */ + Status = SamGetMembersInGroup(GroupHandle, + &OldMemberIDs, + &OldAttributes, + &OldMemberCount); + if (!NT_SUCCESS(Status)) + { + ERR("SamGetMembersInGroup failed (Status %08lx)\n", Status); + ApiStatus = NetpNtStatusToApiStatus(Status); + goto done; + } + + NamesArray = RtlAllocateHeap(RtlGetProcessHeap(), + HEAP_ZERO_MEMORY, + totalentries * sizeof(UNICODE_STRING)); + if (NamesArray == NULL) + { + ERR("RtlAllocateHeap failed\n"); + ApiStatus = ERROR_OUTOFMEMORY; + goto done; + } + + UserInfo0 = (PGROUP_USERS_INFO_0)buf; + UserInfo1 = (PGROUP_USERS_INFO_1)buf; + for (i = 0; i < totalentries; i++) + { + if (level == 0) + RtlInitUnicodeString(&NamesArray[i], UserInfo0[i].grui0_name); + else + RtlInitUnicodeString(&NamesArray[i], UserInfo1[i].grui1_name); + } + + Status = SamLookupNamesInDomain(DomainHandle, + totalentries, + NamesArray, + &NewMemberIDs, + &NewMemberUse); + if (!NT_SUCCESS(Status)) + { + ERR("SamLookupNamesInDomain failed (Status %08lx)\n", Status); + + if (Status == STATUS_NONE_MAPPED) + { + ApiStatus = NERR_UserNotFound; + goto done; + } + + ApiStatus = NetpNtStatusToApiStatus(Status); + goto done; + } + + /* Add members and set attributes for existing members */ + for (i = 0; i < totalentries; i++) + { + Found = FALSE; + for (j = 0; j < OldMemberCount; j++) + { + if (NewMemberIDs[i] == OldMemberIDs[j]) + { + if (level == 1) + { + Status = SamSetMemberAttributesOfGroup(GroupHandle, + NewMemberIDs[i], + UserInfo1[i].grui1_attributes); + if (!NT_SUCCESS(Status)) + { + ERR("SamSetMemberAttributesOfGroup failed (Status %lu)\n", Status); + ApiStatus = NetpNtStatusToApiStatus(Status); + goto done; + } + } + + Found = TRUE; + break; + } + } + + if (Found == FALSE) + { + TRACE("Add member %lx\n", NewMemberIDs[i]); + + if (NewMemberUse[i] != SidTypeUser) + { + ERR("New member is not a user!\n"); + ApiStatus = NERR_GroupNotFound; + goto done; + } + + Status = SamAddMemberToGroup(GroupHandle, + NewMemberIDs[i], + (level == 0) ? 0 : UserInfo1[i].grui1_attributes); + if (!NT_SUCCESS(Status)) + { + ERR("SamAddMemberToGroup failed (Status %lu)\n", Status); + ApiStatus = NetpNtStatusToApiStatus(Status); + goto done; + } + } + } + + /* Remove members */ + for (i = 0; i < OldMemberCount; i++) + { + Found = FALSE; + for (j = 0; j < totalentries; j++) + { + if (OldMemberIDs[i] == NewMemberIDs[j]) + { + Found = TRUE; + break; + } + } + + if (Found == FALSE) + { + TRACE("Delete member %lx\n", OldMemberIDs[i]); + + Status = SamRemoveMemberFromGroup(GroupHandle, + OldMemberIDs[i]); + if (!NT_SUCCESS(Status)) + { + ERR("SamRemoveMemberFromGroup failed (Status %lu)\n", Status); + ApiStatus = NetpNtStatusToApiStatus(Status); + goto done; + } + } + } + +done: + if (NewMemberUse != NULL) + SamFreeMemory(NewMemberUse); + + if (NewMemberIDs != NULL) + SamFreeMemory(NewMemberIDs); + + if (NamesArray != NULL) + RtlFreeHeap(RtlGetProcessHeap(), 0, NamesArray); + + if (OldMemberIDs != NULL) + SamFreeMemory(OldMemberIDs); + + if (GroupHandle != NULL) + SamCloseHandle(GroupHandle); + + if (DomainHandle != NULL) + SamCloseHandle(DomainHandle); + + if (ServerHandle != NULL) + SamCloseHandle(ServerHandle); + + return ApiStatus; +} + /* EOF */

1 0

05/05: [MAINTAINERS] Complete myself
by Pierre Schweitzer 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=739fd481c19192d0306a4… commit 739fd481c19192d0306a43251d3d068341074491 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Mon Sep 10 18:52:51 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed Sep 12 08:13:28 2018 +0200 [MAINTAINERS] Complete myself --- MAINTAINERS | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb7763219b..28ae7ee4de 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -84,6 +84,7 @@ Application Compatibility subystem Cache Manager M: HeisSpiter, Pierre Schweitzer S: Maintained + F: modules/rostests/kmtests/ntos_cc/ F: ntoskrnl/cc/ Cache Manager Rewrite @@ -109,6 +110,8 @@ File Systems File Systems Run Time Library M: HeisSpiter, Pierre Schweitzer S: Maintained + F: modules/rostests/kmtests/ntos_fsrtl/ + F: modules/rostests/kmtests/novp_fsrtl/ F: ntoskrnl/fsrtl/ F: sdk/lib/drivers/ntoskrnl_vista/fsrtl.c @@ -164,6 +167,7 @@ ROS internals tools Run-Time Library (RTL) M: + R: HeisSpiter, Pierre Schweitzer R: learn-more, learn_more, Mark Jansen R: ThFabba, Thomas Faber S: Maintained

1 0

04/05: [MAINTAINERS] Define who can be maintainer and how to be added to the file
by Pierre Schweitzer 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e516c2950b84d54ff66ba… commit e516c2950b84d54ff66ba795956a1080fa06ea43 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Mon Sep 10 18:47:29 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed Sep 12 08:13:28 2018 +0200 [MAINTAINERS] Define who can be maintainer and how to be added to the file --- MAINTAINERS | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 934c42fe86..eb7763219b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9,6 +9,7 @@ area of ReactOS. Being a maintainer means the following: - that person has good knownledge in the area - that person is able to enforce consistency in the area - that person may be available for giving help in the area + - that person has push access on the repository Being a maintainer does not mean the following: - that person is dedicated to the area - that person is working full-time on the area/on ReactOS @@ -25,7 +26,8 @@ from all the listed reviewers. Also, when submitted a pull request on GitHub, rules defined in CONTRIBUTING.md apply. And if the maintainer is not available and reviewers approved the pull request, developers feeling confident -can merge the pull request. +can merge the pull request. Note that reviewers do not necessarily +have push access to the repository. When submitting a bug report on Jira, if you want to be sure to have a developer with skills in that area, write @nick from M people. @@ -37,6 +39,10 @@ managing local patches. He is not here to upstream code on your behalf. As responsible, he may refuse a local patch if you did not try to upstream your changes. +If you want to get listed in that file, either put yourself in the +file and push it, or open a pull request. You can also ask a person +who has push access to add yourself. + This file uses a similar format to the Linux kernel MAINTAINERS file. Descriptions of section entries used here: M: Primary maintainer. Assign them pull requests

1 0

03/05: [MAINTAINERS] Add myself.
by Mark Jansen 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=09bffcab1e373606dcb5e… commit 09bffcab1e373606dcb5e1350a4672d6e2f3fcbe Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Sat Sep 8 13:49:20 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed Sep 12 08:13:28 2018 +0200 [MAINTAINERS] Add myself. Also add Pierre to ntdll --- MAINTAINERS | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1b6338d117..934c42fe86 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -63,6 +63,18 @@ ACPICA Library S: Upstream F: drivers/bus/acpi/acpica/ +Apisets + M: learn-more, learn_more, Mark Jansen + S: Maintained + F: dll/apisets + +Application Compatibility subystem + M: learn-more, learn_more, Mark Jansen + S: Maintained + F: dll/appcompat + F: dll/shellext/acppage + F: ntoskrnl/ps/apphelp.c + Cache Manager M: HeisSpiter, Pierre Schweitzer S: Maintained @@ -74,6 +86,7 @@ Cache Manager Rewrite CMake Build Scripts M: + R: learn-more, learn_more, Mark Jansen R: ThFabba, Thomas Faber S: Maintained F: sdk/cmake/ @@ -120,12 +133,15 @@ Network File Systems kernel libraries NTDLL M: + R: HeisSpiter, Pierre Schweitzer + R: learn-more, learn_more, Mark Jansen R: ThFabba, Thomas Faber S: Maintained F: dll/ntdll/ ReactOS API Tests M: + R: learn-more, learn_more, Mark Jansen R: ThFabba, Thomas Faber S: Maintained F: modules/rostests/apitests/ @@ -142,10 +158,17 @@ ROS internals tools Run-Time Library (RTL) M: + R: learn-more, learn_more, Mark Jansen R: ThFabba, Thomas Faber S: Maintained F: sdk/lib/rtl/ +Shell Extensions + M: + R: learn-more, learn_more, Mark Jansen + S: Maintained + F: dll/shellext + Upstream File Systems M: HeisSpiter, Pierre Schweitzer S: Upstream

1 0

02/05: [MAINTAINERS] Add myself.
by Thomas Faber 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=af4ae5e65815a6fd182b3… commit af4ae5e65815a6fd182b3b3455a1a3c6a788efbd Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sat Sep 8 12:10:53 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed Sep 12 08:13:28 2018 +0200 [MAINTAINERS] Add myself. Also add Pierre to the kernel as a whole, at his request. Also fix a typo in "Abandoned". --- MAINTAINERS | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index ea1ab51212..1b6338d117 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -51,15 +51,35 @@ Descriptions of section entries used here: this area C: Comments +ACPI + M: + R: ThFabba, Thomas Faber + S: Maintained + F: drivers/bus/acpi/ + F: hal/halx86/acpi/ + +ACPICA Library + M: ThFabba, Thomas Faber + S: Upstream + F: drivers/bus/acpi/acpica/ + Cache Manager M: HeisSpiter, Pierre Schweitzer S: Maintained F: ntoskrnl/cc/ Cache Manager Rewrite - S: Abandonned + S: Abandoned F: ntoskrnl/cache/ +CMake Build Scripts + M: + R: ThFabba, Thomas Faber + S: Maintained + F: sdk/cmake/ + F: */CMakeLists.txt + F: */*.cmake + File Systems M: HeisSpiter, Pierre Schweitzer S: Maintained @@ -73,11 +93,24 @@ File Systems Run Time Library F: ntoskrnl/fsrtl/ F: sdk/lib/drivers/ntoskrnl_vista/fsrtl.c -IO Manager +HID Drivers + M: + R: ThFabba, Thomas Faber + S: Maintained + F: drivers/hid/ + +Kernel M: R: HeisSpiter, Pierre Schweitzer + R: ThFabba, Thomas Faber S: Maintained - F: ntoskrnl/io/iomgr/ + F: ntoskrnl/ + +Network Drivers + M: + R: ThFabba, Thomas Faber + S: Maintained + F: drivers/network/ Network File Systems kernel libraries M: HeisSpiter, Pierre Schweitzer @@ -85,11 +118,34 @@ Network File Systems kernel libraries F: sdk/lib/drivers/rdbsslib/ F: sdk/lib/drivers/rxce/ +NTDLL + M: + R: ThFabba, Thomas Faber + S: Maintained + F: dll/ntdll/ + +ReactOS API Tests + M: + R: ThFabba, Thomas Faber + S: Maintained + F: modules/rostests/apitests/ + +ReactOS Kernel-Mode Tests + M: ThFabba, Thomas Faber + S: Maintained + F: modules/rostests/kmtests/ + ROS internals tools M: HeisSpiter, Pierre Schweitzer S: Maintained F: modules/rosapps/applications/rosinternals/ +Run-Time Library (RTL) + M: + R: ThFabba, Thomas Faber + S: Maintained + F: sdk/lib/rtl/ + Upstream File Systems M: HeisSpiter, Pierre Schweitzer S: Upstream @@ -108,6 +164,13 @@ Upstream File Systems F: sdk/lib/fslib/ext2lib/ F: sdk/lib/fslib/vfatlib/check/ +USB Drivers + M: ThFabba, Thomas Faber + S: Maintained + F: drivers/usb/ + F: sdk/lib/drivers/libusb/ + F: sdk/include/reactos/drivers/usbport/ + Virtual CD-ROM M: HeisSpiter, Pierre Schweitzer S: Maintained @@ -129,3 +192,9 @@ Windows Network File Systems functions M: HeisSpiter, Pierre Schweitzer S: Upstream F: dll/win32/mpr/wnet.c + +Wine Tests + M: + R: ThFabba, Thomas Faber + S: Upstream + F: modules/rostests/winetests/

1 0

01/05: Add a maintainers file
by Pierre Schweitzer 12 Sep '18

12 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a8ce91e7168aa16ca71f4… commit a8ce91e7168aa16ca71f456556da35ae0f64eaa7 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Sep 8 11:14:56 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Wed Sep 12 08:13:28 2018 +0200 Add a maintainers file --- MAINTAINERS | 131 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 131 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS new file mode 100644 index 0000000000..ea1ab51212 --- /dev/null +++ b/MAINTAINERS @@ -0,0 +1,131 @@ + List of maintainers for the ReactOS project + +This file purpose is to give newcomers to the projet the responsible +developers when submitting a pull request on GitHub, or opening a bug +report on Jira. + +This file will notably establish who is responsible for a specific +area of ReactOS. Being a maintainer means the following: + - that person has good knownledge in the area + - that person is able to enforce consistency in the area + - that person may be available for giving help in the area +Being a maintainer does not mean the following: + - that person is dedicated to the area + - that person is working full-time on the area/on ReactOS + - that person is paid + - that person is always available + +We have no supported (paid) areas in ReactOS. + +When submitting a pull request on GitHub and looking for reviewers, +look at that file and ask for a review from some of the people (M, R +- the most recently active in the area) listed in the matching area, +also, assign the pull request to the M person. Don't ask for a review +from all the listed reviewers. +Also, when submitted a pull request on GitHub, rules defined in +CONTRIBUTING.md apply. And if the maintainer is not available and +reviewers approved the pull request, developers feeling confident +can merge the pull request. +When submitting a bug report on Jira, if you want to be sure to have +a developer with skills in that area, write @nick from M people. + +There should be one and only one primary maintainer per area. + +In case of 3rd party code (also refered as upstream), the maintainer +is responsible of updating periodically the source code and of +managing local patches. He is not here to upstream code on your behalf. +As responsible, he may refuse a local patch if you did not try to +upstream your changes. + +This file uses a similar format to the Linux kernel MAINTAINERS file. +Descriptions of section entries used here: + M: Primary maintainer. Assign them pull requests + Use the GitHub, Jira, Real Name format for entry, squash if + some are overlapping + R: Reviewers. Ask them for review on pull requests + S: Status, one of the following: + Maintained: Someone is handling that area + Upstream: This is 3rd party code, synced in our tree + Abandoned: No one is handling that code anymore + F: Files. Directories, files (wildcards allowed) covered in + this area + C: Comments + +Cache Manager + M: HeisSpiter, Pierre Schweitzer + S: Maintained + F: ntoskrnl/cc/ + +Cache Manager Rewrite + S: Abandonned + F: ntoskrnl/cache/ + +File Systems + M: HeisSpiter, Pierre Schweitzer + S: Maintained + F: drivers/filesystems/ + F: sdk/lib/fslib/ + C: Also see "Upstream File Systems" + +File Systems Run Time Library + M: HeisSpiter, Pierre Schweitzer + S: Maintained + F: ntoskrnl/fsrtl/ + F: sdk/lib/drivers/ntoskrnl_vista/fsrtl.c + +IO Manager + M: + R: HeisSpiter, Pierre Schweitzer + S: Maintained + F: ntoskrnl/io/iomgr/ + +Network File Systems kernel libraries + M: HeisSpiter, Pierre Schweitzer + S: Maintained + F: sdk/lib/drivers/rdbsslib/ + F: sdk/lib/drivers/rxce/ + +ROS internals tools + M: HeisSpiter, Pierre Schweitzer + S: Maintained + F: modules/rosapps/applications/rosinternals/ + +Upstream File Systems + M: HeisSpiter, Pierre Schweitzer + S: Upstream + F: base/services/nfsd/ + F: dll/np/nfs/ + F: dll/shellext/shellbtrfs/ + F: drivers/filesystems/btrfs/ + F: drivers/filesystems/cdfs/ + F: drivers/filesystems/ext2/ + F: drivers/filesystems/fastfat_new/ + F: drivers/filesystems/ffs/ + F: drivers/filesystems/nfs/ + F: drivers/filesystems/reiserfs/ + F: media/doc/README.FSD + F: sdk/lib/fslib/btrfslib/ + F: sdk/lib/fslib/ext2lib/ + F: sdk/lib/fslib/vfatlib/check/ + +Virtual CD-ROM + M: HeisSpiter, Pierre Schweitzer + S: Maintained + F: modules/rosapps/applications/cmdutils/vcdcli/ + F: modules/rosapps/drivers/vcdrom/ + +Virtual Floppy Disk + M: HeisSpiter, Pierre Schweitzer + S: Upstream + F: modules/rosapps/applications/cmdutils/vfdcmd/ + F: modules/rosapps/drivers/vfd/ + +Win32 file functions + M: HeisSpiter, Pierre Schweitzer + S: Maintained + F: dll/win32/kernel32/client/file/ + +Windows Network File Systems functions + M: HeisSpiter, Pierre Schweitzer + S: Upstream + F: dll/win32/mpr/wnet.c

1 0

01/01: [NETAPI32] Implement NetLogonGetTimeServiceParentDomain
by Eric Kohl 11 Sep '18

11 Sep '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e0b5050089270375e4df0… commit e0b5050089270375e4df0c8949e50020d94e6809 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Tue Sep 11 15:02:19 2018 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Tue Sep 11 15:02:19 2018 +0200 [NETAPI32] Implement NetLogonGetTimeServiceParentDomain --- dll/win32/netapi32/netapi32.spec | 2 +- dll/win32/netapi32/netlogon.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/dll/win32/netapi32/netapi32.spec b/dll/win32/netapi32/netapi32.spec index d00d2f4162..3b476e94b1 100644 --- a/dll/win32/netapi32/netapi32.spec +++ b/dll/win32/netapi32/netapi32.spec @@ -173,7 +173,7 @@ @ stdcall NetLocalGroupGetMembers(wstr wstr long ptr long ptr ptr ptr) @ stdcall NetLocalGroupSetInfo(wstr wstr long ptr ptr) @ stdcall NetLocalGroupSetMembers(wstr wstr long ptr long) -@ stub NetLogonGetTimeServiceParentDomain +@ stdcall NetLogonGetTimeServiceParentDomain(wstr ptr ptr) @ stdcall NetLogonSetServiceBits(wstr long long) @ stdcall NetMessageBufferSend(wstr wstr wstr ptr long) @ stdcall NetMessageNameAdd(wstr wstr) diff --git a/dll/win32/netapi32/netlogon.c b/dll/win32/netapi32/netlogon.c index 1133d5769d..d4b939109f 100644 --- a/dll/win32/netapi32/netlogon.c +++ b/dll/win32/netapi32/netlogon.c @@ -652,6 +652,34 @@ NetGetDCName( } +NET_API_STATUS +WINAPI +NetLogonGetTimeServiceParentDomain( + _In_ LPWSTR ServerName, + _Out_ LPWSTR *DomainName, + _Out_ LPBOOL PdcSameSite) +{ + NET_API_STATUS Status; + + TRACE("NetLogonGetTimeServiceParentDomain(%s, %p, %p)\n", + debugstr_w(ServerName), DomainName, PdcSameSite); + + RpcTryExcept + { + Status = NetrLogonGetTimeServiceParentDomain(ServerName, + DomainName, + PdcSameSite); + } + RpcExcept(EXCEPTION_EXECUTE_HANDLER) + { + Status = I_RpcMapWin32Status(RpcExceptionCode()); + } + RpcEndExcept; + + return Status; +} + + NTSTATUS WINAPI NetLogonSetServiceBits(

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
23
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2018