https://git.reactos.org/?p=reactos.git;a=commitdiff;h=39312ba688ab7a78c4470…
commit 39312ba688ab7a78c4470fa1c72e0efedae0f15f
Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
AuthorDate: Sat Apr 27 16:17:37 2019 +0900
Commit: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
CommitDate: Sat Apr 27 16:17:37 2019 +0900
[WIN32SS][NTGDI] Use UNICODE_NULL for consistency
---
win32ss/gdi/ntgdi/freetype.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/win32ss/gdi/ntgdi/freetype.c b/win32ss/gdi/ntgdi/freetype.c
index 18f9ef9f74..7d19d159f8 100644
--- a/win32ss/gdi/ntgdi/freetype.c
+++ b/win32ss/gdi/ntgdi/freetype.c
@@ -2822,7 +2822,7 @@ GetFontFamilyInfoForSubstitutes(const LOGFONTW *LogFont,
&Win32Process->PrivateFontListHead);
IntUnLockProcessPrivateFonts(Win32Process);
- if (LogFont->lfFaceName[0])
+ if (LogFont->lfFaceName[0] != UNICODE_NULL)
{
/* it's already matched to the exact name and charset if the name
was specified at here, then so don't scan more for another name */
@@ -4487,7 +4487,7 @@ GetFontPenalty(const LOGFONTW * LogFont,
ActualNameW = (WCHAR*)((ULONG_PTR)Otm + (ULONG_PTR)Otm->otmpFamilyName);
- if (LogFont->lfFaceName[0])
+ if (LogFont->lfFaceName[0] != UNICODE_NULL)
{
BOOL Found = FALSE;
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=86ae6b029fd4d18db885e…
commit 86ae6b029fd4d18db885edd12275dc8b120814e4
Author: Colin Finck <colin(a)reactos.org>
AuthorDate: Fri Apr 26 10:30:24 2019 +0200
Commit: Colin Finck <colin(a)reactos.org>
CommitDate: Fri Apr 26 10:31:02 2019 +0200
[ROSAUTOTEST] A timeout of 120 seconds kills the msi:action test prematurely, so increase it to 170 seconds.
This is still below the 180 seconds before sysreg2 kills the entire VM.
I've added a comment to clarify that.
---
modules/rostests/rosautotest/CWineTest.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/modules/rostests/rosautotest/CWineTest.cpp b/modules/rostests/rosautotest/CWineTest.cpp
index 6e163979e0..9967d2d21c 100644
--- a/modules/rostests/rosautotest/CWineTest.cpp
+++ b/modules/rostests/rosautotest/CWineTest.cpp
@@ -8,7 +8,11 @@
#include "precomp.h"
static const DWORD ListTimeout = 10000;
-static const DWORD ProcessActivityTimeout = 120000;
+
+// This value needs to be lower than the <timeout> configured in sysreg.xml! (usually 180000)
+// Otherwise, sysreg2 kills the VM before we can kill the process.
+static const DWORD ProcessActivityTimeout = 170000;
+
/**
* Constructs a CWineTest object.
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e34d3cf3792b9ae44d1e8…
commit e34d3cf3792b9ae44d1e814a1ca160e1714aa71f
Author: Colin Finck <colin(a)reactos.org>
AuthorDate: Wed Apr 24 10:48:15 2019 +0200
Commit: Colin Finck <colin(a)reactos.org>
CommitDate: Fri Apr 26 10:02:47 2019 +0200
[REGTEST] Add regtest.cmd to the Run key inside regtest.cmd, so we're also started on the next reboot in case ReactOS crashed *and* the registry has been saved.
unattend.inf only allows to add RunOnce entries, which are in theory only executed on the first boot after installation.
For almost a decade, this worked anyway to start regtest.cmd again after a ReactOS crash, because the registry and thus the deletion of the RunOnce entry wasn't stored on disk in case of a crash.
Thanks to Sylvain for the hint!
As Explorer processes the Run key right after RunOnce and therefore picks up regtest.cmd a second time during the first boot, exit the script just after adding the Run key.
Otherwise, rosautotest.exe would be started twice, with catastrophic results.
---
boot/bootdata/bootcdregtest/regtest.cmd | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/boot/bootdata/bootcdregtest/regtest.cmd b/boot/bootdata/bootcdregtest/regtest.cmd
index 29ea7becb2..ec263e1324 100644
--- a/boot/bootdata/bootcdregtest/regtest.cmd
+++ b/boot/bootdata/bootcdregtest/regtest.cmd
@@ -2,6 +2,15 @@
set WINETEST_DEBUG=0
set WINETEST_PLATFORM=reactos
+:: On the first boot, we're started through RunOnce.
+:: Add us to the Run key, so we're also started on the next reboot in case ReactOS crashed *and* the registry has been saved.
+:: Exit right after that, because Explorer processes the Run key right after RunOnce and therefore picks up regtest.cmd a second time during the first boot.
+reg query HKLM\Software\Microsoft\Windows\CurrentVersion\Run /v regtest
+if "%errorlevel%"=="1" (
+ reg add HKLM\Software\Microsoft\Windows\CurrentVersion\Run /v regtest /t REG_SZ /d "%SystemRoot%\system32\cmd.exe /c regtest.cmd"
+ exit 0
+)
+
move C:\ReactOS\bin\redirtest1.dll C:\ReactOS\bin\kernel32test_versioned.dll
move C:\ReactOS\bin\testdata\redirtest2.dll C:\ReactOS\bin\testdata\kernel32test_versioned.dll
if exist "C:\ReactOS\bin\AHKAppTests.cmd" (