Ros-diffs September 2019

ros-diffs@reactos.org

21 participants
115 discussions

[reactos] 01/01: [FREELDR] Implement 'SeekRelative' mode for the *Seek() methods for disks & filesystems.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e18e7b100c236835ffa6c… commit e18e7b100c236835ffa6ca06114a5c8551becec5 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Wed Sep 18 02:42:56 2019 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Wed Sep 18 02:42:56 2019 +0200 [FREELDR] Implement 'SeekRelative' mode for the *Seek() methods for disks & filesystems. --- boot/freeldr/freeldr/arch/i386/hwdisk.c | 25 ++++++++++++++++++------- boot/freeldr/freeldr/disk/scsiport.c | 25 ++++++++++++++++++------- boot/freeldr/freeldr/lib/fs/btrfs.c | 19 ++++++++++++++----- boot/freeldr/freeldr/lib/fs/ext2.c | 21 ++++++++++++++------- boot/freeldr/freeldr/lib/fs/fat.c | 21 +++++++++++++++------ boot/freeldr/freeldr/lib/fs/iso.c | 21 +++++++++++++++------ boot/freeldr/freeldr/lib/fs/ntfs.c | 21 ++++++++++++++------- 7 files changed, 108 insertions(+), 45 deletions(-) diff --git a/boot/freeldr/freeldr/arch/i386/hwdisk.c b/boot/freeldr/freeldr/arch/i386/hwdisk.c index ef13c24bbe4..d67494d508d 100644 --- a/boot/freeldr/freeldr/arch/i386/hwdisk.c +++ b/boot/freeldr/freeldr/arch/i386/hwdisk.c @@ -206,18 +206,29 @@ static ARC_STATUS DiskSeek(ULONG FileId, LARGE_INTEGER* Position, SEEKMODE SeekMode) { DISKCONTEXT* Context = FsGetDeviceSpecific(FileId); - ULONGLONG SectorNumber; + LARGE_INTEGER NewPosition = *Position; - if (SeekMode != SeekAbsolute) - return EINVAL; - if (Position->LowPart & (Context->SectorSize - 1)) + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += (Context->SectorNumber * Context->SectorSize); + break; + default: + ASSERT(FALSE); + return EINVAL; + } + + if (NewPosition.QuadPart & (Context->SectorSize - 1)) return EINVAL; - SectorNumber = Position->QuadPart / Context->SectorSize; - if (SectorNumber >= Context->SectorCount) + /* Convert in number of sectors */ + NewPosition.QuadPart /= Context->SectorSize; + if (NewPosition.QuadPart >= Context->SectorCount) return EINVAL; - Context->SectorNumber = SectorNumber; + Context->SectorNumber = NewPosition.QuadPart; return ESUCCESS; } diff --git a/boot/freeldr/freeldr/disk/scsiport.c b/boot/freeldr/freeldr/disk/scsiport.c index 92b032ea574..6cb204d4c31 100644 --- a/boot/freeldr/freeldr/disk/scsiport.c +++ b/boot/freeldr/freeldr/disk/scsiport.c @@ -373,18 +373,29 @@ static ARC_STATUS DiskRead(ULONG FileId, VOID* Buffer, ULONG N, ULONG* Count) static ARC_STATUS DiskSeek(ULONG FileId, LARGE_INTEGER* Position, SEEKMODE SeekMode) { DISKCONTEXT* Context = FsGetDeviceSpecific(FileId); - ULONGLONG SectorNumber; + LARGE_INTEGER NewPosition = *Position; - if (SeekMode != SeekAbsolute) - return EINVAL; - if (Position->QuadPart & (Context->SectorSize - 1)) + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += (Context->SectorNumber * Context->SectorSize); + break; + default: + ASSERT(FALSE); + return EINVAL; + } + + if (NewPosition.QuadPart & (Context->SectorSize - 1)) return EINVAL; - SectorNumber = Position->QuadPart / Context->SectorSize; - if (SectorNumber >= Context->SectorCount) + /* Convert in number of sectors */ + NewPosition.QuadPart /= Context->SectorSize; + if (NewPosition.QuadPart >= Context->SectorCount) return EINVAL; - Context->SectorNumber = SectorNumber; + Context->SectorNumber = NewPosition.QuadPart; return ESUCCESS; } diff --git a/boot/freeldr/freeldr/lib/fs/btrfs.c b/boot/freeldr/freeldr/lib/fs/btrfs.c index 6ba632e0a40..2b88d6f6b39 100644 --- a/boot/freeldr/freeldr/lib/fs/btrfs.c +++ b/boot/freeldr/freeldr/lib/fs/btrfs.c @@ -1201,15 +1201,24 @@ ARC_STATUS BtrFsRead(ULONG FileId, VOID *Buffer, ULONG Size, ULONG *BytesRead) ARC_STATUS BtrFsSeek(ULONG FileId, LARGE_INTEGER *Position, SEEKMODE SeekMode) { pbtrfs_file_info phandle = FsGetDeviceSpecific(FileId); + LARGE_INTEGER NewPosition = *Position; - TRACE("BtrFsSeek %lu NewFilePointer = %llu\n", FileId, Position->QuadPart); + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += phandle->position; + break; + default: + ASSERT(FALSE); + return EINVAL; + } - if (SeekMode != SeekAbsolute) - return EINVAL; - if (Position->QuadPart >= phandle->inode.size) + if (NewPosition.QuadPart >= phandle->inode.size) return EINVAL; - phandle->position = Position->QuadPart; + phandle->position = NewPosition.QuadPart; return ESUCCESS; } diff --git a/boot/freeldr/freeldr/lib/fs/ext2.c b/boot/freeldr/freeldr/lib/fs/ext2.c index d5a4d92b456..9d183488d68 100644 --- a/boot/freeldr/freeldr/lib/fs/ext2.c +++ b/boot/freeldr/freeldr/lib/fs/ext2.c @@ -1263,17 +1263,24 @@ ARC_STATUS Ext2Read(ULONG FileId, VOID* Buffer, ULONG N, ULONG* Count) ARC_STATUS Ext2Seek(ULONG FileId, LARGE_INTEGER* Position, SEEKMODE SeekMode) { PEXT2_FILE_INFO FileHandle = FsGetDeviceSpecific(FileId); + LARGE_INTEGER NewPosition = *Position; - TRACE("Ext2Seek() NewFilePointer = %lu\n", Position->LowPart); + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += FileHandle->FilePointer; + break; + default: + ASSERT(FALSE); + return EINVAL; + } - if (SeekMode != SeekAbsolute) - return EINVAL; - if (Position->HighPart != 0) - return EINVAL; - if (Position->LowPart >= FileHandle->FileSize) + if (NewPosition.QuadPart >= FileHandle->FileSize) return EINVAL; - FileHandle->FilePointer = Position->LowPart; + FileHandle->FilePointer = NewPosition.QuadPart; return ESUCCESS; } diff --git a/boot/freeldr/freeldr/lib/fs/fat.c b/boot/freeldr/freeldr/lib/fs/fat.c index 7dad4f2f516..f16f03a57e1 100644 --- a/boot/freeldr/freeldr/lib/fs/fat.c +++ b/boot/freeldr/freeldr/lib/fs/fat.c @@ -1485,17 +1485,26 @@ ARC_STATUS FatRead(ULONG FileId, VOID* Buffer, ULONG N, ULONG* Count) ARC_STATUS FatSeek(ULONG FileId, LARGE_INTEGER* Position, SEEKMODE SeekMode) { PFAT_FILE_INFO FileHandle = FsGetDeviceSpecific(FileId); + LARGE_INTEGER NewPosition = *Position; - TRACE("FatSeek() NewFilePointer = %lu\n", Position->LowPart); + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += (ULONGLONG)FileHandle->FilePointer; + break; + default: + ASSERT(FALSE); + return EINVAL; + } - if (SeekMode != SeekAbsolute) - return EINVAL; - if (Position->HighPart != 0) + if (NewPosition.HighPart != 0) return EINVAL; - if (Position->LowPart >= FileHandle->FileSize) + if (NewPosition.LowPart >= FileHandle->FileSize) return EINVAL; - FileHandle->FilePointer = Position->LowPart; + FileHandle->FilePointer = NewPosition.LowPart; return ESUCCESS; } diff --git a/boot/freeldr/freeldr/lib/fs/iso.c b/boot/freeldr/freeldr/lib/fs/iso.c index 6e8d0df2a02..6c08d32a0e9 100644 --- a/boot/freeldr/freeldr/lib/fs/iso.c +++ b/boot/freeldr/freeldr/lib/fs/iso.c @@ -462,17 +462,26 @@ ARC_STATUS IsoRead(ULONG FileId, VOID* Buffer, ULONG N, ULONG* Count) ARC_STATUS IsoSeek(ULONG FileId, LARGE_INTEGER* Position, SEEKMODE SeekMode) { PISO_FILE_INFO FileHandle = FsGetDeviceSpecific(FileId); + LARGE_INTEGER NewPosition = *Position; - TRACE("IsoSeek() NewFilePointer = %lu\n", Position->LowPart); + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += (ULONGLONG)FileHandle->FilePointer; + break; + default: + ASSERT(FALSE); + return EINVAL; + } - if (SeekMode != SeekAbsolute) - return EINVAL; - if (Position->HighPart != 0) + if (NewPosition.HighPart != 0) return EINVAL; - if (Position->LowPart >= FileHandle->FileSize) + if (NewPosition.LowPart >= FileHandle->FileSize) return EINVAL; - FileHandle->FilePointer = Position->LowPart; + FileHandle->FilePointer = NewPosition.LowPart; return ESUCCESS; } diff --git a/boot/freeldr/freeldr/lib/fs/ntfs.c b/boot/freeldr/freeldr/lib/fs/ntfs.c index e6f7b2531b9..bc2e6bfee86 100644 --- a/boot/freeldr/freeldr/lib/fs/ntfs.c +++ b/boot/freeldr/freeldr/lib/fs/ntfs.c @@ -846,17 +846,24 @@ ARC_STATUS NtfsRead(ULONG FileId, VOID* Buffer, ULONG N, ULONG* Count) ARC_STATUS NtfsSeek(ULONG FileId, LARGE_INTEGER* Position, SEEKMODE SeekMode) { PNTFS_FILE_HANDLE FileHandle = FsGetDeviceSpecific(FileId); + LARGE_INTEGER NewPosition = *Position; - TRACE("NtfsSeek() NewFilePointer = %lu\n", Position->LowPart); + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += FileHandle->Offset; + break; + default: + ASSERT(FALSE); + return EINVAL; + } - if (SeekMode != SeekAbsolute) - return EINVAL; - if (Position->HighPart != 0) - return EINVAL; - if (Position->LowPart >= (ULONG)NtfsGetAttributeSize(&FileHandle->DataContext->Record)) + if (NewPosition.QuadPart >= NtfsGetAttributeSize(&FileHandle->DataContext->Record)) return EINVAL; - FileHandle->Offset = Position->LowPart; + FileHandle->Offset = NewPosition.QuadPart; return ESUCCESS; }

5 years, 3 months

[reactos] 01/01: [FREELDR] Implement 'SeekRelative' mode for the *Seek() methods for disks & filesystems.

by Hermès Bélusca-Maïto

5 years, 3 months

[reactos] 01/01: [FREELDR] Implement 'SeekRelative' mode for the *Seek() methods for disks & filesystems.

by Hermès Bélusca-Maïto

5 years, 3 months

[reactos] 01/01: [DLLEXPORT_TEST] Fix duplicated export on non-x86 architectures

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=eaf24cc380a66bf8c1cb2… commit eaf24cc380a66bf8c1cb2439da225b351e0b482d Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Wed Aug 28 16:34:33 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 8 16:59:57 2019 +0200 [DLLEXPORT_TEST] Fix duplicated export on non-x86 architectures --- modules/rostests/tests/dllexport/dllexport_test_dll1.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/rostests/tests/dllexport/dllexport_test_dll1.spec b/modules/rostests/tests/dllexport/dllexport_test_dll1.spec index 2a8d06cd340..dfe635f1aeb 100644 --- a/modules/rostests/tests/dllexport/dllexport_test_dll1.spec +++ b/modules/rostests/tests/dllexport/dllexport_test_dll1.spec @@ -12,8 +12,8 @@ @ stdcall StdcallFunc1(ptr) # Decorated export of a stdcall function - @ stdcall _StdcallFunc1@4(ptr) - @ stdcall -arch=i386 _DecoratedStdcallFunc1@4(ptr) + @ stdcall -arch=i386 _StdcallFunc1@4(ptr) # Reuse function name on x86 only! + @ stdcall _DecoratedStdcallFunc1@4(ptr) # Redirected stdcall function @ stdcall StdcallFunc2(ptr) StdcallFunc1

5 years, 3 months

[reactos] 03/03: [IPHLPAPI] Simplify spec file

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=175abab7adab9db5a6e36… commit 175abab7adab9db5a6e36a34b9d6f89ffbc51d6a Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sun Aug 25 11:44:43 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 8 16:23:46 2019 +0200 [IPHLPAPI] Simplify spec file Also move the exports where they are on Windows. This was already handled correctly by MSVC and still doesn't fix the order on GCC builds, but that is a different story and shall be addressed at a different time. --- dll/win32/iphlpapi/iphlpapi.spec | 53 ++++++++++++---------------------------- 1 file changed, 16 insertions(+), 37 deletions(-) diff --git a/dll/win32/iphlpapi/iphlpapi.spec b/dll/win32/iphlpapi/iphlpapi.spec index d9a20667939..6d186f35152 100644 --- a/dll/win32/iphlpapi/iphlpapi.spec +++ b/dll/win32/iphlpapi/iphlpapi.spec @@ -116,6 +116,22 @@ @ stdcall NotifyRouteChange( ptr ptr ) @ stub NotifyRouteChangeEx @ stub NotifySecurityHealthChange +@ stdcall _PfAddFiltersToInterface@24() +@ stdcall _PfAddGlobalFilterToInterface@8() +@ stdcall _PfBindInterfaceToIPAddress@12() +@ stdcall _PfBindInterfaceToIndex@16() +@ stdcall _PfCreateInterface@24() +@ stdcall _PfDeleteInterface@4() +@ stdcall _PfDeleteLog@0() +@ stdcall _PfGetInterfaceStatistics@16() +@ stdcall _PfMakeLog@4() +@ stdcall _PfRebindFilters@8() +@ stdcall _PfRemoveFilterHandles@12() +@ stdcall _PfRemoveFiltersFromInterface@20() +@ stdcall _PfRemoveGlobalFilterFromInterface@8() +@ stdcall _PfSetLogBuffer@28() +@ stdcall _PfTestPacket@20() +@ stdcall _PfUnBindInterface@4() @ stdcall RestoreMediaSense(ptr ptr) @ stdcall SendARP(long long ptr ptr) @ stub SetAdapterIpAddress @@ -136,43 +152,6 @@ @ stdcall SetTcpEntry( ptr ) @ stub SetTcpEntryToStack @ stdcall UnenableRouter( ptr ptr ) - -# These are actually stubs, but we need to forward them to preserve the decoration. -@ stdcall -arch=i386 _PfAddFiltersToInterface@24() _PfAddFiltersToInterface@24 -@ stdcall -arch=i386 _PfAddGlobalFilterToInterface@8() _PfAddGlobalFilterToInterface@8 -@ stdcall -arch=i386 _PfBindInterfaceToIPAddress@12() _PfBindInterfaceToIPAddress@12 -@ stdcall -arch=i386 _PfBindInterfaceToIndex@16() _PfBindInterfaceToIndex@16 -@ stdcall -arch=i386 _PfCreateInterface@24() _PfCreateInterface@24 -@ stdcall -arch=i386 _PfDeleteInterface@4() _PfDeleteInterface@4 -@ stdcall -arch=i386 _PfDeleteLog@0() _PfDeleteLog@0 -@ stdcall -arch=i386 _PfGetInterfaceStatistics@16() _PfGetInterfaceStatistics@16 -@ stdcall -arch=i386 _PfMakeLog@4() _PfMakeLog@4 -@ stdcall -arch=i386 _PfRebindFilters@8() _PfRebindFilters@8 -@ stdcall -arch=i386 _PfRemoveFilterHandles@12() _PfRemoveFilterHandles@12 -@ stdcall -arch=i386 _PfRemoveFiltersFromInterface@20() _PfRemoveFiltersFromInterface@20 -@ stdcall -arch=i386 _PfRemoveGlobalFilterFromInterface@8() _PfRemoveGlobalFilterFromInterface@8 -@ stdcall -arch=i386 _PfSetLogBuffer@28() _PfSetLogBuffer@28 -@ stdcall -arch=i386 _PfTestPacket@20() _PfTestPacket@20 -@ stdcall -arch=i386 _PfUnBindInterface@4() _PfUnBindInterface@4 - -# x64 does not use decoration in these names -@ stdcall -arch=x86_64 _PfAddFiltersToInterface@24() -@ stdcall -arch=x86_64 _PfAddGlobalFilterToInterface@8() -@ stdcall -arch=x86_64 _PfBindInterfaceToIPAddress@12() -@ stdcall -arch=x86_64 _PfBindInterfaceToIndex@16() -@ stdcall -arch=x86_64 _PfCreateInterface@24() -@ stdcall -arch=x86_64 _PfDeleteInterface@4() -@ stdcall -arch=x86_64 _PfDeleteLog@0() -@ stdcall -arch=x86_64 _PfGetInterfaceStatistics@16() -@ stdcall -arch=x86_64 _PfMakeLog@4() -@ stdcall -arch=x86_64 _PfRebindFilters@8() -@ stdcall -arch=x86_64 _PfRemoveFilterHandles@12() -@ stdcall -arch=x86_64 _PfRemoveFiltersFromInterface@20() -@ stdcall -arch=x86_64 _PfRemoveGlobalFilterFromInterface@8() -@ stdcall -arch=x86_64 _PfSetLogBuffer@28() -@ stdcall -arch=x86_64 _PfTestPacket@20() -@ stdcall -arch=x86_64 _PfUnBindInterface@4() - @ stub do_echo_rep @ stub do_echo_req @ stub register_icmp

5 years, 3 months

[reactos] 02/03: [IPHLPAPI] Improve function stubs

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=76eed61813a573126c926… commit 76eed61813a573126c926ddc64abe595b74c2525 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Thu Aug 29 17:59:26 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 8 16:23:46 2019 +0200 [IPHLPAPI] Improve function stubs --- dll/win32/iphlpapi/iphlpapi_fakestubs.c | 196 +++++++++++++++++++++----------- 1 file changed, 128 insertions(+), 68 deletions(-) diff --git a/dll/win32/iphlpapi/iphlpapi_fakestubs.c b/dll/win32/iphlpapi/iphlpapi_fakestubs.c index 8304b33ffc8..04871374e24 100644 --- a/dll/win32/iphlpapi/iphlpapi_fakestubs.c +++ b/dll/win32/iphlpapi/iphlpapi_fakestubs.c @@ -1,120 +1,180 @@ -#include <stubs.h> -// These are here so we can forward the decorated export functions. -// Without forwarding, we'll lose the decoration +// These are here so we can get the decorated export functions. +// With autogenerated stubs we'll lose the decoration // See: // https://jira.reactos.org/browse/CORE-8462 // https://jira.reactos.org/browse/CORE-15665 -int __stdcall PfAddFiltersToInterface(long a0, long a1, long a2, long a3, long a4, long a5) +#include <config.h> +#include "iphlpapi_private.h" +#include <fltdefs.h> + +WINE_DEFAULT_DEBUG_CHANNEL(iphlpapi); + +DWORD +WINAPI +PfAddFiltersToInterface( + INTERFACE_HANDLE ih, + DWORD cInFilters, + PPF_FILTER_DESCRIPTOR pfiltIn, + DWORD cOutFilters, + PPF_FILTER_DESCRIPTOR pfiltOut, + PFILTER_HANDLE pfHandle) { - DbgPrint("WARNING: calling stub PfAddFiltersToInterface(0x%lx,0x%lx,0x%lx,0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2, (long)a3, (long)a4, (long)a5); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfAddGlobalFilterToInterface(long a0, long a1) +DWORD +PFEXPORT +WINAPI +PfAddGlobalFilterToInterface( + INTERFACE_HANDLE pInterface, + GLOBAL_FILTER gfFilter) { - DbgPrint("WARNING: calling stub PfAddGlobalFilterToInterface(0x%lx,0x%lx)\n", (long)a0, (long)a1); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfBindInterfaceToIPAddress(long a0, long a1, long a2) +PFAPIENTRY +PfBindInterfaceToIPAddress( + INTERFACE_HANDLE pInterface, + PFADDRESSTYPE pfatType, + PBYTE IPAddress) { - DbgPrint("WARNING: calling stub PfBindInterfaceToIPAddress(0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfBindInterfaceToIndex(long a0, long a1, long a2, long a3) +PFAPIENTRY +PfBindInterfaceToIndex( + INTERFACE_HANDLE pInterface, + DWORD dwIndex, + PFADDRESSTYPE pfatLinkType, + PBYTE LinkIPAddress) { - DbgPrint("WARNING: calling stub PfBindInterfaceToIndex(0x%lx,0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2, (long)a3); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfCreateInterface(long a0, long a1, long a2, long a3, long a4, long a5) +PFAPIENTRY +PfCreateInterface( + DWORD dwName, + PFFORWARD_ACTION inAction, + PFFORWARD_ACTION outAction, + BOOL bUseLog, + BOOL bMustBeUnique, + INTERFACE_HANDLE* ppInterface) { - DbgPrint("WARNING: calling stub PfCreateInterface(0x%lx,0x%lx,0x%lx,0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2, (long)a3, (long)a4, (long)a5); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfDeleteInterface(long a0) +PFAPIENTRY +PfDeleteInterface( + INTERFACE_HANDLE pInterface) { - DbgPrint("WARNING: calling stub PfDeleteInterface(0x%lx)\n", (long)a0); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfDeleteLog() +PFAPIENTRY +PfDeleteLog( + VOID) { - DbgPrint("WARNING: calling stub PfDeleteLog()\n"); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfGetInterfaceStatistics(long a0, long a1, long a2, long a3) +PFAPIENTRY +PfGetInterfaceStatistics( + INTERFACE_HANDLE pInterface, + PPF_INTERFACE_STATS ppfStats, + PDWORD pdwBufferSize, + BOOL fResetCounters) { - DbgPrint("WARNING: calling stub PfGetInterfaceStatistics(0x%lx,0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2, (long)a3); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfMakeLog(long a0) +PFAPIENTRY +PfMakeLog( + HANDLE hEvent) { - DbgPrint("WARNING: calling stub PfMakeLog(0x%lx)\n", (long)a0); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfRebindFilters(long a0, long a1) +PFAPIENTRY +PfRebindFilters( + INTERFACE_HANDLE pInterface, + PPF_LATEBIND_INFO pLateBindInfo) { - DbgPrint("WARNING: calling stub PfRebindFilters(0x%lx,0x%lx)\n", (long)a0, (long)a1); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfRemoveFilterHandles(long a0, long a1, long a2) +PFAPIENTRY +PfRemoveFilterHandles( + INTERFACE_HANDLE pInterface, + DWORD cFilters, + PFILTER_HANDLE pvHandles) { - DbgPrint("WARNING: calling stub PfRemoveFilterHandles(0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfRemoveFiltersFromInterface(long a0, long a1, long a2, long a3, long a4) +PFAPIENTRY +PfRemoveFiltersFromInterface( + INTERFACE_HANDLE ih, + DWORD cInFilters, + PPF_FILTER_DESCRIPTOR pfiltIn, + DWORD cOutFilters, + PPF_FILTER_DESCRIPTOR pfiltOut) { - DbgPrint("WARNING: calling stub PfRemoveFiltersFromInterface(0x%lx,0x%lx,0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2, (long)a3, (long)a4); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfRemoveGlobalFilterFromInterface(long a0, long a1) +PFAPIENTRY +PfRemoveGlobalFilterFromInterface( + INTERFACE_HANDLE pInterface, + GLOBAL_FILTER gfFilter) { - DbgPrint("WARNING: calling stub PfRemoveGlobalFilterFromInterface(0x%lx,0x%lx)\n", (long)a0, (long)a1); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfSetLogBuffer(long a0, long a1, long a2, long a3, long a4, long a5, long a6) +PFAPIENTRY +PfSetLogBuffer( + PBYTE pbBuffer, + DWORD dwSize, + DWORD dwThreshold, + DWORD dwEntries, + PDWORD pdwLoggedEntries, + PDWORD pdwLostEntries, + PDWORD pdwSizeUsed) { - DbgPrint("WARNING: calling stub PfSetLogBuffer(0x%lx,0x%lx,0x%lx,0x%lx,0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2, (long)a3, (long)a4, (long)a5, (long)a6); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfTestPacket(long a0, long a1, long a2, long a3, long a4) +PFAPIENTRY +PfTestPacket( + INTERFACE_HANDLE pInInterface OPTIONAL, + INTERFACE_HANDLE pOutInterface OPTIONAL, + DWORD cBytes, + PBYTE pbPacket, + PPFFORWARD_ACTION ppAction) { - DbgPrint("WARNING: calling stub PfTestPacket(0x%lx,0x%lx,0x%lx,0x%lx,0x%lx)\n", (long)a0, (long)a1, (long)a2, (long)a3, (long)a4); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -int __stdcall PfUnBindInterface(long a0) +PFAPIENTRY +PfUnBindInterface( + INTERFACE_HANDLE pInterface) { - DbgPrint("WARNING: calling stub PfUnBindInterface(0x%lx)\n", (long)a0); - __wine_spec_unimplemented_stub("iphlpapi.dll", __FUNCTION__); - return 0; + UNIMPLEMENTED; + return ERROR_CALL_NOT_IMPLEMENTED; } -

5 years, 3 months

[reactos] 01/03: [PSDK] Add fltdefs.h

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2adbfdf6cdb3fb1d02f61… commit 2adbfdf6cdb3fb1d02f61f6a12ded2320c663a0b Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Thu Aug 29 17:57:01 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 8 16:23:46 2019 +0200 [PSDK] Add fltdefs.h --- sdk/include/psdk/fltdefs.h | 261 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 261 insertions(+) diff --git a/sdk/include/psdk/fltdefs.h b/sdk/include/psdk/fltdefs.h new file mode 100644 index 00000000000..673db5205a0 --- /dev/null +++ b/sdk/include/psdk/fltdefs.h @@ -0,0 +1,261 @@ +/* + * fltdefs.h + * + * This file is part of the ReactOS PSDK package. + * + * Contributors: + * Created by Timo Kreuzer. + * + * THIS SOFTWARE IS NOT COPYRIGHTED + * + * This source code is offered for use in the public domain. You may + * use, modify or distribute it freely. + * + * This code is distributed in the hope that it will be useful but + * WITHOUT ANY WARRANTY. ALL WARRANTIES, EXPRESS OR IMPLIED ARE HEREBY + * DISCLAIMED. This includes but is not limited to warranties of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. + * + */ + +#ifndef _FLTDEFS_H +#define _FLTDEFS_H + +#pragma once + +#ifdef __cplusplus +#define EXTERNCDECL EXTERN_C +#else +#define EXTERNCDECL +#endif + +#ifdef _M_CEE_PURE +#define PFEXPORT +#else +#define PFEXPORT /* __declspec(dllexport) Native headers have this, but this breaks exports with GCC! */ +#endif + +#define PFAPIENTRY EXTERNCDECL DWORD PFEXPORT WINAPI + +#define ERROR_BASE 23000 +#define PFERROR_NO_PF_INTERFACE (ERROR_BASE + 0) +#define PFERROR_NO_FILTERS_GIVEN (ERROR_BASE + 1) +#define PFERROR_BUFFER_TOO_SMALL (ERROR_BASE + 2) +#define ERROR_IPV6_NOT_IMPLEMENTED (ERROR_BASE + 3) + +#define FD_FLAGS_NOSYN 0x1 +#define FD_FLAGS_ALLFLAGS FD_FLAGS_NOSYN + +#define FILTER_PROTO(ProtoId) MAKELONG(MAKEWORD((ProtoId), 0x00), 0x00000) +#define FILTER_PROTO_ANY FILTER_PROTO(0x00) +#define FILTER_PROTO_ICMP FILTER_PROTO(0x01) +#define FILTER_PROTO_TCP FILTER_PROTO(0x06) +#define FILTER_PROTO_UDP FILTER_PROTO(0x11) + +#define FILTER_TCPUDP_PORT_ANY ((WORD)0x0000) +#define FILTER_ICMP_TYPE_ANY ((BYTE)0xff) +#define FILTER_ICMP_CODE_ANY ((BYTE)0xff) + +#define LB_SRC_ADDR_USE_SRCADDR_FLAG 0x00000001 +#define LB_SRC_ADDR_USE_DSTADDR_FLAG 0x00000002 +#define LB_DST_ADDR_USE_SRCADDR_FLAG 0x00000004 +#define LB_DST_ADDR_USE_DSTADDR_FLAG 0x00000008 +#define LB_SRC_MASK_LATE_FLAG 0x00000010 +#define LB_DST_MASK_LATE_FLAG 0x00000020 + +typedef PVOID FILTER_HANDLE, * PFILTER_HANDLE; +typedef PVOID INTERFACE_HANDLE, * PINTERFACE_HANDLE; + +typedef enum _GlobalFilter +{ + GF_FRAGMENTS = 2, + GF_STRONGHOST = 8, + GF_FRAGCACHE = 9 +} GLOBAL_FILTER, *PGLOBAL_FILTER; + +typedef enum _PfAddresType +{ + PF_IPV4, + PF_IPV6 +} PFADDRESSTYPE, *PPFADDRESSTYPE; + +typedef enum _PfForwardAction +{ + PF_ACTION_FORWARD = 0, + PF_ACTION_DROP +} PFFORWARD_ACTION, *PPFFORWARD_ACTION; + +typedef enum _PfFrameType +{ + PFFT_FILTER = 1, + PFFT_FRAG = 2, + PFFT_SPOOF = 3 +} PFFRAMETYPE, *PPFFRAMETYPE; + +typedef struct _pfLogFrame +{ + LARGE_INTEGER Timestamp; + PFFRAMETYPE pfeTypeOfFrame; + DWORD dwTotalSizeUsed; + DWORD dwFilterRule; + WORD wSizeOfAdditionalData; + WORD wSizeOfIpHeader; + DWORD dwInterfaceName; + DWORD dwIPIndex; + BYTE bPacketData[1]; +} PFLOGFRAME, *PPFLOGFRAME; + +typedef struct _PF_FILTER_DESCRIPTOR +{ + DWORD dwFilterFlags; + DWORD dwRule; + PFADDRESSTYPE pfatType; + PBYTE SrcAddr; + PBYTE SrcMask; + PBYTE DstAddr; + PBYTE DstMask; + DWORD dwProtocol; + DWORD fLateBound; + WORD wSrcPort; + WORD wDstPort; + WORD wSrcPortHighRange; + WORD wDstPortHighRange; +} PF_FILTER_DESCRIPTOR, *PPF_FILTER_DESCRIPTOR; + +#define FILTERSIZE (sizeof(PF_FILTER_DESCRIPTOR) - (DWORD)FIELD_OFFSET(PF_FILTER_DESCRIPTOR, SrcAddr)) + +typedef struct _PF_FILTER_STATS +{ + DWORD dwNumPacketsFiltered; + PF_FILTER_DESCRIPTOR info; +} PF_FILTER_STATS, *PPF_FILTER_STATS; + +typedef struct _PF_INTERFACE_STATS +{ + PVOID pvDriverContext; + DWORD dwFlags; + DWORD dwInDrops; + DWORD dwOutDrops; + PFFORWARD_ACTION eaInAction; + PFFORWARD_ACTION eaOutAction; + DWORD dwNumInFilters; + DWORD dwNumOutFilters; + DWORD dwFrag; + DWORD dwSpoof; + DWORD dwReserved1; + DWORD dwReserved2; + LARGE_INTEGER liSYN; + LARGE_INTEGER liTotalLogged; + DWORD dwLostLogEntries; + PF_FILTER_STATS FilterInfo[1]; +} PF_INTERFACE_STATS, *PPF_INTERFACE_STATS; + +typedef struct _PF_LATEBIND_INFO +{ + PBYTE SrcAddr; + PBYTE DstAddr; + PBYTE Mask; +} PF_LATEBIND_INFO, *PPF_LATEBIND_INFO; + +PFAPIENTRY +PfAddFiltersToInterface( + INTERFACE_HANDLE ih, + DWORD cInFilters, + PPF_FILTER_DESCRIPTOR pfiltIn, + DWORD cOutFilters, + PPF_FILTER_DESCRIPTOR pfiltOut, + PFILTER_HANDLE pfHandle); + +PFAPIENTRY +PfAddGlobalFilterToInterface( + INTERFACE_HANDLE pInterface, + GLOBAL_FILTER gfFilter); + +PFAPIENTRY +PfBindInterfaceToIPAddress( + INTERFACE_HANDLE pInterface, + PFADDRESSTYPE pfatType, + PBYTE IPAddress); + +PFAPIENTRY +PfBindInterfaceToIndex( + INTERFACE_HANDLE pInterface, + DWORD dwIndex, + PFADDRESSTYPE pfatLinkType, + PBYTE LinkIPAddress); + +PFAPIENTRY +PfCreateInterface( + DWORD dwName, + PFFORWARD_ACTION inAction, + PFFORWARD_ACTION outAction, + BOOL bUseLog, + BOOL bMustBeUnique, + INTERFACE_HANDLE* ppInterface); + +PFAPIENTRY +PfDeleteInterface( + INTERFACE_HANDLE pInterface); + +PFAPIENTRY +PfDeleteLog( + VOID); + +PFAPIENTRY +PfGetInterfaceStatistics( + INTERFACE_HANDLE pInterface, + PPF_INTERFACE_STATS ppfStats, + PDWORD pdwBufferSize, + BOOL fResetCounters); + +PFAPIENTRY +PfMakeLog( + HANDLE hEvent); + +PFAPIENTRY +PfRebindFilters( + INTERFACE_HANDLE pInterface, + PPF_LATEBIND_INFO pLateBindInfo); + +PFAPIENTRY +PfRemoveFilterHandles( + INTERFACE_HANDLE pInterface, + DWORD cFilters, + PFILTER_HANDLE pvHandles); + +PFAPIENTRY +PfRemoveFiltersFromInterface( + INTERFACE_HANDLE ih, + DWORD cInFilters, + PPF_FILTER_DESCRIPTOR pfiltIn, + DWORD cOutFilters, + PPF_FILTER_DESCRIPTOR pfiltOut); + +PFAPIENTRY +PfRemoveGlobalFilterFromInterface( + INTERFACE_HANDLE pInterface, + GLOBAL_FILTER gfFilter); + +PFAPIENTRY +PfSetLogBuffer( + PBYTE pbBuffer, + DWORD dwSize, + DWORD dwThreshold, + DWORD dwEntries, + PDWORD pdwLoggedEntries, + PDWORD pdwLostEntries, + PDWORD pdwSizeUsed); + +PFAPIENTRY +PfTestPacket( + INTERFACE_HANDLE pInInterface OPTIONAL, + INTERFACE_HANDLE pOutInterface OPTIONAL, + DWORD cBytes, + PBYTE pbPacket, + PPFFORWARD_ACTION ppAction); + +PFAPIENTRY +PfUnBindInterface( + INTERFACE_HANDLE pInterface); + +#endif // _FLTDEFS_H

5 years, 3 months

[reactos] 01/01: [SETUP] Add support for archtitcure specific inf sections and use it for x64 computer type

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=85616bc8b2dad302417d3… commit 85616bc8b2dad302417d32ee3cac8933ed47cd6d Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Jul 27 09:56:37 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 8 10:42:16 2019 +0200 [SETUP] Add support for archtitcure specific inf sections and use it for x64 computer type --- base/setup/lib/settings.c | 54 ++++++++++++++++++++++++++++++++++------------ boot/bootdata/txtsetup.sif | 14 ++++++++++-- 2 files changed, 52 insertions(+), 16 deletions(-) diff --git a/base/setup/lib/settings.c b/base/setup/lib/settings.c index 2d1c4e1c349..cafe247c05c 100644 --- a/base/setup/lib/settings.c +++ b/base/setup/lib/settings.c @@ -433,16 +433,18 @@ DefaultProcessEntry( } -PGENERIC_LIST -CreateComputerTypeList( - IN HINF InfFile) +BOOLEAN +AddComputerTypeEntries( + _In_ HINF InfFile, + PGENERIC_LIST List, + _In_ PWSTR SectionName) { - PGENERIC_LIST List; INFCONTEXT Context; PCWSTR KeyName; PCWSTR KeyValue; WCHAR ComputerIdentifier[128]; WCHAR ComputerKey[32]; + ULONG Count1, Count2; /* Get the computer identification */ if (!GetComputerIdentifier(ComputerIdentifier, 128)) @@ -453,10 +455,10 @@ CreateComputerTypeList( DPRINT("Computer identifier: '%S'\n", ComputerIdentifier); /* Search for matching device identifier */ - if (!SpInfFindFirstLine(InfFile, L"Map.Computer", NULL, &Context)) + if (!SpInfFindFirstLine(InfFile, SectionName, NULL, &Context)) { /* FIXME: error message */ - return NULL; + return FALSE; } do @@ -467,7 +469,7 @@ CreateComputerTypeList( { /* FIXME: Handle error! */ DPRINT("INF_GetDataField() failed\n"); - return NULL; + return FALSE; } DPRINT("KeyValue: %S\n", KeyValue); @@ -481,7 +483,7 @@ CreateComputerTypeList( { /* FIXME: Handle error! */ DPRINT("INF_GetDataField() failed\n"); - return NULL; + return FALSE; } DPRINT("Computer key: %S\n", KeyName); @@ -489,16 +491,40 @@ CreateComputerTypeList( INF_FreeData(KeyName); } while (SpInfFindNextLine(&Context, &Context)); + Count1 = AddEntriesFromInfSection(List, + InfFile, + L"Computer", + &Context, + DefaultProcessEntry, + ComputerKey); + Count2 = AddEntriesFromInfSection(List, + InfFile, + L"Computer.NT" INF_ARCH, + &Context, + DefaultProcessEntry, + ComputerKey); + if ((Count1 == -1) && (Count2 == -1)) + { + return FALSE; + } + + return TRUE; +} + +PGENERIC_LIST +CreateComputerTypeList( + IN HINF InfFile) +{ + PGENERIC_LIST List; + BOOLEAN Success; + List = CreateGenericList(); if (List == NULL) return NULL; - if (AddEntriesFromInfSection(List, - InfFile, - L"Computer", - &Context, - DefaultProcessEntry, - ComputerKey) == -1) + Success = AddComputerTypeEntries(InfFile, List, L"Map.Computer"); + Success |= AddComputerTypeEntries(InfFile, List, L"Map.Computer.NT" INF_ARCH); + if (!Success) { DestroyGenericList(List, TRUE); return NULL; diff --git a/boot/bootdata/txtsetup.sif b/boot/bootdata/txtsetup.sif index 8b662ef7177..82247b5a154 100644 --- a/boot/bootdata/txtsetup.sif +++ b/boot/bootdata/txtsetup.sif @@ -220,14 +220,17 @@ UnicodeCasetable = l_intl.nls DefaultLayout = 00000409 DefaultLanguage = 00000409 -[Computer] +[Computer.NTx86] pci_up = "Standard PC Uniprocessor" ;pci_mp = "Standard PC Multiprocessor" acpi_up = "ACPI PC Uniprocessor" ;acpi_mp = "ACPI PC Multiprocessor" xbox = "Original Xbox" -[Map.Computer] +[Computer.NTamd64] +x64_up = "Standard x64 Uniprocessor" + +[Map.Computer.NTx86] ;<id> = <pnp id string> pci_up = "PC UP" ;pci_mp = "PC MP" @@ -235,6 +238,9 @@ acpi_up = "ACPI UP" ;acpi_mp = "ACPI MP" xbox = "Xbox" +[Map.Computer.NTamd64] +x64_up = "ACPI UP" + [Files.pci_up] ntoskrnl.exe = 1,,,,,,,2,,,,1,2 hal.dll = 1,,,,,,,2,,,,1,2 @@ -255,6 +261,10 @@ halacpi.dll = 1,,,,,,,2,,,hal.dll,1,2 ntoskrnl.exe = 1,,,,,,,2,,,,1,2 halxbox.dll = 1,,,,,,,2,,,hal.dll,1,2 +[Files.x64_up] +ntoskrnl.exe = 1,,,,,,,2,,,,1,2 +hal.dll = 1,,,,,,,2,,,,1,2 + [Display] ;<id> = <user friendly name>,<spare>,<service key name>,<height>,<width>,<bpp> vga = "VGA Display (640x480x4)",,Vga,640,480,4

5 years, 3 months

[reactos] 01/01: [UNIATA] Fix uniata on x64

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a71a6531ef157fb39d291… commit a71a6531ef157fb39d29171cff6fc59a47e2c4be Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Wed Aug 8 12:29:07 2018 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sun Sep 8 10:39:01 2019 +0200 [UNIATA] Fix uniata on x64 --- drivers/storage/ide/uniata/bsmaster.h | 4 ++++ drivers/storage/ide/uniata/id_sata.cpp | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/storage/ide/uniata/bsmaster.h b/drivers/storage/ide/uniata/bsmaster.h index ed42cc7ba97..4b748b4981b 100644 --- a/drivers/storage/ide/uniata/bsmaster.h +++ b/drivers/storage/ide/uniata/bsmaster.h @@ -1003,7 +1003,11 @@ struct _HW_LU_EXTENSION; typedef struct _IORES { union { +#ifdef __REACTOS__ + ULONG_PTR Addr; /* Base address*/ +#else ULONG Addr; /* Base address*/ +#endif PVOID pAddr; /* Base address in pointer form */ }; ULONG MemIo:1; /* Memory mapping (1) vs IO ports (0) */ diff --git a/drivers/storage/ide/uniata/id_sata.cpp b/drivers/storage/ide/uniata/id_sata.cpp index 2c67131983c..edd7289e3ed 100644 --- a/drivers/storage/ide/uniata/id_sata.cpp +++ b/drivers/storage/ide/uniata/id_sata.cpp @@ -650,7 +650,11 @@ UniataAhciInit( ULONG c, i; PHW_CHANNEL chan; ULONG offs; +#ifdef __REACTOS__ + ULONG_PTR BaseMemAddress; +#else ULONG BaseMemAddress; +#endif ULONG PI; ULONG CAP; ULONG CAP2;

5 years, 3 months

[reactos] 02/02: [KMTESTS:EX] Try to avoid some spurious test failures.

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=acfea670fedbac5eef312… commit acfea670fedbac5eef312c1cbff4726af8c482a6 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sun Sep 8 08:01:23 2019 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sun Sep 8 08:06:51 2019 +0200 [KMTESTS:EX] Try to avoid some spurious test failures. E.g. https://reactos.org/testman/detail.php?id=43906459&prev=43889679 This test depends on the timeout to be long enough for another thread to actually have started waiting, which may take longer than 10ms under load. --- modules/rostests/kmtests/ntos_ex/ExFastMutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/rostests/kmtests/ntos_ex/ExFastMutex.c b/modules/rostests/kmtests/ntos_ex/ExFastMutex.c index ffd3034ba8b..04de7a9a16f 100644 --- a/modules/rostests/kmtests/ntos_ex/ExFastMutex.c +++ b/modules/rostests/kmtests/ntos_ex/ExFastMutex.c @@ -253,7 +253,7 @@ TestFastMutexConcurrent( THREAD_DATA ThreadDataUnsafe; THREAD_DATA ThreadDataTry; LARGE_INTEGER Timeout; - Timeout.QuadPart = -10 * 1000 * 10; /* 10 ms */ + Timeout.QuadPart = -50 * MILLISECOND; InitThreadData(&ThreadData, Mutex, ExAcquireFastMutex, NULL, ExReleaseFastMutex); InitThreadData(&ThreadData2, Mutex, ExAcquireFastMutex, NULL, ExReleaseFastMutex);

5 years, 3 months

← Newer
1
...
5
6
7
8
9
10
11
12
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2019