ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
November 2020
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
18 participants
162 discussions
Start a n
N
ew thread
[reactos] 16/19: [GITHUB] Add CLang build action
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=597660a4b764e2d94f7a9…
commit 597660a4b764e2d94f7a9cfadaf1b2189c00f760 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Tue Nov 10 09:20:04 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [GITHUB] Add CLang build action --- .github/workflows/build.yml | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a3c56f1c208..080bf8b4769 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -55,6 +55,48 @@ jobs: name: reactos-gcc-i386-${{github.sha}} path: build/livecd.iso + build-clang-i386: + name: Clang (i386) + runs-on: ubuntu-latest + steps: + - name: Install RosBE + run: | + wget
https://svn.reactos.org/storage/vperevertkin/rosbe-ci.tar.zst
+ mkdir ${{github.workspace}}/rosbe + tar -I zstd -xvf rosbe-ci.tar.zst --directory ${{github.workspace}}/rosbe + - name: Install other packages + run: | + sudo apt install ccache + sudo bash -c "$(wget -O -
https://apt.llvm.org/llvm.sh
)" + sudo apt install clang-11 + - uses: actions/checkout@v2 + with: + path: src + - name: Set up cache for ccache + uses: actions/cache@v2 + with: + path: ccache + key: ccache-clang-i386-${{github.sha}} + restore-keys: | + ccache-clang-i386- + - name: Set ccache settings + run: | + echo "CCACHE_BASEDIR=${{github.workspace}}" >> $GITHUB_ENV + echo "CCACHE_DIR=${{github.workspace}}/ccache" >> $GITHUB_ENV + echo "CCACHE_MAXSIZE=1G" >> $GITHUB_ENV + echo "CCACHE_SLOPPINESS=time_macros" >> $GITHUB_ENV + - name: Configure + run: | + mkdir build + echo 'cd ${{github.workspace}}/build && cmake ${{github.workspace}}/src -G Ninja -DCMAKE_TOOLCHAIN_FILE:FILEPATH=toolchain-clang.cmake -DARCH:STRING=i386 -DENABLE_CCACHE=1 -DENABLE_ROSTESTS=1 -DENABLE_ROSAPPS=1 -DCLANG_VERSION=11' > commands + ${{github.workspace}}/rosbe/RosBE.sh < commands + - name: Build + run: | + echo 'cd ${{github.workspace}}/build && cmake --build .' > commands + ${{github.workspace}}/rosbe/RosBE.sh < commands + - name: Print ccache statistics + run: ccache -s + build-clang-cl-i386: name: Clang-CL (i386) runs-on: windows-latest
4 years, 1 month
1
0
0
0
[reactos] 15/19: [NTOSKRNL] DO not disable optimisations when compiling with CLang
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=9e7071e8fbb3e321579d1…
commit 9e7071e8fbb3e321579d12d4390f41ad110e8427 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 17:01:07 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [NTOSKRNL] DO not disable optimisations when compiling with CLang --- ntoskrnl/CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/CMakeLists.txt b/ntoskrnl/CMakeLists.txt index 84125c75c9b..fd093c6ca06 100644 --- a/ntoskrnl/CMakeLists.txt +++ b/ntoskrnl/CMakeLists.txt @@ -43,8 +43,10 @@ if(MSVC) add_target_link_flags(ntoskrnl "/SECTION:.rsrc,!DP") #Accessed from bugcheck code add_target_link_flags(ntoskrnl "/SECTION:INIT,ERWD") else() - if(GDB) + if(GDB AND NOT CLANG) # Completely disable optimizations when debugging the kernel + # Not for CLang, which fails as following in _SEH2_EXCEPT macro: + # error: inline assembly requires more registers than available target_compile_options(ntoskrnl PRIVATE -O0) set_image_base(ntoskrnl 0x00800000) else()
4 years, 1 month
1
0
0
0
[reactos] 14/19: [RAPPS] Do not implicitly cast pointer to BOOL
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7a52db76c5fe24f71c662…
commit 7a52db76c5fe24f71c66231bebabac3af7a8f5ab Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 16:05:12 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [RAPPS] Do not implicitly cast pointer to BOOL --- base/applications/rapps/include/rosui.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/base/applications/rapps/include/rosui.h b/base/applications/rapps/include/rosui.h index 0aaf303b017..4402b26f28b 100644 --- a/base/applications/rapps/include/rosui.h +++ b/base/applications/rapps/include/rosui.h @@ -96,9 +96,13 @@ public: BOOL RemoveAt(INT i) { - T* ptr = (T*) DPA_GetPtr(m_hDpa, i); - OnRemoveItem(ptr); - return DPA_DeletePtr(m_hDpa, i); + PVOID ptr = DPA_DeletePtr(m_hDpa, i); + if (ptr != NULL) + { + OnRemoveItem(reinterpret_cast<T*>(ptr)); + return TRUE; + } + return FALSE; } BOOL Clear()
4 years, 1 month
1
0
0
0
[reactos] 13/19: [ATL] Declare pointer as return type for functions returning pointers
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b0abd14b03f7c737148b9…
commit b0abd14b03f7c737148b96d96f9c25a15d192119 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 15:59:55 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [ATL] Declare pointer as return type for functions returning pointers --- sdk/lib/atl/atlpath.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sdk/lib/atl/atlpath.h b/sdk/lib/atl/atlpath.h index 7f476d45239..942b47f638f 100644 --- a/sdk/lib/atl/atlpath.h +++ b/sdk/lib/atl/atlpath.h @@ -23,10 +23,10 @@ class CPathT // const inline BOOL PathFileExistsX(LPCSTR pszPath) { return PathFileExistsA(pszPath); } inline BOOL PathFileExistsX(LPCWSTR pszPath) { return PathFileExistsW(pszPath); } - inline int PathFindExtensionX(LPCSTR pszPath) { return PathFindExtensionA(pszPath); } - inline int PathFindExtensionX(LPCWSTR pszPath) { return PathFindExtensionW(pszPath); } - inline int PathFindFileNameX(LPCSTR pszPath) { return PathFindFileNameA(pszPath); } - inline int PathFindFileNameX(LPCWSTR pszPath) { return PathFindFileNameW(pszPath); } + inline LPCSTR PathFindExtensionX(LPCSTR pszPath) { return PathFindExtensionA(pszPath); } + inline LPCWSTR PathFindExtensionX(LPCWSTR pszPath) { return PathFindExtensionW(pszPath); } + inline LPCSTR PathFindFileNameX(LPCSTR pszPath) { return PathFindFileNameA(pszPath); } + inline LPCWSTR PathFindFileNameX(LPCWSTR pszPath) { return PathFindFileNameW(pszPath); } inline int PathGetDriveNumberX(LPCSTR pszPath) { return PathGetDriveNumberA(pszPath); } inline int PathGetDriveNumberX(LPCWSTR pszPath) { return PathGetDriveNumberW(pszPath); } inline BOOL PathIsDirectoryX(LPCSTR pszPath) { return PathIsDirectoryA(pszPath); } @@ -49,8 +49,8 @@ class CPathT inline BOOL PathIsUNCServerShareX(LPCWSTR pszPath) { return PathIsUNCServerShareW(pszPath); } inline BOOL PathMatchSpecX(LPCSTR pszPath, LPCSTR pszSpec) { return PathMatchSpecA(pszPath, pszSpec); } inline BOOL PathMatchSpecX(LPCWSTR pszPath, LPCWSTR pszSpec) { return PathMatchSpecW(pszPath, pszSpec); } - inline int PathSkipRootX(LPCSTR pszPath) { return PathSkipRootA(pszPath); } - inline int PathSkipRootX(LPCWSTR pszPath) { return PathSkipRootW(pszPath); } + inline LPCSTR PathSkipRootX(LPCSTR pszPath) { return PathSkipRootA(pszPath); } + inline LPCWSTR PathSkipRootX(LPCWSTR pszPath) { return PathSkipRootW(pszPath); } // non-const inline void PathAddBackslashX(LPSTR pszPath) { PathAddBackslashA(pszPath); }
4 years, 1 month
1
0
0
0
[reactos] 12/19: [EXT2FS] Use GNU89 standard when using CLang
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f424d524882efbd06e85a…
commit f424d524882efbd06e85aad1e36fbd7aa8bb60ce Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 13:28:34 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [EXT2FS] Use GNU89 standard when using CLang --- drivers/filesystems/ext2/CMakeLists.txt | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/filesystems/ext2/CMakeLists.txt b/drivers/filesystems/ext2/CMakeLists.txt index 38851437730..dbd8cc84925 100644 --- a/drivers/filesystems/ext2/CMakeLists.txt +++ b/drivers/filesystems/ext2/CMakeLists.txt @@ -92,23 +92,32 @@ if(USE_CLANG_CL) set_property(SOURCE src/create.c src/fileinfo.c src/memory.c src/read.c APPEND_STRING PROPERTY COMPILE_FLAGS " /fallback") endif() -if(MSVC AND (NOT USE_CLANG_CL)) +if(MSVC) # Disable warnings: "unreferenced local variable", "initialized, but not used variable", "benign include" - remove_target_compile_option(ext2fs "/we4101") - remove_target_compile_option(ext2fs "/we4189") - target_compile_options(ext2fs PRIVATE /wd4189 /wd4142 /wd4101) + if (NOT CLANG) + remove_target_compile_option(ext2fs "/we4101") + remove_target_compile_option(ext2fs "/we4189") + target_compile_options(ext2fs PRIVATE /wd4189 /wd4142 /wd4101) + endif() else() - target_compile_options(ext2fs PRIVATE -Wno-pointer-sign -Wno-unused-function) - target_compile_options(ext2fs PRIVATE -Wno-unused-variable -Wno-missing-braces) - if(USE_CLANG_CL) - target_compile_options(ext2fs PRIVATE -Wno-unused-value -Wno-parentheses-equality) - target_compile_options(ext2fs PRIVATE -Wno-incompatible-pointer-types-discards-qualifiers) - target_compile_options(ext2fs PRIVATE "-Wno-#pragma-messages;-Wno-cast-calling-convention") - else() + target_compile_options(ext2fs PRIVATE + -Wno-pointer-sign -Wno-unused-function + -Wno-unused-variable -Wno-missing-braces) + if (NOT CLANG) target_compile_options(ext2fs PRIVATE -Wno-unused-but-set-variable) endif() endif() +if(CLANG) + target_compile_options(ext2fs PRIVATE + -Wno-unused-value -Wno-parentheses-equality + -Wno-incompatible-pointer-types-discards-qualifiers + "-Wno-#pragma-messages;-Wno-cast-calling-convention") + if (GCC) + target_compile_options(ext2fs PRIVATE -std=gnu89) + endif() +endif() + target_link_libraries(ext2fs memcmp ${PSEH_LIB}) add_definitions(-D__KERNEL__ -D_CRT_NO_POSIX_ERROR_CODES) set_module_type(ext2fs kernelmodedriver)
4 years, 1 month
1
0
0
0
[reactos] 11/19: [CDFS] Use GNU89 standard when using CLang
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cab3e62f0ee6746b067fb…
commit cab3e62f0ee6746b067fbdf8ec174b308e714dcd Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 13:28:08 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [CDFS] Use GNU89 standard when using CLang --- drivers/filesystems/cdfs/CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/filesystems/cdfs/CMakeLists.txt b/drivers/filesystems/cdfs/CMakeLists.txt index 2f1d4526c3e..3e35991bfa0 100644 --- a/drivers/filesystems/cdfs/CMakeLists.txt +++ b/drivers/filesystems/cdfs/CMakeLists.txt @@ -38,3 +38,9 @@ target_link_libraries(cdfs ${PSEH_LIB} memcmp) add_importlibs(cdfs ntoskrnl hal) add_cd_file(TARGET cdfs DESTINATION reactos/system32/drivers NO_CAB FOR all) add_registry_inf(cdfs_reg.inf) + +if (CLANG AND GCC) + # Make __inline work as expected + target_compile_options(cdfs PRIVATE -std=gnu89) +endif() +
4 years, 1 month
1
0
0
0
[reactos] 10/19: [MSVCRT] make some functions static
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2c4c25e468e5bbc04594c…
commit 2c4c25e468e5bbc04594c66483a2f6eb81aff591 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 12:54:46 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [MSVCRT] make some functions static --- dll/win32/msvcrt/stubs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dll/win32/msvcrt/stubs.c b/dll/win32/msvcrt/stubs.c index e120a130cc8..72b32222091 100644 --- a/dll/win32/msvcrt/stubs.c +++ b/dll/win32/msvcrt/stubs.c @@ -96,7 +96,7 @@ typedef struct __crt_locale_data_public unsigned int _locale_lc_codepage; } __crt_locale_data_public; -__inline +static __crt_locale_data_public* __CRTDECL __acrt_get_locale_data_prefix( @@ -106,7 +106,7 @@ __acrt_get_locale_data_prefix( return (__crt_locale_data_public*)_TypedLocalePointers->locinfo; } -__inline +static int __CRTDECL __acrt_locale_get_ctype_array_value( @@ -137,7 +137,7 @@ const unsigned short* __cdecl __pctype_func(void); #define __chvalidchk(a, b) (__acrt_locale_get_ctype_array_value(__PCTYPE_FUNC, (a), (b))) #endif -__inline +static int __CRTDECL _chvalidchk_l( @@ -158,7 +158,7 @@ _chvalidchk_l( #endif } -__inline +static int __CRTDECL _ischartype_l(
4 years, 1 month
1
0
0
0
[reactos] 09/19: [CRT] Use ASM aliases for CLang builds
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=281389b7e73970fb93b07…
commit 281389b7e73970fb93b075adc3335a8090cc77fa Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 12:54:06 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [CRT] Use ASM aliases for CLang builds --- sdk/lib/crt/stdlib/rot.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sdk/lib/crt/stdlib/rot.c b/sdk/lib/crt/stdlib/rot.c index 3c4b613a3a6..51a6a6c0218 100644 --- a/sdk/lib/crt/stdlib/rot.c +++ b/sdk/lib/crt/stdlib/rot.c @@ -19,8 +19,16 @@ #pragma function(_rotr, _rotl, _rotr, _lrotl, _lrotr) #endif -unsigned int _rotr( unsigned int value, int shift ); -unsigned long _lrotr(unsigned long value, int shift); +#if defined (__clang__) && !defined(_MSC_VER) +#define ASM_ALIAS __asm__ +#else +#define ASM_ALIAS(x) +#endif + +unsigned int _rotr( unsigned int value, int shift ) ASM_ALIAS("__rotr"); +unsigned long _lrotr(unsigned long value, int shift) ASM_ALIAS("__lrotr"); +unsigned int _rotl( unsigned int value, int shift ) ASM_ALIAS("__rotl"); +unsigned long _lrotl( unsigned long value, int shift ) ASM_ALIAS("__lrotl"); /* * @implemented
4 years, 1 month
1
0
0
0
[reactos] 08/19: [NFS41_DRIVER] Use GNU89 standard when compiling with CLang.
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=567a5231d5a8b00327146…
commit 567a5231d5a8b00327146e651464ff4ef791013b Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 12:04:25 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [NFS41_DRIVER] Use GNU89 standard when compiling with CLang. --- drivers/filesystems/nfs/CMakeLists.txt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/filesystems/nfs/CMakeLists.txt b/drivers/filesystems/nfs/CMakeLists.txt index 9845ef76814..3d05ff676c6 100644 --- a/drivers/filesystems/nfs/CMakeLists.txt +++ b/drivers/filesystems/nfs/CMakeLists.txt @@ -14,10 +14,14 @@ set_module_type(nfs41_driver kernelmodedriver) target_link_libraries(nfs41_driver ntoskrnl_vista rdbsslib rxce copysup memcmp ${PSEH_LIB}) add_importlibs(nfs41_driver ntoskrnl hal) -if(USE_CLANG_CL OR (NOT MSVC)) +if(GCC OR CLANG) target_compile_options(nfs41_driver PRIVATE "-Wno-switch") - if(USE_CLANG_CL) + if(CLANG) target_compile_options(nfs41_driver PRIVATE "-Wno-unused-value") + if(GCC) + # When CLang mimicks GCC, it uses C17 as default, which breaks __inline + target_compile_options(nfs41_driver PRIVATE "-std=gnu89") + endif() endif() endif()
4 years, 1 month
1
0
0
0
[reactos] 07/19: [STORAHCI] Use FORCEINLINE instead of __inline
by Jérôme Gardou
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1f8db9824e0edf1aa5225…
commit 1f8db9824e0edf1aa522537cbde575c17dbef9c3 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Mon Nov 9 09:45:03 2020 +0100 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Nov 16 16:58:10 2020 +0100 [STORAHCI] Use FORCEINLINE instead of __inline --- drivers/storage/port/storahci/storahci.c | 4 ++-- drivers/storage/port/storahci/storahci.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/storage/port/storahci/storahci.c b/drivers/storage/port/storahci/storahci.c index ed94f1d3e87..bf4c96d04c1 100644 --- a/drivers/storage/port/storahci/storahci.c +++ b/drivers/storage/port/storahci/storahci.c @@ -2559,7 +2559,7 @@ RemoveQueue ( * return SrbExtension * */ -__inline +FORCEINLINE PAHCI_SRB_EXTENSION GetSrbExtension ( __in PSCSI_REQUEST_BLOCK Srb @@ -2615,4 +2615,4 @@ AhciGetLba ( } return lba; -}// -- AhciGetLba(); \ No newline at end of file +}// -- AhciGetLba(); diff --git a/drivers/storage/port/storahci/storahci.h b/drivers/storage/port/storahci/storahci.h index fba3f2d4be5..40c08f2f462 100644 --- a/drivers/storage/port/storahci/storahci.h +++ b/drivers/storage/port/storahci/storahci.h @@ -645,7 +645,7 @@ RemoveQueue ( __inout PAHCI_QUEUE Queue ); -__inline +FORCEINLINE PAHCI_SRB_EXTENSION GetSrbExtension( __in PSCSI_REQUEST_BLOCK Srb
4 years, 1 month
1
0
0
0
← Newer
1
2
3
4
5
6
7
8
...
17
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
Results per page:
10
25
50
100
200