ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
June 2020
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
20 participants
95 discussions
Start a n
N
ew thread
[reactos] 01/01: [APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805)
by Serge Gautherie
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6baa151888964a2fe71d1…
commit 6baa151888964a2fe71d1cc75c051e08853d4112 Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Mon Jun 1 11:20:13 2020 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Jun 1 12:20:13 2020 +0300 [APISETS] Some API sets are NT10+ and win32 only (Part 1/2) (#2805) * api-ms-win-downlevel-shell32-l1-1-0.dll is NT10+ and win32 only * api-ms-win-shcore-obsolete-l1-1-0.dll is NT10+ and win32 only * api-ms-win-downlevel-shlwapi-l2-1-0.dll is NT10+ and win32 only CORE-8880 --- .../api-ms-win-downlevel-shell32-l1-1-0.spec | 6 +- .../api-ms-win-downlevel-shlwapi-l2-1-0.spec | 112 ++++++++++----------- dll/apisets/api-ms-win-shcore-obsolete-l1-1-0.spec | 6 +- 3 files changed, 62 insertions(+), 62 deletions(-) diff --git a/dll/apisets/api-ms-win-downlevel-shell32-l1-1-0.spec b/dll/apisets/api-ms-win-downlevel-shell32-l1-1-0.spec index 460d4d9e2a0..421e8836934 100644 --- a/dll/apisets/api-ms-win-downlevel-shell32-l1-1-0.spec +++ b/dll/apisets/api-ms-win-downlevel-shell32-l1-1-0.spec @@ -1,6 +1,6 @@ # This file is autogenerated by update.py -@ stdcall CommandLineToArgvW() shell32.CommandLineToArgvW -@ stub GetCurrentProcessExplicitAppUserModelID -@ stub SetCurrentProcessExplicitAppUserModelID +@ stdcall -version=0xA00+ -arch=win32 CommandLineToArgvW() shell32.CommandLineToArgvW +@ stub -version=0xA00+ -arch=win32 GetCurrentProcessExplicitAppUserModelID +@ stub -version=0xA00+ -arch=win32 SetCurrentProcessExplicitAppUserModelID diff --git a/dll/apisets/api-ms-win-downlevel-shlwapi-l2-1-0.spec b/dll/apisets/api-ms-win-downlevel-shlwapi-l2-1-0.spec index 13f92a5e602..fc59f4bfb28 100644 --- a/dll/apisets/api-ms-win-downlevel-shlwapi-l2-1-0.spec +++ b/dll/apisets/api-ms-win-downlevel-shlwapi-l2-1-0.spec @@ -1,59 +1,59 @@ # This file is autogenerated by update.py -@ stub IStream_Copy -@ stdcall IStream_Read() shlwapi.IStream_Read -@ stub IStream_ReadStr -@ stdcall IStream_Reset() shlwapi.IStream_Reset -@ stdcall IStream_Size() shlwapi.IStream_Size -@ stdcall IStream_Write() shlwapi.IStream_Write -@ stub IStream_WriteStr -@ stdcall IUnknown_AtomicRelease() shlwapi.IUnknown_AtomicRelease -@ stdcall IUnknown_GetSite() shlwapi.IUnknown_GetSite -@ stdcall IUnknown_QueryService() shlwapi.IUnknown_QueryService -@ stdcall IUnknown_Set() shlwapi.IUnknown_Set -@ stdcall IUnknown_SetSite() shlwapi.IUnknown_SetSite -@ stdcall SHAnsiToAnsi() shlwapi.SHAnsiToAnsi -@ stdcall SHAnsiToUnicode() shlwapi.SHAnsiToUnicode -@ stdcall SHCopyKeyA() shlwapi.SHCopyKeyA -@ stdcall SHCopyKeyW() shlwapi.SHCopyKeyW -@ stdcall SHCreateMemStream() shlwapi.SHCreateMemStream -@ stdcall SHCreateStreamOnFileA() shlwapi.SHCreateStreamOnFileA -@ stdcall SHCreateStreamOnFileEx() shlwapi.SHCreateStreamOnFileEx -@ stdcall SHCreateStreamOnFileW() shlwapi.SHCreateStreamOnFileW -@ stdcall SHCreateThreadRef() shlwapi.SHCreateThreadRef -@ stdcall SHDeleteEmptyKeyA() shlwapi.SHDeleteEmptyKeyA -@ stdcall SHDeleteEmptyKeyW() shlwapi.SHDeleteEmptyKeyW -@ stdcall SHDeleteKeyA() shlwapi.SHDeleteKeyA -@ stdcall SHDeleteKeyW() shlwapi.SHDeleteKeyW -@ stdcall SHDeleteValueA() shlwapi.SHDeleteValueA -@ stdcall SHDeleteValueW() shlwapi.SHDeleteValueW -@ stdcall SHEnumKeyExA() shlwapi.SHEnumKeyExA -@ stdcall SHEnumKeyExW() shlwapi.SHEnumKeyExW -@ stdcall SHEnumValueA() shlwapi.SHEnumValueA -@ stdcall SHEnumValueW() shlwapi.SHEnumValueW -@ stdcall SHGetThreadRef() shlwapi.SHGetThreadRef -@ stdcall SHGetValueA() shlwapi.SHGetValueA -@ stdcall SHGetValueW() shlwapi.SHGetValueW -@ stdcall SHOpenRegStream2A() shlwapi.SHOpenRegStream2A -@ stdcall SHOpenRegStream2W() shlwapi.SHOpenRegStream2W -@ stdcall SHOpenRegStreamA() shlwapi.SHOpenRegStreamA -@ stdcall SHOpenRegStreamW() shlwapi.SHOpenRegStreamW -@ stdcall SHQueryInfoKeyA() shlwapi.SHQueryInfoKeyA -@ stdcall SHQueryInfoKeyW() shlwapi.SHQueryInfoKeyW -@ stdcall SHQueryValueExA() shlwapi.SHQueryValueExA -@ stdcall SHQueryValueExW() shlwapi.SHQueryValueExW -@ stdcall SHRegDuplicateHKey() shlwapi.SHRegDuplicateHKey -@ stdcall SHRegGetPathA() shlwapi.SHRegGetPathA -@ stdcall SHRegGetPathW() shlwapi.SHRegGetPathW -@ stdcall SHRegGetValueA() shlwapi.SHRegGetValueA -@ stdcall SHRegGetValueW() shlwapi.SHRegGetValueW -@ stdcall SHRegSetPathA() shlwapi.SHRegSetPathA -@ stdcall SHRegSetPathW() shlwapi.SHRegSetPathW -@ stdcall SHReleaseThreadRef() shlwapi.SHReleaseThreadRef -@ stdcall SHSetThreadRef() shlwapi.SHSetThreadRef -@ stdcall SHSetValueA() shlwapi.SHSetValueA -@ stdcall SHSetValueW() shlwapi.SHSetValueW -@ stdcall SHStrDupW() shlwapi.SHStrDupW -@ stdcall SHUnicodeToAnsi() shlwapi.SHUnicodeToAnsi -@ stdcall SHUnicodeToUnicode() shlwapi.SHUnicodeToUnicode +@ stub -version=0xA00+ -arch=win32 IStream_Copy +@ stdcall -version=0xA00+ -arch=win32 IStream_Read() shlwapi.IStream_Read +@ stub -version=0xA00+ -arch=win32 IStream_ReadStr +@ stdcall -version=0xA00+ -arch=win32 IStream_Reset() shlwapi.IStream_Reset +@ stdcall -version=0xA00+ -arch=win32 IStream_Size() shlwapi.IStream_Size +@ stdcall -version=0xA00+ -arch=win32 IStream_Write() shlwapi.IStream_Write +@ stub -version=0xA00+ -arch=win32 IStream_WriteStr +@ stdcall -version=0xA00+ -arch=win32 IUnknown_AtomicRelease() shlwapi.IUnknown_AtomicRelease +@ stdcall -version=0xA00+ -arch=win32 IUnknown_GetSite() shlwapi.IUnknown_GetSite +@ stdcall -version=0xA00+ -arch=win32 IUnknown_QueryService() shlwapi.IUnknown_QueryService +@ stdcall -version=0xA00+ -arch=win32 IUnknown_Set() shlwapi.IUnknown_Set +@ stdcall -version=0xA00+ -arch=win32 IUnknown_SetSite() shlwapi.IUnknown_SetSite +@ stdcall -version=0xA00+ -arch=win32 SHAnsiToAnsi() shlwapi.SHAnsiToAnsi +@ stdcall -version=0xA00+ -arch=win32 SHAnsiToUnicode() shlwapi.SHAnsiToUnicode +@ stdcall -version=0xA00+ -arch=win32 SHCopyKeyA() shlwapi.SHCopyKeyA +@ stdcall -version=0xA00+ -arch=win32 SHCopyKeyW() shlwapi.SHCopyKeyW +@ stdcall -version=0xA00+ -arch=win32 SHCreateMemStream() shlwapi.SHCreateMemStream +@ stdcall -version=0xA00+ -arch=win32 SHCreateStreamOnFileA() shlwapi.SHCreateStreamOnFileA +@ stdcall -version=0xA00+ -arch=win32 SHCreateStreamOnFileEx() shlwapi.SHCreateStreamOnFileEx +@ stdcall -version=0xA00+ -arch=win32 SHCreateStreamOnFileW() shlwapi.SHCreateStreamOnFileW +@ stdcall -version=0xA00+ -arch=win32 SHCreateThreadRef() shlwapi.SHCreateThreadRef +@ stdcall -version=0xA00+ -arch=win32 SHDeleteEmptyKeyA() shlwapi.SHDeleteEmptyKeyA +@ stdcall -version=0xA00+ -arch=win32 SHDeleteEmptyKeyW() shlwapi.SHDeleteEmptyKeyW +@ stdcall -version=0xA00+ -arch=win32 SHDeleteKeyA() shlwapi.SHDeleteKeyA +@ stdcall -version=0xA00+ -arch=win32 SHDeleteKeyW() shlwapi.SHDeleteKeyW +@ stdcall -version=0xA00+ -arch=win32 SHDeleteValueA() shlwapi.SHDeleteValueA +@ stdcall -version=0xA00+ -arch=win32 SHDeleteValueW() shlwapi.SHDeleteValueW +@ stdcall -version=0xA00+ -arch=win32 SHEnumKeyExA() shlwapi.SHEnumKeyExA +@ stdcall -version=0xA00+ -arch=win32 SHEnumKeyExW() shlwapi.SHEnumKeyExW +@ stdcall -version=0xA00+ -arch=win32 SHEnumValueA() shlwapi.SHEnumValueA +@ stdcall -version=0xA00+ -arch=win32 SHEnumValueW() shlwapi.SHEnumValueW +@ stdcall -version=0xA00+ -arch=win32 SHGetThreadRef() shlwapi.SHGetThreadRef +@ stdcall -version=0xA00+ -arch=win32 SHGetValueA() shlwapi.SHGetValueA +@ stdcall -version=0xA00+ -arch=win32 SHGetValueW() shlwapi.SHGetValueW +@ stdcall -version=0xA00+ -arch=win32 SHOpenRegStream2A() shlwapi.SHOpenRegStream2A +@ stdcall -version=0xA00+ -arch=win32 SHOpenRegStream2W() shlwapi.SHOpenRegStream2W +@ stdcall -version=0xA00+ -arch=win32 SHOpenRegStreamA() shlwapi.SHOpenRegStreamA +@ stdcall -version=0xA00+ -arch=win32 SHOpenRegStreamW() shlwapi.SHOpenRegStreamW +@ stdcall -version=0xA00+ -arch=win32 SHQueryInfoKeyA() shlwapi.SHQueryInfoKeyA +@ stdcall -version=0xA00+ -arch=win32 SHQueryInfoKeyW() shlwapi.SHQueryInfoKeyW +@ stdcall -version=0xA00+ -arch=win32 SHQueryValueExA() shlwapi.SHQueryValueExA +@ stdcall -version=0xA00+ -arch=win32 SHQueryValueExW() shlwapi.SHQueryValueExW +@ stdcall -version=0xA00+ -arch=win32 SHRegDuplicateHKey() shlwapi.SHRegDuplicateHKey +@ stdcall -version=0xA00+ -arch=win32 SHRegGetPathA() shlwapi.SHRegGetPathA +@ stdcall -version=0xA00+ -arch=win32 SHRegGetPathW() shlwapi.SHRegGetPathW +@ stdcall -version=0xA00+ -arch=win32 SHRegGetValueA() shlwapi.SHRegGetValueA +@ stdcall -version=0xA00+ -arch=win32 SHRegGetValueW() shlwapi.SHRegGetValueW +@ stdcall -version=0xA00+ -arch=win32 SHRegSetPathA() shlwapi.SHRegSetPathA +@ stdcall -version=0xA00+ -arch=win32 SHRegSetPathW() shlwapi.SHRegSetPathW +@ stdcall -version=0xA00+ -arch=win32 SHReleaseThreadRef() shlwapi.SHReleaseThreadRef +@ stdcall -version=0xA00+ -arch=win32 SHSetThreadRef() shlwapi.SHSetThreadRef +@ stdcall -version=0xA00+ -arch=win32 SHSetValueA() shlwapi.SHSetValueA +@ stdcall -version=0xA00+ -arch=win32 SHSetValueW() shlwapi.SHSetValueW +@ stdcall -version=0xA00+ -arch=win32 SHStrDupW() shlwapi.SHStrDupW +@ stdcall -version=0xA00+ -arch=win32 SHUnicodeToAnsi() shlwapi.SHUnicodeToAnsi +@ stdcall -version=0xA00+ -arch=win32 SHUnicodeToUnicode() shlwapi.SHUnicodeToUnicode diff --git a/dll/apisets/api-ms-win-shcore-obsolete-l1-1-0.spec b/dll/apisets/api-ms-win-shcore-obsolete-l1-1-0.spec index 297d18ba29c..b7e00b0c1ec 100644 --- a/dll/apisets/api-ms-win-shcore-obsolete-l1-1-0.spec +++ b/dll/apisets/api-ms-win-shcore-obsolete-l1-1-0.spec @@ -1,6 +1,6 @@ # This file is autogenerated by update.py -@ stdcall CommandLineToArgvW() shell32.CommandLineToArgvW -@ stdcall SHStrDupA() shlwapi.SHStrDupA -@ stdcall SHStrDupW() shlwapi.SHStrDupW +@ stdcall -version=0xA00+ -arch=win32 CommandLineToArgvW() shell32.CommandLineToArgvW +@ stdcall -version=0xA00+ -arch=win32 SHStrDupA() shlwapi.SHStrDupA +@ stdcall -version=0xA00+ -arch=win32 SHStrDupW() shlwapi.SHStrDupW
4 years, 6 months
1
0
0
0
[reactos] 01/01: [SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827)
by Serge Gautherie
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=701e6c6a2f8cc1aca6fdf…
commit 701e6c6a2f8cc1aca6fdf5894db0c56474a54470 Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Mon Jun 1 11:17:29 2020 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Jun 1 12:17:29 2020 +0300 [SNDREC32] Use ShellAboutW(..., ..., NULL, ...) (#2827) Addendum to 82e4efea77aa19d79a4a14c41ae2222c2994b829. --- base/applications/sndrec32/sndrec32.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/applications/sndrec32/sndrec32.cpp b/base/applications/sndrec32/sndrec32.cpp index 53c1b49ec8d..0d408fc3f34 100644 --- a/base/applications/sndrec32/sndrec32.cpp +++ b/base/applications/sndrec32/sndrec32.cpp @@ -599,7 +599,7 @@ WndProc(HWND hWnd, case ID_ABOUT: LoadStringW(hInst, IDS_APP_TITLE, szAppName, _countof(szAppName)); hIcon = LoadIconW(hInst, MAKEINTRESOURCEW(IDI_REACTOS_SNDREC32)); - ShellAboutW(hWnd, szAppName, L"\0", hIcon); + ShellAboutW(hWnd, szAppName, NULL, hIcon); DestroyIcon(hIcon); break;
4 years, 6 months
1
0
0
0
[reactos] 01/01: [USER32] MDIClientWndProc_common(): Properly sync to old Wine (#2843)
by Serge Gautherie
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=95e5877027c56498b99ad…
commit 95e5877027c56498b99ad629883066ab896a31b6 Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Mon Jun 1 11:14:38 2020 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Jun 1 12:14:38 2020 +0300 [USER32] MDIClientWndProc_common(): Properly sync to old Wine (#2843) No impact. Missed part of
https://source.winehq.org/git/wine.git/commit/fb6304119a967ea13688ff9e34ed9…
Detected by Cppcheck: identicalInnerCondition. Addendum to 303ece24219da7ec0cac1016767092287abd7877 (r72520). --- win32ss/user/user32/windows/mdi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/win32ss/user/user32/windows/mdi.c b/win32ss/user/user32/windows/mdi.c index 5d9d8bd6ff3..c93e541b463 100644 --- a/win32ss/user/user32/windows/mdi.c +++ b/win32ss/user/user32/windows/mdi.c @@ -1106,18 +1106,18 @@ LRESULT WINAPI MDIClientWndProc_common( HWND hwnd, UINT message, WPARAM wParam, if (!(ci = get_client_info( hwnd ))) { +#ifdef __REACTOS__ if (message == WM_NCCREATE) { -#ifdef __REACTOS__ if (!(ci = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ci)))) return FALSE; SetWindowLongPtrW( hwnd, GWLP_MDIWND, (LONG_PTR)ci ); ci->hBmpClose = 0; NtUserSetWindowFNID( hwnd, FNID_MDICLIENT); // wine uses WIN_ISMDICLIENT + } #else - if (message == WM_NCCREATE) win_set_flags( hwnd, WIN_ISMDICLIENT, 0 ); + if (message == WM_NCCREATE) win_set_flags( hwnd, WIN_ISMDICLIENT, 0 ); #endif - } return unicode ? DefWindowProcW( hwnd, message, wParam, lParam ) : DefWindowProcA( hwnd, message, wParam, lParam ); }
4 years, 6 months
1
0
0
0
[reactos] 01/01: [NTOS:MM] MmDeleteProcessAddressSpace(): Move 'Address' to where it belongs (#2865)
by Serge Gautherie
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ceccaae3112044aaf2a31…
commit ceccaae3112044aaf2a31925b3333faa1eb2cff9 Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Mon Jun 1 11:10:11 2020 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Jun 1 12:10:11 2020 +0300 [NTOS:MM] MmDeleteProcessAddressSpace(): Move 'Address' to where it belongs (#2865) No impact. Detected by Cppcheck: unusedVariable. Addendum to 2dade10d543589e1f5f762bbc1695f2917341171. --- ntoskrnl/mm/marea.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/mm/marea.c b/ntoskrnl/mm/marea.c index 37584477090..d953f422f96 100644 --- a/ntoskrnl/mm/marea.c +++ b/ntoskrnl/mm/marea.c @@ -572,7 +572,6 @@ MmDeleteProcessAddressSpace(PEPROCESS Process) { #ifndef _M_AMD64 KIRQL OldIrql; - PVOID Address; #endif DPRINT("MmDeleteProcessAddressSpace(Process %p (%s))\n", Process, @@ -591,7 +590,9 @@ MmDeleteProcessAddressSpace(PEPROCESS Process) #if (_MI_PAGING_LEVELS == 2) { KIRQL OldIrql; + PVOID Address; PMMPDE pointerPde; + /* Attach to Process */ KeAttachProcess(&Process->Pcb);
4 years, 6 months
1
0
0
0
[reactos] 01/01: [REACTOS] RegQueryValueExW() wants bytes, not chars (#2876)
by Serge Gautherie
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=703c56beb320196c0d08a…
commit 703c56beb320196c0d08ae8f2b8291cc441f62bc Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Mon Jun 1 11:06:49 2020 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Mon Jun 1 12:06:49 2020 +0300 [REACTOS] RegQueryValueExW() wants bytes, not chars (#2876) Cherry-pick:
https://source.winehq.org/git/wine.git/commit/a359e026662251b7c3367fe2815dc…
https://source.winehq.org/git/wine.git/commit/0662da18b85634928905e72041961…
https://source.winehq.org/git/wine.git/commit/e4e5eda3d9afcb5360747ddd97e6b…
CORE-9665 Co-authored-by: Victor Martinez <vicmarcal(a)gmail.com> --- dll/win32/advpack/advpack.c | 2 +- dll/win32/mscoree/metahost.c | 2 +- dll/win32/mscoree/mscoree_main.c | 2 +- dll/win32/shlwapi/ordinal.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dll/win32/advpack/advpack.c b/dll/win32/advpack/advpack.c index f2de8a6b257..e3d4d50837b 100644 --- a/dll/win32/advpack/advpack.c +++ b/dll/win32/advpack/advpack.c @@ -907,7 +907,7 @@ HRESULT WINAPI UserInstStubWrapperW(HWND hWnd, HINSTANCE hInstance, { HKEY setup, guid; WCHAR stub[MAX_PATH]; - DWORD size = MAX_PATH; + DWORD size = sizeof(stub); HRESULT hr = S_OK; BOOL res; diff --git a/dll/win32/mscoree/metahost.c b/dll/win32/mscoree/metahost.c index 7b01f1024c6..599fcc829bb 100644 --- a/dll/win32/mscoree/metahost.c +++ b/dll/win32/mscoree/metahost.c @@ -377,7 +377,7 @@ static BOOL get_install_root(LPWSTR install_dir) if (RegOpenKeyExW(HKEY_LOCAL_MACHINE, dotnet_key, 0, KEY_READ, &key)) return FALSE; - len = MAX_PATH; + len = MAX_PATH * sizeof(WCHAR); if (RegQueryValueExW(key, install_root, 0, NULL, (LPBYTE)install_dir, &len)) { RegCloseKey(key); diff --git a/dll/win32/mscoree/mscoree_main.c b/dll/win32/mscoree/mscoree_main.c index 0b982d08fd2..2af851806cf 100644 --- a/dll/win32/mscoree/mscoree_main.c +++ b/dll/win32/mscoree/mscoree_main.c @@ -53,7 +53,7 @@ static BOOL get_install_root(LPWSTR install_dir) if (RegOpenKeyExW(HKEY_LOCAL_MACHINE, dotnet_key, 0, KEY_READ, &key)) return FALSE; - len = MAX_PATH; + len = MAX_PATH * sizeof(WCHAR); if (RegQueryValueExW(key, install_root, 0, NULL, (LPBYTE)install_dir, &len)) { RegCloseKey(key); diff --git a/dll/win32/shlwapi/ordinal.c b/dll/win32/shlwapi/ordinal.c index 84234865b28..431ec51d2e1 100644 --- a/dll/win32/shlwapi/ordinal.c +++ b/dll/win32/shlwapi/ordinal.c @@ -4126,7 +4126,7 @@ BOOL WINAPI IsOS(DWORD feature) */ HRESULT WINAPI SHLoadRegUIStringW(HKEY hkey, LPCWSTR value, LPWSTR buf, DWORD size) { - DWORD type, sz = size; + DWORD type, sz = size * sizeof(WCHAR); if(RegQueryValueExW(hkey, value, NULL, &type, (LPBYTE)buf, &sz) != ERROR_SUCCESS) return E_FAIL;
4 years, 6 months
1
0
0
0
← Newer
1
2
3
4
5
6
7
8
9
10
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
Results per page:
10
25
50
100
200