Ros-diffs June 2020

ros-diffs@reactos.org

20 participants
95 discussions

[reactos] 01/01: [KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate.

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1481df94abad5cc75a7f5… commit 1481df94abad5cc75a7f5bdcd57273700b7c7dd2 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sat Jun 27 09:27:33 2020 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sat Jun 27 10:13:51 2020 +0200 [KMTESTS:EX] Use stricter checks for the UUID returned from ExUuidCreate. * Check the entire version field * Check the variant field * Accept RPC_NT_UUID_LOCAL_ONLY, which is sometimes returned by Windows * Repeat the test to show that these things happen every time Based on a patch by Serge Gautherie. --- modules/rostests/kmtests/ntos_ex/ExUuid.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/modules/rostests/kmtests/ntos_ex/ExUuid.c b/modules/rostests/kmtests/ntos_ex/ExUuid.c index 2fb0bba8dc8..82bb27b6089 100644 --- a/modules/rostests/kmtests/ntos_ex/ExUuid.c +++ b/modules/rostests/kmtests/ntos_ex/ExUuid.c @@ -14,8 +14,14 @@ START_TEST(ExUuid) { UUID Uuid; NTSTATUS Status; + ULONG i; - Status = ExUuidCreate(&Uuid); - ok(Status == STATUS_SUCCESS, "ExUuidCreate returned unexpected status: %lx\n", Status); - ok((Uuid.Data3 & 0x1000) == 0x1000, "Invalid UUID version: %x\n", (Uuid.Data3 & 0xF000)); + for (i = 0; i < 1000; i++) + { + Status = ExUuidCreate(&Uuid); + ok(Status == STATUS_SUCCESS || Status == RPC_NT_UUID_LOCAL_ONLY, + "ExUuidCreate returned unexpected status: 0x%lx\n", Status); + ok((Uuid.Data3 & 0xF000) == 0x1000, "Invalid UUID version: 0x%x\n", (Uuid.Data3 & 0xF000)); + ok((Uuid.Data4[0] & 0xC0) == 0x80, "Invalid UUID variant: 0x%x\n", (Uuid.Data4[0] & 0xF0)); + } }

4 years, 2 months

[reactos] 01/01: [FASTFAT_NEW] Sync to upstream 16022c5 (#2938)

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8983adf967a696d054ccc… commit 8983adf967a696d054ccca4e118df27e1b5ffa13 Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Fri Jun 26 19:03:01 2020 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Fri Jun 26 20:03:01 2020 +0300 [FASTFAT_NEW] Sync to upstream 16022c5 (#2938) --- drivers/filesystems/fastfat_new/README.md | 53 +++++++++++++++--------------- drivers/filesystems/fastfat_new/close.c | 10 +++--- drivers/filesystems/fastfat_new/devctrl.c | 2 +- drivers/filesystems/fastfat_new/deviosup.c | 2 +- drivers/filesystems/fastfat_new/fatinit.c | 4 +-- drivers/filesystems/fastfat_new/fsctrl.c | 44 +++++++++++++++++++------ drivers/filesystems/fastfat_new/volinfo.c | 41 ++++++++++++++--------- media/doc/README.FSD | 2 +- 8 files changed, 96 insertions(+), 62 deletions(-) diff --git a/drivers/filesystems/fastfat_new/README.md b/drivers/filesystems/fastfat_new/README.md index 801e3f73657..1c409ac7b6d 100644 --- a/drivers/filesystems/fastfat_new/README.md +++ b/drivers/filesystems/fastfat_new/README.md @@ -1,26 +1,24 @@ - - - - -fastfat File System Driver -========================== +--- +page_type: sample +description: "A file system driver based on the Windows inbox FastFAT file system used as a model for new file systems." +languages: +- cpp +products: +- windows +- windows-wdk +--- + +# fastfat File System Driver The *fastfat* sample is file system driver that you can use as a model to write new file systems. *fastfat* is a complete file system that addresses various issues such as storing data on disk, interacting with the cache manager, and handling various I/O operations such as file creation, performing read/writes on a file, setting information on a file, and performing control operations on the file system. ## Universal Windows Driver Compliant + This sample builds a Universal Windows Driver. It uses only APIs and DDIs that are included in OneCoreUAP. -Build the sample ----------------- +## Build the sample You can build the sample in two ways: using Microsoft Visual Studio or the command line (*MSBuild*). @@ -30,25 +28,28 @@ You build a driver the same way you build any project or solution in Visual Stud The default Solution build configuration is **Debug** and **Win32**. -**To select a configuration and build a driver** +#### To select a configuration and build a driver -1. Open the driver project or solution in Visual Studio (find fastfat.sln or fastfat.vcxproj). -2. Right-click the solution in the **Solutions Explorer** and select **Configuration Manager**. -3. From the **Configuration Manager**, select the **Active Solution Configuration** (for example, Debug or Release) and the **Active Solution Platform** (for example, Win32) that correspond to the type of build you are interested in. -4. From the Build menu, click **Build Solution** (Ctrl+Shift+B). +1. Open the driver project or solution in Visual Studio (find fastfat.sln or fastfat.vcxproj). + +1. Right-click the solution in the **Solutions Explorer** and select **Configuration Manager**. + +1. From the **Configuration Manager**, select the **Active Solution Configuration** (for example, Debug or Release) and the **Active Solution Platform** (for example, Win32) that correspond to the type of build you are interested in. + +1. From the Build menu, click **Build Solution** (Ctrl+Shift+B). ### Building a Driver Using the Command Line (MSBuild) You can build a driver from the command line using the Visual Studio Command Prompt window and the Microsoft Build Engine (MSBuild.exe) Previous versions of the WDK used the Windows Build utility (Build.exe) and provided separate build environment windows for each of the supported build configurations. You can now use the Visual Studio Command Prompt window for all build configurations. -**To select a configuration and build a driver or an application** +#### To select a configuration and build a driver or an application + +1. Open a Visual Studio Command Prompt window at the **Start** screen. From this window you can use MsBuild.exe to build any Visual Studio project by specifying the project (.VcxProj) or solutions (.Sln) file. -1. Open a Visual Studio Command Prompt window at the **Start** screen. From this window you can use MsBuild.exe to build any Visual Studio project by specifying the project (.VcxProj) or solutions (.Sln) file. -2. Navigate to the project directory and enter the **MSbuild** command for your target. For example, to perform a clean build of a Visual Studio driver project called *filtername*.vcxproj, navigate to the project directory and enter the following MSBuild command: +1. Navigate to the project directory and enter the **MSbuild** command for your target. For example, to perform a clean build of a Visual Studio driver project called *filtername*.vcxproj, navigate to the project directory and enter the following MSBuild command: - **msbuild /t:clean /t:build .\\fastfat.vcxproj**. +`msbuild /t:clean /t:build .\\fastfat.vcxproj` -Installation ------------- +## Installation No INF file is provided with this sample because the *fastfat* file system driver (fastfat.sys) is already part of the Windows operating system. You can build a private version of this file system and use it as a replacement for the native driver. diff --git a/drivers/filesystems/fastfat_new/close.c b/drivers/filesystems/fastfat_new/close.c index 7e9ac2d4ad3..e92aad02285 100644 --- a/drivers/filesystems/fastfat_new/close.c +++ b/drivers/filesystems/fastfat_new/close.c @@ -299,7 +299,7 @@ Return Value: // // We had some trouble trying to perform the requested // operation, so we'll abort the I/O request with the - // error status that we get back from the execption code. + // error status that we get back from the exception code. // Status = FatProcessException( NULL, Irp, _SEH2_GetExceptionCode() ); @@ -669,7 +669,7 @@ Return Value: // // If the queues are above the limits by a significant amount, we have - // to try hard to pull them down. To do this, we will aggresively try + // to try hard to pull them down. To do this, we will aggressively try // to find closes for the last volume the caller looked at. This will // make sure we fully utilize the acquisition of the volume, which can // be a hugely expensive resource to get (create/close/cleanup use it @@ -884,7 +884,7 @@ Return Value: DebugTrace(+1, Dbg, "FatCommonClose...\n", 0); // - // Initailize the callers variable, if needed. + // Initialize the callers variable, if needed. // LocalVcbDeleted = FALSE; @@ -1082,7 +1082,7 @@ Return Value: // // Dereference the directory file. This may cause a close - // Irp to be processed, so we need to do this before we destory + // Irp to be processed, so we need to do this before we destroy // the Fcb. // @@ -1210,7 +1210,7 @@ Return Value: // // We need the global lock, which must be acquired before the // VCB. Since we already have the VCB, we have to drop and - // reaquire here. Note that we always want to wait from this + // reacquire here. Note that we always want to wait from this // point on. Note that the VCB cannot go away, since we have // biased the open file count. // diff --git a/drivers/filesystems/fastfat_new/devctrl.c b/drivers/filesystems/fastfat_new/devctrl.c index 7cfa954440e..0abbcec6764 100644 --- a/drivers/filesystems/fastfat_new/devctrl.c +++ b/drivers/filesystems/fastfat_new/devctrl.c @@ -99,7 +99,7 @@ Return Value: // We had some trouble trying to perform the requested // operation, so we'll abort the I/O request with // the error status that we get back from the - // execption code + // exception code // Status = FatProcessException( IrpContext, Irp, _SEH2_GetExceptionCode() ); diff --git a/drivers/filesystems/fastfat_new/deviosup.c b/drivers/filesystems/fastfat_new/deviosup.c index 17462d8704b..a1712a396a6 100644 --- a/drivers/filesystems/fastfat_new/deviosup.c +++ b/drivers/filesystems/fastfat_new/deviosup.c @@ -3814,7 +3814,7 @@ Return Value: // // It would be nice if Mm exported a way for us to not have // to pull the Mdl apart and rebuild it ourselves, but this - // is so bizzare a purpose as to be tolerable. + // is so bizarre a purpose as to be tolerable. // SavedByteCount = ZeroMdl->ByteCount; diff --git a/drivers/filesystems/fastfat_new/fatinit.c b/drivers/filesystems/fastfat_new/fatinit.c index b09339640d5..09df201769f 100644 --- a/drivers/filesystems/fastfat_new/fatinit.c +++ b/drivers/filesystems/fastfat_new/fatinit.c @@ -632,14 +632,14 @@ FatIsFujitsuFMR ( Routine Description: - This routine tells if is we running on a FujitsuFMR machine. + This routine tells us if we are running on a FujitsuFMR machine. Arguments: Return Value: - BOOLEAN - TRUE is we are and FALSE otherwise + BOOLEAN - TRUE if we are and FALSE otherwise --*/ diff --git a/drivers/filesystems/fastfat_new/fsctrl.c b/drivers/filesystems/fastfat_new/fsctrl.c index 0938dcc63e9..d5ec06b3155 100644 --- a/drivers/filesystems/fastfat_new/fsctrl.c +++ b/drivers/filesystems/fastfat_new/fsctrl.c @@ -1422,22 +1422,34 @@ Return Value: if (Dirent != NULL) { + UCHAR OemBuffer[11]; OEM_STRING OemString; UNICODE_STRING UnicodeString; + OemString.Buffer = (PCHAR)&OemBuffer[0]; + OemString.MaximumLength = 11; + + RtlCopyMemory( OemString.Buffer, Dirent->FileName, 11 ); + // - // Compute the length of the volume name + // Translate the first character from 0x5 to 0xe5. // - OemString.Buffer = (PCHAR)&Dirent->FileName[0]; - OemString.MaximumLength = 11; + if (OemString.Buffer[0] == FAT_DIRENT_REALLY_0E5) { + + OemString.Buffer[0] = 0xe5; + } + + // + // Compute the length of the volume name + // for ( OemString.Length = 11; OemString.Length > 0; OemString.Length -= 1) { - if ( (Dirent->FileName[OemString.Length-1] != 0x00) && - (Dirent->FileName[OemString.Length-1] != 0x20) ) { break; } + if ( (OemString.Buffer[OemString.Length-1] != 0x00) && + (OemString.Buffer[OemString.Length-1] != 0x20) ) { break; } } UnicodeString.MaximumLength = MAXIMUM_VOLUME_LABEL_LENGTH; @@ -7849,6 +7861,7 @@ Return Value: PDIRENT Dirent; PDIRENT TerminationDirent; ULONG VolumeLabelLength; + UCHAR OemBuffer[11]; OEM_STRING OemString; UNICODE_STRING UnicodeString; @@ -7895,19 +7908,30 @@ Return Value: } + OemString.Buffer = (PCHAR)&OemBuffer[0]; + OemString.MaximumLength = 11; + + RtlCopyMemory( OemString.Buffer, Dirent->FileName, 11 ); + // - // Compute the length of the volume name + // Translate the first character from 0x5 to 0xe5. // - OemString.Buffer = (PCHAR)&Dirent->FileName[0]; - OemString.MaximumLength = 11; + if (OemString.Buffer[0] == FAT_DIRENT_REALLY_0E5) { + + OemString.Buffer[0] = 0xe5; + } + + // + // Compute the length of the volume name + // for ( OemString.Length = 11; OemString.Length > 0; OemString.Length -= 1) { - if ( (Dirent->FileName[OemString.Length-1] != 0x00) && - (Dirent->FileName[OemString.Length-1] != 0x20) ) { break; } + if ( (OemString.Buffer[OemString.Length-1] != 0x00) && + (OemString.Buffer[OemString.Length-1] != 0x20) ) { break; } } UnicodeString.MaximumLength = sizeof( UnicodeBuffer ); diff --git a/drivers/filesystems/fastfat_new/volinfo.c b/drivers/filesystems/fastfat_new/volinfo.c index be38ac9aa94..c9f76aa7625 100644 --- a/drivers/filesystems/fastfat_new/volinfo.c +++ b/drivers/filesystems/fastfat_new/volinfo.c @@ -155,7 +155,7 @@ Return Value: // We had some trouble trying to perform the requested // operation, so we'll abort the I/O request with // the error status that we get back from the - // execption code + // exception code // Status = FatProcessException( IrpContext, Irp, _SEH2_GetExceptionCode() ); @@ -236,7 +236,7 @@ Return Value: // We had some trouble trying to perform the requested // operation, so we'll abort the I/O request with // the error status that we get back from the - // execption code + // exception code // Status = FatProcessException( IrpContext, Irp, _SEH2_GetExceptionCode() ); @@ -331,7 +331,7 @@ Return Value: // // Make sure the vcb is in a usable condition. This will raise - // and error condition if the volume is unusable + // an error condition if the volume is unusable // // Also verify the Root Dcb since we need info from there. // @@ -526,7 +526,7 @@ Return Value: // // Make sure the vcb is in a usable condition. This will raise - // and error condition if the volume is unusable + // an error condition if the volume is unusable // // Also verify the Root Dcb since we need info from there. // @@ -598,8 +598,8 @@ Arguments: Buffer - Supplies a pointer to the output buffer where the information is to be returned - Length - Supplies the length of the buffer in byte. This variable - upon return recieves the remaining bytes free in the buffer + Length - Supplies the length of the buffer in bytes. This variable + upon return receives the remaining bytes free in the buffer Return Value: @@ -692,8 +692,8 @@ Arguments: Buffer - Supplies a pointer to the output buffer where the information is to be returned - Length - Supplies the length of the buffer in byte. This variable - upon return recieves the remaining bytes free in the buffer + Length - Supplies the length of the buffer in bytes. This variable + upon return receives the remaining bytes free in the buffer Return Value: @@ -761,8 +761,8 @@ Arguments: Buffer - Supplies a pointer to the output buffer where the information is to be returned - Length - Supplies the length of the buffer in byte. This variable - upon return recieves the remaining bytes free in the buffer + Length - Supplies the length of the buffer in bytes. This variable + upon return receives the remaining bytes free in the buffer Return Value: @@ -826,8 +826,8 @@ Arguments: Buffer - Supplies a pointer to the output buffer where the information is to be returned - Length - Supplies the length of the buffer in byte. This variable - upon return recieves the remaining bytes free in the buffer + Length - Supplies the length of the buffer in bytes. This variable + upon return receives the remaining bytes free in the buffer Return Value: @@ -949,8 +949,8 @@ Arguments: Buffer - Supplies a pointer to the output buffer where the information is to be returned - Length - Supplies the length of the buffer in byte. This variable - upon return recieves the remaining bytes free in the buffer + Length - Supplies the length of the buffer in bytes. This variable + upon return receives the remaining bytes free in the buffer Return Value: @@ -1067,7 +1067,7 @@ Return Value: // // Volume label that fits in 11 unicode character length limit - // is not necessary within 11 characters in OEM character set. + // is not necessarily within 11 characters in OEM character set. // if (!NT_SUCCESS( Status )) { @@ -1159,6 +1159,15 @@ Return Value: if (OemLabel.Length > 0) { + // + // Translate the first character from 0xe5 to 0x5. + // + + if ((UCHAR)OemLabel.Buffer[0] == 0xe5) { + + OemLabel.Buffer[0] = FAT_DIRENT_REALLY_0E5; + } + // // Locate the volume label if there already is one // @@ -1326,7 +1335,7 @@ Arguments: Buffer - Supplies a pointer to the output buffer where the information is to be returned - Length - Supplies the length of the buffer in byte. This variable + Length - Supplies the length of the buffer in bytes. This variable upon return receives the remaining bytes free in the buffer Return Value: diff --git a/media/doc/README.FSD b/media/doc/README.FSD index 5071e3cc1f5..83137d81a5c 100644 --- a/media/doc/README.FSD +++ b/media/doc/README.FSD @@ -19,7 +19,7 @@ drivers/filesystems/reiserfs # Synced to 0.26 The following FSD are shared with: https://github.com/Microsoft/Windows-driver-samples drivers/filesystems/cdfs # Synced to f73e552 -drivers/filesystems/fastfat_new # Synced to 2817004 +drivers/filesystems/fastfat_new # Synced to 16022c5 drivers/storage/class/disk_new # Forked. (Imported on 2012.01.26 (r55211, from Windows XP DDK), merged to trunk on 2012.02.12 (r55555).) drivers/storage/floppy_new # Synced to 8fb512a

4 years, 2 months

[reactos] 01/01: [NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a72b78558daafbe9562d4… commit a72b78558daafbe9562d43b09f1a18deb439f7ac Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> AuthorDate: Fri May 22 20:24:31 2020 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Jun 25 21:59:02 2020 +0200 [NTOS:MM] MiGetPageTableForProcess(): #if out unreachable code No impact. Detected by Cppcheck: unreachableCode. Addendum to ddaf47dec3f096666757ff2cc9892adc01da887c (r34976). --- ntoskrnl/mm/arm/stubs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ntoskrnl/mm/arm/stubs.c b/ntoskrnl/mm/arm/stubs.c index e1031fee8aa..afbfdae337a 100644 --- a/ntoskrnl/mm/arm/stubs.c +++ b/ntoskrnl/mm/arm/stubs.c @@ -182,7 +182,9 @@ MiGetPageTableForProcess(IN PEPROCESS Process, // // THIS WHOLE PATH IS TODO // +#if 1 goto kernelHack; +#else ASSERT(FALSE); // @@ -200,6 +202,7 @@ MiGetPageTableForProcess(IN PEPROCESS Process, // Set it // *PointerPde = TempPde; +#endif } }

4 years, 2 months

[reactos] 01/01: [USBSTOR] Correctly terminate a REG_MULTI_SZ string returned by the IRP_MN_QUERY_ID handler

by Victor Perevertkin

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1e512e29dc5126f9188c8… commit 1e512e29dc5126f9188c83576bb703a7ce81681c Author: Victor Perevertkin <victor.perevertkin(a)reactos.org> AuthorDate: Wed Jun 24 21:14:36 2020 +0300 Commit: Victor Perevertkin <victor.perevertkin(a)reactos.org> CommitDate: Wed Jun 24 21:15:58 2020 +0300 [USBSTOR] Correctly terminate a REG_MULTI_SZ string returned by the IRP_MN_QUERY_ID handler --- drivers/usb/usbstor/pdo.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/usbstor/pdo.c b/drivers/usb/usbstor/pdo.c index e89eb45d382..86cf368bee6 100644 --- a/drivers/usb/usbstor/pdo.c +++ b/drivers/usb/usbstor/pdo.c @@ -360,6 +360,7 @@ USBSTOR_PdoHandleQueryHardwareId( Id7Length = strlen(Id7) + 1; DPRINT("USBSTOR_PdoHandleQueryHardwareId HardwareId7 %s\n", Id7); + // last +1 is for terminating \0 of REG_MULTI_SZ TotalLength = Id1Length + Id2Length + Id3Length + Id4Length + Id5Length + Id6Length + Id7Length + 1; Buffer = ExAllocatePoolWithTag(PagedPool, TotalLength * sizeof(WCHAR), USB_STOR_TAG); @@ -381,6 +382,8 @@ USBSTOR_PdoHandleQueryHardwareId( USBSTOR_ConvertToUnicodeString(Id6, Length, Offset, Buffer, &Offset); USBSTOR_ConvertToUnicodeString(Id7, Length, Offset, Buffer, &Offset); + Buffer[Offset] = UNICODE_NULL; // finish the REG_MULTI_SZ + ASSERT(Offset + 1 == Length); Irp->IoStatus.Information = (ULONG_PTR)Buffer; @@ -406,6 +409,7 @@ USBSTOR_PdoHandleQueryCompatibleId( // format instance id Length = sprintf(Buffer, "USBSTOR\\%s", DeviceType) + 1; + // +1 for terminating \0 and another +1 for \0 at the end of REG_MULTI_SZ Length += sprintf(&Buffer[Length], "USBSTOR\\%s", "RAW") + 2; InstanceId = ExAllocatePoolWithTag(PagedPool, Length * sizeof(WCHAR), USB_STOR_TAG); @@ -418,6 +422,8 @@ USBSTOR_PdoHandleQueryCompatibleId( USBSTOR_ConvertToUnicodeString(Buffer, Length, 0, InstanceId, &Offset); USBSTOR_ConvertToUnicodeString(&Buffer[Offset], Length, Offset, InstanceId, &Offset); + InstanceId[Offset] = UNICODE_NULL; // finish the REG_MULTI_SZ + DPRINT("USBSTOR_PdoHandleQueryCompatibleId %S\n", InstanceId); Irp->IoStatus.Information = (ULONG_PTR)InstanceId;

4 years, 2 months

[reactos] 01/01: [WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory.

by Nguyen Trung Khanh

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a279b1d2c6cd9a147dab7… commit a279b1d2c6cd9a147dab71fa7e05d55ba7639ada Author: Nguyen Trung Khanh <nguyentrungkhanh97(a)gmail.com> AuthorDate: Sat Jun 20 10:16:56 2020 +0700 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Wed Jun 24 09:15:27 2020 +0200 [WIN32K:NTUSER] Zero allocated memory in IntCbAllocateMemory. This avoids disclosing pool contents to user mode when not all members of the respective structure are initialized or when there is padding. In co_IntCallWindowProc, also zero the stack buffer since this can be passed to user mode as well, and contains padding. --- win32ss/user/ntuser/callback.c | 15 ++------------- win32ss/user/rtl/text.c | 1 - 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/win32ss/user/ntuser/callback.c b/win32ss/user/ntuser/callback.c index 7bcc65f5962..25e6eee5dd7 100644 --- a/win32ss/user/ntuser/callback.c +++ b/win32ss/user/ntuser/callback.c @@ -35,6 +35,7 @@ IntCbAllocateMemory(ULONG Size) return NULL; } + RtlZeroMemory(Mem, Size + sizeof(INT_CALLBACK_HEADER)); W32Thread = PsGetCurrentThreadWin32Thread(); ASSERT(W32Thread); @@ -185,10 +186,6 @@ co_IntClientLoadLibrary(PUNICODE_STRING pstrLibName, pLibNameBuffer -= (ULONG_PTR)pArguments; pArguments->strLibraryName.Buffer = (PWCHAR)(pLibNameBuffer); } - else - { - RtlZeroMemory(&pArguments->strLibraryName, sizeof(UNICODE_STRING)); - } if(pstrInitFunc) { @@ -202,10 +199,6 @@ co_IntClientLoadLibrary(PUNICODE_STRING pstrLibName, pInitFuncBuffer -= (ULONG_PTR)pArguments; pArguments->strInitFuncName.Buffer = (PWCHAR)(pInitFuncBuffer); } - else - { - RtlZeroMemory(&pArguments->strInitFuncName, sizeof(UNICODE_STRING)); - } /* Do the callback */ UserLeaveCo(); @@ -294,7 +287,7 @@ co_IntCallWindowProc(WNDPROC Proc, LPARAM lParam, INT lParamBufferSize) { - WINDOWPROC_CALLBACK_ARGUMENTS StackArguments; + WINDOWPROC_CALLBACK_ARGUMENTS StackArguments = { 0 }; PWINDOWPROC_CALLBACK_ARGUMENTS Arguments; NTSTATUS Status; PVOID ResultPointer, pActCtx; @@ -662,7 +655,6 @@ co_IntCallHookProc(INT HookId, Common->offPfn = offPfn; Common->Ansi = Ansi; Common->lParamSize = lParamSize; - RtlZeroMemory(&Common->ModuleName, sizeof(Common->ModuleName)); if (ModuleName->Buffer && ModuleName->Length) { RtlCopyMemory(&Common->ModuleName, ModuleName->Buffer, ModuleName->Length); @@ -929,9 +921,6 @@ co_IntCallLoadMenu( HINSTANCE hModule, } Common = (PLOADMENU_CALLBACK_ARGUMENTS) Argument; - // Help Intersource check and MenuName is now 4 bytes + so zero it. - RtlZeroMemory(Common, ArgumentLength); - Common->hModule = hModule; if (pMenuName->Length) RtlCopyMemory(&Common->MenuName, pMenuName->Buffer, pMenuName->Length); diff --git a/win32ss/user/rtl/text.c b/win32ss/user/rtl/text.c index 0ab3f00ea31..ac12626796b 100644 --- a/win32ss/user/rtl/text.c +++ b/win32ss/user/rtl/text.c @@ -997,7 +997,6 @@ BOOL UserExtTextOutW(HDC hdc, } else { - RtlZeroMemory(&Argument->rect, sizeof(RECT)); Argument->bRect = FALSE; }

4 years, 2 months

[reactos] 01/01: [NPFS] Fix querying FileAllInformation.

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=67592f97503a45a719c06… commit 67592f97503a45a719c0623b0c65b95ea12bbaab Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Tue Jun 23 10:15:24 2020 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Wed Jun 24 09:04:05 2020 +0200 [NPFS] Fix querying FileAllInformation. --- drivers/filesystems/npfs/fileinfo.c | 5 ++--- drivers/filesystems/npfs/fsctrl.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/filesystems/npfs/fileinfo.c b/drivers/filesystems/npfs/fileinfo.c index dd87ac75d55..56789a22a3e 100644 --- a/drivers/filesystems/npfs/fileinfo.c +++ b/drivers/filesystems/npfs/fileinfo.c @@ -433,7 +433,7 @@ NpCommonQueryInformation(IN PDEVICE_OBJECT DeviceObject, case FileAllInformation: - Length -= 12; + Length -= sizeof(FILE_ACCESS_INFORMATION) + sizeof(FILE_MODE_INFORMATION) + sizeof(FILE_ALIGNMENT_INFORMATION); AllInfo = (PFILE_ALL_INFORMATION)Buffer; NpQueryBasicInfo(Ccb, &AllInfo->BasicInformation, &Length); NpQueryStandardInfo(Ccb, &AllInfo->StandardInformation, &Length, NamedPipeEnd); @@ -441,7 +441,6 @@ NpCommonQueryInformation(IN PDEVICE_OBJECT DeviceObject, NpQueryEaInfo(Ccb, &AllInfo->EaInformation, &Length); NpQueryPositionInfo(Ccb, &AllInfo->PositionInformation, &Length, NamedPipeEnd); Status = NpQueryNameInfo(Ccb, &AllInfo->NameInformation, &Length); - Length += 96; break; case FileEaInformation: @@ -453,7 +452,7 @@ NpCommonQueryInformation(IN PDEVICE_OBJECT DeviceObject, break; } - Irp->IoStatus.Information = IoStack->Parameters.Read.Length - Length; + Irp->IoStatus.Information = IoStack->Parameters.QueryFile.Length - Length; return Status; } diff --git a/drivers/filesystems/npfs/fsctrl.c b/drivers/filesystems/npfs/fsctrl.c index d9ff6c846ee..0c93c8ad1cf 100644 --- a/drivers/filesystems/npfs/fsctrl.c +++ b/drivers/filesystems/npfs/fsctrl.c @@ -604,7 +604,7 @@ NpTransceive(IN PDEVICE_OBJECT DeviceObject, NewIrp->Tail.Overlay.Thread = Irp->Tail.Overlay.Thread; NewIrp->IoStatus.Information = BytesWritten; - IoStack->Parameters.Read.Length = BytesWritten; + IoStack->Parameters.Write.Length = BytesWritten; IoStack->MajorFunction = IRP_MJ_WRITE; if (BytesWritten > 0) NewIrp->Flags = IRP_DEALLOCATE_BUFFER | IRP_BUFFERED_IO;

4 years, 2 months

[reactos] 01/01: [NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c And rearrange them in more logical order.

by Victor Perevertkin

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=21e9e2baa57b744f2367b… commit 21e9e2baa57b744f2367b702c23f580611adad6c Author: Victor Perevertkin <victor.perevertkin(a)reactos.org> AuthorDate: Sun Jun 21 17:54:44 2020 +0300 Commit: Victor Perevertkin <victor.perevertkin(a)reactos.org> CommitDate: Wed Jun 24 04:03:35 2020 +0300 [NTOS:IO] Move device manipulation functions from pnpmgr/pnpmgr.c to pnpmgr/devaction.c And rearrange them in more logical order. This effectively splits the file, leaving public "Io" functions in pnpmgr.c along with some things not related do device object management. Functions which manipulate the device tree are left in devaction.c. In future all these functions will only be accessed from DeviceActionWorker. While being public API, IoRequestDeviceEject and IoInvalidateDeviceState have been moved to devaction.c as well. In next commits they will be converted to DeviceActionWorker routines and their callers will be put in pnpmgr.c --- ntoskrnl/io/pnpmgr/devaction.c | 2375 +++++++++++++++++++++++++++++ ntoskrnl/io/pnpmgr/pnpmgr.c | 3206 ++++++---------------------------------- ntoskrnl/ntos.cmake | 1 + 3 files changed, 2815 insertions(+), 2767 deletions(-) diff --git a/ntoskrnl/io/pnpmgr/devaction.c b/ntoskrnl/io/pnpmgr/devaction.c new file mode 100644 index 00000000000..16877098994 --- /dev/null +++ b/ntoskrnl/io/pnpmgr/devaction.c @@ -0,0 +1,2375 @@ +/* + * PROJECT: ReactOS Kernel + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: PnP manager device manipulation functions + * COPYRIGHT: Casper S. Hornstrup (chorns(a)users.sourceforge.net) + * 2007 Hervé Poussineau (hpoussin(a)reactos.org) + * 2014-2017 Thomas Faber (thomas.faber(a)reactos.org) + */ + +/* INCLUDES ******************************************************************/ + +#include <ntoskrnl.h> +#define NDEBUG +#include <debug.h> + +/* GLOBALS *******************************************************************/ + +extern ERESOURCE IopDriverLoadResource; +extern BOOLEAN PnpSystemInit; +extern PDEVICE_NODE IopRootDeviceNode; + +#define MAX_DEVICE_ID_LEN 200 +#define MAX_SEPARATORS_INSTANCEID 0 +#define MAX_SEPARATORS_DEVICEID 1 + +/* DATA **********************************************************************/ + +LIST_ENTRY IopDeviceActionRequestList; +WORK_QUEUE_ITEM IopDeviceActionWorkItem; +BOOLEAN IopDeviceActionInProgress; +KSPIN_LOCK IopDeviceActionLock; + +/* FUNCTIONS *****************************************************************/ + +PDEVICE_OBJECT +IopGetDeviceObjectFromDeviceInstance(PUNICODE_STRING DeviceInstance); + +NTSTATUS +IopGetParentIdPrefix(PDEVICE_NODE DeviceNode, PUNICODE_STRING ParentIdPrefix); + +USHORT +NTAPI +IopGetBusTypeGuidIndex(LPGUID BusTypeGuid); + +NTSTATUS +IopSetDeviceInstanceData(HANDLE InstanceKey, PDEVICE_NODE DeviceNode); + +VOID +NTAPI +IopInstallCriticalDevice(PDEVICE_NODE DeviceNode); + +static +VOID +IopCancelPrepareDeviceForRemoval(PDEVICE_OBJECT DeviceObject); + +static +NTSTATUS +IopPrepareDeviceForRemoval(PDEVICE_OBJECT DeviceObject, BOOLEAN Force); + +static +BOOLEAN +IopValidateID( + _In_ PWCHAR Id, + _In_ BUS_QUERY_ID_TYPE QueryType) +{ + PWCHAR PtrChar; + PWCHAR StringEnd; + WCHAR Char; + ULONG SeparatorsCount = 0; + PWCHAR PtrPrevChar = NULL; + ULONG MaxSeparators; + BOOLEAN IsMultiSz; + + PAGED_CODE(); + + switch (QueryType) + { + case BusQueryDeviceID: + MaxSeparators = MAX_SEPARATORS_DEVICEID; + IsMultiSz = FALSE; + break; + case BusQueryInstanceID: + MaxSeparators = MAX_SEPARATORS_INSTANCEID; + IsMultiSz = FALSE; + break; + + case BusQueryHardwareIDs: + case BusQueryCompatibleIDs: + MaxSeparators = MAX_SEPARATORS_DEVICEID; + IsMultiSz = TRUE; + break; + + default: + DPRINT1("IopValidateID: Not handled QueryType - %x\n", QueryType); + return FALSE; + } + + StringEnd = Id + MAX_DEVICE_ID_LEN; + + for (PtrChar = Id; PtrChar < StringEnd; PtrChar++) + { + Char = *PtrChar; + + if (Char == UNICODE_NULL) + { + if (!IsMultiSz || (PtrPrevChar && PtrChar == PtrPrevChar + 1)) + { + if (MaxSeparators == SeparatorsCount || IsMultiSz) + { + return TRUE; + } + + DPRINT1("IopValidateID: SeparatorsCount - %lu, MaxSeparators - %lu\n", + SeparatorsCount, MaxSeparators); + goto ErrorExit; + } + + StringEnd = PtrChar + MAX_DEVICE_ID_LEN + 1; + PtrPrevChar = PtrChar; + SeparatorsCount = 0; + } + else if (Char < ' ' || Char > 0x7F || Char == ',') + { + DPRINT1("IopValidateID: Invalid character - %04X\n", Char); + goto ErrorExit; + } + else if (Char == ' ') + { + *PtrChar = '_'; + } + else if (Char == '\\') + { + SeparatorsCount++; + + if (SeparatorsCount > MaxSeparators) + { + DPRINT1("IopValidateID: SeparatorsCount - %lu, MaxSeparators - %lu\n", + SeparatorsCount, MaxSeparators); + goto ErrorExit; + } + } + } + + DPRINT1("IopValidateID: Not terminated ID\n"); + +ErrorExit: + // FIXME logging + return FALSE; +} + +static +NTSTATUS +IopCreateDeviceInstancePath( + _In_ PDEVICE_NODE DeviceNode, + _Out_ PUNICODE_STRING InstancePath) +{ + IO_STATUS_BLOCK IoStatusBlock; + UNICODE_STRING DeviceId; + UNICODE_STRING InstanceId; + IO_STACK_LOCATION Stack; + NTSTATUS Status; + UNICODE_STRING ParentIdPrefix = { 0, 0, NULL }; + DEVICE_CAPABILITIES DeviceCapabilities; + BOOLEAN IsValidID; + + DPRINT("Sending IRP_MN_QUERY_ID.BusQueryDeviceID to device stack\n"); + + Stack.Parameters.QueryId.IdType = BusQueryDeviceID; + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_ID, + &Stack); + if (!NT_SUCCESS(Status)) + { + DPRINT1("IopInitiatePnpIrp(BusQueryDeviceID) failed (Status %x)\n", Status); + return Status; + } + + IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryDeviceID); + + if (!IsValidID) + { + DPRINT1("Invalid DeviceID. DeviceNode - %p\n", DeviceNode); + } + + /* Save the device id string */ + RtlInitUnicodeString(&DeviceId, (PWSTR)IoStatusBlock.Information); + + DPRINT("Sending IRP_MN_QUERY_CAPABILITIES to device stack (after enumeration)\n"); + + Status = IopQueryDeviceCapabilities(DeviceNode, &DeviceCapabilities); + if (!NT_SUCCESS(Status)) + { + DPRINT1("IopQueryDeviceCapabilities() failed (Status 0x%08lx)\n", Status); + RtlFreeUnicodeString(&DeviceId); + return Status; + } + + /* This bit is only check after enumeration */ + if (DeviceCapabilities.HardwareDisabled) + { + /* FIXME: Cleanup device */ + DeviceNode->Flags |= DNF_DISABLED; + RtlFreeUnicodeString(&DeviceId); + return STATUS_PLUGPLAY_NO_DEVICE; + } + else + { + DeviceNode->Flags &= ~DNF_DISABLED; + } + + if (!DeviceCapabilities.UniqueID) + { + /* Device has not a unique ID. We need to prepend parent bus unique identifier */ + DPRINT("Instance ID is not unique\n"); + Status = IopGetParentIdPrefix(DeviceNode, &ParentIdPrefix); + if (!NT_SUCCESS(Status)) + { + DPRINT1("IopGetParentIdPrefix() failed (Status 0x%08lx)\n", Status); + RtlFreeUnicodeString(&DeviceId); + return Status; + } + } + + DPRINT("Sending IRP_MN_QUERY_ID.BusQueryInstanceID to device stack\n"); + + Stack.Parameters.QueryId.IdType = BusQueryInstanceID; + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_ID, + &Stack); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopInitiatePnpIrp(BusQueryInstanceID) failed (Status %lx)\n", Status); + ASSERT(IoStatusBlock.Information == 0); + } + + if (IoStatusBlock.Information) + { + IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryInstanceID); + + if (!IsValidID) + { + DPRINT1("Invalid InstanceID. DeviceNode - %p\n", DeviceNode); + } + } + + RtlInitUnicodeString(&InstanceId, + (PWSTR)IoStatusBlock.Information); + + InstancePath->Length = 0; + InstancePath->MaximumLength = DeviceId.Length + sizeof(WCHAR) + + ParentIdPrefix.Length + + InstanceId.Length + + sizeof(UNICODE_NULL); + if (ParentIdPrefix.Length && InstanceId.Length) + { + InstancePath->MaximumLength += sizeof(WCHAR); + } + + InstancePath->Buffer = ExAllocatePoolWithTag(PagedPool, + InstancePath->MaximumLength, + TAG_IO); + if (!InstancePath->Buffer) + { + RtlFreeUnicodeString(&InstanceId); + RtlFreeUnicodeString(&ParentIdPrefix); + RtlFreeUnicodeString(&DeviceId); + return STATUS_INSUFFICIENT_RESOURCES; + } + + /* Start with the device id */ + RtlCopyUnicodeString(InstancePath, &DeviceId); + RtlAppendUnicodeToString(InstancePath, L"\\"); + + /* Add information from parent bus device to InstancePath */ + RtlAppendUnicodeStringToString(InstancePath, &ParentIdPrefix); + if (ParentIdPrefix.Length && InstanceId.Length) + { + RtlAppendUnicodeToString(InstancePath, L"&"); + } + + /* Finally, add the id returned by the driver stack */ + RtlAppendUnicodeStringToString(InstancePath, &InstanceId); + + /* + * FIXME: Check for valid characters, if there is invalid characters + * then bugcheck + */ + + RtlFreeUnicodeString(&InstanceId); + RtlFreeUnicodeString(&DeviceId); + RtlFreeUnicodeString(&ParentIdPrefix); + + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI +IopQueryDeviceCapabilities(PDEVICE_NODE DeviceNode, + PDEVICE_CAPABILITIES DeviceCaps) +{ + IO_STATUS_BLOCK StatusBlock; + IO_STACK_LOCATION Stack; + NTSTATUS Status; + HANDLE InstanceKey; + UNICODE_STRING ValueName; + + /* Set up the Header */ + RtlZeroMemory(DeviceCaps, sizeof(DEVICE_CAPABILITIES)); + DeviceCaps->Size = sizeof(DEVICE_CAPABILITIES); + DeviceCaps->Version = 1; + DeviceCaps->Address = -1; + DeviceCaps->UINumber = -1; + + /* Set up the Stack */ + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.Parameters.DeviceCapabilities.Capabilities = DeviceCaps; + + /* Send the IRP */ + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &StatusBlock, + IRP_MN_QUERY_CAPABILITIES, + &Stack); + if (!NT_SUCCESS(Status)) + { + if (Status != STATUS_NOT_SUPPORTED) + { + DPRINT1("IRP_MN_QUERY_CAPABILITIES failed with status 0x%lx\n", Status); + } + return Status; + } + + /* Map device capabilities to capability flags */ + DeviceNode->CapabilityFlags = 0; + if (DeviceCaps->LockSupported) + DeviceNode->CapabilityFlags |= 0x00000001; // CM_DEVCAP_LOCKSUPPORTED + + if (DeviceCaps->EjectSupported) + DeviceNode->CapabilityFlags |= 0x00000002; // CM_DEVCAP_EJECTSUPPORTED + + if (DeviceCaps->Removable) + DeviceNode->CapabilityFlags |= 0x00000004; // CM_DEVCAP_REMOVABLE + + if (DeviceCaps->DockDevice) + DeviceNode->CapabilityFlags |= 0x00000008; // CM_DEVCAP_DOCKDEVICE + + if (DeviceCaps->UniqueID) + DeviceNode->CapabilityFlags |= 0x00000010; // CM_DEVCAP_UNIQUEID + + if (DeviceCaps->SilentInstall) + DeviceNode->CapabilityFlags |= 0x00000020; // CM_DEVCAP_SILENTINSTALL + + if (DeviceCaps->RawDeviceOK) + DeviceNode->CapabilityFlags |= 0x00000040; // CM_DEVCAP_RAWDEVICEOK + + if (DeviceCaps->SurpriseRemovalOK) + DeviceNode->CapabilityFlags |= 0x00000080; // CM_DEVCAP_SURPRISEREMOVALOK + + if (DeviceCaps->HardwareDisabled) + DeviceNode->CapabilityFlags |= 0x00000100; // CM_DEVCAP_HARDWAREDISABLED + + if (DeviceCaps->NonDynamic) + DeviceNode->CapabilityFlags |= 0x00000200; // CM_DEVCAP_NONDYNAMIC + + if (DeviceCaps->NoDisplayInUI) + DeviceNode->UserFlags |= DNUF_DONT_SHOW_IN_UI; + else + DeviceNode->UserFlags &= ~DNUF_DONT_SHOW_IN_UI; + + Status = IopCreateDeviceKeyPath(&DeviceNode->InstancePath, REG_OPTION_NON_VOLATILE, &InstanceKey); + if (NT_SUCCESS(Status)) + { + /* Set 'Capabilities' value */ + RtlInitUnicodeString(&ValueName, L"Capabilities"); + Status = ZwSetValueKey(InstanceKey, + &ValueName, + 0, + REG_DWORD, + &DeviceNode->CapabilityFlags, + sizeof(ULONG)); + + /* Set 'UINumber' value */ + if (DeviceCaps->UINumber != MAXULONG) + { + RtlInitUnicodeString(&ValueName, L"UINumber"); + Status = ZwSetValueKey(InstanceKey, + &ValueName, + 0, + REG_DWORD, + &DeviceCaps->UINumber, + sizeof(ULONG)); + } + + ZwClose(InstanceKey); + } + + return Status; +} + +static +NTSTATUS +IopQueryHardwareIds(PDEVICE_NODE DeviceNode, + HANDLE InstanceKey) +{ + IO_STACK_LOCATION Stack; + IO_STATUS_BLOCK IoStatusBlock; + PWSTR Ptr; + UNICODE_STRING ValueName; + NTSTATUS Status; + ULONG Length, TotalLength; + BOOLEAN IsValidID; + + DPRINT("Sending IRP_MN_QUERY_ID.BusQueryHardwareIDs to device stack\n"); + + RtlZeroMemory(&Stack, sizeof(Stack)); + Stack.Parameters.QueryId.IdType = BusQueryHardwareIDs; + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_ID, + &Stack); + if (NT_SUCCESS(Status)) + { + IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryHardwareIDs); + + if (!IsValidID) + { + DPRINT1("Invalid HardwareIDs. DeviceNode - %p\n", DeviceNode); + } + + TotalLength = 0; + + Ptr = (PWSTR)IoStatusBlock.Information; + DPRINT("Hardware IDs:\n"); + while (*Ptr) + { + DPRINT(" %S\n", Ptr); + Length = (ULONG)wcslen(Ptr) + 1; + + Ptr += Length; + TotalLength += Length; + } + DPRINT("TotalLength: %hu\n", TotalLength); + DPRINT("\n"); + + RtlInitUnicodeString(&ValueName, L"HardwareID"); + Status = ZwSetValueKey(InstanceKey, + &ValueName, + 0, + REG_MULTI_SZ, + (PVOID)IoStatusBlock.Information, + (TotalLength + 1) * sizeof(WCHAR)); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ZwSetValueKey() failed (Status %lx)\n", Status); + } + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %x)\n", Status); + } + + return Status; +} + +static +NTSTATUS +IopQueryCompatibleIds(PDEVICE_NODE DeviceNode, + HANDLE InstanceKey) +{ + IO_STACK_LOCATION Stack; + IO_STATUS_BLOCK IoStatusBlock; + PWSTR Ptr; + UNICODE_STRING ValueName; + NTSTATUS Status; + ULONG Length, TotalLength; + BOOLEAN IsValidID; + + DPRINT("Sending IRP_MN_QUERY_ID.BusQueryCompatibleIDs to device stack\n"); + + RtlZeroMemory(&Stack, sizeof(Stack)); + Stack.Parameters.QueryId.IdType = BusQueryCompatibleIDs; + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_ID, + &Stack); + if (NT_SUCCESS(Status) && IoStatusBlock.Information) + { + IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryCompatibleIDs); + + if (!IsValidID) + { + DPRINT1("Invalid CompatibleIDs. DeviceNode - %p\n", DeviceNode); + } + + TotalLength = 0; + + Ptr = (PWSTR)IoStatusBlock.Information; + DPRINT("Compatible IDs:\n"); + while (*Ptr) + { + DPRINT(" %S\n", Ptr); + Length = (ULONG)wcslen(Ptr) + 1; + + Ptr += Length; + TotalLength += Length; + } + DPRINT("TotalLength: %hu\n", TotalLength); + DPRINT("\n"); + + RtlInitUnicodeString(&ValueName, L"CompatibleIDs"); + Status = ZwSetValueKey(InstanceKey, + &ValueName, + 0, + REG_MULTI_SZ, + (PVOID)IoStatusBlock.Information, + (TotalLength + 1) * sizeof(WCHAR)); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ZwSetValueKey() failed (Status %lx) or no Compatible ID returned\n", Status); + } + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %x)\n", Status); + } + + return Status; +} + +/* + * IopActionInterrogateDeviceStack + * + * Retrieve information for all (direct) child nodes of a parent node. + * + * Parameters + * DeviceNode + * Pointer to device node. + * Context + * Pointer to parent node to retrieve child node information for. + * + * Remarks + * Any errors that occur are logged instead so that all child services have a chance + * of being interrogated. + */ + +NTSTATUS +IopActionInterrogateDeviceStack(PDEVICE_NODE DeviceNode, + PVOID Context) +{ + IO_STATUS_BLOCK IoStatusBlock; + PWSTR DeviceDescription; + PWSTR LocationInformation; + PDEVICE_NODE ParentDeviceNode; + IO_STACK_LOCATION Stack; + NTSTATUS Status; + ULONG RequiredLength; + LCID LocaleId; + HANDLE InstanceKey = NULL; + UNICODE_STRING ValueName; + UNICODE_STRING InstancePathU; + PDEVICE_OBJECT OldDeviceObject; + + DPRINT("IopActionInterrogateDeviceStack(%p, %p)\n", DeviceNode, Context); + DPRINT("PDO 0x%p\n", DeviceNode->PhysicalDeviceObject); + + ParentDeviceNode = (PDEVICE_NODE)Context; + + /* + * We are called for the parent too, but we don't need to do special + * handling for this node + */ + if (DeviceNode == ParentDeviceNode) + { + DPRINT("Success\n"); + return STATUS_SUCCESS; + } + + /* + * Make sure this device node is a direct child of the parent device node + * that is given as an argument + */ + if (DeviceNode->Parent != ParentDeviceNode) + { + DPRINT("Skipping 2+ level child\n"); + return STATUS_SUCCESS; + } + + /* Skip processing if it was already completed before */ + if (DeviceNode->Flags & DNF_PROCESSED) + { + /* Nothing to do */ + return STATUS_SUCCESS; + } + + /* Get Locale ID */ + Status = ZwQueryDefaultLocale(FALSE, &LocaleId); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ZwQueryDefaultLocale() failed with status 0x%lx\n", Status); + return Status; + } + + /* + * FIXME: For critical errors, cleanup and disable device, but always + * return STATUS_SUCCESS. + */ + + Status = IopCreateDeviceInstancePath(DeviceNode, &InstancePathU); + if (!NT_SUCCESS(Status)) + { + if (Status != STATUS_PLUGPLAY_NO_DEVICE) + { + DPRINT1("IopCreateDeviceInstancePath() failed with status 0x%lx\n", Status); + } + + /* We have to return success otherwise we abort the traverse operation */ + return STATUS_SUCCESS; + } + + /* Verify that this is not a duplicate */ + OldDeviceObject = IopGetDeviceObjectFromDeviceInstance(&InstancePathU); + if (OldDeviceObject != NULL) + { + PDEVICE_NODE OldDeviceNode = IopGetDeviceNode(OldDeviceObject); + + DPRINT1("Duplicate device instance '%wZ'\n", &InstancePathU); + DPRINT1("Current instance parent: '%wZ'\n", &DeviceNode->Parent->InstancePath); + DPRINT1("Old instance parent: '%wZ'\n", &OldDeviceNode->Parent->InstancePath); + + KeBugCheckEx(PNP_DETECTED_FATAL_ERROR, + 0x01, + (ULONG_PTR)DeviceNode->PhysicalDeviceObject, + (ULONG_PTR)OldDeviceObject, + 0); + } + + DeviceNode->InstancePath = InstancePathU; + + DPRINT("InstancePath is %S\n", DeviceNode->InstancePath.Buffer); + + /* + * Create registry key for the instance id, if it doesn't exist yet + */ + Status = IopCreateDeviceKeyPath(&DeviceNode->InstancePath, REG_OPTION_NON_VOLATILE, &InstanceKey); + if (!NT_SUCCESS(Status)) + { + DPRINT1("Failed to create the instance key! (Status %lx)\n", Status); + + /* We have to return success otherwise we abort the traverse operation */ + return STATUS_SUCCESS; + } + + IopQueryHardwareIds(DeviceNode, InstanceKey); + + IopQueryCompatibleIds(DeviceNode, InstanceKey); + + DPRINT("Sending IRP_MN_QUERY_DEVICE_TEXT.DeviceTextDescription to device stack\n"); + + Stack.Parameters.QueryDeviceText.DeviceTextType = DeviceTextDescription; + Stack.Parameters.QueryDeviceText.LocaleId = LocaleId; + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_DEVICE_TEXT, + &Stack); + DeviceDescription = NT_SUCCESS(Status) ? (PWSTR)IoStatusBlock.Information + : NULL; + /* This key is mandatory, so even if the Irp fails, we still write it */ + RtlInitUnicodeString(&ValueName, L"DeviceDesc"); + if (ZwQueryValueKey(InstanceKey, &ValueName, KeyValueBasicInformation, NULL, 0, &RequiredLength) == STATUS_OBJECT_NAME_NOT_FOUND) + { + if (DeviceDescription && + *DeviceDescription != UNICODE_NULL) + { + /* This key is overriden when a driver is installed. Don't write the + * new description if another one already exists */ + Status = ZwSetValueKey(InstanceKey, + &ValueName, + 0, + REG_SZ, + DeviceDescription, + ((ULONG)wcslen(DeviceDescription) + 1) * sizeof(WCHAR)); + } + else + { + UNICODE_STRING DeviceDesc = RTL_CONSTANT_STRING(L"Unknown device"); + DPRINT("Driver didn't return DeviceDesc (Status 0x%08lx), so place unknown device there\n", Status); + + Status = ZwSetValueKey(InstanceKey, + &ValueName, + 0, + REG_SZ, + DeviceDesc.Buffer, + DeviceDesc.MaximumLength); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ZwSetValueKey() failed (Status 0x%lx)\n", Status); + } + + } + } + + if (DeviceDescription) + { + ExFreePoolWithTag(DeviceDescription, 0); + } + + DPRINT("Sending IRP_MN_QUERY_DEVICE_TEXT.DeviceTextLocation to device stack\n"); + + Stack.Parameters.QueryDeviceText.DeviceTextType = DeviceTextLocationInformation; + Stack.Parameters.QueryDeviceText.LocaleId = LocaleId; + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_DEVICE_TEXT, + &Stack); + if (NT_SUCCESS(Status) && IoStatusBlock.Information) + { + LocationInformation = (PWSTR)IoStatusBlock.Information; + DPRINT("LocationInformation: %S\n", LocationInformation); + RtlInitUnicodeString(&ValueName, L"LocationInformation"); + Status = ZwSetValueKey(InstanceKey, + &ValueName, + 0, + REG_SZ, + LocationInformation, + ((ULONG)wcslen(LocationInformation) + 1) * sizeof(WCHAR)); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ZwSetValueKey() failed (Status %lx)\n", Status); + } + + ExFreePoolWithTag(LocationInformation, 0); + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %x) or IoStatusBlock.Information=NULL\n", Status); + } + + DPRINT("Sending IRP_MN_QUERY_BUS_INFORMATION to device stack\n"); + + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_BUS_INFORMATION, + NULL); + if (NT_SUCCESS(Status) && IoStatusBlock.Information) + { + PPNP_BUS_INFORMATION BusInformation = (PPNP_BUS_INFORMATION)IoStatusBlock.Information; + + DeviceNode->ChildBusNumber = BusInformation->BusNumber; + DeviceNode->ChildInterfaceType = BusInformation->LegacyBusType; + DeviceNode->ChildBusTypeIndex = IopGetBusTypeGuidIndex(&BusInformation->BusTypeGuid); + ExFreePoolWithTag(BusInformation, 0); + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %x) or IoStatusBlock.Information=NULL\n", Status); + + DeviceNode->ChildBusNumber = 0xFFFFFFF0; + DeviceNode->ChildInterfaceType = InterfaceTypeUndefined; + DeviceNode->ChildBusTypeIndex = -1; + } + + DPRINT("Sending IRP_MN_QUERY_RESOURCES to device stack\n"); + + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_RESOURCES, + NULL); + if (NT_SUCCESS(Status) && IoStatusBlock.Information) + { + DeviceNode->BootResources = (PCM_RESOURCE_LIST)IoStatusBlock.Information; + IopDeviceNodeSetFlag(DeviceNode, DNF_HAS_BOOT_CONFIG); + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %x) or IoStatusBlock.Information=NULL\n", Status); + DeviceNode->BootResources = NULL; + } + + DPRINT("Sending IRP_MN_QUERY_RESOURCE_REQUIREMENTS to device stack\n"); + + Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_RESOURCE_REQUIREMENTS, + NULL); + if (NT_SUCCESS(Status)) + { + DeviceNode->ResourceRequirements = (PIO_RESOURCE_REQUIREMENTS_LIST)IoStatusBlock.Information; + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %08lx)\n", Status); + DeviceNode->ResourceRequirements = NULL; + } + + if (InstanceKey != NULL) + { + IopSetDeviceInstanceData(InstanceKey, DeviceNode); + } + + ZwClose(InstanceKey); + + IopDeviceNodeSetFlag(DeviceNode, DNF_PROCESSED); + + if (!IopDeviceNodeHasFlag(DeviceNode, DNF_LEGACY_DRIVER)) + { + /* Report the device to the user-mode pnp manager */ + IopQueueTargetDeviceEvent(&GUID_DEVICE_ENUMERATED, + &DeviceNode->InstancePath); + } + + return STATUS_SUCCESS; +} + +/* + * IopActionConfigureChildServices + * + * Retrieve configuration for all (direct) child nodes of a parent node. + * + * Parameters + * DeviceNode + * Pointer to device node. + * Context + * Pointer to parent node to retrieve child node configuration for. + * + * Remarks + * Any errors that occur are logged instead so that all child services have a chance of beeing + * configured. + */ + +NTSTATUS +IopActionConfigureChildServices(PDEVICE_NODE DeviceNode, + PVOID Context) +{ + RTL_QUERY_REGISTRY_TABLE QueryTable[3]; + PDEVICE_NODE ParentDeviceNode; + PUNICODE_STRING Service; + UNICODE_STRING ClassGUID; + NTSTATUS Status; + DEVICE_CAPABILITIES DeviceCaps; + + DPRINT("IopActionConfigureChildServices(%p, %p)\n", DeviceNode, Context); + + ParentDeviceNode = (PDEVICE_NODE)Context; + + /* + * We are called for the parent too, but we don't need to do special + * handling for this node + */ + if (DeviceNode == ParentDeviceNode) + { + DPRINT("Success\n"); + return STATUS_SUCCESS; + } + + /* + * Make sure this device node is a direct child of the parent device node + * that is given as an argument + */ + + if (DeviceNode->Parent != ParentDeviceNode) + { + DPRINT("Skipping 2+ level child\n"); + return STATUS_SUCCESS; + } + + if (!(DeviceNode->Flags & DNF_PROCESSED)) + { + DPRINT1("Child not ready to be configured\n"); + return STATUS_SUCCESS; + } + + if (!(DeviceNode->Flags & (DNF_DISABLED | DNF_STARTED | DNF_ADDED))) + { + UNICODE_STRING RegKey; + + /* Install the service for this if it's in the CDDB */ + IopInstallCriticalDevice(DeviceNode); + + /* + * Retrieve configuration from Enum key + */ + + Service = &DeviceNode->ServiceName; + + RtlZeroMemory(QueryTable, sizeof(QueryTable)); + RtlInitUnicodeString(Service, NULL); + RtlInitUnicodeString(&ClassGUID, NULL); + + QueryTable[0].Name = L"Service"; + QueryTable[0].Flags = RTL_QUERY_REGISTRY_DIRECT; + QueryTable[0].EntryContext = Service; + + QueryTable[1].Name = L"ClassGUID"; + QueryTable[1].Flags = RTL_QUERY_REGISTRY_DIRECT; + QueryTable[1].EntryContext = &ClassGUID; + QueryTable[1].DefaultType = REG_SZ; + QueryTable[1].DefaultData = L""; + QueryTable[1].DefaultLength = 0; + + RegKey.Length = 0; + RegKey.MaximumLength = sizeof(ENUM_ROOT) + sizeof(WCHAR) + DeviceNode->InstancePath.Length; + RegKey.Buffer = ExAllocatePoolWithTag(PagedPool, + RegKey.MaximumLength, + TAG_IO); + if (RegKey.Buffer == NULL) + { + IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); + return STATUS_INSUFFICIENT_RESOURCES; + } + + RtlAppendUnicodeToString(&RegKey, ENUM_ROOT); + RtlAppendUnicodeToString(&RegKey, L"\\"); + RtlAppendUnicodeStringToString(&RegKey, &DeviceNode->InstancePath); + + Status = RtlQueryRegistryValues(RTL_REGISTRY_ABSOLUTE, + RegKey.Buffer, QueryTable, NULL, NULL); + ExFreePoolWithTag(RegKey.Buffer, TAG_IO); + + if (!NT_SUCCESS(Status)) + { + /* FIXME: Log the error */ + DPRINT("Could not retrieve configuration for device %wZ (Status 0x%08x)\n", + &DeviceNode->InstancePath, Status); + IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); + return STATUS_SUCCESS; + } + + if (Service->Buffer == NULL) + { + if (NT_SUCCESS(IopQueryDeviceCapabilities(DeviceNode, &DeviceCaps)) && + DeviceCaps.RawDeviceOK) + { + DPRINT("%wZ is using parent bus driver (%wZ)\n", &DeviceNode->InstancePath, &ParentDeviceNode->ServiceName); + RtlInitEmptyUnicodeString(&DeviceNode->ServiceName, NULL, 0); + } + else if (ClassGUID.Length != 0) + { + /* Device has a ClassGUID value, but no Service value. + * Suppose it is using the NULL driver, so state the + * device is started */ + DPRINT("%wZ is using NULL driver\n", &DeviceNode->InstancePath); + IopDeviceNodeSetFlag(DeviceNode, DNF_STARTED); + } + else + { + DeviceNode->Problem = CM_PROB_FAILED_INSTALL; + IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); + } + return STATUS_SUCCESS; + } + + DPRINT("Got Service %S\n", Service->Buffer); + } + + return STATUS_SUCCESS; +} + +/* + * IopActionInitChildServices + * + * Initialize the service for all (direct) child nodes of a parent node + * + * Parameters + * DeviceNode + * Pointer to device node. + * Context + * Pointer to parent node to initialize child node services for. + * + * Remarks + * If the driver image for a service is not loaded and initialized + * it is done here too. Any errors that occur are logged instead so + * that all child services have a chance of being initialized. + */ + +NTSTATUS +IopActionInitChildServices(PDEVICE_NODE DeviceNode, + PVOID Context) +{ + PDEVICE_NODE ParentDeviceNode; + NTSTATUS Status; + BOOLEAN BootDrivers = !PnpSystemInit; + + DPRINT("IopActionInitChildServices(%p, %p)\n", DeviceNode, Context); + + ParentDeviceNode = Context; + + /* + * We are called for the parent too, but we don't need to do special + * handling for this node + */ + if (DeviceNode == ParentDeviceNode) + { + DPRINT("Success\n"); + return STATUS_SUCCESS; + } + + /* + * We don't want to check for a direct child because + * this function is called during boot to reinitialize + * devices with drivers that couldn't load yet due to + * stage 0 limitations (ie can't load from disk yet). + */ + + if (!(DeviceNode->Flags & DNF_PROCESSED)) + { + DPRINT1("Child not ready to be added\n"); + return STATUS_SUCCESS; + } + + if (IopDeviceNodeHasFlag(DeviceNode, DNF_STARTED) || + IopDeviceNodeHasFlag(DeviceNode, DNF_ADDED) || + IopDeviceNodeHasFlag(DeviceNode, DNF_DISABLED)) + return STATUS_SUCCESS; + + if (DeviceNode->ServiceName.Buffer == NULL) + { + /* We don't need to worry about loading the driver because we're + * being driven in raw mode so our parent must be loaded to get here */ + Status = IopInitializeDevice(DeviceNode, NULL); + if (NT_SUCCESS(Status)) + { + Status = IopStartDevice(DeviceNode); + if (!NT_SUCCESS(Status)) + { + DPRINT1("IopStartDevice(%wZ) failed with status 0x%08x\n", + &DeviceNode->InstancePath, Status); + } + } + } + else + { + PLDR_DATA_TABLE_ENTRY ModuleObject; + PDRIVER_OBJECT DriverObject; + + KeEnterCriticalRegion(); + ExAcquireResourceExclusiveLite(&IopDriverLoadResource, TRUE); + /* Get existing DriverObject pointer (in case the driver has + already been loaded and initialized) */ + Status = IopGetDriverObject( + &DriverObject, + &DeviceNode->ServiceName, + FALSE); + + if (!NT_SUCCESS(Status)) + { + /* Driver is not initialized, try to load it */ + Status = IopLoadServiceModule(&DeviceNode->ServiceName, &ModuleObject); + + if (NT_SUCCESS(Status) || Status == STATUS_IMAGE_ALREADY_LOADED) + { + /* Initialize the driver */ + Status = IopInitializeDriverModule(DeviceNode, ModuleObject, + &DeviceNode->ServiceName, FALSE, &DriverObject); + if (!NT_SUCCESS(Status)) + DeviceNode->Problem = CM_PROB_FAILED_DRIVER_ENTRY; + } + else if (Status == STATUS_DRIVER_UNABLE_TO_LOAD) + { + DPRINT1("Service '%wZ' is disabled\n", &DeviceNode->ServiceName); + DeviceNode->Problem = CM_PROB_DISABLED_SERVICE; + } + else + { + DPRINT("IopLoadServiceModule(%wZ) failed with status 0x%08x\n", + &DeviceNode->ServiceName, Status); + if (!BootDrivers) + DeviceNode->Problem = CM_PROB_DRIVER_FAILED_LOAD; + } + } + ExReleaseResourceLite(&IopDriverLoadResource); + KeLeaveCriticalRegion(); + + /* Driver is loaded and initialized at this point */ + if (NT_SUCCESS(Status)) + { + /* Initialize the device, including all filters */ + Status = PipCallDriverAddDevice(DeviceNode, FALSE, DriverObject); + + /* Remove the extra reference */ + ObDereferenceObject(DriverObject); + } + else + { + /* + * Don't disable when trying to load only boot drivers + */ + if (!BootDrivers) + { + IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); + } + } + } + + return STATUS_SUCCESS; +} + +static +NTSTATUS +IopSetServiceEnumData(PDEVICE_NODE DeviceNode) +{ + UNICODE_STRING ServicesKeyPath = RTL_CONSTANT_STRING(L"\\Registry\\Machine\\System\\CurrentControlSet\\Services\\"); + UNICODE_STRING ServiceKeyName; + UNICODE_STRING EnumKeyName; + UNICODE_STRING ValueName; + PKEY_VALUE_FULL_INFORMATION KeyValueInformation; + HANDLE ServiceKey = NULL, ServiceEnumKey = NULL; + ULONG Disposition; + ULONG Count = 0, NextInstance = 0; + WCHAR ValueBuffer[6]; + NTSTATUS Status = STATUS_SUCCESS; + + DPRINT("IopSetServiceEnumData(%p)\n", DeviceNode); + DPRINT("Instance: %wZ\n", &DeviceNode->InstancePath); + DPRINT("Service: %wZ\n", &DeviceNode->ServiceName); + + if (DeviceNode->ServiceName.Buffer == NULL) + { + DPRINT1("No service!\n"); + return STATUS_SUCCESS; + } + + ServiceKeyName.MaximumLength = ServicesKeyPath.Length + DeviceNode->ServiceName.Length + sizeof(UNICODE_NULL); + ServiceKeyName.Length = 0; + ServiceKeyName.Buffer = ExAllocatePool(PagedPool, ServiceKeyName.MaximumLength); + if (ServiceKeyName.Buffer == NULL) + { + DPRINT1("No ServiceKeyName.Buffer!\n"); + return STATUS_INSUFFICIENT_RESOURCES; + } + + RtlAppendUnicodeStringToString(&ServiceKeyName, &ServicesKeyPath); + RtlAppendUnicodeStringToString(&ServiceKeyName, &DeviceNode->ServiceName); + + DPRINT("ServiceKeyName: %wZ\n", &ServiceKeyName); + + Status = IopOpenRegistryKeyEx(&ServiceKey, NULL, &ServiceKeyName, KEY_CREATE_SUB_KEY); + if (!NT_SUCCESS(Status)) + { + goto done; + } + + RtlInitUnicodeString(&EnumKeyName, L"Enum"); + Status = IopCreateRegistryKeyEx(&ServiceEnumKey, + ServiceKey, + &EnumKeyName, + KEY_SET_VALUE, + REG_OPTION_VOLATILE, + &Disposition); + if (NT_SUCCESS(Status)) + { + if (Disposition == REG_OPENED_EXISTING_KEY) + { + /* Read the NextInstance value */ + Status = IopGetRegistryValue(ServiceEnumKey, + L"Count", + &KeyValueInformation); + if (!NT_SUCCESS(Status)) + goto done; + + if ((KeyValueInformation->Type == REG_DWORD) && + (KeyValueInformation->DataLength)) + { + /* Read it */ + Count = *(PULONG)((ULONG_PTR)KeyValueInformation + + KeyValueInformation->DataOffset); + } + + ExFreePool(KeyValueInformation); + KeyValueInformation = NULL; + + /* Read the NextInstance value */ + Status = IopGetRegistryValue(ServiceEnumKey, + L"NextInstance", + &KeyValueInformation); + if (!NT_SUCCESS(Status)) + goto done; + + if ((KeyValueInformation->Type == REG_DWORD) && + (KeyValueInformation->DataLength)) + { + NextInstance = *(PULONG)((ULONG_PTR)KeyValueInformation + + KeyValueInformation->DataOffset); + } + + ExFreePool(KeyValueInformation); + KeyValueInformation = NULL; + } + + /* Set the instance path */ + swprintf(ValueBuffer, L"%lu", NextInstance); + RtlInitUnicodeString(&ValueName, ValueBuffer); + Status = ZwSetValueKey(ServiceEnumKey, + &ValueName, + 0, + REG_SZ, + DeviceNode->InstancePath.Buffer, + DeviceNode->InstancePath.MaximumLength); + if (!NT_SUCCESS(Status)) + goto done; + + /* Increment Count and NextInstance */ + Count++; + NextInstance++; + + /* Set the new Count value */ + RtlInitUnicodeString(&ValueName, L"Count"); + Status = ZwSetValueKey(ServiceEnumKey, + &ValueName, + 0, + REG_DWORD, + &Count, + sizeof(Count)); + if (!NT_SUCCESS(Status)) + goto done; + + /* Set the new NextInstance value */ + RtlInitUnicodeString(&ValueName, L"NextInstance"); + Status = ZwSetValueKey(ServiceEnumKey, + &ValueName, + 0, + REG_DWORD, + &NextInstance, + sizeof(NextInstance)); + } + +done: + if (ServiceEnumKey != NULL) + ZwClose(ServiceEnumKey); + + if (ServiceKey != NULL) + ZwClose(ServiceKey); + + ExFreePool(ServiceKeyName.Buffer); + + return Status; +} + +static +VOID +NTAPI +IopStartDevice2(IN PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + PDEVICE_NODE DeviceNode; + NTSTATUS Status; + PVOID Dummy; + DEVICE_CAPABILITIES DeviceCapabilities; + + /* Get the device node */ + DeviceNode = IopGetDeviceNode(DeviceObject); + + ASSERT(!(DeviceNode->Flags & DNF_DISABLED)); + + /* Build the I/O stack location */ + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_START_DEVICE; + + Stack.Parameters.StartDevice.AllocatedResources = + DeviceNode->ResourceList; + Stack.Parameters.StartDevice.AllocatedResourcesTranslated = + DeviceNode->ResourceListTranslated; + + /* Do the call */ + Status = IopSynchronousCall(DeviceObject, &Stack, &Dummy); + if (!NT_SUCCESS(Status)) + { + /* Send an IRP_MN_REMOVE_DEVICE request */ + IopRemoveDevice(DeviceNode); + + /* Set the appropriate flag */ + DeviceNode->Flags |= DNF_START_FAILED; + DeviceNode->Problem = CM_PROB_FAILED_START; + + DPRINT1("Warning: PnP Start failed (%wZ) [Status: 0x%x]\n", &DeviceNode->InstancePath, Status); + return; + } + + DPRINT("Sending IRP_MN_QUERY_CAPABILITIES to device stack (after start)\n"); + + Status = IopQueryDeviceCapabilities(DeviceNode, &DeviceCapabilities); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopInitiatePnpIrp() failed (Status 0x%08lx)\n", Status); + } + + /* Invalidate device state so IRP_MN_QUERY_PNP_DEVICE_STATE is sent */ + IoInvalidateDeviceState(DeviceObject); + + /* Otherwise, mark us as started */ + DeviceNode->Flags |= DNF_STARTED; + DeviceNode->Flags &= ~DNF_STOPPED; + + /* We now need enumeration */ + DeviceNode->Flags |= DNF_NEED_ENUMERATION_ONLY; +} + +static +NTSTATUS +NTAPI +IopStartAndEnumerateDevice(IN PDEVICE_NODE DeviceNode) +{ + PDEVICE_OBJECT DeviceObject; + NTSTATUS Status; + PAGED_CODE(); + + /* Sanity check */ + ASSERT((DeviceNode->Flags & DNF_ADDED)); + ASSERT((DeviceNode->Flags & (DNF_RESOURCE_ASSIGNED | + DNF_RESOURCE_REPORTED | + DNF_NO_RESOURCE_REQUIRED))); + + /* Get the device object */ + DeviceObject = DeviceNode->PhysicalDeviceObject; + + /* Check if we're not started yet */ + if (!(DeviceNode->Flags & DNF_STARTED)) + { + /* Start us */ + IopStartDevice2(DeviceObject); + } + + /* Do we need to query IDs? This happens in the case of manual reporting */ +#if 0 + if (DeviceNode->Flags & DNF_NEED_QUERY_IDS) + { + DPRINT1("Warning: Device node has DNF_NEED_QUERY_IDS\n"); + /* And that case shouldn't happen yet */ + ASSERT(FALSE); + } +#endif + + IopSetServiceEnumData(DeviceNode); + + /* Make sure we're started, and check if we need enumeration */ + if ((DeviceNode->Flags & DNF_STARTED) && + (DeviceNode->Flags & DNF_NEED_ENUMERATION_ONLY)) + { + /* Enumerate us */ + IoSynchronousInvalidateDeviceRelations(DeviceObject, BusRelations); + Status = STATUS_SUCCESS; + } + else + { + /* Nothing to do */ + Status = STATUS_SUCCESS; + } + + /* Return */ + return Status; +} + +NTSTATUS +IopStartDevice( + PDEVICE_NODE DeviceNode) +{ + NTSTATUS Status; + HANDLE InstanceHandle = NULL, ControlHandle = NULL; + UNICODE_STRING KeyName, ValueString; + OBJECT_ATTRIBUTES ObjectAttributes; + + if (DeviceNode->Flags & DNF_DISABLED) + return STATUS_SUCCESS; + + Status = IopAssignDeviceResources(DeviceNode); + if (!NT_SUCCESS(Status)) + goto ByeBye; + + /* New PnP ABI */ + IopStartAndEnumerateDevice(DeviceNode); + + /* FIX: Should be done in new device instance code */ + Status = IopCreateDeviceKeyPath(&DeviceNode->InstancePath, REG_OPTION_NON_VOLATILE, &InstanceHandle); + if (!NT_SUCCESS(Status)) + goto ByeBye; + + /* FIX: Should be done in IoXxxPrepareDriverLoading */ + // { + RtlInitUnicodeString(&KeyName, L"Control"); + InitializeObjectAttributes(&ObjectAttributes, + &KeyName, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, + InstanceHandle, + NULL); + Status = ZwCreateKey(&ControlHandle, + KEY_SET_VALUE, + &ObjectAttributes, + 0, + NULL, + REG_OPTION_VOLATILE, + NULL); + if (!NT_SUCCESS(Status)) + goto ByeBye; + + RtlInitUnicodeString(&KeyName, L"ActiveService"); + ValueString = DeviceNode->ServiceName; + if (!ValueString.Buffer) + RtlInitUnicodeString(&ValueString, L""); + Status = ZwSetValueKey(ControlHandle, &KeyName, 0, REG_SZ, ValueString.Buffer, ValueString.Length + sizeof(UNICODE_NULL)); + // } + +ByeBye: + if (ControlHandle != NULL) + ZwClose(ControlHandle); + + if (InstanceHandle != NULL) + ZwClose(InstanceHandle); + + return Status; +} + +static +NTSTATUS +NTAPI +IopQueryStopDevice(IN PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + PVOID Dummy; + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_QUERY_STOP_DEVICE; + + return IopSynchronousCall(DeviceObject, &Stack, &Dummy); +} + +static +VOID +NTAPI +IopSendStopDevice(IN PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + PVOID Dummy; + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_STOP_DEVICE; + + /* Drivers should never fail a IRP_MN_STOP_DEVICE request */ + IopSynchronousCall(DeviceObject, &Stack, &Dummy); +} + +NTSTATUS +IopStopDevice( + PDEVICE_NODE DeviceNode) +{ + NTSTATUS Status; + + DPRINT("Stopping device: %wZ\n", &DeviceNode->InstancePath); + + Status = IopQueryStopDevice(DeviceNode->PhysicalDeviceObject); + if (NT_SUCCESS(Status)) + { + IopSendStopDevice(DeviceNode->PhysicalDeviceObject); + + DeviceNode->Flags &= ~(DNF_STARTED | DNF_START_REQUEST_PENDING); + DeviceNode->Flags |= DNF_STOPPED; + + return STATUS_SUCCESS; + } + + return Status; +} + +/* PUBLIC FUNCTIONS **********************************************************/ + +static +VOID +NTAPI +IopSendRemoveDevice(IN PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + PVOID Dummy; + PDEVICE_NODE DeviceNode = IopGetDeviceNode(DeviceObject); + + /* Drop all our state for this device in case it isn't really going away */ + DeviceNode->Flags &= DNF_ENUMERATED | DNF_PROCESSED; + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_REMOVE_DEVICE; + + /* Drivers should never fail a IRP_MN_REMOVE_DEVICE request */ + IopSynchronousCall(DeviceObject, &Stack, &Dummy); + + IopNotifyPlugPlayNotification(DeviceObject, + EventCategoryTargetDeviceChange, + &GUID_TARGET_DEVICE_REMOVE_COMPLETE, + NULL, + NULL); + ObDereferenceObject(DeviceObject); +} + +static +VOID +IopSendRemoveDeviceRelations(PDEVICE_RELATIONS DeviceRelations) +{ + /* This function DOES dereference the device objects in all cases */ + + ULONG i; + + for (i = 0; i < DeviceRelations->Count; i++) + { + IopSendRemoveDevice(DeviceRelations->Objects[i]); + DeviceRelations->Objects[i] = NULL; + } + + ExFreePool(DeviceRelations); +} + +static +VOID +IopSendRemoveChildDevices(PDEVICE_NODE ParentDeviceNode) +{ + PDEVICE_NODE ChildDeviceNode, NextDeviceNode; + KIRQL OldIrql; + + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + ChildDeviceNode = ParentDeviceNode->Child; + while (ChildDeviceNode != NULL) + { + NextDeviceNode = ChildDeviceNode->Sibling; + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); + + IopSendRemoveDevice(ChildDeviceNode->PhysicalDeviceObject); + + ChildDeviceNode = NextDeviceNode; + + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + } + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); +} + +static +VOID +NTAPI +IopSendSurpriseRemoval(IN PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + PVOID Dummy; + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_SURPRISE_REMOVAL; + + /* Drivers should never fail a IRP_MN_SURPRISE_REMOVAL request */ + IopSynchronousCall(DeviceObject, &Stack, &Dummy); +} + +static +VOID +NTAPI +IopCancelRemoveDevice(IN PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + PVOID Dummy; + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_CANCEL_REMOVE_DEVICE; + + /* Drivers should never fail a IRP_MN_CANCEL_REMOVE_DEVICE request */ + IopSynchronousCall(DeviceObject, &Stack, &Dummy); + + IopNotifyPlugPlayNotification(DeviceObject, + EventCategoryTargetDeviceChange, + &GUID_TARGET_DEVICE_REMOVE_CANCELLED, + NULL, + NULL); +} + +static +VOID +IopCancelRemoveChildDevices(PDEVICE_NODE ParentDeviceNode) +{ + PDEVICE_NODE ChildDeviceNode, NextDeviceNode; + KIRQL OldIrql; + + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + ChildDeviceNode = ParentDeviceNode->Child; + while (ChildDeviceNode != NULL) + { + NextDeviceNode = ChildDeviceNode->Sibling; + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); + + IopCancelPrepareDeviceForRemoval(ChildDeviceNode->PhysicalDeviceObject); + + ChildDeviceNode = NextDeviceNode; + + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + } + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); +} + +static +VOID +IopCancelRemoveDeviceRelations(PDEVICE_RELATIONS DeviceRelations) +{ + /* This function DOES dereference the device objects in all cases */ + + ULONG i; + + for (i = 0; i < DeviceRelations->Count; i++) + { + IopCancelPrepareDeviceForRemoval(DeviceRelations->Objects[i]); + ObDereferenceObject(DeviceRelations->Objects[i]); + DeviceRelations->Objects[i] = NULL; + } + + ExFreePool(DeviceRelations); +} + +static +VOID +IopCancelPrepareDeviceForRemoval(PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + IO_STATUS_BLOCK IoStatusBlock; + PDEVICE_RELATIONS DeviceRelations; + NTSTATUS Status; + + IopCancelRemoveDevice(DeviceObject); + + Stack.Parameters.QueryDeviceRelations.Type = RemovalRelations; + + Status = IopInitiatePnpIrp(DeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_DEVICE_RELATIONS, + &Stack); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopInitiatePnpIrp() failed with status 0x%08lx\n", Status); + DeviceRelations = NULL; + } + else + { + DeviceRelations = (PDEVICE_RELATIONS)IoStatusBlock.Information; + } + + if (DeviceRelations) + IopCancelRemoveDeviceRelations(DeviceRelations); +} + +static +NTSTATUS +NTAPI +IopQueryRemoveDevice(IN PDEVICE_OBJECT DeviceObject) +{ + PDEVICE_NODE DeviceNode = IopGetDeviceNode(DeviceObject); + IO_STACK_LOCATION Stack; + PVOID Dummy; + NTSTATUS Status; + + ASSERT(DeviceNode); + + IopQueueTargetDeviceEvent(&GUID_DEVICE_REMOVE_PENDING, + &DeviceNode->InstancePath); + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_QUERY_REMOVE_DEVICE; + + Status = IopSynchronousCall(DeviceObject, &Stack, &Dummy); + + IopNotifyPlugPlayNotification(DeviceObject, + EventCategoryTargetDeviceChange, + &GUID_TARGET_DEVICE_QUERY_REMOVE, + NULL, + NULL); + + if (!NT_SUCCESS(Status)) + { + DPRINT1("Removal vetoed by %wZ\n", &DeviceNode->InstancePath); + IopQueueTargetDeviceEvent(&GUID_DEVICE_REMOVAL_VETOED, + &DeviceNode->InstancePath); + } + + return Status; +} + +static +NTSTATUS +IopQueryRemoveChildDevices(PDEVICE_NODE ParentDeviceNode, BOOLEAN Force) +{ + PDEVICE_NODE ChildDeviceNode, NextDeviceNode, FailedRemoveDevice; + NTSTATUS Status; + KIRQL OldIrql; + + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + ChildDeviceNode = ParentDeviceNode->Child; + while (ChildDeviceNode != NULL) + { + NextDeviceNode = ChildDeviceNode->Sibling; + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); + + Status = IopPrepareDeviceForRemoval(ChildDeviceNode->PhysicalDeviceObject, Force); + if (!NT_SUCCESS(Status)) + { + FailedRemoveDevice = ChildDeviceNode; + goto cleanup; + } + + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + ChildDeviceNode = NextDeviceNode; + } + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); + + return STATUS_SUCCESS; + +cleanup: + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + ChildDeviceNode = ParentDeviceNode->Child; + while (ChildDeviceNode != NULL) + { + NextDeviceNode = ChildDeviceNode->Sibling; + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); + + IopCancelPrepareDeviceForRemoval(ChildDeviceNode->PhysicalDeviceObject); + + /* IRP_MN_CANCEL_REMOVE_DEVICE is also sent to the device + * that failed the IRP_MN_QUERY_REMOVE_DEVICE request */ + if (ChildDeviceNode == FailedRemoveDevice) + return Status; + + ChildDeviceNode = NextDeviceNode; + + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + } + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); + + return Status; +} + +static +NTSTATUS +IopQueryRemoveDeviceRelations(PDEVICE_RELATIONS DeviceRelations, BOOLEAN Force) +{ + /* This function DOES NOT dereference the device objects on SUCCESS + * but it DOES dereference device objects on FAILURE */ + + ULONG i, j; + NTSTATUS Status; + + for (i = 0; i < DeviceRelations->Count; i++) + { + Status = IopPrepareDeviceForRemoval(DeviceRelations->Objects[i], Force); + if (!NT_SUCCESS(Status)) + { + j = i; + goto cleanup; + } + } + + return STATUS_SUCCESS; + +cleanup: + /* IRP_MN_CANCEL_REMOVE_DEVICE is also sent to the device + * that failed the IRP_MN_QUERY_REMOVE_DEVICE request */ + for (i = 0; i <= j; i++) + { + IopCancelPrepareDeviceForRemoval(DeviceRelations->Objects[i]); + ObDereferenceObject(DeviceRelations->Objects[i]); + DeviceRelations->Objects[i] = NULL; + } + for (; i < DeviceRelations->Count; i++) + { + ObDereferenceObject(DeviceRelations->Objects[i]); + DeviceRelations->Objects[i] = NULL; + } + ExFreePool(DeviceRelations); + + return Status; +} + +static +NTSTATUS +IopPrepareDeviceForRemoval(IN PDEVICE_OBJECT DeviceObject, BOOLEAN Force) +{ + PDEVICE_NODE DeviceNode = IopGetDeviceNode(DeviceObject); + IO_STACK_LOCATION Stack; + IO_STATUS_BLOCK IoStatusBlock; + PDEVICE_RELATIONS DeviceRelations; + NTSTATUS Status; + + if ((DeviceNode->UserFlags & DNUF_NOT_DISABLEABLE) && !Force) + { + DPRINT1("Removal not allowed for %wZ\n", &DeviceNode->InstancePath); + return STATUS_UNSUCCESSFUL; + } + + if (!Force && IopQueryRemoveDevice(DeviceObject) != STATUS_SUCCESS) + { + DPRINT1("Removal vetoed by failing the query remove request\n"); + + IopCancelRemoveDevice(DeviceObject); + + return STATUS_UNSUCCESSFUL; + } + + Stack.Parameters.QueryDeviceRelations.Type = RemovalRelations; + + Status = IopInitiatePnpIrp(DeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_DEVICE_RELATIONS, + &Stack); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopInitiatePnpIrp() failed with status 0x%08lx\n", Status); + DeviceRelations = NULL; + } + else + { + DeviceRelations = (PDEVICE_RELATIONS)IoStatusBlock.Information; + } + + if (DeviceRelations) + { + Status = IopQueryRemoveDeviceRelations(DeviceRelations, Force); + if (!NT_SUCCESS(Status)) + return Status; + } + + Status = IopQueryRemoveChildDevices(DeviceNode, Force); + if (!NT_SUCCESS(Status)) + { + if (DeviceRelations) + IopCancelRemoveDeviceRelations(DeviceRelations); + return Status; + } + + if (DeviceRelations) + IopSendRemoveDeviceRelations(DeviceRelations); + IopSendRemoveChildDevices(DeviceNode); + + return STATUS_SUCCESS; +} + +static +VOID +IopHandleDeviceRemoval( + IN PDEVICE_NODE DeviceNode, + IN PDEVICE_RELATIONS DeviceRelations) +{ + PDEVICE_NODE Child = DeviceNode->Child, NextChild; + ULONG i; + BOOLEAN Found; + + if (DeviceNode == IopRootDeviceNode) + return; + + while (Child != NULL) + { + NextChild = Child->Sibling; + Found = FALSE; + + for (i = 0; DeviceRelations && i < DeviceRelations->Count; i++) + { + if (IopGetDeviceNode(DeviceRelations->Objects[i]) == Child) + { + Found = TRUE; + break; + } + } + + if (!Found && !(Child->Flags & DNF_WILL_BE_REMOVED)) + { + /* Send removal IRPs to all of its children */ + IopPrepareDeviceForRemoval(Child->PhysicalDeviceObject, TRUE); + + /* Send the surprise removal IRP */ + IopSendSurpriseRemoval(Child->PhysicalDeviceObject); + + /* Tell the user-mode PnP manager that a device was removed */ + IopQueueTargetDeviceEvent(&GUID_DEVICE_SURPRISE_REMOVAL, + &Child->InstancePath); + + /* Send the remove device IRP */ + IopSendRemoveDevice(Child->PhysicalDeviceObject); + } + + Child = NextChild; + } +} + +NTSTATUS +IopRemoveDevice(PDEVICE_NODE DeviceNode) +{ + NTSTATUS Status; + + DPRINT("Removing device: %wZ\n", &DeviceNode->InstancePath); + + Status = IopPrepareDeviceForRemoval(DeviceNode->PhysicalDeviceObject, FALSE); + if (NT_SUCCESS(Status)) + { + IopSendRemoveDevice(DeviceNode->PhysicalDeviceObject); + IopQueueTargetDeviceEvent(&GUID_DEVICE_SAFE_REMOVAL, + &DeviceNode->InstancePath); + return STATUS_SUCCESS; + } + + return Status; +} + +/* + * @implemented + */ +VOID +NTAPI +IoInvalidateDeviceState(IN PDEVICE_OBJECT PhysicalDeviceObject) +{ + PDEVICE_NODE DeviceNode = IopGetDeviceNode(PhysicalDeviceObject); + IO_STACK_LOCATION Stack; + ULONG_PTR PnPFlags; + NTSTATUS Status; + IO_STATUS_BLOCK IoStatusBlock; + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_QUERY_PNP_DEVICE_STATE; + + Status = IopSynchronousCall(PhysicalDeviceObject, &Stack, (PVOID*)&PnPFlags); + if (!NT_SUCCESS(Status)) + { + if (Status != STATUS_NOT_SUPPORTED) + { + DPRINT1("IRP_MN_QUERY_PNP_DEVICE_STATE failed with status 0x%lx\n", Status); + } + return; + } + + if (PnPFlags & PNP_DEVICE_NOT_DISABLEABLE) + DeviceNode->UserFlags |= DNUF_NOT_DISABLEABLE; + else + DeviceNode->UserFlags &= ~DNUF_NOT_DISABLEABLE; + + if (PnPFlags & PNP_DEVICE_DONT_DISPLAY_IN_UI) + DeviceNode->UserFlags |= DNUF_DONT_SHOW_IN_UI; + else + DeviceNode->UserFlags &= ~DNUF_DONT_SHOW_IN_UI; + + if ((PnPFlags & PNP_DEVICE_REMOVED) || + ((PnPFlags & PNP_DEVICE_FAILED) && !(PnPFlags & PNP_DEVICE_RESOURCE_REQUIREMENTS_CHANGED))) + { + /* Flag it if it's failed */ + if (PnPFlags & PNP_DEVICE_FAILED) DeviceNode->Problem = CM_PROB_FAILED_POST_START; + + /* Send removal IRPs to all of its children */ + IopPrepareDeviceForRemoval(PhysicalDeviceObject, TRUE); + + /* Send surprise removal */ + IopSendSurpriseRemoval(PhysicalDeviceObject); + + /* Tell the user-mode PnP manager that a device was removed */ + IopQueueTargetDeviceEvent(&GUID_DEVICE_SURPRISE_REMOVAL, + &DeviceNode->InstancePath); + + IopSendRemoveDevice(PhysicalDeviceObject); + } + else if ((PnPFlags & PNP_DEVICE_FAILED) && (PnPFlags & PNP_DEVICE_RESOURCE_REQUIREMENTS_CHANGED)) + { + /* Stop for resource rebalance */ + Status = IopStopDevice(DeviceNode); + if (!NT_SUCCESS(Status)) + { + DPRINT1("Failed to stop device for rebalancing\n"); + + /* Stop failed so don't rebalance */ + PnPFlags &= ~PNP_DEVICE_RESOURCE_REQUIREMENTS_CHANGED; + } + } + + /* Resource rebalance */ + if (PnPFlags & PNP_DEVICE_RESOURCE_REQUIREMENTS_CHANGED) + { + DPRINT("Sending IRP_MN_QUERY_RESOURCES to device stack\n"); + + Status = IopInitiatePnpIrp(PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_RESOURCES, + NULL); + if (NT_SUCCESS(Status) && IoStatusBlock.Information) + { + DeviceNode->BootResources = + (PCM_RESOURCE_LIST)IoStatusBlock.Information; + IopDeviceNodeSetFlag(DeviceNode, DNF_HAS_BOOT_CONFIG); + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %x) or IoStatusBlock.Information=NULL\n", Status); + DeviceNode->BootResources = NULL; + } + + DPRINT("Sending IRP_MN_QUERY_RESOURCE_REQUIREMENTS to device stack\n"); + + Status = IopInitiatePnpIrp(PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_RESOURCE_REQUIREMENTS, + NULL); + if (NT_SUCCESS(Status)) + { + DeviceNode->ResourceRequirements = + (PIO_RESOURCE_REQUIREMENTS_LIST)IoStatusBlock.Information; + } + else + { + DPRINT("IopInitiatePnpIrp() failed (Status %08lx)\n", Status); + DeviceNode->ResourceRequirements = NULL; + } + + /* IRP_MN_FILTER_RESOURCE_REQUIREMENTS is called indirectly by IopStartDevice */ + if (IopStartDevice(DeviceNode) != STATUS_SUCCESS) + { + DPRINT1("Restart after resource rebalance failed\n"); + + DeviceNode->Flags &= ~(DNF_STARTED | DNF_START_REQUEST_PENDING); + DeviceNode->Flags |= DNF_START_FAILED; + + IopRemoveDevice(DeviceNode); + } + } +} + +/* + * IopInitializePnpServices + * + * Initialize services for discovered children + * + * Parameters + * DeviceNode + * Top device node to start initializing services. + * + * Return Value + * Status + */ +NTSTATUS +IopInitializePnpServices(IN PDEVICE_NODE DeviceNode) +{ + DEVICETREE_TRAVERSE_CONTEXT Context; + + DPRINT("IopInitializePnpServices(%p)\n", DeviceNode); + + IopInitDeviceTreeTraverseContext( + &Context, + DeviceNode, + IopActionInitChildServices, + DeviceNode); + + return IopTraverseDeviceTree(&Context); +} + + +NTSTATUS +IopEnumerateDevice( + IN PDEVICE_OBJECT DeviceObject) +{ + PDEVICE_NODE DeviceNode = IopGetDeviceNode(DeviceObject); + DEVICETREE_TRAVERSE_CONTEXT Context; + PDEVICE_RELATIONS DeviceRelations; + PDEVICE_OBJECT ChildDeviceObject; + IO_STATUS_BLOCK IoStatusBlock; + PDEVICE_NODE ChildDeviceNode; + IO_STACK_LOCATION Stack; + NTSTATUS Status; + ULONG i; + + DPRINT("DeviceObject 0x%p\n", DeviceObject); + + if (DeviceNode->Flags & DNF_NEED_ENUMERATION_ONLY) + { + DeviceNode->Flags &= ~DNF_NEED_ENUMERATION_ONLY; + + DPRINT("Sending GUID_DEVICE_ARRIVAL\n"); + IopQueueTargetDeviceEvent(&GUID_DEVICE_ARRIVAL, + &DeviceNode->InstancePath); + } + + DPRINT("Sending IRP_MN_QUERY_DEVICE_RELATIONS to device stack\n"); + + Stack.Parameters.QueryDeviceRelations.Type = BusRelations; + + Status = IopInitiatePnpIrp( + DeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_DEVICE_RELATIONS, + &Stack); + if (!NT_SUCCESS(Status) || Status == STATUS_PENDING) + { + DPRINT("IopInitiatePnpIrp() failed with status 0x%08lx\n", Status); + return Status; + } + + DeviceRelations = (PDEVICE_RELATIONS)IoStatusBlock.Information; + + /* + * Send removal IRPs for devices that have disappeared + * NOTE: This code handles the case where no relations are specified + */ + IopHandleDeviceRemoval(DeviceNode, DeviceRelations); + + /* Now we bail if nothing was returned */ + if (!DeviceRelations) + { + /* We're all done */ + DPRINT("No PDOs\n"); + return STATUS_SUCCESS; + } + + DPRINT("Got %u PDOs\n", DeviceRelations->Count); + + /* + * Create device nodes for all discovered devices + */ + for (i = 0; i < DeviceRelations->Count; i++) + { + ChildDeviceObject = DeviceRelations->Objects[i]; + ASSERT((ChildDeviceObject->Flags & DO_DEVICE_INITIALIZING) == 0); + + ChildDeviceNode = IopGetDeviceNode(ChildDeviceObject); + if (!ChildDeviceNode) + { + /* One doesn't exist, create it */ + Status = IopCreateDeviceNode( + DeviceNode, + ChildDeviceObject, + NULL, + &ChildDeviceNode); + if (NT_SUCCESS(Status)) + { + /* Mark the node as enumerated */ + ChildDeviceNode->Flags |= DNF_ENUMERATED; + + /* Mark the DO as bus enumerated */ + ChildDeviceObject->Flags |= DO_BUS_ENUMERATED_DEVICE; + } + else + { + /* Ignore this DO */ + DPRINT1("IopCreateDeviceNode() failed with status 0x%08x. Skipping PDO %u\n", Status, i); + ObDereferenceObject(ChildDeviceObject); + } + } + else + { + /* Mark it as enumerated */ + ChildDeviceNode->Flags |= DNF_ENUMERATED; + ObDereferenceObject(ChildDeviceObject); + } + } + ExFreePool(DeviceRelations); + + /* + * Retrieve information about all discovered children from the bus driver + */ + IopInitDeviceTreeTraverseContext( + &Context, + DeviceNode, + IopActionInterrogateDeviceStack, + DeviceNode); + + Status = IopTraverseDeviceTree(&Context); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopTraverseDeviceTree() failed with status 0x%08lx\n", Status); + return Status; + } + + /* + * Retrieve configuration from the registry for discovered children + */ + IopInitDeviceTreeTraverseContext( + &Context, + DeviceNode, + IopActionConfigureChildServices, + DeviceNode); + + Status = IopTraverseDeviceTree(&Context); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopTraverseDeviceTree() failed with status 0x%08lx\n", Status); + return Status; + } + + /* + * Initialize services for discovered children. + */ + Status = IopInitializePnpServices(DeviceNode); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopInitializePnpServices() failed with status 0x%08lx\n", Status); + return Status; + } + + DPRINT("IopEnumerateDevice() finished\n"); + return STATUS_SUCCESS; +} + +static +NTSTATUS +NTAPI +IopSendEject(IN PDEVICE_OBJECT DeviceObject) +{ + IO_STACK_LOCATION Stack; + PVOID Dummy; + + RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); + Stack.MajorFunction = IRP_MJ_PNP; + Stack.MinorFunction = IRP_MN_EJECT; + + return IopSynchronousCall(DeviceObject, &Stack, &Dummy); +} + +/* + * @implemented + */ +VOID +NTAPI +IoRequestDeviceEject(IN PDEVICE_OBJECT PhysicalDeviceObject) +{ + PDEVICE_NODE DeviceNode = IopGetDeviceNode(PhysicalDeviceObject); + PDEVICE_RELATIONS DeviceRelations; + IO_STATUS_BLOCK IoStatusBlock; + IO_STACK_LOCATION Stack; + DEVICE_CAPABILITIES Capabilities; + NTSTATUS Status; + + IopQueueTargetDeviceEvent(&GUID_DEVICE_KERNEL_INITIATED_EJECT, + &DeviceNode->InstancePath); + + if (IopQueryDeviceCapabilities(DeviceNode, &Capabilities) != STATUS_SUCCESS) + { + goto cleanup; + } + + Stack.Parameters.QueryDeviceRelations.Type = EjectionRelations; + + Status = IopInitiatePnpIrp(PhysicalDeviceObject, + &IoStatusBlock, + IRP_MN_QUERY_DEVICE_RELATIONS, + &Stack); + if (!NT_SUCCESS(Status)) + { + DPRINT("IopInitiatePnpIrp() failed with status 0x%08lx\n", Status); + DeviceRelations = NULL; + } + else + { + DeviceRelations = (PDEVICE_RELATIONS)IoStatusBlock.Information; + } + + if (DeviceRelations) + { + Status = IopQueryRemoveDeviceRelations(DeviceRelations, FALSE); + if (!NT_SUCCESS(Status)) + goto cleanup; + } + + Status = IopQueryRemoveChildDevices(DeviceNode, FALSE); + if (!NT_SUCCESS(Status)) + { + if (DeviceRelations) + IopCancelRemoveDeviceRelations(DeviceRelations); + goto cleanup; + } + + if (IopPrepareDeviceForRemoval(PhysicalDeviceObject, FALSE) != STATUS_SUCCESS) + { + if (DeviceRelations) + IopCancelRemoveDeviceRelations(DeviceRelations); + IopCancelRemoveChildDevices(DeviceNode); + goto cleanup; + } + + if (DeviceRelations) + IopSendRemoveDeviceRelations(DeviceRelations); + IopSendRemoveChildDevices(DeviceNode); + + DeviceNode->Problem = CM_PROB_HELD_FOR_EJECT; + if (Capabilities.EjectSupported) + { + if (IopSendEject(PhysicalDeviceObject) != STATUS_SUCCESS) + { + goto cleanup; + } + } + else + { + DeviceNode->Flags |= DNF_DISABLED; + } + + IopQueueTargetDeviceEvent(&GUID_DEVICE_EJECT, + &DeviceNode->InstancePath); + + return; + +cleanup: + IopQueueTargetDeviceEvent(&GUID_DEVICE_EJECT_VETOED, + &DeviceNode->InstancePath); +} + +static +VOID +NTAPI +IopDeviceActionWorker( + _In_ PVOID Context) +{ + PLIST_ENTRY ListEntry; + PDEVICE_ACTION_DATA Data; + KIRQL OldIrql; + + KeAcquireSpinLock(&IopDeviceActionLock, &OldIrql); + while (!IsListEmpty(&IopDeviceActionRequestList)) + { + ListEntry = RemoveHeadList(&IopDeviceActionRequestList); + KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); + Data = CONTAINING_RECORD(ListEntry, + DEVICE_ACTION_DATA, + RequestListEntry); + + switch (Data->Action) + { + case DeviceActionInvalidateDeviceRelations: + IoSynchronousInvalidateDeviceRelations(Data->DeviceObject, + Data->InvalidateDeviceRelations.Type); + break; + + default: + DPRINT1("Unimplemented device action %u\n", Data->Action); + break; + } + + ObDereferenceObject(Data->DeviceObject); + ExFreePoolWithTag(Data, TAG_IO); + KeAcquireSpinLock(&IopDeviceActionLock, &OldIrql); + } + IopDeviceActionInProgress = FALSE; + KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); +} + +VOID +IopQueueDeviceAction( + _In_ PDEVICE_ACTION_DATA ActionData) +{ + PDEVICE_ACTION_DATA Data; + KIRQL OldIrql; + + DPRINT("IopQueueDeviceAction(%p)\n", ActionData); + + Data = ExAllocatePoolWithTag(NonPagedPool, + sizeof(DEVICE_ACTION_DATA), + TAG_IO); + if (!Data) + return; + + ObReferenceObject(ActionData->DeviceObject); + RtlCopyMemory(Data, ActionData, sizeof(DEVICE_ACTION_DATA)); + + DPRINT("Action %u\n", Data->Action); + + KeAcquireSpinLock(&IopDeviceActionLock, &OldIrql); + InsertTailList(&IopDeviceActionRequestList, &Data->RequestListEntry); + if (IopDeviceActionInProgress) + { + KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); + return; + } + IopDeviceActionInProgress = TRUE; + KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); + + ExInitializeWorkItem(&IopDeviceActionWorkItem, + IopDeviceActionWorker, + NULL); + ExQueueWorkItem(&IopDeviceActionWorkItem, + DelayedWorkQueue); +} diff --git a/ntoskrnl/io/pnpmgr/pnpmgr.c b/ntoskrnl/io/pnpmgr/pnpmgr.c index 436e1376f9a..8b9c92ca466 100644 --- a/ntoskrnl/io/pnpmgr/pnpmgr.c +++ b/ntoskrnl/io/pnpmgr/pnpmgr.c @@ -19,35 +19,15 @@ ERESOURCE PpRegistryDeviceResource; KGUARDED_MUTEX PpDeviceReferenceTableLock; RTL_AVL_TABLE PpDeviceReferenceTable; -extern ERESOURCE IopDriverLoadResource; extern ULONG ExpInitializationPhase; -extern BOOLEAN PnpSystemInit; -extern PDEVICE_NODE IopRootDeviceNode; - -#define MAX_DEVICE_ID_LEN 200 -#define MAX_SEPARATORS_INSTANCEID 0 -#define MAX_SEPARATORS_DEVICEID 1 /* DATA **********************************************************************/ PDRIVER_OBJECT IopRootDriverObject; PIO_BUS_TYPE_GUID_LIST PnpBusTypeGuidList = NULL; -LIST_ENTRY IopDeviceActionRequestList; -WORK_QUEUE_ITEM IopDeviceActionWorkItem; -BOOLEAN IopDeviceActionInProgress; -KSPIN_LOCK IopDeviceActionLock; /* FUNCTIONS *****************************************************************/ -VOID -IopCancelPrepareDeviceForRemoval(PDEVICE_OBJECT DeviceObject); - -NTSTATUS -IopPrepareDeviceForRemoval(PDEVICE_OBJECT DeviceObject, BOOLEAN Force); - -PDEVICE_OBJECT -IopGetDeviceObjectFromDeviceInstance(PUNICODE_STRING DeviceInstance); - VOID IopFixupDeviceId(PWCHAR String) { @@ -478,2380 +458,565 @@ IopInitializeDevice(PDEVICE_NODE DeviceNode, return STATUS_SUCCESS; } -static -NTSTATUS -NTAPI -IopSendEject(IN PDEVICE_OBJECT DeviceObject) -{ - IO_STACK_LOCATION Stack; - PVOID Dummy; - - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_EJECT; - - return IopSynchronousCall(DeviceObject, &Stack, &Dummy); -} - -static -VOID -NTAPI -IopSendSurpriseRemoval(IN PDEVICE_OBJECT DeviceObject) -{ - IO_STACK_LOCATION Stack; - PVOID Dummy; - - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_SURPRISE_REMOVAL; - - /* Drivers should never fail a IRP_MN_SURPRISE_REMOVAL request */ - IopSynchronousCall(DeviceObject, &Stack, &Dummy); -} - -static NTSTATUS -NTAPI -IopQueryRemoveDevice(IN PDEVICE_OBJECT DeviceObject) +IopGetSystemPowerDeviceObject(PDEVICE_OBJECT *DeviceObject) { - PDEVICE_NODE DeviceNode = IopGetDeviceNode(DeviceObject); - IO_STACK_LOCATION Stack; - PVOID Dummy; - NTSTATUS Status; - - ASSERT(DeviceNode); - - IopQueueTargetDeviceEvent(&GUID_DEVICE_REMOVE_PENDING, - &DeviceNode->InstancePath); - - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_QUERY_REMOVE_DEVICE; - - Status = IopSynchronousCall(DeviceObject, &Stack, &Dummy); - - IopNotifyPlugPlayNotification(DeviceObject, - EventCategoryTargetDeviceChange, - &GUID_TARGET_DEVICE_QUERY_REMOVE, - NULL, - NULL); + KIRQL OldIrql; - if (!NT_SUCCESS(Status)) + if (PopSystemPowerDeviceNode) { - DPRINT1("Removal vetoed by %wZ\n", &DeviceNode->InstancePath); - IopQueueTargetDeviceEvent(&GUID_DEVICE_REMOVAL_VETOED, - &DeviceNode->InstancePath); - } - - return Status; -} - -static -NTSTATUS -NTAPI -IopQueryStopDevice(IN PDEVICE_OBJECT DeviceObject) -{ - IO_STACK_LOCATION Stack; - PVOID Dummy; - - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_QUERY_STOP_DEVICE; - - return IopSynchronousCall(DeviceObject, &Stack, &Dummy); -} - -static -VOID -NTAPI -IopSendRemoveDevice(IN PDEVICE_OBJECT DeviceObject) -{ - IO_STACK_LOCATION Stack; - PVOID Dummy; - PDEVICE_NODE DeviceNode = IopGetDeviceNode(DeviceObject); - - /* Drop all our state for this device in case it isn't really going away */ - DeviceNode->Flags &= DNF_ENUMERATED | DNF_PROCESSED; - - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_REMOVE_DEVICE; - - /* Drivers should never fail a IRP_MN_REMOVE_DEVICE request */ - IopSynchronousCall(DeviceObject, &Stack, &Dummy); - - IopNotifyPlugPlayNotification(DeviceObject, - EventCategoryTargetDeviceChange, - &GUID_TARGET_DEVICE_REMOVE_COMPLETE, - NULL, - NULL); - ObDereferenceObject(DeviceObject); -} - -static -VOID -NTAPI -IopCancelRemoveDevice(IN PDEVICE_OBJECT DeviceObject) -{ - IO_STACK_LOCATION Stack; - PVOID Dummy; - - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_CANCEL_REMOVE_DEVICE; + KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); + *DeviceObject = PopSystemPowerDeviceNode->PhysicalDeviceObject; + KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); - /* Drivers should never fail a IRP_MN_CANCEL_REMOVE_DEVICE request */ - IopSynchronousCall(DeviceObject, &Stack, &Dummy); + return STATUS_SUCCESS; + } - IopNotifyPlugPlayNotification(DeviceObject, - EventCategoryTargetDeviceChange, - &GUID_TARGET_DEVICE_REMOVE_CANCELLED, - NULL, - NULL); + return STATUS_UNSUCCESSFUL; } -static -VOID +USHORT NTAPI -IopSendStopDevice(IN PDEVICE_OBJECT DeviceObject) -{ - IO_STACK_LOCATION Stack; - PVOID Dummy; - - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_STOP_DEVICE; - - /* Drivers should never fail a IRP_MN_STOP_DEVICE request */ - IopSynchronousCall(DeviceObject, &Stack, &Dummy); -} - -static -NTSTATUS -IopSetServiceEnumData(PDEVICE_NODE DeviceNode) +IopGetBusTypeGuidIndex(LPGUID BusTypeGuid) { - UNICODE_STRING ServicesKeyPath = RTL_CONSTANT_STRING(L"\\Registry\\Machine\\System\\CurrentControlSet\\Services\\"); - UNICODE_STRING ServiceKeyName; - UNICODE_STRING EnumKeyName; - UNICODE_STRING ValueName; - PKEY_VALUE_FULL_INFORMATION KeyValueInformation; - HANDLE ServiceKey = NULL, ServiceEnumKey = NULL; - ULONG Disposition; - ULONG Count = 0, NextInstance = 0; - WCHAR ValueBuffer[6]; - NTSTATUS Status = STATUS_SUCCESS; + USHORT i = 0, FoundIndex = 0xFFFF; + ULONG NewSize; + PVOID NewList; - DPRINT("IopSetServiceEnumData(%p)\n", DeviceNode); - DPRINT("Instance: %wZ\n", &DeviceNode->InstancePath); - DPRINT("Service: %wZ\n", &DeviceNode->ServiceName); + /* Acquire the lock */ + ExAcquireFastMutex(&PnpBusTypeGuidList->Lock); - if (DeviceNode->ServiceName.Buffer == NULL) + /* Loop all entries */ + while (i < PnpBusTypeGuidList->GuidCount) { - DPRINT1("No service!\n"); - return STATUS_SUCCESS; + /* Try to find a match */ + if (RtlCompareMemory(BusTypeGuid, + &PnpBusTypeGuidList->Guids[i], + sizeof(GUID)) == sizeof(GUID)) + { + /* Found it */ + FoundIndex = i; + goto Quickie; + } + i++; } - ServiceKeyName.MaximumLength = ServicesKeyPath.Length + DeviceNode->ServiceName.Length + sizeof(UNICODE_NULL); - ServiceKeyName.Length = 0; - ServiceKeyName.Buffer = ExAllocatePool(PagedPool, ServiceKeyName.MaximumLength); - if (ServiceKeyName.Buffer == NULL) + /* Check if we have to grow the list */ + if (PnpBusTypeGuidList->GuidCount) { - DPRINT1("No ServiceKeyName.Buffer!\n"); - return STATUS_INSUFFICIENT_RESOURCES; - } - - RtlAppendUnicodeStringToString(&ServiceKeyName, &ServicesKeyPath); - RtlAppendUnicodeStringToString(&ServiceKeyName, &DeviceNode->ServiceName); - - DPRINT("ServiceKeyName: %wZ\n", &ServiceKeyName); + /* Calculate the new size */ + NewSize = sizeof(IO_BUS_TYPE_GUID_LIST) + + (sizeof(GUID) * PnpBusTypeGuidList->GuidCount); - Status = IopOpenRegistryKeyEx(&ServiceKey, NULL, &ServiceKeyName, KEY_CREATE_SUB_KEY); - if (!NT_SUCCESS(Status)) - { - goto done; - } + /* Allocate the new copy */ + NewList = ExAllocatePool(PagedPool, NewSize); - RtlInitUnicodeString(&EnumKeyName, L"Enum"); - Status = IopCreateRegistryKeyEx(&ServiceEnumKey, - ServiceKey, - &EnumKeyName, - KEY_SET_VALUE, - REG_OPTION_VOLATILE, - &Disposition); - if (NT_SUCCESS(Status)) - { - if (Disposition == REG_OPENED_EXISTING_KEY) + if (!NewList) { - /* Read the NextInstance value */ - Status = IopGetRegistryValue(ServiceEnumKey, - L"Count", - &KeyValueInformation); - if (!NT_SUCCESS(Status)) - goto done; - - if ((KeyValueInformation->Type == REG_DWORD) && - (KeyValueInformation->DataLength)) - { - /* Read it */ - Count = *(PULONG)((ULONG_PTR)KeyValueInformation + - KeyValueInformation->DataOffset); - } - - ExFreePool(KeyValueInformation); - KeyValueInformation = NULL; - - /* Read the NextInstance value */ - Status = IopGetRegistryValue(ServiceEnumKey, - L"NextInstance", - &KeyValueInformation); - if (!NT_SUCCESS(Status)) - goto done; - - if ((KeyValueInformation->Type == REG_DWORD) && - (KeyValueInformation->DataLength)) - { - NextInstance = *(PULONG)((ULONG_PTR)KeyValueInformation + - KeyValueInformation->DataOffset); - } - - ExFreePool(KeyValueInformation); - KeyValueInformation = NULL; + /* Fail */ + ExFreePool(PnpBusTypeGuidList); + goto Quickie; } - /* Set the instance path */ - swprintf(ValueBuffer, L"%lu", NextInstance); - RtlInitUnicodeString(&ValueName, ValueBuffer); - Status = ZwSetValueKey(ServiceEnumKey, - &ValueName, - 0, - REG_SZ, - DeviceNode->InstancePath.Buffer, - DeviceNode->InstancePath.MaximumLength); - if (!NT_SUCCESS(Status)) - goto done; - - /* Increment Count and NextInstance */ - Count++; - NextInstance++; + /* Now copy them, decrease the size too */ + NewSize -= sizeof(GUID); + RtlCopyMemory(NewList, PnpBusTypeGuidList, NewSize); - /* Set the new Count value */ - RtlInitUnicodeString(&ValueName, L"Count"); - Status = ZwSetValueKey(ServiceEnumKey, - &ValueName, - 0, - REG_DWORD, - &Count, - sizeof(Count)); - if (!NT_SUCCESS(Status)) - goto done; + /* Free the old list */ + ExFreePool(PnpBusTypeGuidList); - /* Set the new NextInstance value */ - RtlInitUnicodeString(&ValueName, L"NextInstance"); - Status = ZwSetValueKey(ServiceEnumKey, - &ValueName, - 0, - REG_DWORD, - &NextInstance, - sizeof(NextInstance)); + /* Use the new buffer */ + PnpBusTypeGuidList = NewList; } -done: - if (ServiceEnumKey != NULL) - ZwClose(ServiceEnumKey); - - if (ServiceKey != NULL) - ZwClose(ServiceKey); + /* Copy the new GUID */ + RtlCopyMemory(&PnpBusTypeGuidList->Guids[PnpBusTypeGuidList->GuidCount], + BusTypeGuid, + sizeof(GUID)); - ExFreePool(ServiceKeyName.Buffer); + /* The new entry is the index */ + FoundIndex = (USHORT)PnpBusTypeGuidList->GuidCount; + PnpBusTypeGuidList->GuidCount++; - return Status; +Quickie: + ExReleaseFastMutex(&PnpBusTypeGuidList->Lock); + return FoundIndex; } -VOID +NTSTATUS NTAPI -IopStartDevice2(IN PDEVICE_OBJECT DeviceObject) +IopSynchronousCall(IN PDEVICE_OBJECT DeviceObject, + IN PIO_STACK_LOCATION IoStackLocation, + OUT PVOID *Information) { - IO_STACK_LOCATION Stack; - PDEVICE_NODE DeviceNode; + PIRP Irp; + PIO_STACK_LOCATION IrpStack; + IO_STATUS_BLOCK IoStatusBlock; + KEVENT Event; NTSTATUS Status; - PVOID Dummy; - DEVICE_CAPABILITIES DeviceCapabilities; - - /* Get the device node */ - DeviceNode = IopGetDeviceNode(DeviceObject); + PDEVICE_OBJECT TopDeviceObject; + PAGED_CODE(); - ASSERT(!(DeviceNode->Flags & DNF_DISABLED)); + /* Call the top of the device stack */ + TopDeviceObject = IoGetAttachedDeviceReference(DeviceObject); - /* Build the I/O stack location */ - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.MajorFunction = IRP_MJ_PNP; - Stack.MinorFunction = IRP_MN_START_DEVICE; + /* Allocate an IRP */ + Irp = IoAllocateIrp(TopDeviceObject->StackSize, FALSE); + if (!Irp) return STATUS_INSUFFICIENT_RESOURCES; - Stack.Parameters.StartDevice.AllocatedResources = - DeviceNode->ResourceList; - Stack.Parameters.StartDevice.AllocatedResourcesTranslated = - DeviceNode->ResourceListTranslated; + /* Initialize to failure */ + Irp->IoStatus.Status = IoStatusBlock.Status = STATUS_NOT_SUPPORTED; + Irp->IoStatus.Information = IoStatusBlock.Information = 0; - /* Do the call */ - Status = IopSynchronousCall(DeviceObject, &Stack, &Dummy); - if (!NT_SUCCESS(Status)) + /* Special case for IRP_MN_FILTER_RESOURCE_REQUIREMENTS */ + if ((IoStackLocation->MajorFunction == IRP_MJ_PNP) && + (IoStackLocation->MinorFunction == IRP_MN_FILTER_RESOURCE_REQUIREMENTS)) { - /* Send an IRP_MN_REMOVE_DEVICE request */ - IopRemoveDevice(DeviceNode); + /* Copy the resource requirements list into the IOSB */ + Irp->IoStatus.Information = + IoStatusBlock.Information = (ULONG_PTR)IoStackLocation->Parameters.FilterResourceRequirements.IoResourceRequirementList; + } - /* Set the appropriate flag */ - DeviceNode->Flags |= DNF_START_FAILED; - DeviceNode->Problem = CM_PROB_FAILED_START; + /* Initialize the event */ + KeInitializeEvent(&Event, SynchronizationEvent, FALSE); - DPRINT1("Warning: PnP Start failed (%wZ) [Status: 0x%x]\n", &DeviceNode->InstancePath, Status); - return; - } + /* Set them up */ + Irp->UserIosb = &IoStatusBlock; + Irp->UserEvent = &Event; + + /* Queue the IRP */ + Irp->Tail.Overlay.Thread = PsGetCurrentThread(); + IoQueueThreadIrp(Irp); - DPRINT("Sending IRP_MN_QUERY_CAPABILITIES to device stack (after start)\n"); + /* Copy-in the stack */ + IrpStack = IoGetNextIrpStackLocation(Irp); + *IrpStack = *IoStackLocation; - Status = IopQueryDeviceCapabilities(DeviceNode, &DeviceCapabilities); - if (!NT_SUCCESS(Status)) + /* Call the driver */ + Status = IoCallDriver(TopDeviceObject, Irp); + if (Status == STATUS_PENDING) { - DPRINT("IopInitiatePnpIrp() failed (Status 0x%08lx)\n", Status); + /* Wait for it */ + KeWaitForSingleObject(&Event, + Executive, + KernelMode, + FALSE, + NULL); + Status = IoStatusBlock.Status; } - /* Invalidate device state so IRP_MN_QUERY_PNP_DEVICE_STATE is sent */ - IoInvalidateDeviceState(DeviceObject); - - /* Otherwise, mark us as started */ - DeviceNode->Flags |= DNF_STARTED; - DeviceNode->Flags &= ~DNF_STOPPED; + /* Remove the reference */ + ObDereferenceObject(TopDeviceObject); - /* We now need enumeration */ - DeviceNode->Flags |= DNF_NEED_ENUMERATION_ONLY; + /* Return the information */ + *Information = (PVOID)IoStatusBlock.Information; + return Status; } NTSTATUS NTAPI -IopStartAndEnumerateDevice(IN PDEVICE_NODE DeviceNode) +IopInitiatePnpIrp(IN PDEVICE_OBJECT DeviceObject, + IN OUT PIO_STATUS_BLOCK IoStatusBlock, + IN UCHAR MinorFunction, + IN PIO_STACK_LOCATION Stack OPTIONAL) { - PDEVICE_OBJECT DeviceObject; - NTSTATUS Status; - PAGED_CODE(); - - /* Sanity check */ - ASSERT((DeviceNode->Flags & DNF_ADDED)); - ASSERT((DeviceNode->Flags & (DNF_RESOURCE_ASSIGNED | - DNF_RESOURCE_REPORTED | - DNF_NO_RESOURCE_REQUIRED))); - - /* Get the device object */ - DeviceObject = DeviceNode->PhysicalDeviceObject; - - /* Check if we're not started yet */ - if (!(DeviceNode->Flags & DNF_STARTED)) - { - /* Start us */ - IopStartDevice2(DeviceObject); - } + IO_STACK_LOCATION IoStackLocation; - /* Do we need to query IDs? This happens in the case of manual reporting */ -#if 0 - if (DeviceNode->Flags & DNF_NEED_QUERY_IDS) + /* Fill out the stack information */ + RtlZeroMemory(&IoStackLocation, sizeof(IO_STACK_LOCATION)); + IoStackLocation.MajorFunction = IRP_MJ_PNP; + IoStackLocation.MinorFunction = MinorFunction; + if (Stack) { - DPRINT1("Warning: Device node has DNF_NEED_QUERY_IDS\n"); - /* And that case shouldn't happen yet */ - ASSERT(FALSE); + /* Copy the rest */ + RtlCopyMemory(&IoStackLocation.Parameters, + &Stack->Parameters, + sizeof(Stack->Parameters)); } -#endif - IopSetServiceEnumData(DeviceNode); - - /* Make sure we're started, and check if we need enumeration */ - if ((DeviceNode->Flags & DNF_STARTED) && - (DeviceNode->Flags & DNF_NEED_ENUMERATION_ONLY)) - { - /* Enumerate us */ - IoSynchronousInvalidateDeviceRelations(DeviceObject, BusRelations); - Status = STATUS_SUCCESS; - } - else - { - /* Nothing to do */ - Status = STATUS_SUCCESS; - } - - /* Return */ - return Status; -} + /* Do the PnP call */ + IoStatusBlock->Status = IopSynchronousCall(DeviceObject, + &IoStackLocation, + (PVOID)&IoStatusBlock->Information); + return IoStatusBlock->Status; +} +/* + * IopCreateDeviceKeyPath + * + * Creates a registry key + * + * Parameters + * RegistryPath + * Name of the key to be created. + * Handle + * Handle to the newly created key + * + * Remarks + * This method can create nested trees, so parent of RegistryPath can + * be not existant, and will be created if needed. + */ NTSTATUS -IopStopDevice( - PDEVICE_NODE DeviceNode) +NTAPI +IopCreateDeviceKeyPath(IN PCUNICODE_STRING RegistryPath, + IN ULONG CreateOptions, + OUT PHANDLE Handle) { + UNICODE_STRING EnumU = RTL_CONSTANT_STRING(ENUM_ROOT); + HANDLE hParent = NULL, hKey; + OBJECT_ATTRIBUTES ObjectAttributes; + UNICODE_STRING KeyName; + PCWSTR Current, Last; + USHORT Length; NTSTATUS Status; - DPRINT("Stopping device: %wZ\n", &DeviceNode->InstancePath); + /* Assume failure */ + *Handle = NULL; + + /* Open root key for device instances */ + Status = IopOpenRegistryKeyEx(&hParent, NULL, &EnumU, KEY_CREATE_SUB_KEY); + if (!NT_SUCCESS(Status)) + { + DPRINT1("ZwOpenKey('%wZ') failed with status 0x%08lx\n", &EnumU, Status); + return Status; + } + + Current = KeyName.Buffer = RegistryPath->Buffer; + Last = &RegistryPath->Buffer[RegistryPath->Length / sizeof(WCHAR)]; - Status = IopQueryStopDevice(DeviceNode->PhysicalDeviceObject); - if (NT_SUCCESS(Status)) + /* Go up to the end of the string */ + while (Current <= Last) { - IopSendStopDevice(DeviceNode->PhysicalDeviceObject); + if (Current != Last && *Current != L'\\') + { + /* Not the end of the string and not a separator */ + Current++; + continue; + } - DeviceNode->Flags &= ~(DNF_STARTED | DNF_START_REQUEST_PENDING); - DeviceNode->Flags |= DNF_STOPPED; + /* Prepare relative key name */ + Length = (USHORT)((ULONG_PTR)Current - (ULONG_PTR)KeyName.Buffer); + KeyName.MaximumLength = KeyName.Length = Length; + DPRINT("Create '%wZ'\n", &KeyName); - return STATUS_SUCCESS; + /* Open key */ + InitializeObjectAttributes(&ObjectAttributes, + &KeyName, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, + hParent, + NULL); + Status = ZwCreateKey(&hKey, + Current == Last ? KEY_ALL_ACCESS : KEY_CREATE_SUB_KEY, + &ObjectAttributes, + 0, + NULL, + CreateOptions, + NULL); + + /* Close parent key handle, we don't need it anymore */ + if (hParent) + ZwClose(hParent); + + /* Key opening/creating failed? */ + if (!NT_SUCCESS(Status)) + { + DPRINT1("ZwCreateKey('%wZ') failed with status 0x%08lx\n", &KeyName, Status); + return Status; + } + + /* Check if it is the end of the string */ + if (Current == Last) + { + /* Yes, return success */ + *Handle = hKey; + return STATUS_SUCCESS; + } + + /* Start with this new parent key */ + hParent = hKey; + Current++; + KeyName.Buffer = (PWSTR)Current; } - return Status; + return STATUS_UNSUCCESSFUL; } NTSTATUS -IopStartDevice( - PDEVICE_NODE DeviceNode) +IopSetDeviceInstanceData(HANDLE InstanceKey, + PDEVICE_NODE DeviceNode) { - NTSTATUS Status; - HANDLE InstanceHandle = NULL, ControlHandle = NULL; - UNICODE_STRING KeyName, ValueString; OBJECT_ATTRIBUTES ObjectAttributes; + UNICODE_STRING KeyName; + HANDLE LogConfKey, ControlKey, DeviceParamsKey; + ULONG ResCount; + ULONG ResultLength; + NTSTATUS Status; - if (DeviceNode->Flags & DNF_DISABLED) - return STATUS_SUCCESS; - - Status = IopAssignDeviceResources(DeviceNode); - if (!NT_SUCCESS(Status)) - goto ByeBye; - - /* New PnP ABI */ - IopStartAndEnumerateDevice(DeviceNode); - - /* FIX: Should be done in new device instance code */ - Status = IopCreateDeviceKeyPath(&DeviceNode->InstancePath, REG_OPTION_NON_VOLATILE, &InstanceHandle); - if (!NT_SUCCESS(Status)) - goto ByeBye; + DPRINT("IopSetDeviceInstanceData() called\n"); - /* FIX: Should be done in IoXxxPrepareDriverLoading */ - // { - RtlInitUnicodeString(&KeyName, L"Control"); + /* Create the 'LogConf' key */ + RtlInitUnicodeString(&KeyName, L"LogConf"); InitializeObjectAttributes(&ObjectAttributes, &KeyName, OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, - InstanceHandle, + InstanceKey, NULL); - Status = ZwCreateKey(&ControlHandle, - KEY_SET_VALUE, + Status = ZwCreateKey(&LogConfKey, + KEY_ALL_ACCESS, &ObjectAttributes, 0, NULL, + // FIXME? In r53694 it was silently turned from non-volatile into this, + // without any extra warning. Is this still needed?? REG_OPTION_VOLATILE, NULL); - if (!NT_SUCCESS(Status)) - goto ByeBye; - - RtlInitUnicodeString(&KeyName, L"ActiveService"); - ValueString = DeviceNode->ServiceName; - if (!ValueString.Buffer) - RtlInitUnicodeString(&ValueString, L""); - Status = ZwSetValueKey(ControlHandle, &KeyName, 0, REG_SZ, ValueString.Buffer, ValueString.Length + sizeof(UNICODE_NULL)); - // } - -ByeBye: - if (ControlHandle != NULL) - ZwClose(ControlHandle); - - if (InstanceHandle != NULL) - ZwClose(InstanceHandle); - - return Status; -} - -NTSTATUS -NTAPI -IopQueryDeviceCapabilities(PDEVICE_NODE DeviceNode, - PDEVICE_CAPABILITIES DeviceCaps) -{ - IO_STATUS_BLOCK StatusBlock; - IO_STACK_LOCATION Stack; - NTSTATUS Status; - HANDLE InstanceKey; - UNICODE_STRING ValueName; - - /* Set up the Header */ - RtlZeroMemory(DeviceCaps, sizeof(DEVICE_CAPABILITIES)); - DeviceCaps->Size = sizeof(DEVICE_CAPABILITIES); - DeviceCaps->Version = 1; - DeviceCaps->Address = -1; - DeviceCaps->UINumber = -1; - - /* Set up the Stack */ - RtlZeroMemory(&Stack, sizeof(IO_STACK_LOCATION)); - Stack.Parameters.DeviceCapabilities.Capabilities = DeviceCaps; - - /* Send the IRP */ - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &StatusBlock, - IRP_MN_QUERY_CAPABILITIES, - &Stack); - if (!NT_SUCCESS(Status)) - { - if (Status != STATUS_NOT_SUPPORTED) - { - DPRINT1("IRP_MN_QUERY_CAPABILITIES failed with status 0x%lx\n", Status); - } - return Status; - } - - /* Map device capabilities to capability flags */ - DeviceNode->CapabilityFlags = 0; - if (DeviceCaps->LockSupported) - DeviceNode->CapabilityFlags |= 0x00000001; // CM_DEVCAP_LOCKSUPPORTED - - if (DeviceCaps->EjectSupported) - DeviceNode->CapabilityFlags |= 0x00000002; // CM_DEVCAP_EJECTSUPPORTED - - if (DeviceCaps->Removable) - DeviceNode->CapabilityFlags |= 0x00000004; // CM_DEVCAP_REMOVABLE - - if (DeviceCaps->DockDevice) - DeviceNode->CapabilityFlags |= 0x00000008; // CM_DEVCAP_DOCKDEVICE - - if (DeviceCaps->UniqueID) - DeviceNode->CapabilityFlags |= 0x00000010; // CM_DEVCAP_UNIQUEID - - if (DeviceCaps->SilentInstall) - DeviceNode->CapabilityFlags |= 0x00000020; // CM_DEVCAP_SILENTINSTALL - - if (DeviceCaps->RawDeviceOK) - DeviceNode->CapabilityFlags |= 0x00000040; // CM_DEVCAP_RAWDEVICEOK - - if (DeviceCaps->SurpriseRemovalOK) - DeviceNode->CapabilityFlags |= 0x00000080; // CM_DEVCAP_SURPRISEREMOVALOK - - if (DeviceCaps->HardwareDisabled) - DeviceNode->CapabilityFlags |= 0x00000100; // CM_DEVCAP_HARDWAREDISABLED - - if (DeviceCaps->NonDynamic) - DeviceNode->CapabilityFlags |= 0x00000200; // CM_DEVCAP_NONDYNAMIC - - if (DeviceCaps->NoDisplayInUI) - DeviceNode->UserFlags |= DNUF_DONT_SHOW_IN_UI; - else - DeviceNode->UserFlags &= ~DNUF_DONT_SHOW_IN_UI; - - Status = IopCreateDeviceKeyPath(&DeviceNode->InstancePath, REG_OPTION_NON_VOLATILE, &InstanceKey); if (NT_SUCCESS(Status)) { - /* Set 'Capabilities' value */ - RtlInitUnicodeString(&ValueName, L"Capabilities"); - Status = ZwSetValueKey(InstanceKey, - &ValueName, - 0, - REG_DWORD, - &DeviceNode->CapabilityFlags, - sizeof(ULONG)); - - /* Set 'UINumber' value */ - if (DeviceCaps->UINumber != MAXULONG) + /* Set 'BootConfig' value */ + if (DeviceNode->BootResources != NULL) { - RtlInitUnicodeString(&ValueName, L"UINumber"); - Status = ZwSetValueKey(InstanceKey, - &ValueName, - 0, - REG_DWORD, - &DeviceCaps->UINumber, - sizeof(ULONG)); + ResCount = DeviceNode->BootResources->Count; + if (ResCount != 0) + { + RtlInitUnicodeString(&KeyName, L"BootConfig"); + Status = ZwSetValueKey(LogConfKey, + &KeyName, + 0, + REG_RESOURCE_LIST, + DeviceNode->BootResources, + PnpDetermineResourceListSize(DeviceNode->BootResources)); + } } - ZwClose(InstanceKey); - } - - return Status; -} - -static -VOID -NTAPI -IopDeviceActionWorker( - _In_ PVOID Context) -{ - PLIST_ENTRY ListEntry; - PDEVICE_ACTION_DATA Data; - KIRQL OldIrql; - - KeAcquireSpinLock(&IopDeviceActionLock, &OldIrql); - while (!IsListEmpty(&IopDeviceActionRequestList)) - { - ListEntry = RemoveHeadList(&IopDeviceActionRequestList); - KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); - Data = CONTAINING_RECORD(ListEntry, - DEVICE_ACTION_DATA, - RequestListEntry); - - switch (Data->Action) + /* Set 'BasicConfigVector' value */ + if (DeviceNode->ResourceRequirements != NULL && + DeviceNode->ResourceRequirements->ListSize != 0) { - case DeviceActionInvalidateDeviceRelations: - IoSynchronousInvalidateDeviceRelations(Data->DeviceObject, - Data->InvalidateDeviceRelations.Type); - break; - - default: - DPRINT1("Unimplemented device action %u\n", Data->Action); - break; + RtlInitUnicodeString(&KeyName, L"BasicConfigVector"); + Status = ZwSetValueKey(LogConfKey, + &KeyName, + 0, + REG_RESOURCE_REQUIREMENTS_LIST, + DeviceNode->ResourceRequirements, + DeviceNode->ResourceRequirements->ListSize); } - ObDereferenceObject(Data->DeviceObject); - ExFreePoolWithTag(Data, TAG_IO); - KeAcquireSpinLock(&IopDeviceActionLock, &OldIrql); + ZwClose(LogConfKey); } - IopDeviceActionInProgress = FALSE; - KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); -} - -VOID -IopQueueDeviceAction( - _In_ PDEVICE_ACTION_DATA ActionData) -{ - PDEVICE_ACTION_DATA Data; - KIRQL OldIrql; - - DPRINT("IopQueueDeviceAction(%p)\n", ActionData); - - Data = ExAllocatePoolWithTag(NonPagedPool, - sizeof(DEVICE_ACTION_DATA), - TAG_IO); - if (!Data) - return; - ObReferenceObject(ActionData->DeviceObject); - RtlCopyMemory(Data, ActionData, sizeof(DEVICE_ACTION_DATA)); - - DPRINT("Action %u\n", Data->Action); - - KeAcquireSpinLock(&IopDeviceActionLock, &OldIrql); - InsertTailList(&IopDeviceActionRequestList, &Data->RequestListEntry); - if (IopDeviceActionInProgress) + /* Set the 'ConfigFlags' value */ + RtlInitUnicodeString(&KeyName, L"ConfigFlags"); + Status = ZwQueryValueKey(InstanceKey, + &KeyName, + KeyValueBasicInformation, + NULL, + 0, + &ResultLength); + if (Status == STATUS_OBJECT_NAME_NOT_FOUND) { - KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); - return; + /* Write the default value */ + ULONG DefaultConfigFlags = 0; + Status = ZwSetValueKey(InstanceKey, + &KeyName, + 0, + REG_DWORD, + &DefaultConfigFlags, + sizeof(DefaultConfigFlags)); } - IopDeviceActionInProgress = TRUE; - KeReleaseSpinLock(&IopDeviceActionLock, OldIrql); - ExInitializeWorkItem(&IopDeviceActionWorkItem, - IopDeviceActionWorker, + /* Create the 'Control' key */ + RtlInitUnicodeString(&KeyName, L"Control"); + InitializeObjectAttributes(&ObjectAttributes, + &KeyName, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, + InstanceKey, + NULL); + Status = ZwCreateKey(&ControlKey, + 0, + &ObjectAttributes, + 0, + NULL, + REG_OPTION_VOLATILE, NULL); - ExQueueWorkItem(&IopDeviceActionWorkItem, - DelayedWorkQueue); -} - -NTSTATUS -IopGetSystemPowerDeviceObject(PDEVICE_OBJECT *DeviceObject) -{ - KIRQL OldIrql; - - if (PopSystemPowerDeviceNode) - { - KeAcquireSpinLock(&IopDeviceTreeLock, &OldIrql); - *DeviceObject = PopSystemPowerDeviceNode->PhysicalDeviceObject; - KeReleaseSpinLock(&IopDeviceTreeLock, OldIrql); - - return STATUS_SUCCESS; - } - - return STATUS_UNSUCCESSFUL; -} - -USHORT -NTAPI -IopGetBusTypeGuidIndex(LPGUID BusTypeGuid) -{ - USHORT i = 0, FoundIndex = 0xFFFF; - ULONG NewSize; - PVOID NewList; - - /* Acquire the lock */ - ExAcquireFastMutex(&PnpBusTypeGuidList->Lock); - - /* Loop all entries */ - while (i < PnpBusTypeGuidList->GuidCount) - { - /* Try to find a match */ - if (RtlCompareMemory(BusTypeGuid, - &PnpBusTypeGuidList->Guids[i], - sizeof(GUID)) == sizeof(GUID)) - { - /* Found it */ - FoundIndex = i; - goto Quickie; - } - i++; - } - - /* Check if we have to grow the list */ - if (PnpBusTypeGuidList->GuidCount) - { - /* Calculate the new size */ - NewSize = sizeof(IO_BUS_TYPE_GUID_LIST) + - (sizeof(GUID) * PnpBusTypeGuidList->GuidCount); - - /* Allocate the new copy */ - NewList = ExAllocatePool(PagedPool, NewSize); - - if (!NewList) - { - /* Fail */ - ExFreePool(PnpBusTypeGuidList); - goto Quickie; - } - - /* Now copy them, decrease the size too */ - NewSize -= sizeof(GUID); - RtlCopyMemory(NewList, PnpBusTypeGuidList, NewSize); - - /* Free the old list */ - ExFreePool(PnpBusTypeGuidList); - - /* Use the new buffer */ - PnpBusTypeGuidList = NewList; - } - - /* Copy the new GUID */ - RtlCopyMemory(&PnpBusTypeGuidList->Guids[PnpBusTypeGuidList->GuidCount], - BusTypeGuid, - sizeof(GUID)); - - /* The new entry is the index */ - FoundIndex = (USHORT)PnpBusTypeGuidList->GuidCount; - PnpBusTypeGuidList->GuidCount++; - -Quickie: - ExReleaseFastMutex(&PnpBusTypeGuidList->Lock); - return FoundIndex; -} - -NTSTATUS -NTAPI -IopSynchronousCall(IN PDEVICE_OBJECT DeviceObject, - IN PIO_STACK_LOCATION IoStackLocation, - OUT PVOID *Information) -{ - PIRP Irp; - PIO_STACK_LOCATION IrpStack; - IO_STATUS_BLOCK IoStatusBlock; - KEVENT Event; - NTSTATUS Status; - PDEVICE_OBJECT TopDeviceObject; - PAGED_CODE(); - - /* Call the top of the device stack */ - TopDeviceObject = IoGetAttachedDeviceReference(DeviceObject); - - /* Allocate an IRP */ - Irp = IoAllocateIrp(TopDeviceObject->StackSize, FALSE); - if (!Irp) return STATUS_INSUFFICIENT_RESOURCES; - - /* Initialize to failure */ - Irp->IoStatus.Status = IoStatusBlock.Status = STATUS_NOT_SUPPORTED; - Irp->IoStatus.Information = IoStatusBlock.Information = 0; - - /* Special case for IRP_MN_FILTER_RESOURCE_REQUIREMENTS */ - if ((IoStackLocation->MajorFunction == IRP_MJ_PNP) && - (IoStackLocation->MinorFunction == IRP_MN_FILTER_RESOURCE_REQUIREMENTS)) - { - /* Copy the resource requirements list into the IOSB */ - Irp->IoStatus.Information = - IoStatusBlock.Information = (ULONG_PTR)IoStackLocation->Parameters.FilterResourceRequirements.IoResourceRequirementList; - } - - /* Initialize the event */ - KeInitializeEvent(&Event, SynchronizationEvent, FALSE); - - /* Set them up */ - Irp->UserIosb = &IoStatusBlock; - Irp->UserEvent = &Event; - - /* Queue the IRP */ - Irp->Tail.Overlay.Thread = PsGetCurrentThread(); - IoQueueThreadIrp(Irp); - - /* Copy-in the stack */ - IrpStack = IoGetNextIrpStackLocation(Irp); - *IrpStack = *IoStackLocation; - - /* Call the driver */ - Status = IoCallDriver(TopDeviceObject, Irp); - if (Status == STATUS_PENDING) - { - /* Wait for it */ - KeWaitForSingleObject(&Event, - Executive, - KernelMode, - FALSE, - NULL); - Status = IoStatusBlock.Status; - } - - /* Remove the reference */ - ObDereferenceObject(TopDeviceObject); - - /* Return the information */ - *Information = (PVOID)IoStatusBlock.Information; - return Status; -} - -NTSTATUS -NTAPI -IopInitiatePnpIrp(IN PDEVICE_OBJECT DeviceObject, - IN OUT PIO_STATUS_BLOCK IoStatusBlock, - IN UCHAR MinorFunction, - IN PIO_STACK_LOCATION Stack OPTIONAL) -{ - IO_STACK_LOCATION IoStackLocation; - - /* Fill out the stack information */ - RtlZeroMemory(&IoStackLocation, sizeof(IO_STACK_LOCATION)); - IoStackLocation.MajorFunction = IRP_MJ_PNP; - IoStackLocation.MinorFunction = MinorFunction; - if (Stack) - { - /* Copy the rest */ - RtlCopyMemory(&IoStackLocation.Parameters, - &Stack->Parameters, - sizeof(Stack->Parameters)); - } - - /* Do the PnP call */ - IoStatusBlock->Status = IopSynchronousCall(DeviceObject, - &IoStackLocation, - (PVOID)&IoStatusBlock->Information); - return IoStatusBlock->Status; -} - -/* - * IopCreateDeviceKeyPath - * - * Creates a registry key - * - * Parameters - * RegistryPath - * Name of the key to be created. - * Handle - * Handle to the newly created key - * - * Remarks - * This method can create nested trees, so parent of RegistryPath can - * be not existant, and will be created if needed. - */ -NTSTATUS -NTAPI -IopCreateDeviceKeyPath(IN PCUNICODE_STRING RegistryPath, - IN ULONG CreateOptions, - OUT PHANDLE Handle) -{ - UNICODE_STRING EnumU = RTL_CONSTANT_STRING(ENUM_ROOT); - HANDLE hParent = NULL, hKey; - OBJECT_ATTRIBUTES ObjectAttributes; - UNICODE_STRING KeyName; - PCWSTR Current, Last; - USHORT Length; - NTSTATUS Status; - - /* Assume failure */ - *Handle = NULL; - - /* Open root key for device instances */ - Status = IopOpenRegistryKeyEx(&hParent, NULL, &EnumU, KEY_CREATE_SUB_KEY); - if (!NT_SUCCESS(Status)) - { - DPRINT1("ZwOpenKey('%wZ') failed with status 0x%08lx\n", &EnumU, Status); - return Status; - } - - Current = KeyName.Buffer = RegistryPath->Buffer; - Last = &RegistryPath->Buffer[RegistryPath->Length / sizeof(WCHAR)]; - - /* Go up to the end of the string */ - while (Current <= Last) - { - if (Current != Last && *Current != L'\\') - { - /* Not the end of the string and not a separator */ - Current++; - continue; - } - - /* Prepare relative key name */ - Length = (USHORT)((ULONG_PTR)Current - (ULONG_PTR)KeyName.Buffer); - KeyName.MaximumLength = KeyName.Length = Length; - DPRINT("Create '%wZ'\n", &KeyName); - - /* Open key */ - InitializeObjectAttributes(&ObjectAttributes, - &KeyName, - OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, - hParent, - NULL); - Status = ZwCreateKey(&hKey, - Current == Last ? KEY_ALL_ACCESS : KEY_CREATE_SUB_KEY, - &ObjectAttributes, - 0, - NULL, - CreateOptions, - NULL); - - /* Close parent key handle, we don't need it anymore */ - if (hParent) - ZwClose(hParent); - - /* Key opening/creating failed? */ - if (!NT_SUCCESS(Status)) - { - DPRINT1("ZwCreateKey('%wZ') failed with status 0x%08lx\n", &KeyName, Status); - return Status; - } - - /* Check if it is the end of the string */ - if (Current == Last) - { - /* Yes, return success */ - *Handle = hKey; - return STATUS_SUCCESS; - } - - /* Start with this new parent key */ - hParent = hKey; - Current++; - KeyName.Buffer = (PWSTR)Current; - } - - return STATUS_UNSUCCESSFUL; -} - -NTSTATUS -IopSetDeviceInstanceData(HANDLE InstanceKey, - PDEVICE_NODE DeviceNode) -{ - OBJECT_ATTRIBUTES ObjectAttributes; - UNICODE_STRING KeyName; - HANDLE LogConfKey, ControlKey, DeviceParamsKey; - ULONG ResCount; - ULONG ResultLength; - NTSTATUS Status; - - DPRINT("IopSetDeviceInstanceData() called\n"); - - /* Create the 'LogConf' key */ - RtlInitUnicodeString(&KeyName, L"LogConf"); - InitializeObjectAttributes(&ObjectAttributes, - &KeyName, - OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, - InstanceKey, - NULL); - Status = ZwCreateKey(&LogConfKey, - KEY_ALL_ACCESS, - &ObjectAttributes, - 0, - NULL, - // FIXME? In r53694 it was silently turned from non-volatile into this, - // without any extra warning. Is this still needed?? - REG_OPTION_VOLATILE, - NULL); - if (NT_SUCCESS(Status)) - { - /* Set 'BootConfig' value */ - if (DeviceNode->BootResources != NULL) - { - ResCount = DeviceNode->BootResources->Count; - if (ResCount != 0) - { - RtlInitUnicodeString(&KeyName, L"BootConfig"); - Status = ZwSetValueKey(LogConfKey, - &KeyName, - 0, - REG_RESOURCE_LIST, - DeviceNode->BootResources, - PnpDetermineResourceListSize(DeviceNode->BootResources)); - } - } - - /* Set 'BasicConfigVector' value */ - if (DeviceNode->ResourceRequirements != NULL && - DeviceNode->ResourceRequirements->ListSize != 0) - { - RtlInitUnicodeString(&KeyName, L"BasicConfigVector"); - Status = ZwSetValueKey(LogConfKey, - &KeyName, - 0, - REG_RESOURCE_REQUIREMENTS_LIST, - DeviceNode->ResourceRequirements, - DeviceNode->ResourceRequirements->ListSize); - } - - ZwClose(LogConfKey); - } - - /* Set the 'ConfigFlags' value */ - RtlInitUnicodeString(&KeyName, L"ConfigFlags"); - Status = ZwQueryValueKey(InstanceKey, - &KeyName, - KeyValueBasicInformation, - NULL, - 0, - &ResultLength); - if (Status == STATUS_OBJECT_NAME_NOT_FOUND) - { - /* Write the default value */ - ULONG DefaultConfigFlags = 0; - Status = ZwSetValueKey(InstanceKey, - &KeyName, - 0, - REG_DWORD, - &DefaultConfigFlags, - sizeof(DefaultConfigFlags)); - } - - /* Create the 'Control' key */ - RtlInitUnicodeString(&KeyName, L"Control"); - InitializeObjectAttributes(&ObjectAttributes, - &KeyName, - OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, - InstanceKey, - NULL); - Status = ZwCreateKey(&ControlKey, - 0, - &ObjectAttributes, - 0, - NULL, - REG_OPTION_VOLATILE, - NULL); - if (NT_SUCCESS(Status)) - ZwClose(ControlKey); - - /* Create the 'Device Parameters' key and set the 'FirmwareIdentified' value for all ACPI-enumerated devices */ - if (_wcsnicmp(DeviceNode->InstancePath.Buffer, L"ACPI\\", 5) == 0) - { - RtlInitUnicodeString(&KeyName, L"Device Parameters"); - InitializeObjectAttributes(&ObjectAttributes, - &KeyName, - OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, - InstanceKey, - NULL); - Status = ZwCreateKey(&DeviceParamsKey, - 0, - &ObjectAttributes, - 0, - NULL, - REG_OPTION_NON_VOLATILE, - NULL); - if (NT_SUCCESS(Status)) - { - ULONG FirmwareIdentified = 1; - RtlInitUnicodeString(&KeyName, L"FirmwareIdentified"); - Status = ZwSetValueKey(DeviceParamsKey, - &KeyName, - 0, - REG_DWORD, - &FirmwareIdentified, - sizeof(FirmwareIdentified)); - - ZwClose(DeviceParamsKey); - } - } - - DPRINT("IopSetDeviceInstanceData() done\n"); - - return Status; -} - -/* - * IopGetParentIdPrefix - * - * Retrieve (or create) a string which identifies a device. - * - * Parameters - * DeviceNode - * Pointer to device node. - * ParentIdPrefix - * Pointer to the string where is returned the parent node identifier - * - * Remarks - * If the return code is STATUS_SUCCESS, the ParentIdPrefix string is - * valid and its Buffer field is NULL-terminated. The caller needs to - * to free the string with RtlFreeUnicodeString when it is no longer - * needed. - */ - -NTSTATUS -IopGetParentIdPrefix(PDEVICE_NODE DeviceNode, - PUNICODE_STRING ParentIdPrefix) -{ - const UNICODE_STRING EnumKeyPath = RTL_CONSTANT_STRING(L"\\Registry\\Machine\\System\\CurrentControlSet\\Enum\\"); - ULONG KeyNameBufferLength; - PKEY_VALUE_PARTIAL_INFORMATION ParentIdPrefixInformation = NULL; - UNICODE_STRING KeyName = {0, 0, NULL}; - UNICODE_STRING KeyValue; - UNICODE_STRING ValueName; - HANDLE hKey = NULL; - ULONG crc32; - NTSTATUS Status; - - /* HACK: As long as some devices have a NULL device - * instance path, the following test is required :( - */ - if (DeviceNode->Parent->InstancePath.Length == 0) - { - DPRINT1("Parent of %wZ has NULL Instance path, please report!\n", - &DeviceNode->InstancePath); - return STATUS_UNSUCCESSFUL; - } - - /* 1. Try to retrieve ParentIdPrefix from registry */ - KeyNameBufferLength = FIELD_OFFSET(KEY_VALUE_PARTIAL_INFORMATION, Data) + sizeof(L"12345678&12345678"); - ParentIdPrefixInformation = ExAllocatePoolWithTag(PagedPool, - KeyNameBufferLength + sizeof(UNICODE_NULL), - TAG_IO); - if (!ParentIdPrefixInformation) - { - return STATUS_INSUFFICIENT_RESOURCES; - } - - KeyName.Length = 0; - KeyName.MaximumLength = EnumKeyPath.Length + - DeviceNode->Parent->InstancePath.Length + - sizeof(UNICODE_NULL); - KeyName.Buffer = ExAllocatePoolWithTag(PagedPool, - KeyName.MaximumLength, - TAG_IO); - if (!KeyName.Buffer) - { - Status = STATUS_INSUFFICIENT_RESOURCES; - goto cleanup; - } - - RtlCopyUnicodeString(&KeyName, &EnumKeyPath); - RtlAppendUnicodeStringToString(&KeyName, &DeviceNode->Parent->InstancePath); - - Status = IopOpenRegistryKeyEx(&hKey, NULL, &KeyName, KEY_QUERY_VALUE | KEY_SET_VALUE); - if (!NT_SUCCESS(Status)) - { - goto cleanup; - } - RtlInitUnicodeString(&ValueName, L"ParentIdPrefix"); - Status = ZwQueryValueKey(hKey, - &ValueName, - KeyValuePartialInformation, - ParentIdPrefixInformation, - KeyNameBufferLength, - &KeyNameBufferLength); - if (NT_SUCCESS(Status)) - { - if (ParentIdPrefixInformation->Type != REG_SZ) - { - Status = STATUS_UNSUCCESSFUL; - } - else - { - KeyValue.MaximumLength = (USHORT)ParentIdPrefixInformation->DataLength; - KeyValue.Length = KeyValue.MaximumLength - sizeof(UNICODE_NULL); - KeyValue.Buffer = (PWSTR)ParentIdPrefixInformation->Data; - ASSERT(KeyValue.Buffer[KeyValue.Length / sizeof(WCHAR)] == UNICODE_NULL); - } - goto cleanup; - } - if (Status != STATUS_OBJECT_NAME_NOT_FOUND) - { - /* FIXME how do we get here and why is ParentIdPrefixInformation valid? */ - KeyValue.MaximumLength = (USHORT)ParentIdPrefixInformation->DataLength; - KeyValue.Length = KeyValue.MaximumLength - sizeof(UNICODE_NULL); - KeyValue.Buffer = (PWSTR)ParentIdPrefixInformation->Data; - ASSERT(KeyValue.Buffer[KeyValue.Length / sizeof(WCHAR)] == UNICODE_NULL); - goto cleanup; - } - - /* 2. Create the ParentIdPrefix value */ - crc32 = RtlComputeCrc32(0, - (PUCHAR)DeviceNode->Parent->InstancePath.Buffer, - DeviceNode->Parent->InstancePath.Length); - - RtlStringCbPrintfW((PWSTR)ParentIdPrefixInformation, - KeyNameBufferLength, - L"%lx&%lx", - DeviceNode->Parent->Level, - crc32); - RtlInitUnicodeString(&KeyValue, (PWSTR)ParentIdPrefixInformation); - - /* 3. Try to write the ParentIdPrefix to registry */ - Status = ZwSetValueKey(hKey, - &ValueName, - 0, - REG_SZ, - KeyValue.Buffer, - ((ULONG)wcslen(KeyValue.Buffer) + 1) * sizeof(WCHAR)); - -cleanup: - if (NT_SUCCESS(Status)) - { - /* Duplicate the string to return it */ - Status = RtlDuplicateUnicodeString(RTL_DUPLICATE_UNICODE_STRING_NULL_TERMINATE, - &KeyValue, - ParentIdPrefix); - } - ExFreePoolWithTag(ParentIdPrefixInformation, TAG_IO); - RtlFreeUnicodeString(&KeyName); - if (hKey != NULL) - { - ZwClose(hKey); - } - return Status; -} - -static -BOOLEAN -IopValidateID( - _In_ PWCHAR Id, - _In_ BUS_QUERY_ID_TYPE QueryType) -{ - PWCHAR PtrChar; - PWCHAR StringEnd; - WCHAR Char; - ULONG SeparatorsCount = 0; - PWCHAR PtrPrevChar = NULL; - ULONG MaxSeparators; - BOOLEAN IsMultiSz; - - PAGED_CODE(); - - switch (QueryType) - { - case BusQueryDeviceID: - MaxSeparators = MAX_SEPARATORS_DEVICEID; - IsMultiSz = FALSE; - break; - case BusQueryInstanceID: - MaxSeparators = MAX_SEPARATORS_INSTANCEID; - IsMultiSz = FALSE; - break; - - case BusQueryHardwareIDs: - case BusQueryCompatibleIDs: - MaxSeparators = MAX_SEPARATORS_DEVICEID; - IsMultiSz = TRUE; - break; - - default: - DPRINT1("IopValidateID: Not handled QueryType - %x\n", QueryType); - return FALSE; - } - - StringEnd = Id + MAX_DEVICE_ID_LEN; - - for (PtrChar = Id; PtrChar < StringEnd; PtrChar++) - { - Char = *PtrChar; - - if (Char == UNICODE_NULL) - { - if (!IsMultiSz || (PtrPrevChar && PtrChar == PtrPrevChar + 1)) - { - if (MaxSeparators == SeparatorsCount || IsMultiSz) - { - return TRUE; - } - - DPRINT1("IopValidateID: SeparatorsCount - %lu, MaxSeparators - %lu\n", - SeparatorsCount, MaxSeparators); - goto ErrorExit; - } - - StringEnd = PtrChar + MAX_DEVICE_ID_LEN + 1; - PtrPrevChar = PtrChar; - SeparatorsCount = 0; - } - else if (Char < ' ' || Char > 0x7F || Char == ',') - { - DPRINT1("IopValidateID: Invalid character - %04X\n", Char); - goto ErrorExit; - } - else if (Char == ' ') - { - *PtrChar = '_'; - } - else if (Char == '\\') - { - SeparatorsCount++; - - if (SeparatorsCount > MaxSeparators) - { - DPRINT1("IopValidateID: SeparatorsCount - %lu, MaxSeparators - %lu\n", - SeparatorsCount, MaxSeparators); - goto ErrorExit; - } - } - } - - DPRINT1("IopValidateID: Not terminated ID\n"); - -ErrorExit: - // FIXME logging - return FALSE; -} - -NTSTATUS -IopQueryHardwareIds(PDEVICE_NODE DeviceNode, - HANDLE InstanceKey) -{ - IO_STACK_LOCATION Stack; - IO_STATUS_BLOCK IoStatusBlock; - PWSTR Ptr; - UNICODE_STRING ValueName; - NTSTATUS Status; - ULONG Length, TotalLength; - BOOLEAN IsValidID; - - DPRINT("Sending IRP_MN_QUERY_ID.BusQueryHardwareIDs to device stack\n"); - - RtlZeroMemory(&Stack, sizeof(Stack)); - Stack.Parameters.QueryId.IdType = BusQueryHardwareIDs; - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_ID, - &Stack); - if (NT_SUCCESS(Status)) - { - IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryHardwareIDs); - - if (!IsValidID) - { - DPRINT1("Invalid HardwareIDs. DeviceNode - %p\n", DeviceNode); - } - - TotalLength = 0; - - Ptr = (PWSTR)IoStatusBlock.Information; - DPRINT("Hardware IDs:\n"); - while (*Ptr) - { - DPRINT(" %S\n", Ptr); - Length = (ULONG)wcslen(Ptr) + 1; - - Ptr += Length; - TotalLength += Length; - } - DPRINT("TotalLength: %hu\n", TotalLength); - DPRINT("\n"); - - RtlInitUnicodeString(&ValueName, L"HardwareID"); - Status = ZwSetValueKey(InstanceKey, - &ValueName, - 0, - REG_MULTI_SZ, - (PVOID)IoStatusBlock.Information, - (TotalLength + 1) * sizeof(WCHAR)); - if (!NT_SUCCESS(Status)) - { - DPRINT1("ZwSetValueKey() failed (Status %lx)\n", Status); - } - } - else - { - DPRINT("IopInitiatePnpIrp() failed (Status %x)\n", Status); - } - - return Status; -} - -NTSTATUS -IopQueryCompatibleIds(PDEVICE_NODE DeviceNode, - HANDLE InstanceKey) -{ - IO_STACK_LOCATION Stack; - IO_STATUS_BLOCK IoStatusBlock; - PWSTR Ptr; - UNICODE_STRING ValueName; - NTSTATUS Status; - ULONG Length, TotalLength; - BOOLEAN IsValidID; - - DPRINT("Sending IRP_MN_QUERY_ID.BusQueryCompatibleIDs to device stack\n"); - - RtlZeroMemory(&Stack, sizeof(Stack)); - Stack.Parameters.QueryId.IdType = BusQueryCompatibleIDs; - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_ID, - &Stack); - if (NT_SUCCESS(Status) && IoStatusBlock.Information) - { - IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryCompatibleIDs); - - if (!IsValidID) - { - DPRINT1("Invalid CompatibleIDs. DeviceNode - %p\n", DeviceNode); - } - - TotalLength = 0; - - Ptr = (PWSTR)IoStatusBlock.Information; - DPRINT("Compatible IDs:\n"); - while (*Ptr) - { - DPRINT(" %S\n", Ptr); - Length = (ULONG)wcslen(Ptr) + 1; - - Ptr += Length; - TotalLength += Length; - } - DPRINT("TotalLength: %hu\n", TotalLength); - DPRINT("\n"); - - RtlInitUnicodeString(&ValueName, L"CompatibleIDs"); - Status = ZwSetValueKey(InstanceKey, - &ValueName, - 0, - REG_MULTI_SZ, - (PVOID)IoStatusBlock.Information, - (TotalLength + 1) * sizeof(WCHAR)); - if (!NT_SUCCESS(Status)) - { - DPRINT1("ZwSetValueKey() failed (Status %lx) or no Compatible ID returned\n", Status); - } - } - else - { - DPRINT("IopInitiatePnpIrp() failed (Status %x)\n", Status); - } - - return Status; -} - -NTSTATUS -IopCreateDeviceInstancePath( - _In_ PDEVICE_NODE DeviceNode, - _Out_ PUNICODE_STRING InstancePath) -{ - IO_STATUS_BLOCK IoStatusBlock; - UNICODE_STRING DeviceId; - UNICODE_STRING InstanceId; - IO_STACK_LOCATION Stack; - NTSTATUS Status; - UNICODE_STRING ParentIdPrefix = { 0, 0, NULL }; - DEVICE_CAPABILITIES DeviceCapabilities; - BOOLEAN IsValidID; - - DPRINT("Sending IRP_MN_QUERY_ID.BusQueryDeviceID to device stack\n"); - - Stack.Parameters.QueryId.IdType = BusQueryDeviceID; - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_ID, - &Stack); - if (!NT_SUCCESS(Status)) - { - DPRINT1("IopInitiatePnpIrp(BusQueryDeviceID) failed (Status %x)\n", Status); - return Status; - } - - IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryDeviceID); - - if (!IsValidID) - { - DPRINT1("Invalid DeviceID. DeviceNode - %p\n", DeviceNode); - } - - /* Save the device id string */ - RtlInitUnicodeString(&DeviceId, (PWSTR)IoStatusBlock.Information); - - DPRINT("Sending IRP_MN_QUERY_CAPABILITIES to device stack (after enumeration)\n"); - - Status = IopQueryDeviceCapabilities(DeviceNode, &DeviceCapabilities); - if (!NT_SUCCESS(Status)) - { - DPRINT1("IopQueryDeviceCapabilities() failed (Status 0x%08lx)\n", Status); - RtlFreeUnicodeString(&DeviceId); - return Status; - } - - /* This bit is only check after enumeration */ - if (DeviceCapabilities.HardwareDisabled) - { - /* FIXME: Cleanup device */ - DeviceNode->Flags |= DNF_DISABLED; - RtlFreeUnicodeString(&DeviceId); - return STATUS_PLUGPLAY_NO_DEVICE; - } - else - { - DeviceNode->Flags &= ~DNF_DISABLED; - } - - if (!DeviceCapabilities.UniqueID) - { - /* Device has not a unique ID. We need to prepend parent bus unique identifier */ - DPRINT("Instance ID is not unique\n"); - Status = IopGetParentIdPrefix(DeviceNode, &ParentIdPrefix); - if (!NT_SUCCESS(Status)) - { - DPRINT1("IopGetParentIdPrefix() failed (Status 0x%08lx)\n", Status); - RtlFreeUnicodeString(&DeviceId); - return Status; - } - } - - DPRINT("Sending IRP_MN_QUERY_ID.BusQueryInstanceID to device stack\n"); - - Stack.Parameters.QueryId.IdType = BusQueryInstanceID; - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_ID, - &Stack); - if (!NT_SUCCESS(Status)) - { - DPRINT("IopInitiatePnpIrp(BusQueryInstanceID) failed (Status %lx)\n", Status); - ASSERT(IoStatusBlock.Information == 0); - } - - if (IoStatusBlock.Information) - { - IsValidID = IopValidateID((PWCHAR)IoStatusBlock.Information, BusQueryInstanceID); - - if (!IsValidID) - { - DPRINT1("Invalid InstanceID. DeviceNode - %p\n", DeviceNode); - } - } - - RtlInitUnicodeString(&InstanceId, - (PWSTR)IoStatusBlock.Information); - - InstancePath->Length = 0; - InstancePath->MaximumLength = DeviceId.Length + sizeof(WCHAR) + - ParentIdPrefix.Length + - InstanceId.Length + - sizeof(UNICODE_NULL); - if (ParentIdPrefix.Length && InstanceId.Length) - { - InstancePath->MaximumLength += sizeof(WCHAR); - } - - InstancePath->Buffer = ExAllocatePoolWithTag(PagedPool, - InstancePath->MaximumLength, - TAG_IO); - if (!InstancePath->Buffer) - { - RtlFreeUnicodeString(&InstanceId); - RtlFreeUnicodeString(&ParentIdPrefix); - RtlFreeUnicodeString(&DeviceId); - return STATUS_INSUFFICIENT_RESOURCES; - } - - /* Start with the device id */ - RtlCopyUnicodeString(InstancePath, &DeviceId); - RtlAppendUnicodeToString(InstancePath, L"\\"); - - /* Add information from parent bus device to InstancePath */ - RtlAppendUnicodeStringToString(InstancePath, &ParentIdPrefix); - if (ParentIdPrefix.Length && InstanceId.Length) - { - RtlAppendUnicodeToString(InstancePath, L"&"); - } - - /* Finally, add the id returned by the driver stack */ - RtlAppendUnicodeStringToString(InstancePath, &InstanceId); - - /* - * FIXME: Check for valid characters, if there is invalid characters - * then bugcheck - */ - - RtlFreeUnicodeString(&InstanceId); - RtlFreeUnicodeString(&DeviceId); - RtlFreeUnicodeString(&ParentIdPrefix); - - return STATUS_SUCCESS; -} - -/* - * IopActionInterrogateDeviceStack - * - * Retrieve information for all (direct) child nodes of a parent node. - * - * Parameters - * DeviceNode - * Pointer to device node. - * Context - * Pointer to parent node to retrieve child node information for. - * - * Remarks - * Any errors that occur are logged instead so that all child services have a chance - * of being interrogated. - */ - -NTSTATUS -IopActionInterrogateDeviceStack(PDEVICE_NODE DeviceNode, - PVOID Context) -{ - IO_STATUS_BLOCK IoStatusBlock; - PWSTR DeviceDescription; - PWSTR LocationInformation; - PDEVICE_NODE ParentDeviceNode; - IO_STACK_LOCATION Stack; - NTSTATUS Status; - ULONG RequiredLength; - LCID LocaleId; - HANDLE InstanceKey = NULL; - UNICODE_STRING ValueName; - UNICODE_STRING InstancePathU; - PDEVICE_OBJECT OldDeviceObject; - - DPRINT("IopActionInterrogateDeviceStack(%p, %p)\n", DeviceNode, Context); - DPRINT("PDO 0x%p\n", DeviceNode->PhysicalDeviceObject); - - ParentDeviceNode = (PDEVICE_NODE)Context; - - /* - * We are called for the parent too, but we don't need to do special - * handling for this node - */ - if (DeviceNode == ParentDeviceNode) - { - DPRINT("Success\n"); - return STATUS_SUCCESS; - } - - /* - * Make sure this device node is a direct child of the parent device node - * that is given as an argument - */ - if (DeviceNode->Parent != ParentDeviceNode) - { - DPRINT("Skipping 2+ level child\n"); - return STATUS_SUCCESS; - } - - /* Skip processing if it was already completed before */ - if (DeviceNode->Flags & DNF_PROCESSED) - { - /* Nothing to do */ - return STATUS_SUCCESS; - } - - /* Get Locale ID */ - Status = ZwQueryDefaultLocale(FALSE, &LocaleId); - if (!NT_SUCCESS(Status)) - { - DPRINT1("ZwQueryDefaultLocale() failed with status 0x%lx\n", Status); - return Status; - } - - /* - * FIXME: For critical errors, cleanup and disable device, but always - * return STATUS_SUCCESS. - */ - - Status = IopCreateDeviceInstancePath(DeviceNode, &InstancePathU); - if (!NT_SUCCESS(Status)) - { - if (Status != STATUS_PLUGPLAY_NO_DEVICE) - { - DPRINT1("IopCreateDeviceInstancePath() failed with status 0x%lx\n", Status); - } - - /* We have to return success otherwise we abort the traverse operation */ - return STATUS_SUCCESS; - } - - /* Verify that this is not a duplicate */ - OldDeviceObject = IopGetDeviceObjectFromDeviceInstance(&InstancePathU); - if (OldDeviceObject != NULL) - { - PDEVICE_NODE OldDeviceNode = IopGetDeviceNode(OldDeviceObject); - - DPRINT1("Duplicate device instance '%wZ'\n", &InstancePathU); - DPRINT1("Current instance parent: '%wZ'\n", &DeviceNode->Parent->InstancePath); - DPRINT1("Old instance parent: '%wZ'\n", &OldDeviceNode->Parent->InstancePath); - - KeBugCheckEx(PNP_DETECTED_FATAL_ERROR, - 0x01, - (ULONG_PTR)DeviceNode->PhysicalDeviceObject, - (ULONG_PTR)OldDeviceObject, - 0); - } - - DeviceNode->InstancePath = InstancePathU; - - DPRINT("InstancePath is %S\n", DeviceNode->InstancePath.Buffer); - - /* - * Create registry key for the instance id, if it doesn't exist yet - */ - Status = IopCreateDeviceKeyPath(&DeviceNode->InstancePath, REG_OPTION_NON_VOLATILE, &InstanceKey); - if (!NT_SUCCESS(Status)) - { - DPRINT1("Failed to create the instance key! (Status %lx)\n", Status); - - /* We have to return success otherwise we abort the traverse operation */ - return STATUS_SUCCESS; - } - - IopQueryHardwareIds(DeviceNode, InstanceKey); - - IopQueryCompatibleIds(DeviceNode, InstanceKey); - - DPRINT("Sending IRP_MN_QUERY_DEVICE_TEXT.DeviceTextDescription to device stack\n"); - - Stack.Parameters.QueryDeviceText.DeviceTextType = DeviceTextDescription; - Stack.Parameters.QueryDeviceText.LocaleId = LocaleId; - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_DEVICE_TEXT, - &Stack); - DeviceDescription = NT_SUCCESS(Status) ? (PWSTR)IoStatusBlock.Information - : NULL; - /* This key is mandatory, so even if the Irp fails, we still write it */ - RtlInitUnicodeString(&ValueName, L"DeviceDesc"); - if (ZwQueryValueKey(InstanceKey, &ValueName, KeyValueBasicInformation, NULL, 0, &RequiredLength) == STATUS_OBJECT_NAME_NOT_FOUND) - { - if (DeviceDescription && - *DeviceDescription != UNICODE_NULL) - { - /* This key is overriden when a driver is installed. Don't write the - * new description if another one already exists */ - Status = ZwSetValueKey(InstanceKey, - &ValueName, - 0, - REG_SZ, - DeviceDescription, - ((ULONG)wcslen(DeviceDescription) + 1) * sizeof(WCHAR)); - } - else - { - UNICODE_STRING DeviceDesc = RTL_CONSTANT_STRING(L"Unknown device"); - DPRINT("Driver didn't return DeviceDesc (Status 0x%08lx), so place unknown device there\n", Status); - - Status = ZwSetValueKey(InstanceKey, - &ValueName, - 0, - REG_SZ, - DeviceDesc.Buffer, - DeviceDesc.MaximumLength); - if (!NT_SUCCESS(Status)) - { - DPRINT1("ZwSetValueKey() failed (Status 0x%lx)\n", Status); - } - - } - } - - if (DeviceDescription) - { - ExFreePoolWithTag(DeviceDescription, 0); - } - - DPRINT("Sending IRP_MN_QUERY_DEVICE_TEXT.DeviceTextLocation to device stack\n"); - - Stack.Parameters.QueryDeviceText.DeviceTextType = DeviceTextLocationInformation; - Stack.Parameters.QueryDeviceText.LocaleId = LocaleId; - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_DEVICE_TEXT, - &Stack); - if (NT_SUCCESS(Status) && IoStatusBlock.Information) - { - LocationInformation = (PWSTR)IoStatusBlock.Information; - DPRINT("LocationInformation: %S\n", LocationInformation); - RtlInitUnicodeString(&ValueName, L"LocationInformation"); - Status = ZwSetValueKey(InstanceKey, - &ValueName, - 0, - REG_SZ, - LocationInformation, - ((ULONG)wcslen(LocationInformation) + 1) * sizeof(WCHAR)); - if (!NT_SUCCESS(Status)) - { - DPRINT1("ZwSetValueKey() failed (Status %lx)\n", Status); - } - - ExFreePoolWithTag(LocationInformation, 0); - } - else - { - DPRINT("IopInitiatePnpIrp() failed (Status %x) or IoStatusBlock.Information=NULL\n", Status); - } - - DPRINT("Sending IRP_MN_QUERY_BUS_INFORMATION to device stack\n"); - - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_BUS_INFORMATION, - NULL); - if (NT_SUCCESS(Status) && IoStatusBlock.Information) - { - PPNP_BUS_INFORMATION BusInformation = (PPNP_BUS_INFORMATION)IoStatusBlock.Information; - - DeviceNode->ChildBusNumber = BusInformation->BusNumber; - DeviceNode->ChildInterfaceType = BusInformation->LegacyBusType; - DeviceNode->ChildBusTypeIndex = IopGetBusTypeGuidIndex(&BusInformation->BusTypeGuid); - ExFreePoolWithTag(BusInformation, 0); - } - else - { - DPRINT("IopInitiatePnpIrp() failed (Status %x) or IoStatusBlock.Information=NULL\n", Status); - - DeviceNode->ChildBusNumber = 0xFFFFFFF0; - DeviceNode->ChildInterfaceType = InterfaceTypeUndefined; - DeviceNode->ChildBusTypeIndex = -1; - } - - DPRINT("Sending IRP_MN_QUERY_RESOURCES to device stack\n"); - - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_RESOURCES, - NULL); - if (NT_SUCCESS(Status) && IoStatusBlock.Information) - { - DeviceNode->BootResources = (PCM_RESOURCE_LIST)IoStatusBlock.Information; - IopDeviceNodeSetFlag(DeviceNode, DNF_HAS_BOOT_CONFIG); - } - else - { - DPRINT("IopInitiatePnpIrp() failed (Status %x) or IoStatusBlock.Information=NULL\n", Status); - DeviceNode->BootResources = NULL; - } - - DPRINT("Sending IRP_MN_QUERY_RESOURCE_REQUIREMENTS to device stack\n"); - - Status = IopInitiatePnpIrp(DeviceNode->PhysicalDeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_RESOURCE_REQUIREMENTS, - NULL); if (NT_SUCCESS(Status)) - { - DeviceNode->ResourceRequirements = (PIO_RESOURCE_REQUIREMENTS_LIST)IoStatusBlock.Information; - } - else - { - DPRINT("IopInitiatePnpIrp() failed (Status %08lx)\n", Status); - DeviceNode->ResourceRequirements = NULL; - } - - if (InstanceKey != NULL) - { - IopSetDeviceInstanceData(InstanceKey, DeviceNode); - } - - ZwClose(InstanceKey); - - IopDeviceNodeSetFlag(DeviceNode, DNF_PROCESSED); - - if (!IopDeviceNodeHasFlag(DeviceNode, DNF_LEGACY_DRIVER)) - { - /* Report the device to the user-mode pnp manager */ - IopQueueTargetDeviceEvent(&GUID_DEVICE_ENUMERATED, - &DeviceNode->InstancePath); - } - - return STATUS_SUCCESS; -} - -static -VOID -IopHandleDeviceRemoval( - IN PDEVICE_NODE DeviceNode, - IN PDEVICE_RELATIONS DeviceRelations) -{ - PDEVICE_NODE Child = DeviceNode->Child, NextChild; - ULONG i; - BOOLEAN Found; - - if (DeviceNode == IopRootDeviceNode) - return; - - while (Child != NULL) - { - NextChild = Child->Sibling; - Found = FALSE; - - for (i = 0; DeviceRelations && i < DeviceRelations->Count; i++) - { - if (IopGetDeviceNode(DeviceRelations->Objects[i]) == Child) - { - Found = TRUE; - break; - } - } - - if (!Found && !(Child->Flags & DNF_WILL_BE_REMOVED)) - { - /* Send removal IRPs to all of its children */ - IopPrepareDeviceForRemoval(Child->PhysicalDeviceObject, TRUE); - - /* Send the surprise removal IRP */ - IopSendSurpriseRemoval(Child->PhysicalDeviceObject); - - /* Tell the user-mode PnP manager that a device was removed */ - IopQueueTargetDeviceEvent(&GUID_DEVICE_SURPRISE_REMOVAL, - &Child->InstancePath); - - /* Send the remove device IRP */ - IopSendRemoveDevice(Child->PhysicalDeviceObject); - } - - Child = NextChild; - } -} - -NTSTATUS -IopEnumerateDevice( - IN PDEVICE_OBJECT DeviceObject) -{ - PDEVICE_NODE DeviceNode = IopGetDeviceNode(DeviceObject); - DEVICETREE_TRAVERSE_CONTEXT Context; - PDEVICE_RELATIONS DeviceRelations; - PDEVICE_OBJECT ChildDeviceObject; - IO_STATUS_BLOCK IoStatusBlock; - PDEVICE_NODE ChildDeviceNode; - IO_STACK_LOCATION Stack; - NTSTATUS Status; - ULONG i; - - DPRINT("DeviceObject 0x%p\n", DeviceObject); - - if (DeviceNode->Flags & DNF_NEED_ENUMERATION_ONLY) - { - DeviceNode->Flags &= ~DNF_NEED_ENUMERATION_ONLY; - - DPRINT("Sending GUID_DEVICE_ARRIVAL\n"); - IopQueueTargetDeviceEvent(&GUID_DEVICE_ARRIVAL, - &DeviceNode->InstancePath); - } - - DPRINT("Sending IRP_MN_QUERY_DEVICE_RELATIONS to device stack\n"); - - Stack.Parameters.QueryDeviceRelations.Type = BusRelations; - - Status = IopInitiatePnpIrp( - DeviceObject, - &IoStatusBlock, - IRP_MN_QUERY_DEVICE_RELATIONS, - &Stack); - if (!NT_SUCCESS(Status) || Status == STATUS_PENDING) - { - DPRINT("IopInitiatePnpIrp() failed with status 0x%08lx\n", Status); - return Status; - } - - DeviceRelations = (PDEVICE_RELATIONS)IoStatusBlock.Information; - - /* - * Send removal IRPs for devices that have disappeared - * NOTE: This code handles the case where no relations are specified - */ - IopHandleDeviceRemoval(DeviceNode, DeviceRelations); - - /* Now we bail if nothing was returned */ - if (!DeviceRelations) - { - /* We're all done */ - DPRINT("No PDOs\n"); - return STATUS_SUCCESS; - } - - DPRINT("Got %u PDOs\n", DeviceRelations->Count); - - /* - * Create device nodes for all discovered devices - */ - for (i = 0; i < DeviceRelations->Count; i++) - { - ChildDeviceObject = DeviceRelations->Objects[i]; - ASSERT((ChildDeviceObject->Flags & DO_DEVICE_INITIALIZING) == 0); - - ChildDeviceNode = IopGetDeviceNode(ChildDeviceObject); - if (!ChildDeviceNode) - { - /* One doesn't exist, create it */ - Status = IopCreateDeviceNode( - DeviceNode, - ChildDeviceObject, - NULL, - &ChildDeviceNode); - if (NT_SUCCESS(Status)) - { - /* Mark the node as enumerated */ - ChildDeviceNode->Flags |= DNF_ENUMERATED; - - /* Mark the DO as bus enumerated */ - ChildDeviceObject->Flags |= DO_BUS_ENUMERATED_DEVICE; - } - else - { - /* Ignore this DO */ - DPRINT1("IopCreateDeviceNode() failed with status 0x%08x. Skipping PDO %u\n", Status, i); - ObDereferenceObject(ChildDeviceObject); - } - } - else - { - /* Mark it as enumerated */ - ChildDeviceNode->Flags |= DNF_ENUMERATED; - ObDereferenceObject(ChildDeviceObject); - } - } - ExFreePool(DeviceRelations); - - /* - * Retrieve information about all discovered children from the bus driver - */ - IopInitDeviceTreeTraverseContext( - &Context, - DeviceNode, - IopActionInterrogateDeviceStack, - DeviceNode); - - Status = IopTraverseDeviceTree(&Context); - if (!NT_SUCCESS(Status)) - { - DPRINT("IopTraverseDeviceTree() failed with status 0x%08lx\n", Status); - return Status; - } - - /* - * Retrieve configuration from the registry for discovered children - */ - IopInitDeviceTreeTraverseContext( - &Context, - DeviceNode, - IopActionConfigureChildServices, - DeviceNode); - - Status = IopTraverseDeviceTree(&Context); - if (!NT_SUCCESS(Status)) - { - DPRINT("IopTraverseDeviceTree() failed with status 0x%08lx\n", Status); - return Status; - } - - /* - * Initialize services for discovered children. - */ - Status = IopInitializePnpServices(DeviceNode); - if (!NT_SUCCESS(Status)) - { - DPRINT("IopInitializePnpServices() failed with status 0x%08lx\n", Status); - return Status; - } - - DPRINT("IopEnumerateDevice() finished\n"); - return STATUS_SUCCESS; -} - - -/* - * IopActionConfigureChildServices - * - * Retrieve configuration for all (direct) child nodes of a parent node. - * - * Parameters - * DeviceNode - * Pointer to device node. - * Context - * Pointer to parent node to retrieve child node configuration for. - * - * Remarks - * Any errors that occur are logged instead so that all child services have a chance of beeing - * configured. - */ - -NTSTATUS -IopActionConfigureChildServices(PDEVICE_NODE DeviceNode, - PVOID Context) -{ - RTL_QUERY_REGISTRY_TABLE QueryTable[3]; - PDEVICE_NODE ParentDeviceNode; - PUNICODE_STRING Service; - UNICODE_STRING ClassGUID; - NTSTATUS Status; - DEVICE_CAPABILITIES DeviceCaps; - - DPRINT("IopActionConfigureChildServices(%p, %p)\n", DeviceNode, Context); - - ParentDeviceNode = (PDEVICE_NODE)Context; - - /* - * We are called for the parent too, but we don't need to do special - * handling for this node - */ - if (DeviceNode == ParentDeviceNode) - { - DPRINT("Success\n"); - return STATUS_SUCCESS; - } - - /* - * Make sure this device node is a direct child of the parent device node - * that is given as an argument - */ - - if (DeviceNode->Parent != ParentDeviceNode) - { - DPRINT("Skipping 2+ level child\n"); - return STATUS_SUCCESS; - } - - if (!(DeviceNode->Flags & DNF_PROCESSED)) - { - DPRINT1("Child not ready to be configured\n"); - return STATUS_SUCCESS; - } - - if (!(DeviceNode->Flags & (DNF_DISABLED | DNF_STARTED | DNF_ADDED))) - { - UNICODE_STRING RegKey; - - /* Install the service for this if it's in the CDDB */ - IopInstallCriticalDevice(DeviceNode); - - /* - * Retrieve configuration from Enum key - */ - - Service = &DeviceNode->ServiceName; - - RtlZeroMemory(QueryTable, sizeof(QueryTable)); - RtlInitUnicodeString(Service, NULL); - RtlInitUnicodeString(&ClassGUID, NULL); - - QueryTable[0].Name = L"Service"; - QueryTable[0].Flags = RTL_QUERY_REGISTRY_DIRECT; - QueryTable[0].EntryContext = Service; - - QueryTable[1].Name = L"ClassGUID"; - QueryTable[1].Flags = RTL_QUERY_REGISTRY_DIRECT; - QueryTable[1].EntryContext = &ClassGUID; - QueryTable[1].DefaultType = REG_SZ; - QueryTable[1].DefaultData = L""; - QueryTable[1].DefaultLength = 0; - - RegKey.Length = 0; - RegKey.MaximumLength = sizeof(ENUM_ROOT) + sizeof(WCHAR) + DeviceNode->InstancePath.Length; - RegKey.Buffer = ExAllocatePoolWithTag(PagedPool, - RegKey.MaximumLength, - TAG_IO); - if (RegKey.Buffer == NULL) - { - IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); - return STATUS_INSUFFICIENT_RESOURCES; - } - - RtlAppendUnicodeToString(&RegKey, ENUM_ROOT); - RtlAppendUnicodeToString(&RegKey, L"\\"); - RtlAppendUnicodeStringToString(&RegKey, &DeviceNode->InstancePath); - - Status = RtlQueryRegistryValues(RTL_REGISTRY_ABSOLUTE, - RegKey.Buffer, QueryTable, NULL, NULL); - ExFreePoolWithTag(RegKey.Buffer, TAG_IO); + ZwClose(ControlKey); - if (!NT_SUCCESS(Status)) + /* Create the 'Device Parameters' key and set the 'FirmwareIdentified' value for all ACPI-enumerated devices */ + if (_wcsnicmp(DeviceNode->InstancePath.Buffer, L"ACPI\\", 5) == 0) + { + RtlInitUnicodeString(&KeyName, L"Device Parameters"); + InitializeObjectAttributes(&ObjectAttributes, + &KeyName, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, + InstanceKey, + NULL); + Status = ZwCreateKey(&DeviceParamsKey, + 0, + &ObjectAttributes, + 0, + NULL, + REG_OPTION_NON_VOLATILE, + NULL); + if (NT_SUCCESS(Status)) { - /* FIXME: Log the error */ - DPRINT("Could not retrieve configuration for device %wZ (Status 0x%08x)\n", - &DeviceNode->InstancePath, Status); - IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); - return STATUS_SUCCESS; - } + ULONG FirmwareIdentified = 1; + RtlInitUnicodeString(&KeyName, L"FirmwareIdentified"); + Status = ZwSetValueKey(DeviceParamsKey, + &KeyName, + 0, + REG_DWORD, + &FirmwareIdentified, + sizeof(FirmwareIdentified)); - if (Service->Buffer == NULL) - { - if (NT_SUCCESS(IopQueryDeviceCapabilities(DeviceNode, &DeviceCaps)) && - DeviceCaps.RawDeviceOK) - { - DPRINT("%wZ is using parent bus driver (%wZ)\n", &DeviceNode->InstancePath, &ParentDeviceNode->ServiceName); - RtlInitEmptyUnicodeString(&DeviceNode->ServiceName, NULL, 0); - } - else if (ClassGUID.Length != 0) - { - /* Device has a ClassGUID value, but no Service value. - * Suppose it is using the NULL driver, so state the - * device is started */ - DPRINT("%wZ is using NULL driver\n", &DeviceNode->InstancePath); - IopDeviceNodeSetFlag(DeviceNode, DNF_STARTED); - } - else - { - DeviceNode->Problem = CM_PROB_FAILED_INSTALL; - IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); - } - return STATUS_SUCCESS; + ZwClose(DeviceParamsKey); } - - DPRINT("Got Service %S\n", Service->Buffer); } - return STATUS_SUCCESS; + DPRINT("IopSetDeviceInstanceData() done\n"); + + return Status; } /* - * IopActionInitChildServices + * IopGetParentIdPrefix * - * Initialize the service for all (direct) child nodes of a parent node + * Retrieve (or create) a string which identifies a device. * * Parameters * DeviceNode - * Pointer to device node. - * Context - * Pointer to parent node to initialize child node services for. + * Pointer to device node. + * ParentIdPrefix + * Pointer to the string where is returned the parent node identifier * * Remarks - * If the driver image for a service is not loaded and initialized - * it is done here too. Any errors that occur are logged instead so - * that all child services have a chance of being initialized. + * If the return code is STATUS_SUCCESS, the ParentIdPrefix string is + * valid and its Buffer field is NULL-terminated. The caller needs to + * to free the string with RtlFreeUnicodeString when it is no longer + * needed. */ NTSTATUS ... 811 lines suppressed ...

4 years, 2 months

[reactos] 01/01: [ROSAUTOTEST] Add /t parameter for repeating tests

by Victor Perevertkin

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d230f8829c7bf1235dc00… commit d230f8829c7bf1235dc00074c55be5cafa130e15 Author: Victor Perevertkin <victor.perevertkin(a)reactos.org> AuthorDate: Mon May 18 05:42:53 2020 +0300 Commit: Victor Perevertkin <victor(a)perevertkin.ru> CommitDate: Wed Jun 24 02:40:18 2020 +0300 [ROSAUTOTEST] Add /t parameter for repeating tests --- modules/rostests/rosautotest/CConfiguration.cpp | 25 +++++++++++++++++++++++++ modules/rostests/rosautotest/CConfiguration.h | 2 ++ modules/rostests/rosautotest/main.cpp | 25 ++++++++++++++++++++++--- 3 files changed, 49 insertions(+), 3 deletions(-) diff --git a/modules/rostests/rosautotest/CConfiguration.cpp b/modules/rostests/rosautotest/CConfiguration.cpp index 95f95cac55c..f7e880d8221 100644 --- a/modules/rostests/rosautotest/CConfiguration.cpp +++ b/modules/rostests/rosautotest/CConfiguration.cpp @@ -19,6 +19,7 @@ CConfiguration::CConfiguration() : m_CrashRecovery(false), m_IsInteractive(false), m_PrintToConsole(true), + m_RepeatCount(1), m_Shutdown(false), m_Submit(false) { @@ -52,10 +53,17 @@ CConfiguration::ParseParameters(int argc, wchar_t* argv[]) { if(argv[i][0] == '-' || argv[i][0] == '/') { + unsigned long tmp_RepeatCount; + switch(argv[i][1]) { case 'c': ++i; + if (i >= argc) + { + throw CInvalidParameterException(); + } + m_Comment = UnicodeToAscii(argv[i]); break; @@ -75,6 +83,23 @@ CConfiguration::ParseParameters(int argc, wchar_t* argv[]) m_Submit = true; break; + case 't': + ++i; + if (i >= argc) + { + throw CInvalidParameterException(); + } + + tmp_RepeatCount = wcstoul(argv[i], NULL, 10); + + if (tmp_RepeatCount == 0 || tmp_RepeatCount > 10000) + { + throw CInvalidParameterException(); + } + + m_RepeatCount = tmp_RepeatCount; + break; + default: throw CInvalidParameterException(); } diff --git a/modules/rostests/rosautotest/CConfiguration.h b/modules/rostests/rosautotest/CConfiguration.h index a6a6a948796..4359f751dd2 100644 --- a/modules/rostests/rosautotest/CConfiguration.h +++ b/modules/rostests/rosautotest/CConfiguration.h @@ -12,6 +12,7 @@ private: bool m_IsInteractive; bool m_IsReactOS; bool m_PrintToConsole; + unsigned long m_RepeatCount; bool m_Shutdown; bool m_Submit; string m_Comment; @@ -33,6 +34,7 @@ public: bool DoSubmit() const { return m_Submit; } bool IsInteractive() const { return m_IsInteractive; } bool IsReactOS() const { return m_IsReactOS; } + unsigned long GetRepeatCount() const { return m_RepeatCount; } const string& GetComment() const { return m_Comment; } const wstring& GetModule() const { return m_Module; } const string& GetTest() const { return m_Test; } diff --git a/modules/rostests/rosautotest/main.cpp b/modules/rostests/rosautotest/main.cpp index 9c728d8d494..5061d7d664c 100644 --- a/modules/rostests/rosautotest/main.cpp +++ b/modules/rostests/rosautotest/main.cpp @@ -28,6 +28,7 @@ IntPrintUsage() << " Can only be run under ReactOS and relies on sysreg2," << endl << " so incompatible with /w" << endl << " /s - Shut down the system after finishing the tests." << endl + << " /t <num> - Repeat the test <num> times (1-10000)" << endl << " /w - Submit the results to the webservice." << endl << " Requires a \"rosautotest.ini\" with valid login data." << endl << " Incompatible with the /r option." << endl @@ -47,7 +48,6 @@ IntPrintUsage() extern "C" int wmain(int argc, wchar_t* argv[]) { - CWineTest WineTest; int ReturnValue = 1; try @@ -64,7 +64,7 @@ wmain(int argc, wchar_t* argv[]) << "[ROSAUTOTEST] System uptime " << setprecision(2) << fixed; ss << ((float)GetTickCount()/1000) << " seconds" << endl; StringOut(ss.str()); - + /* Report tests startup */ InitLogs(); ReportEventW(hLog, @@ -77,8 +77,27 @@ wmain(int argc, wchar_t* argv[]) NULL, NULL); + if (Configuration.GetRepeatCount() > 1) + { + stringstream ss1; + + ss1 << "[ROSAUTOTEST] The test will be repeated " << Configuration.GetRepeatCount() << " times" << endl; + StringOut(ss1.str()); + } + /* Run the tests */ - WineTest.Run(); + for (unsigned long i = 0; i < Configuration.GetRepeatCount(); i++) + { + CWineTest WineTest; + + if (Configuration.GetRepeatCount() > 1) + { + stringstream ss; + ss << "[ROSAUTOTEST] Running attempt #" << i+1 << endl; + StringOut(ss.str()); + } + WineTest.Run(); + } /* For sysreg2 */ DbgPrint("SYSREG_CHECKPOINT:THIRDBOOT_COMPLETE\n");

4 years, 2 months

[reactos] 02/02: [KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=29b49c36ffcbfe043ffc2… commit 29b49c36ffcbfe043ffc2beed07f91d759261b59 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sun Jun 21 10:18:19 2020 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sun Jun 21 10:39:49 2020 +0200 [KBDCLASS][MOUCLASS] Properly stub power IRP handling. CORE-12148 CORE-17136 --- drivers/input/kbdclass/kbdclass.c | 43 +++++++++++++++------------------------ drivers/input/mouclass/mouclass.c | 43 +++++++++++++++------------------------ 2 files changed, 32 insertions(+), 54 deletions(-) diff --git a/drivers/input/kbdclass/kbdclass.c b/drivers/input/kbdclass/kbdclass.c index c18b0c72a5e..1ba29a2bbdb 100644 --- a/drivers/input/kbdclass/kbdclass.c +++ b/drivers/input/kbdclass/kbdclass.c @@ -20,7 +20,7 @@ static DRIVER_DISPATCH ClassClose; static DRIVER_DISPATCH ClassCleanup; static DRIVER_DISPATCH ClassRead; static DRIVER_DISPATCH ClassDeviceControl; -static DRIVER_DISPATCH IrpStub; +static DRIVER_DISPATCH ClassPower; static DRIVER_ADD_DEVICE ClassAddDevice; static DRIVER_STARTIO ClassStartIo; static DRIVER_CANCEL ClassCancelRoutine; @@ -188,39 +188,31 @@ ClassDeviceControl( } static NTSTATUS NTAPI -IrpStub( +ClassPower( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { - NTSTATUS Status = STATUS_NOT_SUPPORTED; + NTSTATUS Status; PPORT_DEVICE_EXTENSION DeviceExtension; DeviceExtension = DeviceObject->DeviceExtension; if (!DeviceExtension->Common.IsClassDO) { - /* Forward some IRPs to lower device */ - switch (IoGetCurrentIrpStackLocation(Irp)->MajorFunction) - { - case IRP_MJ_POWER: - PoStartNextPowerIrp(Irp); - IoSkipCurrentIrpStackLocation(Irp); - return PoCallDriver(DeviceExtension->LowerDevice, Irp); - default: - { - ERR_(CLASS_NAME, "Port DO stub for major function 0x%lx\n", - IoGetCurrentIrpStackLocation(Irp)->MajorFunction); - ASSERT(FALSE); - } - } + /* Forward port DO IRPs to lower device */ + PoStartNextPowerIrp(Irp); + IoSkipCurrentIrpStackLocation(Irp); + return PoCallDriver(DeviceExtension->LowerDevice, Irp); } - else + + switch (IoGetCurrentIrpStackLocation(Irp)->MinorFunction) { - ERR_(CLASS_NAME, "Class DO stub for major function 0x%lx\n", - IoGetCurrentIrpStackLocation(Irp)->MajorFunction); - ASSERT(FALSE); + case IRP_MN_SET_POWER: + case IRP_MN_QUERY_POWER: + Irp->IoStatus.Status = STATUS_SUCCESS; + break; } - - Irp->IoStatus.Status = Status; + Status = Irp->IoStatus.Status; + PoStartNextPowerIrp(Irp); IoCompleteRequest(Irp, IO_NO_INCREMENT); return Status; } @@ -1047,7 +1039,6 @@ DriverEntry( IN PUNICODE_STRING RegistryPath) { PCLASS_DRIVER_EXTENSION DriverExtension; - ULONG i; NTSTATUS Status; Status = IoAllocateDriverObjectExtension( @@ -1094,13 +1085,11 @@ DriverEntry( DriverObject->DriverExtension->AddDevice = ClassAddDevice; DriverObject->DriverUnload = DriverUnload; - for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) - DriverObject->MajorFunction[i] = IrpStub; - DriverObject->MajorFunction[IRP_MJ_CREATE] = ClassCreate; DriverObject->MajorFunction[IRP_MJ_CLOSE] = ClassClose; DriverObject->MajorFunction[IRP_MJ_CLEANUP] = ClassCleanup; DriverObject->MajorFunction[IRP_MJ_READ] = ClassRead; + DriverObject->MajorFunction[IRP_MJ_POWER] = ClassPower; DriverObject->MajorFunction[IRP_MJ_PNP] = ClassPnp; DriverObject->MajorFunction[IRP_MJ_DEVICE_CONTROL] = ClassDeviceControl; DriverObject->MajorFunction[IRP_MJ_INTERNAL_DEVICE_CONTROL] = ForwardIrpAndForget; diff --git a/drivers/input/mouclass/mouclass.c b/drivers/input/mouclass/mouclass.c index 8628c582b2e..3f0f56b1b40 100644 --- a/drivers/input/mouclass/mouclass.c +++ b/drivers/input/mouclass/mouclass.c @@ -20,7 +20,7 @@ static DRIVER_DISPATCH ClassClose; static DRIVER_DISPATCH ClassCleanup; static DRIVER_DISPATCH ClassRead; static DRIVER_DISPATCH ClassDeviceControl; -static DRIVER_DISPATCH IrpStub; +static DRIVER_DISPATCH ClassPower; static DRIVER_ADD_DEVICE ClassAddDevice; static DRIVER_STARTIO ClassStartIo; static DRIVER_CANCEL ClassCancelRoutine; @@ -165,39 +165,31 @@ ClassDeviceControl( } static NTSTATUS NTAPI -IrpStub( +ClassPower( IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { - NTSTATUS Status = STATUS_NOT_SUPPORTED; + NTSTATUS Status; PPORT_DEVICE_EXTENSION DeviceExtension; DeviceExtension = DeviceObject->DeviceExtension; if (!DeviceExtension->Common.IsClassDO) { - /* Forward some IRPs to lower device */ - switch (IoGetCurrentIrpStackLocation(Irp)->MajorFunction) - { - case IRP_MJ_POWER: - PoStartNextPowerIrp(Irp); - IoSkipCurrentIrpStackLocation(Irp); - return PoCallDriver(DeviceExtension->LowerDevice, Irp); - default: - { - ERR_(CLASS_NAME, "Port DO stub for major function 0x%lx\n", - IoGetCurrentIrpStackLocation(Irp)->MajorFunction); - ASSERT(FALSE); - } - } + /* Forward port DO IRPs to lower device */ + PoStartNextPowerIrp(Irp); + IoSkipCurrentIrpStackLocation(Irp); + return PoCallDriver(DeviceExtension->LowerDevice, Irp); } - else + + switch (IoGetCurrentIrpStackLocation(Irp)->MinorFunction) { - ERR_(CLASS_NAME, "Class DO stub for major function 0x%lx\n", - IoGetCurrentIrpStackLocation(Irp)->MajorFunction); - ASSERT(FALSE); + case IRP_MN_SET_POWER: + case IRP_MN_QUERY_POWER: + Irp->IoStatus.Status = STATUS_SUCCESS; + break; } - - Irp->IoStatus.Status = Status; + Status = Irp->IoStatus.Status; + PoStartNextPowerIrp(Irp); IoCompleteRequest(Irp, IO_NO_INCREMENT); return Status; } @@ -1023,7 +1015,6 @@ DriverEntry( IN PUNICODE_STRING RegistryPath) { PCLASS_DRIVER_EXTENSION DriverExtension; - ULONG i; NTSTATUS Status; Status = IoAllocateDriverObjectExtension( @@ -1070,13 +1061,11 @@ DriverEntry( DriverObject->DriverExtension->AddDevice = ClassAddDevice; DriverObject->DriverUnload = DriverUnload; - for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) - DriverObject->MajorFunction[i] = IrpStub; - DriverObject->MajorFunction[IRP_MJ_CREATE] = ClassCreate; DriverObject->MajorFunction[IRP_MJ_CLOSE] = ClassClose; DriverObject->MajorFunction[IRP_MJ_CLEANUP] = ClassCleanup; DriverObject->MajorFunction[IRP_MJ_READ] = ClassRead; + DriverObject->MajorFunction[IRP_MJ_POWER] = ClassPower; DriverObject->MajorFunction[IRP_MJ_PNP] = ClassPnp; DriverObject->MajorFunction[IRP_MJ_DEVICE_CONTROL] = ClassDeviceControl; DriverObject->MajorFunction[IRP_MJ_INTERNAL_DEVICE_CONTROL] = ForwardIrpAndForget;

4 years, 2 months

[reactos] 01/02: [I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=23ccd13639265a5a8b889… commit 23ccd13639265a5a8b889956d76491f8e2e55db2 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sun Jun 21 09:57:17 2020 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sun Jun 21 10:39:34 2020 +0200 [I8042PRT] Get rid of IrpStub. CORE-12148 CORE-17136 We neither want to handle IRPs we don't understand, nor do we want to assert in case of unexpected IOCTLs. --- drivers/input/i8042prt/i8042prt.c | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/drivers/input/i8042prt/i8042prt.c b/drivers/input/i8042prt/i8042prt.c index 19027a9b0df..879c231d80f 100644 --- a/drivers/input/i8042prt/i8042prt.c +++ b/drivers/input/i8042prt/i8042prt.c @@ -18,7 +18,6 @@ /* FUNCTIONS *****************************************************************/ static DRIVER_STARTIO i8042StartIo; -static DRIVER_DISPATCH IrpStub; _Dispatch_type_(IRP_MJ_DEVICE_CONTROL) static DRIVER_DISPATCH i8042DeviceControl; _Dispatch_type_(IRP_MJ_INTERNAL_DEVICE_CONTROL) @@ -387,21 +386,6 @@ done: return Status; } -static NTSTATUS NTAPI -IrpStub( - IN PDEVICE_OBJECT DeviceObject, - IN PIRP Irp) -{ - NTSTATUS Status = Irp->IoStatus.Status; - - UNREFERENCED_PARAMETER(DeviceObject); - - /* Do nothing */ - ASSERT(FALSE); - IoCompleteRequest(Irp, IO_NO_INCREMENT); - return Status; -} - static NTSTATUS NTAPI i8042DeviceControl( IN PDEVICE_OBJECT DeviceObject, @@ -416,9 +400,10 @@ i8042DeviceControl( { case Keyboard: return i8042KbdDeviceControl(DeviceObject, Irp); - break; default: - return IrpStub(DeviceObject, Irp); + Irp->IoStatus.Status = STATUS_INVALID_DEVICE_REQUEST; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return STATUS_INVALID_DEVICE_REQUEST; } } @@ -499,7 +484,6 @@ DriverEntry( IN PUNICODE_STRING RegistryPath) { PI8042_DRIVER_EXTENSION DriverExtension; - ULONG i; NTSTATUS Status; Status = IoAllocateDriverObjectExtension( @@ -537,9 +521,6 @@ DriverEntry( DriverObject->DriverExtension->AddDevice = i8042AddDevice; DriverObject->DriverStartIo = i8042StartIo; - for (i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) - DriverObject->MajorFunction[i] = IrpStub; - DriverObject->MajorFunction[IRP_MJ_CREATE] = i8042Create; DriverObject->MajorFunction[IRP_MJ_CLEANUP] = i8042Cleanup; DriverObject->MajorFunction[IRP_MJ_CLOSE] = i8042Close;

4 years, 2 months

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2020