Ros-diffs August 2020

ros-diffs@reactos.org

27 participants
188 discussions

[reactos] 01/01: [USERSRV] Update Hebrew translation (#3010)

by Omer Itzic S

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a6946307fc10030048215… commit a6946307fc1003004821538c0d3d1efbe23c9fc5 Author: Omer Itzic S <66558205+omeritzics(a)users.noreply.github.com> AuthorDate: Tue Jul 28 10:32:12 2020 +0300 Commit: Stanislav Motylkov <x86corez(a)gmail.com> CommitDate: Sat Aug 15 22:57:07 2020 +0300 [USERSRV] Update Hebrew translation (#3010) Co-authored-by: Baruch Rutman <peterooch(a)gmail.com> --- win32ss/user/winsrv/usersrv/lang/he-IL.rc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/win32ss/user/winsrv/usersrv/lang/he-IL.rc b/win32ss/user/winsrv/usersrv/lang/he-IL.rc index 50ec399ea90..ef61989ef95 100644 --- a/win32ss/user/winsrv/usersrv/lang/he-IL.rc +++ b/win32ss/user/winsrv/usersrv/lang/he-IL.rc @@ -28,16 +28,16 @@ END STRINGTABLE BEGIN - IDS_SEVERITY_SUCCESS "Success" - IDS_SEVERITY_INFORMATIONAL "System Information" - IDS_SEVERITY_WARNING "System Warning" - IDS_SEVERITY_ERROR "System Error" + IDS_SEVERITY_SUCCESS "הצלחה" + IDS_SEVERITY_INFORMATIONAL "פרטי מערכת" + IDS_SEVERITY_WARNING "אזהרת מערכת" + IDS_SEVERITY_ERROR "שגיאת מערכת" END STRINGTABLE BEGIN - IDS_SYSTEM_PROCESS "System Process" - IDS_UNKNOWN_SOFTWARE_EXCEPT "unknown software exception" - IDS_OK_TERMINATE_PROGRAM "Click on OK to terminate the program." - IDS_CANCEL_DEBUG_PROGRAM "Click on CANCEL to debug the program." + IDS_SYSTEM_PROCESS "תהליך מערכת" + IDS_UNKNOWN_SOFTWARE_EXCEPT "חריגת תכנה לא ידועה" + IDS_OK_TERMINATE_PROGRAM "לחץ על אישור כדי לסיים את התוכנית." + IDS_CANCEL_DEBUG_PROGRAM "לחץ על ביטול כדי לנפות שגיאות בתוכנית." END

4 years, 2 months

[reactos] 02/02: [KMTESTS:RTL] Add initial range list tests. CORE-6372

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4bc7e664fbc1b8afcd736… commit 4bc7e664fbc1b8afcd736cc32444bf42b14fe575 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sat Jun 13 12:24:35 2020 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sat Aug 15 21:31:32 2020 +0200 [KMTESTS:RTL] Add initial range list tests. CORE-6372 --- modules/rostests/kmtests/CMakeLists.txt | 1 + modules/rostests/kmtests/kmtest_drv/testlist.c | 2 + modules/rostests/kmtests/rtl/RtlRangeList.c | 465 +++++++++++++++++++++++++ 3 files changed, 468 insertions(+) diff --git a/modules/rostests/kmtests/CMakeLists.txt b/modules/rostests/kmtests/CMakeLists.txt index 4c03a27d58f..0d7eb194aaf 100644 --- a/modules/rostests/kmtests/CMakeLists.txt +++ b/modules/rostests/kmtests/CMakeLists.txt @@ -97,6 +97,7 @@ list(APPEND KMTEST_DRV_SOURCE ntos_se/SeInheritance.c ntos_se/SeQueryInfoToken.c rtl/RtlIsValidOemCharacter.c + rtl/RtlRangeList.c ${COMMON_SOURCE} kmtest_drv/kmtest_drv.rc) diff --git a/modules/rostests/kmtests/kmtest_drv/testlist.c b/modules/rostests/kmtests/kmtest_drv/testlist.c index 8bdd245b79a..859ec68ea6c 100644 --- a/modules/rostests/kmtests/kmtest_drv/testlist.c +++ b/modules/rostests/kmtests/kmtest_drv/testlist.c @@ -69,6 +69,7 @@ KMT_TESTFUNC Test_RtlException; KMT_TESTFUNC Test_RtlIntSafe; KMT_TESTFUNC Test_RtlIsValidOemCharacter; KMT_TESTFUNC Test_RtlMemory; +KMT_TESTFUNC Test_RtlRangeList; KMT_TESTFUNC Test_RtlRegistry; KMT_TESTFUNC Test_RtlSplayTree; KMT_TESTFUNC Test_RtlStack; @@ -142,6 +143,7 @@ const KMT_TEST TestList[] = { "RtlIntSafeKM", Test_RtlIntSafe }, { "RtlIsValidOemCharacter", Test_RtlIsValidOemCharacter }, { "RtlMemoryKM", Test_RtlMemory }, + { "RtlRangeList", Test_RtlRangeList }, { "RtlRegistryKM", Test_RtlRegistry }, { "RtlSplayTreeKM", Test_RtlSplayTree }, { "RtlStackKM", Test_RtlStack }, diff --git a/modules/rostests/kmtests/rtl/RtlRangeList.c b/modules/rostests/kmtests/rtl/RtlRangeList.c new file mode 100644 index 00000000000..e487e2b9730 --- /dev/null +++ b/modules/rostests/kmtests/rtl/RtlRangeList.c @@ -0,0 +1,465 @@ +/* + * PROJECT: ReactOS kernel-mode tests + * LICENSE: LGPL-2.1-or-later (https://spdx.org/licenses/LGPL-2.1-or-later) + * PURPOSE: Test for Rtl Range Lists + * COPYRIGHT: Copyright 2020 Thomas Faber (thomas.faber(a)reactos.org) + */ + +#include <kmt_test.h> +#include <ndk/rtlfuncs.h> + +static UCHAR MyUserData1, MyUserData2; +static UCHAR MyOwner1, MyOwner2; + +/* Helpers *******************************************************************/ +static +NTSTATUS +RtlAddRangeWrapper( + _Inout_ PRTL_RANGE_LIST RangeList, + _In_ const RTL_RANGE *Range, + _In_ ULONG Flags) +{ + return RtlAddRange(RangeList, + Range->Start, + Range->End, + Range->Attributes, + Flags, + Range->UserData, + Range->Owner); +} + +static +void +ExpectRange( + _In_ PCSTR File, + _In_ INT Line, + _In_ ULONG Index, + _In_ const RTL_RANGE *ActualRange, + _In_ const RTL_RANGE *ExpectedRange) +{ + CHAR FileAndLine[128]; + RtlStringCbPrintfA(FileAndLine, sizeof(FileAndLine), "%s:%d", File, Line); + + KmtOk(ActualRange->Start == ExpectedRange->Start, FileAndLine, + "[%lu] Start = 0x%I64x, expected 0x%I64x\n", Index, ActualRange->Start, ExpectedRange->Start); + KmtOk(ActualRange->End == ExpectedRange->End, FileAndLine, + "[%lu] End = 0x%I64x, expected 0x%I64x\n", Index, ActualRange->End, ExpectedRange->End); + KmtOk(ActualRange->UserData == ExpectedRange->UserData, FileAndLine, + "[%lu] UserData = %p, expected %p\n", Index, ActualRange->UserData, ExpectedRange->UserData); + KmtOk(ActualRange->Owner == ExpectedRange->Owner, FileAndLine, + "[%lu] Owner = %p, expected %p\n", Index, ActualRange->Owner, ExpectedRange->Owner); + KmtOk(ActualRange->Attributes == ExpectedRange->Attributes, FileAndLine, + "[%lu] Attributes = 0x%x, expected 0x%x\n", Index, ActualRange->Attributes, ExpectedRange->Attributes); + KmtOk(ActualRange->Flags == ExpectedRange->Flags, FileAndLine, + "[%lu] Flags = 0x%x, expected 0x%x\n", Index, ActualRange->Flags, ExpectedRange->Flags); +} + +static +void +ExpectRangeEntryList( + _In_ PCSTR File, + _In_ INT Line, + _In_ RTL_RANGE_LIST *RangeList, + _In_ ULONG NumRanges, + _In_reads_(NumRanges) const RTL_RANGE *Ranges) +{ + NTSTATUS Status; + ULONG i; + RTL_RANGE_LIST_ITERATOR Iterator; + PRTL_RANGE Range; + CHAR FileAndLine[128]; + RtlStringCbPrintfA(FileAndLine, sizeof(FileAndLine), "%s:%d", File, Line); + + RtlFillMemory(&Iterator, sizeof(Iterator), 0x55); + Range = KmtInvalidPointer; + Status = RtlGetFirstRange(RangeList, &Iterator, &Range); +#ifdef _WIN64 + /* Padding at the end is uninitialized */ + C_ASSERT(sizeof(Iterator) == RTL_SIZEOF_THROUGH_FIELD(RTL_RANGE_LIST_ITERATOR, Stamp) + sizeof(ULONG)); + KmtOk((&Iterator.Stamp)[1] == 0x55555555, FileAndLine, + "Padding is 0x%lx\n", (&Iterator.Stamp)[1]); +#endif + + for (i = 0; i < NumRanges; i++) + { + if (!KmtSkip(NT_SUCCESS(Status), FileAndLine, "Range does not have %lu element(s)\n", i + 1)) + { + ExpectRange(File, Line, i, Range, &Ranges[i]); + + /* Validate iterator */ + KmtOk(Iterator.RangeListHead == &RangeList->ListHead, FileAndLine, + "[%lu] Iterator.RangeListHead = %p, expected %p\n", i, Iterator.RangeListHead, &RangeList->ListHead); + KmtOk(Iterator.MergedHead == NULL, FileAndLine, + "[%lu] Iterator.MergedHead = %p\n", i, Iterator.MergedHead); + KmtOk(Iterator.Current == Range, FileAndLine, + "[%lu] Iterator.Current = %p, expected %p\n", i, Iterator.Current, Range); + KmtOk(Iterator.Stamp == RangeList->Stamp, FileAndLine, + "[%lu] Iterator.Stamp = %lu, expected %lu\n", i, Iterator.Stamp, RangeList->Stamp); + } + + Range = KmtInvalidPointer; + Status = RtlGetNextRange(&Iterator, &Range, TRUE); + } + + /* Final iteration status */ + KmtOk(Status == STATUS_NO_MORE_ENTRIES, FileAndLine, + "Status = 0x%lx after enumeration\n", Status); + KmtOk(Range == NULL, FileAndLine, + "[%lu] Range = %p\n", i, Range); + KmtOk(Iterator.RangeListHead == &RangeList->ListHead, FileAndLine, + "[%lu] Iterator.RangeListHead = %p, expected %p\n", i, Iterator.RangeListHead, &RangeList->ListHead); + KmtOk(Iterator.MergedHead == NULL, FileAndLine, + "[%lu] Iterator.MergedHead = %p\n", i, Iterator.MergedHead); + KmtOk(Iterator.Current == NULL, FileAndLine, + "[%lu] Iterator.Current = %p\n", i, Iterator.Current); + KmtOk(Iterator.Stamp == RangeList->Stamp, FileAndLine, + "[%lu] Iterator.Stamp = %lu, expected %lu\n", i, Iterator.Stamp, RangeList->Stamp); + + /* Try one more iteration */ + Range = KmtInvalidPointer; + Status = RtlGetNextRange(&Iterator, &Range, TRUE); + KmtOk(Status == STATUS_NO_MORE_ENTRIES, FileAndLine, + "Status = 0x%lx after enumeration\n", Status); + KmtOk(Range == NULL, FileAndLine, + "[%lu] Range = %p\n", i, Range); + KmtOk(Iterator.RangeListHead == &RangeList->ListHead, FileAndLine, + "[%lu] Iterator.RangeListHead = %p, expected %p\n", i, Iterator.RangeListHead, &RangeList->ListHead); + KmtOk(Iterator.MergedHead == NULL, FileAndLine, + "[%lu] Iterator.MergedHead = %p\n", i, Iterator.MergedHead); + KmtOk(Iterator.Current == NULL, FileAndLine, + "[%lu] Iterator.Current = %p\n", i, Iterator.Current); + KmtOk(Iterator.Stamp == RangeList->Stamp, FileAndLine, + "[%lu] Iterator.Stamp = %lu, expected %lu\n", i, Iterator.Stamp, RangeList->Stamp); +} + +#define expect_range_entries(RangeList, NumRanges, Ranges) \ + ExpectRangeEntryList(__FILE__, __LINE__, RangeList, NumRanges, Ranges) + +/* Test functions ************************************************************/ +static +void +TestStartGreaterThanEnd( + _Inout_ PRTL_RANGE_LIST RangeList, + _Inout_ PRTL_RANGE Ranges) +{ + NTSTATUS Status; + ULONG StartStamp = RangeList->Stamp; + + Ranges[1].Start = 0x300; + Ranges[1].End = 0x2ff; + Ranges[1].Attributes = 2; + Ranges[1].Flags = 0; + Ranges[1].UserData = &MyUserData2; + Ranges[1].Owner = &MyOwner2; + + /* Start > End bails out early with invalid parameter */ + Status = RtlAddRangeWrapper(RangeList, &Ranges[1], 0); + ok_eq_hex(Status, STATUS_INVALID_PARAMETER); + + /* List should be unchanged */ + ok_eq_ulong(RangeList->Flags, 0UL); + ok_eq_ulong(RangeList->Count, 1UL); + ok_eq_ulong(RangeList->Stamp, StartStamp); + expect_range_entries(RangeList, 1, &Ranges[0]); +} + +static +void +TestStartEqualsEnd( + _Inout_ PRTL_RANGE_LIST RangeList, + _Inout_ PRTL_RANGE Ranges) +{ + NTSTATUS Status; + ULONG StartStamp = RangeList->Stamp; + + Ranges[1].Start = 0x300; + Ranges[1].End = 0x300; + Ranges[1].Attributes = 0xff; + Ranges[1].Flags = 0; + Ranges[1].UserData = &MyUserData2; + Ranges[1].Owner = &MyOwner2; + + /* Start == End is valid */ + Status = RtlAddRangeWrapper(RangeList, &Ranges[1], 0); + ok_eq_hex(Status, STATUS_SUCCESS); + + /* List now has two entries */ + ok_eq_ulong(RangeList->Flags, 0UL); + ok_eq_ulong(RangeList->Count, 2UL); + ok_eq_ulong(RangeList->Stamp, StartStamp + 1); + expect_range_entries(RangeList, 2, &Ranges[0]); + + /* Delete our new entry -- List goes back to one entry */ + Status = RtlDeleteRange(RangeList, Ranges[1].Start, Ranges[1].End, Ranges[1].Owner); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_ulong(RangeList->Flags, 0UL); + ok_eq_ulong(RangeList->Count, 1UL); + ok_eq_ulong(RangeList->Stamp, StartStamp + 2); + expect_range_entries(RangeList, 1, &Ranges[0]); +} + +static +void +TestSharedFlag( + _Inout_ PRTL_RANGE_LIST RangeList, + _Inout_ PRTL_RANGE Ranges) +{ + NTSTATUS Status; + ULONG StartStamp = RangeList->Stamp; + + Ranges[1].Start = 0x300; + Ranges[1].End = 0x400; + Ranges[1].Attributes = 2; + Ranges[1].Flags = RTL_RANGE_SHARED; + Ranges[1].UserData = &MyUserData2; + Ranges[1].Owner = &MyOwner2; + + /* Pass in the shared flag */ + Status = RtlAddRangeWrapper(RangeList, &Ranges[1], RTL_RANGE_LIST_ADD_SHARED); + ok_eq_hex(Status, STATUS_SUCCESS); + + /* List now has two entries */ + ok_eq_ulong(RangeList->Flags, 0UL); + ok_eq_ulong(RangeList->Count, 2UL); + ok_eq_ulong(RangeList->Stamp, StartStamp + 1); + expect_range_entries(RangeList, 2, &Ranges[0]); + + /* Delete our new entry -- List goes back to one entry */ + Status = RtlDeleteRange(RangeList, Ranges[1].Start, Ranges[1].End, Ranges[1].Owner); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_ulong(RangeList->Flags, 0UL); + ok_eq_ulong(RangeList->Count, 1UL); + ok_eq_ulong(RangeList->Stamp, StartStamp + 2); + expect_range_entries(RangeList, 1, &Ranges[0]); +} + +static +void +TestIsAvailable( + _Inout_ PRTL_RANGE_LIST RangeList, + _Inout_ PRTL_RANGE Ranges) +{ + NTSTATUS Status; + BOOLEAN Available; + ULONG StartStamp = RangeList->Stamp; + +#define is_range_available(RangeList, Start, End, pAvail) \ + RtlIsRangeAvailable(RangeList, \ + Start, \ + End, \ + 0, \ + 0, \ + NULL, \ + NULL, \ + pAvail) + + /* Single item range before Start */ + Status = is_range_available(RangeList, + Ranges[0].Start - 1, + Ranges[0].Start - 1, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* Single item range at Start */ + Status = is_range_available(RangeList, + Ranges[0].Start, + Ranges[0].Start, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Single item range at End */ + Status = is_range_available(RangeList, + Ranges[0].End, + Ranges[0].End, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Single item range after End */ + Status = is_range_available(RangeList, + Ranges[0].End + 1, + Ranges[0].End + 1, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* Range ending before Start */ + Status = is_range_available(RangeList, + 0x0, + Ranges[0].Start - 1, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* Range ending at Start */ + Status = is_range_available(RangeList, + 0x0, + Ranges[0].Start, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Range ending in the middle */ + Status = is_range_available(RangeList, + 0x0, + (Ranges[0].Start + Ranges[0].End) / 2, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Range going all the way through */ + Status = is_range_available(RangeList, + 0x0, + Ranges[0].End + 0x100, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Range starting in the middle */ + Status = is_range_available(RangeList, + (Ranges[0].Start + Ranges[0].End) / 2, + Ranges[0].End + 0x100, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Range starting at End */ + Status = is_range_available(RangeList, + Ranges[0].End, + Ranges[0].End + 0x100, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Range starting after End */ + Status = is_range_available(RangeList, + Ranges[0].End + 1, + Ranges[0].End + 0x100, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* Start > End, at start */ + Status = is_range_available(RangeList, + Ranges[0].Start, + Ranges[0].Start - 1, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* Start > End, at start */ + Status = is_range_available(RangeList, + Ranges[0].Start + 1, + Ranges[0].Start, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Start > End, at end */ + Status = is_range_available(RangeList, + Ranges[0].End + 1, + Ranges[0].End, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* Start > End, at end */ + Status = is_range_available(RangeList, + Ranges[0].End, + Ranges[0].End - 1, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, FALSE); + + /* Start > End, through the range */ + Status = is_range_available(RangeList, + Ranges[0].End + 1, + Ranges[0].Start - 1, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* AttributesAvailableMask will make our range available */ + Status = RtlIsRangeAvailable(RangeList, + 0x0, + Ranges[0].End + 0x100, + 0, + Ranges[0].Attributes, + NULL, + NULL, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + /* AttributesAvailableMask with additional bits */ + Status = RtlIsRangeAvailable(RangeList, + 0x0, + Ranges[0].End + 0x100, + 0, + 0xFF, + NULL, + NULL, + &Available); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_bool(Available, TRUE); + + ok_eq_ulong(RangeList->Stamp, StartStamp); +} + +/* Entry point ***************************************************************/ +START_TEST(RtlRangeList) +{ + NTSTATUS Status; + RTL_RANGE_LIST RangeList; + RTL_RANGE Ranges[5]; + ULONG Stamp; + + RtlFillMemory(&RangeList, sizeof(RangeList), 0x55); + RtlInitializeRangeList(&RangeList); + ok(IsListEmpty(&RangeList.ListHead), + "RangeList.ListHead %p %p %p, expected empty\n", + &RangeList.ListHead, RangeList.ListHead.Flink, RangeList.ListHead.Blink); + ok_eq_ulong(RangeList.Flags, 0UL); + ok_eq_ulong(RangeList.Count, 0UL); + ok_eq_ulong(RangeList.Stamp, 0UL); +#ifdef _WIN64 + /* Padding at the end is uninitialized */ + C_ASSERT(sizeof(RangeList) == RTL_SIZEOF_THROUGH_FIELD(RTL_RANGE_LIST, Stamp) + sizeof(ULONG)); + ok_eq_ulong((&RangeList.Stamp)[1], 0x55555555UL); +#endif + + /* Add a simple range */ + Ranges[0].Start = 0x100; + Ranges[0].End = 0x200; + Ranges[0].Attributes = 1; + Ranges[0].Flags = 0; + Ranges[0].UserData = &MyUserData1; + Ranges[0].Owner = &MyOwner1; + Status = RtlAddRangeWrapper(&RangeList, &Ranges[0], 0); + ok_eq_hex(Status, STATUS_SUCCESS); + ok_eq_ulong(RangeList.Flags, 0UL); + ok_eq_ulong(RangeList.Count, 1UL); + ok_eq_ulong(RangeList.Stamp, 1UL); + expect_range_entries(&RangeList, 1, &Ranges[0]); + + /* + * Individual tests. + * These should always leave the list with our single start entry. + * Stamp may change between tests. + */ + TestStartGreaterThanEnd(&RangeList, Ranges); + TestStartEqualsEnd(&RangeList, Ranges); + TestSharedFlag(&RangeList, Ranges); + TestIsAvailable(&RangeList, Ranges); + + Stamp = RangeList.Stamp; + + /* Free it and check the result */ + RtlFreeRangeList(&RangeList); + ok_eq_ulong(RangeList.Flags, 0UL); + ok_eq_ulong(RangeList.Count, 0UL); + ok_eq_ulong(RangeList.Stamp, Stamp); + expect_range_entries(&RangeList, 0, NULL); +}

4 years, 2 months

[reactos] 01/02: [NDK] Complete range list function & structure declarations. CORE-6372

by Thomas Faber

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2c4a554d72cc5c0375b9b… commit 2c4a554d72cc5c0375b9b654a445091b1e983da1 Author: Thomas Faber <thomas.faber(a)reactos.org> AuthorDate: Sat Jun 13 11:55:53 2020 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sat Aug 15 21:31:29 2020 +0200 [NDK] Complete range list function & structure declarations. CORE-6372 * Add the remaining functions & annotate. * Add the RTLP_RANGE_LIST_ENTRY structure, which is present in symbols Note: range list declarations should really be !NTOS_MODE_USER, since ntdll doesn't export these functions; however, our RTL itself is built with NTOS_MODE_USER, so that's not an option at this point. --- sdk/include/ndk/rtlfuncs.h | 94 +++++++++++++++++++++++++++++++++++++++++++++- sdk/include/ndk/rtltypes.h | 25 +++++++++++- 2 files changed, 117 insertions(+), 2 deletions(-) diff --git a/sdk/include/ndk/rtlfuncs.h b/sdk/include/ndk/rtlfuncs.h index 4fa1bde2747..85110d3c213 100644 --- a/sdk/include/ndk/rtlfuncs.h +++ b/sdk/include/ndk/rtlfuncs.h @@ -3574,7 +3574,7 @@ NTSYSAPI VOID NTAPI RtlInitializeRangeList( - _Inout_ PRTL_RANGE_LIST RangeList + _Out_ PRTL_RANGE_LIST RangeList ); NTSYSAPI @@ -3584,6 +3584,32 @@ RtlFreeRangeList( _In_ PRTL_RANGE_LIST RangeList ); +NTSYSAPI +NTSTATUS +NTAPI +RtlCopyRangeList( + _Out_ PRTL_RANGE_LIST CopyRangeList, + _In_ PRTL_RANGE_LIST RangeList +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlMergeRangeLists( + _Out_ PRTL_RANGE_LIST MergedRangeList, + _In_ PRTL_RANGE_LIST RangeList1, + _In_ PRTL_RANGE_LIST RangeList2, + _In_ ULONG Flags +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlInvertRangeList( + _Out_ PRTL_RANGE_LIST InvertedRangeList, + _In_ PRTL_RANGE_LIST RangeList +); + NTSYSAPI NTSTATUS NTAPI @@ -3597,6 +3623,72 @@ RtlAddRange( _In_opt_ PVOID Owner ); +NTSYSAPI +NTSTATUS +NTAPI +RtlDeleteRange( + _Inout_ PRTL_RANGE_LIST RangeList, + _In_ ULONGLONG Start, + _In_ ULONGLONG End, + _In_ PVOID Owner +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlDeleteOwnersRanges( + _Inout_ PRTL_RANGE_LIST RangeList, + _In_ _Maybenull_ PVOID Owner +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlFindRange( + _In_ PRTL_RANGE_LIST RangeList, + _In_ ULONGLONG Minimum, + _In_ ULONGLONG Maximum, + _In_ ULONG Length, + _In_ ULONG Alignment, + _In_ ULONG Flags, + _In_ UCHAR AttributeAvailableMask, + _In_opt_ PVOID Context, + _In_opt_ PRTL_CONFLICT_RANGE_CALLBACK Callback, + _Out_ PULONGLONG Start +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlIsRangeAvailable( + _In_ PRTL_RANGE_LIST RangeList, + _In_ ULONGLONG Start, + _In_ ULONGLONG End, + _In_ ULONG Flags, + _In_ UCHAR AttributeAvailableMask, + _In_opt_ PVOID Context, + _In_opt_ PRTL_CONFLICT_RANGE_CALLBACK Callback, + _Out_ PBOOLEAN Available +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlGetFirstRange( + _In_ PRTL_RANGE_LIST RangeList, + _Out_ PRTL_RANGE_LIST_ITERATOR Iterator, + _Outptr_ PRTL_RANGE *Range +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlGetNextRange( + _Inout_ PRTL_RANGE_LIST_ITERATOR Iterator, + _Outptr_ PRTL_RANGE *Range, + _In_ BOOLEAN MoveForwards +); + // // Debug Functions // diff --git a/sdk/include/ndk/rtltypes.h b/sdk/include/ndk/rtltypes.h index 74e8551c4be..0799bcce4cb 100644 --- a/sdk/include/ndk/rtltypes.h +++ b/sdk/include/ndk/rtltypes.h @@ -697,7 +697,6 @@ typedef NTSTATUS // // RTL Range List callbacks // -#ifdef NTOS_MODE_USER typedef BOOLEAN (NTAPI *PRTL_CONFLICT_RANGE_CALLBACK)( PVOID Context, @@ -707,6 +706,7 @@ typedef BOOLEAN // // Custom Heap Commit Routine for RtlCreateHeap // +#ifdef NTOS_MODE_USER typedef NTSTATUS (NTAPI * PRTL_HEAP_COMMIT_ROUTINE)( _In_ PVOID Base, @@ -1480,6 +1480,29 @@ typedef struct _RANGE_LIST_ITERATOR ULONG Stamp; } RTL_RANGE_LIST_ITERATOR, *PRTL_RANGE_LIST_ITERATOR; +typedef struct _RTLP_RANGE_LIST_ENTRY +{ + ULONGLONG Start; + ULONGLONG End; + union + { + struct + { + PVOID UserData; + PVOID Owner; + } Allocated; + struct + { + LIST_ENTRY ListHead; + } Merged; + }; + UCHAR Attributes; + UCHAR PublicFlags; + USHORT PrivateFlags; + LIST_ENTRY ListEntry; +} RTLP_RANGE_LIST_ENTRY, *PRTLP_RANGE_LIST_ENTRY; +C_ASSERT(RTL_SIZEOF_THROUGH_FIELD(RTL_RANGE, Flags) == RTL_SIZEOF_THROUGH_FIELD(RTLP_RANGE_LIST_ENTRY, PublicFlags)); + // // RTL Resource //

4 years, 2 months

[reactos] 01/01: [SHELL32] Russian translation for "Problem with Shortcut" dialog

by Stanislav Motylkov

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=037e84ec7f511ca925554… commit 037e84ec7f511ca9255546286bd17fc49f6a3d9a Author: Stanislav Motylkov <x86corez(a)gmail.com> AuthorDate: Sat Aug 15 17:26:15 2020 +0300 Commit: Stanislav Motylkov <x86corez(a)gmail.com> CommitDate: Sat Aug 15 17:26:15 2020 +0300 [SHELL32] Russian translation for "Problem with Shortcut" dialog Addendum to a3ec01c. CORE-16816 --- dll/win32/shell32/lang/ru-RU.rc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dll/win32/shell32/lang/ru-RU.rc b/dll/win32/shell32/lang/ru-RU.rc index 7c48ac992ff..52e20a39d8e 100644 --- a/dll/win32/shell32/lang/ru-RU.rc +++ b/dll/win32/shell32/lang/ru-RU.rc @@ -717,17 +717,17 @@ BEGIN END IDD_LINK_PROBLEM DIALOGEX 0, 0, 250, 140 -CAPTION "Problem with Shortcut" +CAPTION "Проблема с ярлыком" STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU FONT 8, "MS Shell Dlg" BEGIN ICON 0, IDC_LINK_PROBLEM_ICON, 5, 5, 0, 0 - LTEXT "The item '%s' that this shortcut refers to has been changed or moved, so this shortcut will no longer work properly.", IDC_LINK_PROBLEM_LABEL1, 35, 5, 210, 35 - LTEXT "Nearest match based on name, type, size, and date:", IDC_LINK_PROBLEM_LABEL2, 35, 45, 210, 35 - LTEXT "Do you want to fix this shortcut to point to this target or do you just want to delete it?", -1, 35, 85, 210, 30 - DEFPUSHBUTTON "&Fix it", IDOK, 55, 120, 60, 15, WS_DISABLED - PUSHBUTTON "&Delete it", IDYES, 120, 120, 60, 15 - PUSHBUTTON "Cancel", IDCANCEL, 185, 120, 60, 15 + LTEXT "Элемент '%s', на который ссылается этот ярлык, был изменён или перемещён, поэтому ярлык не будет работать правильно.", IDC_LINK_PROBLEM_LABEL1, 35, 5, 210, 35 + LTEXT "Ближайшее совпадение по имени, типу, размеру, и дате:", IDC_LINK_PROBLEM_LABEL2, 35, 45, 210, 35 + LTEXT "Вы хотите исправить назначение этого ярлыка или просто удалить его?", -1, 35, 85, 210, 30 + DEFPUSHBUTTON "&Исправить", IDOK, 55, 120, 60, 15, WS_DISABLED + PUSHBUTTON "&Удалить", IDYES, 120, 120, 60, 15 + PUSHBUTTON "Отмена", IDCANCEL, 185, 120, 60, 15 END STRINGTABLE @@ -1004,5 +1004,5 @@ BEGIN IDS_EDITING_ACTION "Изменение действия для типа: " IDS_NO_ICONS "Файл '%s' не содержит значков.\n\nВыберите значок из списка или укажите другой файл." IDS_FILE_NOT_FOUND "Файл '%s' не найден." - IDS_LINK_INVALID "The item '%s' that this shortcut refers to has been changed or moved, so this shortcut will no longer work properly." + IDS_LINK_INVALID "Элемент '%s', на который ссылается этот ярлык, был изменён или перемещён, поэтому ярлык не будет работать правильно." END

4 years, 2 months

[reactos] 01/01: [BOOTDATA] Add display name and description for Browser Service

by Stanislav Motylkov

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3d9ab23ef066a18584b57… commit 3d9ab23ef066a18584b57ae7d6dcfd5bc7f77c4c Author: Stanislav Motylkov <x86corez(a)gmail.com> AuthorDate: Sat Aug 15 15:30:08 2020 +0300 Commit: Stanislav Motylkov <x86corez(a)gmail.com> CommitDate: Sat Aug 15 15:30:08 2020 +0300 [BOOTDATA] Add display name and description for Browser Service Also add Russian translation. Addendum to 1b90e54. CORE-17201 --- boot/bootdata/hivesys.inf | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/boot/bootdata/hivesys.inf b/boot/bootdata/hivesys.inf index d3041b676a0..fd212c03001 100644 --- a/boot/bootdata/hivesys.inf +++ b/boot/bootdata/hivesys.inf @@ -2246,6 +2246,9 @@ AUDIO_SERVICE_DESCRIPTION="Provides audio facilities to applications" BITS_SERVICE="Background Intelligent Transfer Service" BITS_SERVICE_DESCRIPTION="Transfers files in the background using idle network bandwidth." +BROWSER_SERVICE="Computer Browser" +BROWSER_SERVICE_DESCRIPTION="Maintains an updated list of computers on the network and supplies this list to computers designated as browsers." + DCOMLAUNCH_SERVICE="DcomLaunch service" DCOMLAUNCH_SERVICE_DESCRIPTION="DcomLaunch service stub." @@ -2696,6 +2699,9 @@ AUDIO_SERVICE_DESCRIPTION="Обеспечивает звуковыми устр BITS_SERVICE="Фоновая интеллектуальная служба передачи (BITS)" BITS_SERVICE_DESCRIPTION="Обеспечивает передачу данных между клиентами и серверами в фоновом режиме с использованием пропускной способности простаивающей сети." +BROWSER_SERVICE="Обозреватель компьютеров" +BROWSER_SERVICE_DESCRIPTION="Обслуживает список компьютеров в сети и выдает его программам по запросу." + DCOMLAUNCH_SERVICE="DcomLaunch service" DCOMLAUNCH_SERVICE_DESCRIPTION="DcomLaunch service stub."

4 years, 2 months

[reactos] 01/01: [SHELLBTRFS] Prevent the compression dropbox from accepting free text CORE-16971

by Joachim Henze

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e95643c7c95fb83b9366c… commit e95643c7c95fb83b9366cfda9eb3ab282c82a195 Author: Joachim Henze <Joachim.Henze(a)reactos.org> AuthorDate: Sat Aug 15 13:43:00 2020 +0200 Commit: Joachim Henze <Joachim.Henze(a)reactos.org> CommitDate: Sat Aug 15 13:43:00 2020 +0200 [SHELLBTRFS] Prevent the compression dropbox from accepting free text CORE-16971 Initially proposed to ros via https://github.com/reactos/reactos/pull/2677 and already integrated upstream Apr 28, 2020 by https://github.com/maharmstone/btrfs/pull/258/commits/aba729c8f56a7267d1140… --- dll/shellext/shellbtrfs/shellbtrfs.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/shellext/shellbtrfs/shellbtrfs.rc b/dll/shellext/shellbtrfs/shellbtrfs.rc index 86034752e45..cf13a2bbe65 100644 --- a/dll/shellext/shellbtrfs/shellbtrfs.rc +++ b/dll/shellext/shellbtrfs/shellbtrfs.rc @@ -134,7 +134,7 @@ BEGIN CONTROL "Compress",IDC_COMPRESS,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,14,246,46,10 LTEXT "Size on disk:",IDC_STATIC,14,63,61,8 CONTROL "%s (<a>Details</a>)",IDC_SIZE_ON_DISK,"SysLink",WS_TABSTOP,78,63,142,8 - COMBOBOX IDC_COMPRESS_TYPE,63,245,48,13,CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + COMBOBOX IDC_COMPRESS_TYPE,63,245,48,13,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP CONTROL "Readonly subvolume",IDC_SUBVOL_RO,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,124,232,80,10 LTEXT "(blank)",IDC_SUBVOL,78,21,70,8 PUSHBUTTON "&Open as Admin",IDC_OPEN_ADMIN,151,21,70,14

4 years, 2 months

[reactos] 01/01: [SCSIPORT] Demote a noisy DPRINT1 to DPRINT CORE-17200

by Joachim Henze

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=011a9e2ae87b90cc6deca… commit 011a9e2ae87b90cc6deca8c4f2cfb1cf49954c6e Author: Joachim Henze <Joachim.Henze(a)reactos.org> AuthorDate: Sat Aug 15 12:50:03 2020 +0200 Commit: Joachim Henze <Joachim.Henze(a)reactos.org> CommitDate: Sat Aug 15 12:50:45 2020 +0200 [SCSIPORT] Demote a noisy DPRINT1 to DPRINT CORE-17200 It started to spam when more components of the MountMgr were coded during 0.4.14dev. According to Victor Perevertkin it is not crucial for us to see it, as those are 'optional MountMgr features'. Imho this points towards unimplemented stuff. No official ros release has been affected, because I did revert most of the new MountMgr features for 0.4.14release earlier. --- drivers/storage/port/scsiport/scsiport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/storage/port/scsiport/scsiport.c b/drivers/storage/port/scsiport/scsiport.c index bc4fe7d85e6..f0adf12384e 100644 --- a/drivers/storage/port/scsiport/scsiport.c +++ b/drivers/storage/port/scsiport/scsiport.c @@ -2887,7 +2887,7 @@ ScsiPortDeviceControl(IN PDEVICE_OBJECT DeviceObject, DPRINT1("Got unexpected IOCTL_MOUNTDEV_QUERY_UNIQUE_ID\n"); break; default: - DPRINT1(" got ioctl intended for the mount manager: 0x%lX\n", Stack->Parameters.DeviceIoControl.IoControlCode); + DPRINT(" got ioctl intended for the mount manager: 0x%lX\n", Stack->Parameters.DeviceIoControl.IoControlCode); break; } } else {

4 years, 2 months

[reactos] 01/01: [NTOS:PS] Fix stack memory disclosure in PsGetContextThread #3024

by Nguyen Trung Khanh

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bc584bdf9994b8e17034e… commit bc584bdf9994b8e17034e94a02788a8996aec9e9 Author: Nguyen Trung Khanh <nguyentrungkhanh97(a)gmail.com> AuthorDate: Sat Aug 15 17:18:35 2020 +0700 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Aug 15 19:18:35 2020 +0900 [NTOS:PS] Fix stack memory disclosure in PsGetContextThread #3024 Fix stack memory disclosure in PsGetContextThread. --- ntoskrnl/ps/debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/ps/debug.c b/ntoskrnl/ps/debug.c index d87595a8d54..b7ea2db32eb 100644 --- a/ntoskrnl/ps/debug.c +++ b/ntoskrnl/ps/debug.c @@ -112,7 +112,7 @@ PsGetContextThread(IN PETHREAD Thread, /* Enter SEH */ _SEH2_TRY { - /* Set default ength */ + /* Set default length */ Size = sizeof(CONTEXT); /* Read the flags */ @@ -146,6 +146,7 @@ PsGetContextThread(IN PETHREAD Thread, KeInitializeEvent(&GetSetContext.Event, NotificationEvent, FALSE); /* Set the flags and previous mode */ + RtlZeroMemory(&GetSetContext.Context, Size); GetSetContext.Context.ContextFlags = Flags; GetSetContext.Mode = PreviousMode;

4 years, 2 months

[reactos] 01/01: [FONTVIEW] Fix regression; opening files won't list files (#3045)

by Katayama Hirofumi MZ

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=49be08bc69b8921493e73… commit 49be08bc69b8921493e731f4be10ce1e61b51b19 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Sat Aug 15 07:08:40 2020 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Aug 15 07:08:40 2020 +0900 [FONTVIEW] Fix regression; opening files won't list files (#3045) Based on Mark Jansen's patch in CORE-17001. --- base/applications/fontview/fontview.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/base/applications/fontview/fontview.c b/base/applications/fontview/fontview.c index 8ef2a7cb98b..1ad824f786d 100644 --- a/base/applications/fontview/fontview.c +++ b/base/applications/fontview/fontview.c @@ -35,7 +35,7 @@ HINSTANCE g_hInstance; INT g_FontIndex = 0; INT g_NumFonts = 0; LOGFONTW g_LogFonts[64]; -LPCWSTR g_fileName; +LPCWSTR g_fileName = L""; WCHAR g_FontTitle[1024] = L""; BOOL g_FontPrint = FALSE; BOOL g_DisableInstall = FALSE; @@ -102,7 +102,6 @@ wWinMain(HINSTANCE hThisInstance, int argc; INT i; WCHAR** argv; - WCHAR szFileName[MAX_PATH] = L""; DWORD dwSize; HWND hMainWnd; MSG msg; @@ -125,6 +124,8 @@ wWinMain(HINSTANCE hThisInstance, argv = CommandLineToArgvW(GetCommandLineW(), &argc); if (argc < 2) { +#if 0 + WCHAR szFileName[MAX_PATH] = L""; OPENFILENAMEW fontOpen; WCHAR filter[MAX_PATH*2] = {0}, dialogTitle[MAX_PATH]; @@ -154,6 +155,7 @@ wWinMain(HINSTANCE hThisInstance, exiting the program altogether */ return 0; } +#endif } else { @@ -190,9 +192,9 @@ wWinMain(HINSTANCE hThisInstance, g_fileName = fileName; } - if (!AddFontResourceW(fileName)) + if (!AddFontResourceW(g_fileName)) { - ErrorMsgBox(0, IDS_ERROR_NOFONT, fileName); + ErrorMsgBox(0, IDS_ERROR_NOFONT, g_fileName); return -1; }

4 years, 2 months

[reactos] 01/01: [SHELL32] Polish translation for "Problem with Shortcut" dialog (#3043)

by Piotr Hetnarowicz

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=9170432c8f54404d65244… commit 9170432c8f54404d65244e43f20535be2dd9ad23 Author: Piotr Hetnarowicz <40692062+pithwz(a)users.noreply.github.com> AuthorDate: Fri Aug 14 19:07:32 2020 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Aug 15 02:07:32 2020 +0900 [SHELL32] Polish translation for "Problem with Shortcut" dialog (#3043) pl-pl Polish translation update for new dialog with SHORTCUT --- dll/win32/shell32/lang/pl-PL.rc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dll/win32/shell32/lang/pl-PL.rc b/dll/win32/shell32/lang/pl-PL.rc index e2686b0938b..1b5de4427d8 100644 --- a/dll/win32/shell32/lang/pl-PL.rc +++ b/dll/win32/shell32/lang/pl-PL.rc @@ -716,17 +716,17 @@ BEGIN END IDD_LINK_PROBLEM DIALOGEX 0, 0, 250, 140 -CAPTION "Problem with Shortcut" +CAPTION "Problem ze skrótem" STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU FONT 8, "MS Shell Dlg" BEGIN ICON 0, IDC_LINK_PROBLEM_ICON, 5, 5, 0, 0 - LTEXT "The item '%s' that this shortcut refers to has been changed or moved, so this shortcut will no longer work properly.", IDC_LINK_PROBLEM_LABEL1, 35, 5, 210, 35 - LTEXT "Nearest match based on name, type, size, and date:", IDC_LINK_PROBLEM_LABEL2, 35, 45, 210, 35 - LTEXT "Do you want to fix this shortcut to point to this target or do you just want to delete it?", -1, 35, 85, 210, 30 - DEFPUSHBUTTON "&Fix it", IDOK, 55, 120, 60, 15, WS_DISABLED - PUSHBUTTON "&Delete it", IDYES, 120, 120, 60, 15 - PUSHBUTTON "Cancel", IDCANCEL, 185, 120, 60, 15 + LTEXT "Element '%s', do którego odwołuje się ten skrót, został zmieniony lub przeniesiony i dlatego skrót ten nie będzie działał poprawnie.", IDC_LINK_PROBLEM_LABEL1, 35, 5, 210, 35 + LTEXT "Najbliższy odpowiednik pod względem nazwy, typu, rozmiaru i daty:", IDC_LINK_PROBLEM_LABEL2, 35, 45, 210, 35 + LTEXT "Chcesz naprawić ten skrót, tak aby wskazywał ten element docelowy, czy chcesz go usunąć?", -1, 35, 85, 210, 30 + DEFPUSHBUTTON "&Napraw", IDOK, 55, 120, 60, 15, WS_DISABLED + PUSHBUTTON "&Usuń", IDYES, 120, 120, 60, 15 + PUSHBUTTON "Anuluj", IDCANCEL, 185, 120, 60, 15 END STRINGTABLE @@ -1003,5 +1003,5 @@ BEGIN IDS_EDITING_ACTION "Edytowanie akcji dla typu: " IDS_NO_ICONS "Plik '%s' nie zawiera ikon.\n\nWybierz ikonę z listy lub określ inny plik." IDS_FILE_NOT_FOUND "Nie odnaleziono pliku '%s'." - IDS_LINK_INVALID "The item '%s' that this shortcut refers to has been changed or moved, so this shortcut will no longer work properly." + IDS_LINK_INVALID "Element '%s', do którego odwołuje się ten skrót, został zmieniony lub przeniesiony i dlatego skrót ten nie będzie działał poprawnie." END

4 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2020