Ros-diffs June 2021

ros-diffs@reactos.org

19 participants
228 discussions

[reactos] 16/26: [NTOS:PO] Do not ignore IoRegisterPlugPlayNotification return value

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=07d38cd4c527b73e5feba… commit 07d38cd4c527b73e5feba38dc0bbf31303131bdd Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 17:52:12 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:PO] Do not ignore IoRegisterPlugPlayNotification return value CORE-17637 --- ntoskrnl/po/power.c | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/ntoskrnl/po/power.c b/ntoskrnl/po/power.c index 5f100d7a8d5..7b5b39fa818 100644 --- a/ntoskrnl/po/power.c +++ b/ntoskrnl/po/power.c @@ -403,26 +403,27 @@ PoInitSystem(IN ULONG BootPhase) /* Check if this is phase 1 init */ if (BootPhase == 1) { + NTSTATUS Status; /* Register power button notification */ - IoRegisterPlugPlayNotification(EventCategoryDeviceInterfaceChange, - PNPNOTIFY_DEVICE_INTERFACE_INCLUDE_EXISTING_INTERFACES, - (PVOID)&GUID_DEVICE_SYS_BUTTON, - IopRootDeviceNode-> - PhysicalDeviceObject->DriverObject, - PopAddRemoveSysCapsCallback, - NULL, - &NotificationEntry); + Status = IoRegisterPlugPlayNotification(EventCategoryDeviceInterfaceChange, + PNPNOTIFY_DEVICE_INTERFACE_INCLUDE_EXISTING_INTERFACES, + (PVOID)&GUID_DEVICE_SYS_BUTTON, + IopRootDeviceNode->PhysicalDeviceObject->DriverObject, + PopAddRemoveSysCapsCallback, + NULL, + &NotificationEntry); + if (!NT_SUCCESS(Status)) + return FALSE; /* Register lid notification */ - IoRegisterPlugPlayNotification(EventCategoryDeviceInterfaceChange, - PNPNOTIFY_DEVICE_INTERFACE_INCLUDE_EXISTING_INTERFACES, - (PVOID)&GUID_DEVICE_LID, - IopRootDeviceNode-> - PhysicalDeviceObject->DriverObject, - PopAddRemoveSysCapsCallback, - NULL, - &NotificationEntry); - return TRUE; + Status = IoRegisterPlugPlayNotification(EventCategoryDeviceInterfaceChange, + PNPNOTIFY_DEVICE_INTERFACE_INCLUDE_EXISTING_INTERFACES, + (PVOID)&GUID_DEVICE_LID, + IopRootDeviceNode->PhysicalDeviceObject->DriverObject, + PopAddRemoveSysCapsCallback, + NULL, + &NotificationEntry); + return NT_SUCCESS(Status); } /* Initialize the power capabilities */

3 years, 6 months

[reactos] 15/26: [NTOS:INBV] Do not ignore RtlUnicodeStringToOemString return value

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=230e6b94926dd58c1105e… commit 230e6b94926dd58c1105e67e0a6702cbb9c7394b Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 17:49:40 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:INBV] Do not ignore RtlUnicodeStringToOemString return value CORE-17637 --- ntoskrnl/inbv/inbv.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/inbv/inbv.c b/ntoskrnl/inbv/inbv.c index ae7ca62f6f8..78da5d5dd84 100644 --- a/ntoskrnl/inbv/inbv.c +++ b/ntoskrnl/inbv/inbv.c @@ -960,7 +960,12 @@ NtDisplayString(IN PUNICODE_STRING DisplayString) Status = STATUS_NO_MEMORY; goto Quit; } - RtlUnicodeStringToOemString(&OemString, &CapturedString, FALSE); + Status = RtlUnicodeStringToOemString(&OemString, &CapturedString, FALSE); + if (!NT_SUCCESS(Status)) + { + ExFreePoolWithTag(OemString.Buffer, TAG_OSTR); + goto Quit; + } /* Display the string */ InbvDisplayString(OemString.Buffer);

3 years, 6 months

[reactos] 14/26: [NTOS:IO] Do not ignore RtlDuplicateUnicodeString return value

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=838abc475cfc485acdc36… commit 838abc475cfc485acdc362e0df88b4590081c8e4 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 17:47:01 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:IO] Do not ignore RtlDuplicateUnicodeString return value CORE-17637 --- ntoskrnl/io/pnpmgr/devaction.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/ntoskrnl/io/pnpmgr/devaction.c b/ntoskrnl/io/pnpmgr/devaction.c index b98c2145723..18a435f3a38 100644 --- a/ntoskrnl/io/pnpmgr/devaction.c +++ b/ntoskrnl/io/pnpmgr/devaction.c @@ -1396,6 +1396,14 @@ IopSetServiceEnumData( goto done; } + Status = RtlDuplicateUnicodeString(RTL_DUPLICATE_UNICODE_STRING_ALLOCATE_NULL_STRING, + &ServiceName, + &DeviceNode->ServiceName); + if (!NT_SUCCESS(Status)) + { + goto done; + } + RtlInitUnicodeString(&EnumKeyName, L"Enum"); Status = IopCreateRegistryKeyEx(&ServiceEnumKey, ServiceKey, @@ -1480,10 +1488,6 @@ IopSetServiceEnumData( sizeof(NextInstance)); } - RtlDuplicateUnicodeString(RTL_DUPLICATE_UNICODE_STRING_ALLOCATE_NULL_STRING, - &ServiceName, - &DeviceNode->ServiceName); - done: if (ServiceEnumKey != NULL) ZwClose(ServiceEnumKey);

3 years, 6 months

[reactos] 13/26: [NTOS:EX] Do not ignore PsCreateSystemThread return value

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cf1a95a588e077341c6c1… commit cf1a95a588e077341c6c1a3540a8f895949065c2 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 17:41:37 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:EX] Do not ignore PsCreateSystemThread return value CORE-17637 --- ntoskrnl/ex/work.c | 40 ++++++++++++++++++++++++++-------------- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/ntoskrnl/ex/work.c b/ntoskrnl/ex/work.c index a10a4878b42..9dec3405b76 100644 --- a/ntoskrnl/ex/work.c +++ b/ntoskrnl/ex/work.c @@ -254,6 +254,7 @@ ExpCreateWorkerThread(WORK_QUEUE_TYPE WorkQueueType, HANDLE hThread; ULONG Context; KPRIORITY Priority; + NTSTATUS Status; /* Check if this is going to be a dynamic thread */ Context = WorkQueueType; @@ -262,13 +263,19 @@ ExpCreateWorkerThread(WORK_QUEUE_TYPE WorkQueueType, if (Dynamic) Context |= EX_DYNAMIC_WORK_THREAD; /* Create the System Thread */ - PsCreateSystemThread(&hThread, - THREAD_ALL_ACCESS, - NULL, - NULL, - NULL, - ExpWorkerThreadEntryPoint, - UlongToPtr(Context)); + Status = PsCreateSystemThread(&hThread, + THREAD_ALL_ACCESS, + NULL, + NULL, + NULL, + ExpWorkerThreadEntryPoint, + UlongToPtr(Context)); + if (!NT_SUCCESS(Status)) + { + /* Well... */ + DPRINT1("Failed to create worker thread: 0x%08x\n", Status); + return; + } /* If the thread is dynamic */ if (Dynamic) @@ -519,6 +526,7 @@ ExpInitializeWorkerThreads(VOID) HANDLE ThreadHandle; PETHREAD Thread; ULONG i; + NTSTATUS Status; /* Setup the stack swap support */ ExInitializeFastMutex(&ExpWorkerSwapinMutex); @@ -576,13 +584,17 @@ ExpInitializeWorkerThreads(VOID) ExpCreateWorkerThread(HyperCriticalWorkQueue, FALSE); /* Create the balance set manager thread */ - PsCreateSystemThread(&ThreadHandle, - THREAD_ALL_ACCESS, - NULL, - 0, - NULL, - ExpWorkerThreadBalanceManager, - NULL); + Status = PsCreateSystemThread(&ThreadHandle, + THREAD_ALL_ACCESS, + NULL, + 0, + NULL, + ExpWorkerThreadBalanceManager, + NULL); + if (!NT_SUCCESS(Status)) + { + KeBugCheckEx(PHASE1_INITIALIZATION_FAILED, Status, 0, 0, 0); + } /* Get a pointer to it for the shutdown process */ ObReferenceObjectByHandle(ThreadHandle,

3 years, 6 months

[reactos] 12/26: [NTOS:EX] Do not ignore RtlAnsiStringToUnicodeString return value

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=93c0d324e0b4b1fe0b4cc… commit 93c0d324e0b4b1fe0b4cc9c15e24f6e99d7076cd Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 17:24:34 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:EX] Do not ignore RtlAnsiStringToUnicodeString return value CORE-17637 --- ntoskrnl/ex/sysinfo.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/ex/sysinfo.c b/ntoskrnl/ex/sysinfo.c index f02f0a1cce1..7a57c8d2c33 100644 --- a/ntoskrnl/ex/sysinfo.c +++ b/ntoskrnl/ex/sysinfo.c @@ -1008,7 +1008,11 @@ QSI_DEF(SystemProcessInformation) else { RtlInitAnsiString(&ImageName, Process->ImageFileName); - RtlAnsiStringToUnicodeString(&SpiCurrent->ImageName, &ImageName, FALSE); + Status = RtlAnsiStringToUnicodeString(&SpiCurrent->ImageName, &ImageName, FALSE); + if (!NT_SUCCESS(Status)) + { + SpiCurrent->ImageName.Length = 0; + } } } else

3 years, 6 months

[reactos] 11/26: [NTOS:MM] Check result of RtlCreateUnicodeString in MmGetFileNameForAddress

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=376fbc524227d278604f2… commit 376fbc524227d278604f252dc86ec715e968bec2 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 16:45:28 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:MM] Check result of RtlCreateUnicodeString in MmGetFileNameForAddress CORE-17637 --- ntoskrnl/mm/ARM3/section.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/mm/ARM3/section.c b/ntoskrnl/mm/ARM3/section.c index fa4bb52d999..4a65209d38b 100644 --- a/ntoskrnl/mm/ARM3/section.c +++ b/ntoskrnl/mm/ARM3/section.c @@ -1927,11 +1927,13 @@ MmGetFileNameForAddress(IN PVOID Address, if (NT_SUCCESS(Status)) { /* Init modulename */ - RtlCreateUnicodeString(ModuleName, ModuleNameInformation->Name.Buffer); + if (!RtlCreateUnicodeString(ModuleName, ModuleNameInformation->Name.Buffer)) + Status = STATUS_INSUFFICIENT_RESOURCES; /* Free temp taged buffer from MmGetFileNameForFileObject() */ ExFreePoolWithTag(ModuleNameInformation, TAG_MM); - DPRINT("Found ModuleName %S by address %p\n", ModuleName->Buffer, Address); + + DPRINT("Found ModuleName %wZ by address %p\n", ModuleName, Address); } /* Return status */

3 years, 6 months

[reactos] 10/26: [NTOS:IO] Check RtlCreateUnicodeString return value when initializing PnP services

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3f16c8615c816c7617d47… commit 3f16c8615c816c7617d478bcc155e3ae26ea3226 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 16:38:32 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:IO] Check RtlCreateUnicodeString return value when initializing PnP services CORE-17637 --- ntoskrnl/io/pnpmgr/pnpinit.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/io/pnpmgr/pnpinit.c b/ntoskrnl/io/pnpmgr/pnpinit.c index b189ac8280a..b1a5e24c8e5 100644 --- a/ntoskrnl/io/pnpmgr/pnpinit.c +++ b/ntoskrnl/io/pnpmgr/pnpinit.c @@ -435,8 +435,11 @@ IopInitializePlugPlayServices(VOID) DNF_IDS_QUERIED | DNF_NO_RESOURCE_REQUIRED; /* Create instance path */ - RtlCreateUnicodeString(&IopRootDeviceNode->InstancePath, - REGSTR_VAL_ROOT_DEVNODE); + if (!RtlCreateUnicodeString(&IopRootDeviceNode->InstancePath, REGSTR_VAL_ROOT_DEVNODE)) + { + DPRINT1("RtlCreateUnicodeString() failed\n"); + KeBugCheckEx(PHASE1_INITIALIZATION_FAILED, Status, 0, 0, 0); + } /* Call the add device routine */ IopRootDriverObject->DriverExtension->AddDevice(IopRootDriverObject,

3 years, 6 months

[reactos] 09/26: [NTOS:IO] Check RtlAnsiStringToUnicodeString return value when initializing Arc names

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=24a4e12a769ab91027dc1… commit 24a4e12a769ab91027dc1a51e7579d138a3cdd91 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 16:36:32 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:IO] Check RtlAnsiStringToUnicodeString return value when initializing Arc names CORE-17637 --- ntoskrnl/io/iomgr/arcname.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/io/iomgr/arcname.c b/ntoskrnl/io/iomgr/arcname.c index 937b5cfb0c5..3b516c40ddc 100644 --- a/ntoskrnl/io/iomgr/arcname.c +++ b/ntoskrnl/io/iomgr/arcname.c @@ -54,12 +54,16 @@ IopCreateArcNames(IN PLOADER_PARAMETER_BLOCK LoaderBlock) /* Create the global HAL partition name */ sprintf(Buffer, "\\ArcName\\%s", LoaderBlock->ArcHalDeviceName); RtlInitAnsiString(&ArcString, Buffer); - RtlAnsiStringToUnicodeString(&IoArcHalDeviceName, &ArcString, TRUE); + Status = RtlAnsiStringToUnicodeString(&IoArcHalDeviceName, &ArcString, TRUE); + if (!NT_SUCCESS(Status)) + return Status; /* Create the global system partition name */ sprintf(Buffer, "\\ArcName\\%s", LoaderBlock->ArcBootDeviceName); RtlInitAnsiString(&ArcString, Buffer); - RtlAnsiStringToUnicodeString(&IoArcBootDeviceName, &ArcString, TRUE); + Status = RtlAnsiStringToUnicodeString(&IoArcBootDeviceName, &ArcString, TRUE); + if (!NT_SUCCESS(Status)) + return Status; /* Allocate memory for the string */ Length = strlen(LoaderBlock->ArcBootDeviceName) + sizeof(ANSI_NULL);

3 years, 6 months

[reactos] 08/26: [NTOS:IO] Check RtlAnsiStringToUnicodeString return value when initializing ramdisk

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=293f8230536c79128f380… commit 293f8230536c79128f380f2dd69d2c684b4167f9 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 16:33:33 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NTOS:IO] Check RtlAnsiStringToUnicodeString return value when initializing ramdisk CORE-17637 --- ntoskrnl/include/internal/io.h | 4 ++++ ntoskrnl/io/iomgr/ramdisk.c | 10 +++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/include/internal/io.h b/ntoskrnl/include/internal/io.h index 095d63bbefc..46470e9835c 100644 --- a/ntoskrnl/include/internal/io.h +++ b/ntoskrnl/include/internal/io.h @@ -80,6 +80,10 @@ // Unable to create symbolic link pointing to the RAM disk device // #define RD_SYMLINK_CREATE_FAILED 5 +// +// Unable to create system root path when creating the RAM disk +// +#define RD_SYSROOT_INIT_FAILED 6 // // Max traversal of reparse points for a single open in IoParseDevice diff --git a/ntoskrnl/io/iomgr/ramdisk.c b/ntoskrnl/io/iomgr/ramdisk.c index b959e964fff..d83bb8050cb 100644 --- a/ntoskrnl/io/iomgr/ramdisk.c +++ b/ntoskrnl/io/iomgr/ramdisk.c @@ -262,7 +262,15 @@ IopStartRamdisk(IN PLOADER_PARAMETER_BLOCK LoaderBlock) RtlInitEmptyUnicodeString(&NtSystemRoot, SharedUserData->NtSystemRoot, sizeof(SharedUserData->NtSystemRoot)); - RtlAnsiStringToUnicodeString(&NtSystemRoot, &AnsiPath, FALSE); + Status = RtlAnsiStringToUnicodeString(&NtSystemRoot, &AnsiPath, FALSE); + if (!NT_SUCCESS(Status)) + { + KeBugCheckEx(RAMDISK_BOOT_INITIALIZATION_FAILED, + RD_SYSROOT_INIT_FAILED, + Status, + 0, + 0); + } IoCreateSymbolicLink(&DriveLetter, &DeviceString); }

3 years, 6 months

[reactos] 07/26: [NSLOOKUP] Check WSAStartup return value

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e961958823332e3d8790d… commit e961958823332e3d8790d0a106eb36619cc32ee0 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Jun 17 16:17:44 2021 +0200 Commit: Jérôme Gardou <zefklop(a)users.noreply.github.com> CommitDate: Mon Jun 28 10:20:57 2021 +0200 [NSLOOKUP] Check WSAStartup return value CORE-17637 --- base/applications/network/nslookup/nslookup.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/base/applications/network/nslookup/nslookup.c b/base/applications/network/nslookup/nslookup.c index d86803eb3aa..2f59e268b38 100644 --- a/base/applications/network/nslookup/nslookup.c +++ b/base/applications/network/nslookup/nslookup.c @@ -376,7 +376,7 @@ void PerformLookup( PCHAR pAddr ) case RCODE_NXDOMAIN: _tprintf( _T("*** %s can't find %s: Non-existant domain\n"), State.DefaultServer, pAddr ); break; - + case RCODE_REFUSED: _tprintf( _T("*** %s can't find %s: Query refused\n"), State.DefaultServer, pAddr ); break; @@ -384,7 +384,7 @@ void PerformLookup( PCHAR pAddr ) default: _tprintf( _T("*** %s can't find %s: Unknown RCODE\n"), State.DefaultServer, pAddr ); } - + goto cleanup; } @@ -761,6 +761,7 @@ int main( int argc, char* argv[] ) PFIXED_INFO pNetInfo = NULL; ULONG NetBufLen = 0; WSADATA wsaData; + int ret; ProcessHeap = GetProcessHeap(); RequestID = 1; @@ -827,7 +828,12 @@ int main( int argc, char* argv[] ) HeapFree( ProcessHeap, 0, pNetInfo ); - WSAStartup( MAKEWORD(2,2), &wsaData ); + ret = WSAStartup( MAKEWORD(2, 2), &wsaData ); + if (ret != 0) + { + _tprintf( _T("Winsock initialization failed: %d\n"), ret ); + return ret; + } switch( ParseCommandLine( argc, argv ) ) {

3 years, 6 months

← Newer
1
2
3
4
5
6
7
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2021