Ros-diffs January 2025

ros-diffs@reactos.org

23 participants
278 discussions

[reactos] 27/30: [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetKdBlockEnable/SysDbgSetKdBlockEnable

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6b89a0da1183ecdf70dd1… commit 6b89a0da1183ecdf70dd163876fab5e6d98fad44 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:43:00 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:53 2025 +0100 [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetKdBlockEnable/SysDbgSetKdBlockEnable --- ntoskrnl/ex/dbgctrl.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index a624b576463..a62345ee692 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -367,12 +367,31 @@ NtSystemDebugControl( break; case SysDbgGetTriageDump: - case SysDbgGetKdBlockEnable: - case SysDbgSetKdBlockEnable: UNIMPLEMENTED; Status = STATUS_NOT_IMPLEMENTED; break; + case SysDbgGetKdBlockEnable: + if (OutputBufferLength != sizeof(BOOLEAN)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + *(PBOOLEAN)OutputBuffer = KdBlockEnable; + Status = STATUS_SUCCESS; + } + break; + + case SysDbgSetKdBlockEnable: + Status = KdChangeOption(KD_OPTION_SET_BLOCK_ENABLE, + InputBufferLength, + InputBuffer, + OutputBufferLength, + OutputBuffer, + &Length); + break; + default: Status = STATUS_INVALID_INFO_CLASS; break;

1 week, 1 day

[reactos] 26/30: [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetKdUmExceptionEnable/SysDbgSetKdUmExceptionEnable

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d4546753f62f0d801efd6… commit d4546753f62f0d801efd6b7277a71448a2e74bb2 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:42:43 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:53 2025 +0100 [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetKdUmExceptionEnable/SysDbgSetKdUmExceptionEnable --- ntoskrnl/ex/dbgctrl.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index 0091af90f23..a624b576463 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -332,8 +332,40 @@ NtSystemDebugControl( break; case SysDbgSetPrintBufferSize: + UNIMPLEMENTED; + Status = STATUS_NOT_IMPLEMENTED; + break; + case SysDbgGetKdUmExceptionEnable: + if (OutputBufferLength != sizeof(BOOLEAN)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + /* Unfortunately, the internal flag says if UM exceptions are disabled */ + *(PBOOLEAN)OutputBuffer = !KdIgnoreUmExceptions; + Status = STATUS_SUCCESS; + } + break; + case SysDbgSetKdUmExceptionEnable: + if (InputBufferLength != sizeof(BOOLEAN)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else if (KdPitchDebugger) + { + Status = STATUS_ACCESS_DENIED; + } + else + { + /* Unfortunately, the internal flag says if UM exceptions are disabled */ + KdIgnoreUmExceptions = !*(PBOOLEAN)InputBuffer; + Status = STATUS_SUCCESS; + } + break; + case SysDbgGetTriageDump: case SysDbgGetKdBlockEnable: case SysDbgSetKdBlockEnable:

1 week, 1 day

[reactos] 25/30: [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetPrintBufferSize

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=734a043b22d56d0eee89f… commit 734a043b22d56d0eee89f546de39a632360619f4 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:42:21 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:51 2025 +0100 [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetPrintBufferSize --- ntoskrnl/ex/dbgctrl.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index 1948164397f..0091af90f23 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -319,6 +319,18 @@ NtSystemDebugControl( break; case SysDbgGetPrintBufferSize: + if (OutputBufferLength != sizeof(ULONG)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + /* Return buffer size only if KD is enabled */ + *(PULONG)OutputBuffer = KdPitchDebugger ? 0 : KdPrintBufferSize; + Status = STATUS_SUCCESS; + } + break; + case SysDbgSetPrintBufferSize: case SysDbgGetKdUmExceptionEnable: case SysDbgSetKdUmExceptionEnable:

1 week, 1 day

[reactos] 24/30: [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetAutoKdEnable/SysDbgSetAutoKdEnable

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4dc0e5cc81ef3db911b96… commit 4dc0e5cc81ef3db911b96ec0fa42d0a30f7274e8 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:41:46 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:50 2025 +0100 [NTOS:EX] Implement NtSystemDebugControl: SysDbgGetAutoKdEnable/SysDbgSetAutoKdEnable --- ntoskrnl/ex/dbgctrl.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index 048cc0c53e5..1948164397f 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -291,7 +291,33 @@ NtSystemDebugControl( break; case SysDbgGetAutoKdEnable: + if (OutputBufferLength != sizeof(BOOLEAN)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + *(PBOOLEAN)OutputBuffer = KdAutoEnableOnEvent; + Status = STATUS_SUCCESS; + } + break; + case SysDbgSetAutoKdEnable: + if (InputBufferLength != sizeof(BOOLEAN)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else if (KdPitchDebugger) + { + Status = STATUS_ACCESS_DENIED; + } + else + { + KdAutoEnableOnEvent = *(PBOOLEAN)InputBuffer; + Status = STATUS_SUCCESS; + } + break; + case SysDbgGetPrintBufferSize: case SysDbgSetPrintBufferSize: case SysDbgGetKdUmExceptionEnable:

1 week, 1 day

[reactos] 23/30: [NTOS:EX] Implement NtSystemDebugControl: SysDbgEnableKernelDebugger/SysDbgDisableKernelDebugger

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4bae44e412da6d1288350… commit 4bae44e412da6d1288350cf5b132d0ef220b301e Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:41:31 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:49 2025 +0100 [NTOS:EX] Implement NtSystemDebugControl: SysDbgEnableKernelDebugger/SysDbgDisableKernelDebugger --- ntoskrnl/ex/dbgctrl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index 8c27e3267b0..048cc0c53e5 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -283,7 +283,13 @@ NtSystemDebugControl( break; case SysDbgEnableKernelDebugger: + Status = KdEnableDebugger(); + break; + case SysDbgDisableKernelDebugger: + Status = KdDisableDebugger(); + break; + case SysDbgGetAutoKdEnable: case SysDbgSetAutoKdEnable: case SysDbgGetPrintBufferSize:

1 week, 1 day

[reactos] 22/30: [NTOS:EX] Implement NtSystemDebugControl: SysDbgBreakPoint

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7b4d618994587b6ba08d9… commit 7b4d618994587b6ba08d9794c34eb466fe121823 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:48 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:48 2025 +0100 [NTOS:EX] Implement NtSystemDebugControl: SysDbgBreakPoint --- ntoskrnl/ex/dbgctrl.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index c6553324a80..8c27e3267b0 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -271,6 +271,17 @@ NtSystemDebugControl( break; case SysDbgBreakPoint: + if (KdDebuggerEnabled) + { + DbgBreakPointWithStatus(DBG_STATUS_DEBUG_CONTROL); + Status = STATUS_SUCCESS; + } + else + { + Status = STATUS_UNSUCCESSFUL; + } + break; + case SysDbgEnableKernelDebugger: case SysDbgDisableKernelDebugger: case SysDbgGetAutoKdEnable:

1 week, 1 day

[reactos] 21/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgCheckLowMemory

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1db1bceaa728ab13c58e1… commit 1db1bceaa728ab13c58e15da866d5a602208987b Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:23 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:48 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgCheckLowMemory --- ntoskrnl/kd64/kdapi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 482c817a9bc..76f6786c112 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2571,8 +2571,7 @@ KdSystemDebugControl( break; case SysDbgCheckLowMemory: - UNIMPLEMENTED; - Status = STATUS_NOT_IMPLEMENTED; + Status = KdpSysCheckLowMemory(0); break; default:

1 week, 1 day

[reactos] 20/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadBusData/SysDbgWriteBusData

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2fe3de6c69b98fa426796… commit 2fe3de6c69b98fa4267963bafca7afea0d74cd0f Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:14 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:47 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadBusData/SysDbgWriteBusData --- ntoskrnl/kd64/kdapi.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 2d900336c24..482c817a9bc 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2509,7 +2509,67 @@ KdSystemDebugControl( break; case SysDbgReadBusData: + if (InputBufferLength != sizeof(SYSDBG_BUS_DATA)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_BUS_DATA Request = *(PSYSDBG_BUS_DATA)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoWriteAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysReadBusData(Request.BusDataType, + Request.BusNumber, + Request.SlotNumber, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgWriteBusData: + if (InputBufferLength != sizeof(SYSDBG_BUS_DATA)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_BUS_DATA Request = *(PSYSDBG_BUS_DATA)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoReadAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysWriteBusData(Request.BusDataType, + Request.BusNumber, + Request.SlotNumber, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgCheckLowMemory: UNIMPLEMENTED; Status = STATUS_NOT_IMPLEMENTED;

1 week, 1 day

[reactos] 19/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadMsr/SysDbgWriteMsr

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=19046a253bc28af7f052e… commit 19046a253bc28af7f052e35ccd23c723e5620b64 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:00 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:46 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadMsr/SysDbgWriteMsr --- ntoskrnl/kd64/kdapi.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index ed1a74e9ee1..2d900336c24 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2485,7 +2485,29 @@ KdSystemDebugControl( break; case SysDbgReadMsr: + if (InputBufferLength != sizeof(SYSDBG_MSR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + PSYSDBG_MSR Request = (PSYSDBG_MSR)InputBuffer; + Status = KdpSysReadMsr(Request->Address, &Request->Data); + } + break; + case SysDbgWriteMsr: + if (InputBufferLength != sizeof(SYSDBG_MSR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + PSYSDBG_MSR Request = (PSYSDBG_MSR)InputBuffer; + Status = KdpSysWriteMsr(Request->Address, &Request->Data); + } + break; + case SysDbgReadBusData: case SysDbgWriteBusData: case SysDbgCheckLowMemory:

1 week, 1 day

[reactos] 18/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadIoSpace/SysDbgWriteIoSpace

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b187662f3930ea3244d26… commit b187662f3930ea3244d26fd7c47e052c76ffa998 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:39:47 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:46 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadIoSpace/SysDbgWriteIoSpace --- ntoskrnl/kd64/kdapi.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 899e225f013..ed1a74e9ee1 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2423,7 +2423,67 @@ KdSystemDebugControl( break; case SysDbgReadIoSpace: + if (InputBufferLength != sizeof(SYSDBG_IO_SPACE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_IO_SPACE Request = *(PSYSDBG_IO_SPACE)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoWriteAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysReadIoSpace(Request.InterfaceType, + Request.BusNumber, + Request.AddressSpace, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgWriteIoSpace: + if (InputBufferLength != sizeof(SYSDBG_IO_SPACE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_IO_SPACE Request = *(PSYSDBG_IO_SPACE)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoReadAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysWriteIoSpace(Request.InterfaceType, + Request.BusNumber, + Request.AddressSpace, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgReadMsr: case SysDbgWriteMsr: case SysDbgReadBusData:

1 week, 1 day

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2025