https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8d91d4c8e1907ca50c348…
commit 8d91d4c8e1907ca50c3489e8f4868cf5827f1d5c
Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
AuthorDate: Tue Jan 28 14:45:15 2025 +0100
Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
CommitDate: Tue Jan 28 15:29:40 2025 +0100
[MOUNTMGR] MountMgrMountedDeviceArrival(): Fix pool buffer double-free.
`DeviceInformation->DeviceName.Buffer` was already freed via the previous
`FreePool(TargetDeviceName.Buffer);` call,
since `DeviceInformation->DeviceName` was set to `TargetDeviceName` above
in the code. This resulted in a pool double-free, triggering a corruption
of the pool, and a BSoD.
What had to be freed instead, is `DeviceInformation->SymbolicName.Buffer`
that is allocated at the beginning of the function.
---
drivers/storage/mountmgr/mountmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/storage/mountmgr/mountmgr.c b/drivers/storage/mountmgr/mountmgr.c
index 4e1552791bc..6603df3f53b 100644
--- a/drivers/storage/mountmgr/mountmgr.c
+++ b/drivers/storage/mountmgr/mountmgr.c
@@ -995,7 +995,7 @@ MountMgrMountedDeviceArrival(IN PDEVICE_EXTENSION DeviceExtension,
FreePool(UniqueId);
FreePool(TargetDeviceName.Buffer);
- FreePool(DeviceInformation->DeviceName.Buffer);
+ FreePool(DeviceInformation->SymbolicName.Buffer);
FreePool(DeviceInformation);
KeReleaseSemaphore(&(DeviceExtension->DeviceLock), IO_NO_INCREMENT, 1, FALSE);
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0e327e9a705ef20ecb846…
commit 0e327e9a705ef20ecb8460edb1e1e1b34858c81e
Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
AuthorDate: Tue Jan 28 20:17:30 2025 +0900
Commit: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com>
CommitDate: Tue Jan 28 20:17:30 2025 +0900
[REACTOS] Follow-up of #7632; Revert 3rd-party changes
CORE-19963
---
drivers/filesystems/ext2/src/nls/nls_base.c | 2 +-
drivers/filesystems/ext2/src/nls/nls_cp932.c | 2 +-
drivers/filesystems/ext2/src/nls/nls_cp936.c | 2 +-
drivers/filesystems/ext2/src/nls/nls_cp949.c | 2 +-
drivers/filesystems/ext2/src/nls/nls_cp950.c | 2 +-
drivers/filesystems/ext2/src/nls/nls_euc-jp.c | 2 +-
drivers/filesystems/nfs/nfs41_driver.c | 4 ++--
drivers/network/tcpip/lwip/src/apps/snmp/snmp_core.c | 2 +-
drivers/network/tcpip/lwip/src/apps/snmp/snmp_msg.c | 2 +-
drivers/network/tcpip/lwip/src/core/tcp.c | 2 +-
drivers/network/tcpip/lwip/src/core/udp.c | 2 +-
drivers/network/tcpip/lwip/src/include/lwip/apps/snmp_opts.h | 4 ++--
drivers/network/tcpip/lwip/src/netif/ppp/polarssl/arc4.c | 2 +-
drivers/network/tcpip/lwip/src/netif/ppp/polarssl/des.c | 2 +-
drivers/network/tcpip/lwip/src/netif/ppp/polarssl/sha1.c | 2 +-
15 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/filesystems/ext2/src/nls/nls_base.c b/drivers/filesystems/ext2/src/nls/nls_base.c
index b0b67b520ea..b1932cfb1c5 100644
--- a/drivers/filesystems/ext2/src/nls/nls_base.c
+++ b/drivers/filesystems/ext2/src/nls/nls_base.c
@@ -24,7 +24,7 @@ spinlock_t nls_lock;
/*
* Sample implementation from Unicode home page.
- * http://www.stonehand.com/unicode/standard/fss-utf.html (DEAD_LINK)
+ * http://www.stonehand.com/unicode/standard/fss-utf.html
*/
struct utf8_table {
int cmask;
diff --git a/drivers/filesystems/ext2/src/nls/nls_cp932.c b/drivers/filesystems/ext2/src/nls/nls_cp932.c
index 3562a656d28..1f005344041 100644
--- a/drivers/filesystems/ext2/src/nls/nls_cp932.c
+++ b/drivers/filesystems/ext2/src/nls/nls_cp932.c
@@ -4,7 +4,7 @@
* Charset cp932 translation tables.
* This translation table was generated automatically, the
* original table can be download from the Microsoft website.
- * (https://learn.microsoft.com/en-us/typography/)
+ * (http://www.microsoft.com/typography/unicode/unicodecp.htm)
*/
#include <linux/module.h>
diff --git a/drivers/filesystems/ext2/src/nls/nls_cp936.c b/drivers/filesystems/ext2/src/nls/nls_cp936.c
index 1320316922d..6144a12db87 100644
--- a/drivers/filesystems/ext2/src/nls/nls_cp936.c
+++ b/drivers/filesystems/ext2/src/nls/nls_cp936.c
@@ -4,7 +4,7 @@
* Charset cp936 translation tables.
* This translation table was generated automatically, the
* original table can be download from the Microsoft website.
- * (https://learn.microsoft.com/en-us/typography/)
+ * (http://www.microsoft.com/typography/unicode/unicodecp.htm)
*/
#include <linux/module.h>
diff --git a/drivers/filesystems/ext2/src/nls/nls_cp949.c b/drivers/filesystems/ext2/src/nls/nls_cp949.c
index d44fddb592b..f3b472c464c 100644
--- a/drivers/filesystems/ext2/src/nls/nls_cp949.c
+++ b/drivers/filesystems/ext2/src/nls/nls_cp949.c
@@ -4,7 +4,7 @@
* Charset cp949 translation tables.
* This translation table was generated automatically, the
* original table can be download from the Microsoft website.
- * (https://learn.microsoft.com/en-us/typography/)
+ * (http://www.microsoft.com/typography/unicode/unicodecp.htm)
*/
#include <linux/module.h>
diff --git a/drivers/filesystems/ext2/src/nls/nls_cp950.c b/drivers/filesystems/ext2/src/nls/nls_cp950.c
index 3eb42525b94..b7ef07f2403 100644
--- a/drivers/filesystems/ext2/src/nls/nls_cp950.c
+++ b/drivers/filesystems/ext2/src/nls/nls_cp950.c
@@ -4,7 +4,7 @@
* Charset cp950 translation tables.
* This translation table was generated automatically, the
* original table can be download from the Microsoft website.
- * (https://learn.microsoft.com/en-us/typography/)
+ * (http://www.microsoft.com/typography/unicode/unicodecp.htm)
*/
#include <linux/module.h>
diff --git a/drivers/filesystems/ext2/src/nls/nls_euc-jp.c b/drivers/filesystems/ext2/src/nls/nls_euc-jp.c
index 6c3947e6ca5..275ea84271e 100644
--- a/drivers/filesystems/ext2/src/nls/nls_euc-jp.c
+++ b/drivers/filesystems/ext2/src/nls/nls_euc-jp.c
@@ -3,7 +3,7 @@
*
* Added `OSF/JVC Recommended Code Set Conversion Specification
* between Japanese EUC and Shift-JIS' support: <hirofumi(a)mail.parknet.co.jp>
- * (https://web.archive.org/web/20060514215542/http://www.opengroup.or.jp/jvc/c…)
+ * (http://www.opengroup.or.jp/jvc/cde/sjis-euc-e.html)
*/
#include <linux/module.h>
diff --git a/drivers/filesystems/nfs/nfs41_driver.c b/drivers/filesystems/nfs/nfs41_driver.c
index f2ec2f4d6ef..86e8b594a9b 100644
--- a/drivers/filesystems/nfs/nfs41_driver.c
+++ b/drivers/filesystems/nfs/nfs41_driver.c
@@ -5639,8 +5639,8 @@ NTSTATUS check_nfs41_setattr_args(
goto out;
}
- /* https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-fsa/3820da…
- * https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-fsa/5555bc…
+ /* http://msdn.microsoft.com/en-us/library/ff469355(v=PROT.10).aspx
+ * http://msdn.microsoft.com/en-us/library/ff469424(v=PROT.10).aspx
* If Open.GrantedAccess does not contain FILE_WRITE_DATA, the operation
* MUST be failed with STATUS_ACCESS_DENIED.
*/
diff --git a/drivers/network/tcpip/lwip/src/apps/snmp/snmp_core.c b/drivers/network/tcpip/lwip/src/apps/snmp/snmp_core.c
index e68749ce372..04e0c317c7e 100644
--- a/drivers/network/tcpip/lwip/src/apps/snmp/snmp_core.c
+++ b/drivers/network/tcpip/lwip/src/apps/snmp/snmp_core.c
@@ -74,7 +74,7 @@
* - Developed on Windows with Visual Studio 2010.
* - Can be compiled and used on all platforms with http://www.monodevelop.com/.
* - Based on a heavily modified version of of SharpSnmpLib (a4bd05c6afb4)
- * (https://sharpsnmplib.codeplex.com/SourceControl/network/forks/Nemo157/MIBPa… (DEAD_LINK)).
+ * (https://sharpsnmplib.codeplex.com/SourceControl/network/forks/Nemo157/MIBPa…).
* This has been the last known revision of that code before being converted to
* closed source. The new code on github has completely changed, so we can not
* just update :-(
diff --git a/drivers/network/tcpip/lwip/src/apps/snmp/snmp_msg.c b/drivers/network/tcpip/lwip/src/apps/snmp/snmp_msg.c
index bd8353c3581..9cd4b071e17 100644
--- a/drivers/network/tcpip/lwip/src/apps/snmp/snmp_msg.c
+++ b/drivers/network/tcpip/lwip/src/apps/snmp/snmp_msg.c
@@ -967,7 +967,7 @@ snmp_parse_inbound_frame(struct snmp_request *request)
* 1) securityParameters was correctly serialized if we reach here.
* 2) securityParameters are already cached.
* 3) if msgAuthoritativeEngineID is unknown, zero-length or too long:
- b) https://datatracker.ietf.org/doc/html/rfc3414#section-7
+ b) https://tools.ietf.org/html/rfc3414#section-7
*/
{
const char *eid;
diff --git a/drivers/network/tcpip/lwip/src/core/tcp.c b/drivers/network/tcpip/lwip/src/core/tcp.c
index d64f34d9a3a..ea95ffeef8a 100644
--- a/drivers/network/tcpip/lwip/src/core/tcp.c
+++ b/drivers/network/tcpip/lwip/src/core/tcp.c
@@ -119,7 +119,7 @@
#endif
#ifndef TCP_LOCAL_PORT_RANGE_START
-/* From http://www.iana.org/assignments/service-names-port-numbers/service-names-po… :
+/* From http://www.iana.org/assignments/port-numbers:
"The Dynamic and/or Private Ports are those from 49152 through 65535" */
#define TCP_LOCAL_PORT_RANGE_START 0xc000
#define TCP_LOCAL_PORT_RANGE_END 0xffff
diff --git a/drivers/network/tcpip/lwip/src/core/udp.c b/drivers/network/tcpip/lwip/src/core/udp.c
index 1de8901aec2..23c2be27bd5 100644
--- a/drivers/network/tcpip/lwip/src/core/udp.c
+++ b/drivers/network/tcpip/lwip/src/core/udp.c
@@ -66,7 +66,7 @@
#include <string.h>
#ifndef UDP_LOCAL_PORT_RANGE_START
-/* From https://www.iana.org/assignments/service-names-port-numbers/service-names-p… :
+/* From http://www.iana.org/assignments/port-numbers:
"The Dynamic and/or Private Ports are those from 49152 through 65535" */
#define UDP_LOCAL_PORT_RANGE_START 0xc000
#define UDP_LOCAL_PORT_RANGE_END 0xffff
diff --git a/drivers/network/tcpip/lwip/src/include/lwip/apps/snmp_opts.h b/drivers/network/tcpip/lwip/src/include/lwip/apps/snmp_opts.h
index ec561fe6cf2..c892d22afa5 100644
--- a/drivers/network/tcpip/lwip/src/include/lwip/apps/snmp_opts.h
+++ b/drivers/network/tcpip/lwip/src/include/lwip/apps/snmp_opts.h
@@ -181,7 +181,7 @@
#define SNMP_LWIP_ENTERPRISE_OID 26381
/**
* IANA assigned enterprise ID for lwIP is 26381
- * @see https://www.iana.org/assignments/enterprise-numbers/
+ * @see http://www.iana.org/assignments/enterprise-numbers
*
* @note this enterprise ID is assigned to the lwIP project,
* all object identifiers living under this ID are assigned
@@ -190,7 +190,7 @@
*
* If you need to create your own private MIB you'll need
* to apply for your own enterprise ID with IANA:
- * https://www.iana.org/protocols
+ * http://www.iana.org/numbers.html
*/
#define SNMP_DEVICE_ENTERPRISE_OID {1, 3, 6, 1, 4, 1, SNMP_LWIP_ENTERPRISE_OID}
/**
diff --git a/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/arc4.c b/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/arc4.c
index 305f47f1f71..6e17ec421bd 100644
--- a/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/arc4.c
+++ b/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/arc4.c
@@ -35,7 +35,7 @@
/*
* The ARCFOUR algorithm was publicly disclosed on 94/09.
*
- * https://groups.google.com/g/sci.crypt/c/TPS_Ix7aTJ4/m/oPwa0skAoxAJ?pli=1
+ * http://groups.google.com/group/sci.crypt/msg/10a300c9d21afca0
*/
#include "netif/ppp/ppp_opts.h"
diff --git a/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/des.c b/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/des.c
index 2fca713a22d..9a89d007bd2 100644
--- a/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/des.c
+++ b/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/des.c
@@ -36,7 +36,7 @@
* DES, on which TDES is based, was originally designed by Horst Feistel
* at IBM in 1974, and was adopted as a standard by NIST (formerly NBS).
*
- * https://csrc.nist.gov/files/pubs/fips/46-3/final/docs/fips46-3.pdf
+ * http://csrc.nist.gov/publications/fips/fips46-3/fips46-3.pdf
*/
#include "netif/ppp/ppp_opts.h"
diff --git a/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/sha1.c b/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/sha1.c
index f28120524e7..c2192eac542 100644
--- a/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/sha1.c
+++ b/drivers/network/tcpip/lwip/src/netif/ppp/polarssl/sha1.c
@@ -35,7 +35,7 @@
/*
* The SHA-1 standard was published by NIST in 1993.
*
- * http://www.itl.nist.gov/fipspubs/fip180-1.htm (DEAD_LINK)
+ * http://www.itl.nist.gov/fipspubs/fip180-1.htm
*/
#include "netif/ppp/ppp_opts.h"