https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4ef08871ee67cafc1b356…
commit 4ef08871ee67cafc1b3566f408bd4f7a86df9a80
Author: Pierre Schweitzer <pierre(a)reactos.org>
AuthorDate: Sun Dec 17 23:30:58 2017 +0100
[NTOSKRNL] Make again an attempt at killing the IopParseDevice() hack.
For the record, the only place it was remaining was 1st stage, notably because
FSD (FastAT <3) was missing a few features. As this features weren't triggered
in 3rd stage (unless forced), it was not needed there any longer.
Now that they are implemented, and seem working out of the box, this hack might
not be longer anymore.
This is my ... ?! pfff attempt at killing it. It might not be the last, so just
disabling the hack for now. If there are no regressions (who can really believe that?)
we'll be clear for dropping it once for all.
---
ntoskrnl/io/iomgr/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ntoskrnl/io/iomgr/file.c b/ntoskrnl/io/iomgr/file.c
index 71863ccb42..11ad0529b3 100644
--- a/ntoskrnl/io/iomgr/file.c
+++ b/ntoskrnl/io/iomgr/file.c
@@ -533,7 +533,7 @@ IopParseDevice(IN PVOID ParseObject,
/* Check if we can simply use a dummy file */
UseDummyFile = ((OpenPacket->QueryOnly) || (OpenPacket->DeleteOnly));
-#if 1
+#if 0
/* FIXME: Small hack still exists, have to check why...
* This is triggered multiple times by usetup and then once per boot.
*/
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c8f2befb5ff1465123d0b…
commit c8f2befb5ff1465123d0bceb4595a00add62326f
Author: Pierre Schweitzer <pierre(a)reactos.org>
AuthorDate: Sun Dec 17 23:26:38 2017 +0100
[USETUP] Our current FAT ChkDsk being a bit slow when using the right path make
it only perform a full check if dirty bit is set (which should never happen *cough*).
This is needed because otherwise, ReactOS installation takes forever when IopParseDevice is gone
due to slow ChkDsk.
---
base/setup/usetup/chkdsk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/base/setup/usetup/chkdsk.c b/base/setup/usetup/chkdsk.c
index 1ad582a4be..6d8df5d214 100644
--- a/base/setup/usetup/chkdsk.c
+++ b/base/setup/usetup/chkdsk.c
@@ -77,7 +77,7 @@ ChkdskPartition(
Status = FileSystem->ChkdskFunc(DriveRoot,
TRUE, /* FixErrors */
FALSE, /* Verbose */
- FALSE, /* CheckOnlyIfDirty */
+ TRUE, /* CheckOnlyIfDirty */
FALSE, /* ScanDrive */
ChkdskCallback); /* Callback */