https://git.reactos.org/?p=reactos.git;a=commitdiff;h=dcd95c1a85d88c2adc98a…
commit dcd95c1a85d88c2adc98af14194e9b3057cbcb27
Author: Pierre Schweitzer <pierre(a)reactos.org>
AuthorDate: Sun Dec 17 18:25:43 2017 +0100
[FASTFAT] Add a comment (and an ASSERT) in VfatCreateFile() that shows that my stats code is broken...
---
drivers/filesystems/fastfat/create.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/filesystems/fastfat/create.c b/drivers/filesystems/fastfat/create.c
index 248d99e7f7..20a4bc0d04 100644
--- a/drivers/filesystems/fastfat/create.c
+++ b/drivers/filesystems/fastfat/create.c
@@ -982,6 +982,8 @@ VfatCreateFile(
/* FIXME : test write access if requested */
+ /* FIXME: That is broken, we cannot reach this code path with failure */
+ ASSERT(NT_SUCCESS(Status));
if (NT_SUCCESS(Status))
{
vfatAddToStat(DeviceExt, Fat.SuccessfulCreates, 1);
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=64bc96558e878cc91da14…
commit 64bc96558e878cc91da148ec5892a7e2bf58e052
Author: Pierre Schweitzer <pierre(a)reactos.org>
AuthorDate: Sun Dec 17 18:21:51 2017 +0100
[FASTFAT] While closing FCBs on dismount, release from tail to head and not the contrary.
It fixes assertion failure in vfatDestroyFCB() where we would have release parent before child.
This is still not perfect, but less bug prone...
With this commits (and ENABLE_SWAPOUT defined), ReactOS seems to unmount FAT volumes quite nice! :-)
(Tried with fsutil volume dismount X:)
---
drivers/filesystems/fastfat/fsctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/filesystems/fastfat/fsctl.c b/drivers/filesystems/fastfat/fsctl.c
index f059410044..abd772648a 100644
--- a/drivers/filesystems/fastfat/fsctl.c
+++ b/drivers/filesystems/fastfat/fsctl.c
@@ -1203,7 +1203,7 @@ VfatDismountVolume(
/* Rebrowse the FCB in order to free them now */
while (!IsListEmpty(&DeviceExt->FcbListHead))
{
- NextEntry = RemoveHeadList(&DeviceExt->FcbListHead);
+ NextEntry = RemoveTailList(&DeviceExt->FcbListHead);
Fcb = CONTAINING_RECORD(NextEntry, VFATFCB, FcbListEntry);
vfatDestroyFCB(Fcb);
}
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8f04bf3af6e941764d581…
commit 8f04bf3af6e941764d581d1b09d65b0f556caefb
Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org>
AuthorDate: Sun Dec 17 14:44:23 2017 +0100
[MSCONFIG_NEW] Temporarily "fix" the header of the SimpChinese resource file because this has nothing to do with Paint whatsoever. Proper headers will be used as soon as msconfig_new replaces the old one and such headers be used in all of its code.
---
base/applications/msconfig_new/lang/zh-CN.rc | 3 ---
1 file changed, 3 deletions(-)
diff --git a/base/applications/msconfig_new/lang/zh-CN.rc b/base/applications/msconfig_new/lang/zh-CN.rc
index ad772d76b8..f6282e7028 100644
--- a/base/applications/msconfig_new/lang/zh-CN.rc
+++ b/base/applications/msconfig_new/lang/zh-CN.rc
@@ -1,7 +1,4 @@
/*
- * PROJECT: PAINT for ReactOS
- * LICENSE: LGPL
- * FILE: base/applications/mspaint/lang/zh-CN.rc
* PURPOSE: Simplified Chinese Language resource file
* TRANSLATORS: zhangbing <e_zb(a)21cn.com, ezb(a)mail.gywb.cn>
* Li Keqing <auroracloud4096(a)gmail.com>