Ros-diffs

ros-diffs@reactos.org

81390 discussions

[aandrejevic] 59929: [SOFT386] Fix the "persistant prefix" bug. Fix the conditional jump bug. Implement Soft386ExecuteAt. [NTVDM] Add Soft386 support to ntvdm.
by aandrejevic＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: aandrejevic Date: Sat Aug 31 19:18:12 2013 New Revision: 59929 URL: http://svn.reactos.org/svn/reactos?rev=59929&view=rev Log: [SOFT386] Fix the "persistant prefix" bug. Fix the conditional jump bug. Implement Soft386ExecuteAt. [NTVDM] Add Soft386 support to ntvdm. Modified: branches/ntvdm/include/reactos/libs/soft386/soft386.h branches/ntvdm/lib/soft386/opcodes.c branches/ntvdm/lib/soft386/soft386.c branches/ntvdm/subsystems/ntvdm/emulator.c branches/ntvdm/subsystems/ntvdm/ntvdm.h Modified: branches/ntvdm/include/reactos/libs/soft386/soft386.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/include/reactos/libs/soft… ============================================================================== --- branches/ntvdm/include/reactos/libs/soft386/soft386.h [iso-8859-1] (original) +++ branches/ntvdm/include/reactos/libs/soft386/soft386.h [iso-8859-1] Sat Aug 31 19:18:12 2013 @@ -332,6 +332,10 @@ NTAPI Soft386Interrupt(PSOFT386_STATE State, UCHAR Number); +VOID +NTAPI +Soft386ExecuteAt(PSOFT386_STATE State, USHORT Segment, ULONG Offset); + #endif // _SOFT386_H_ /* EOF */ Modified: branches/ntvdm/lib/soft386/opcodes.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/soft386/opcodes.c?rev… ============================================================================== --- branches/ntvdm/lib/soft386/opcodes.c [iso-8859-1] (original) +++ branches/ntvdm/lib/soft386/opcodes.c [iso-8859-1] Sat Aug 31 19:18:12 2013 @@ -726,7 +726,7 @@ } } - if ((Opcode & 0xF0) & 1) + if (Opcode & 1) { /* Invert the result */ Jump = !Jump; Modified: branches/ntvdm/lib/soft386/soft386.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/lib/soft386/soft386.c?rev… ============================================================================== --- branches/ntvdm/lib/soft386/soft386.c [iso-8859-1] (original) +++ branches/ntvdm/lib/soft386/soft386.c [iso-8859-1] Sat Aug 31 19:18:12 2013 @@ -57,6 +57,12 @@ { /* This is not a valid opcode */ Soft386Exception(State, SOFT386_EXCEPTION_UD); + } + + if (Soft386OpcodeHandlers[Opcode] != Soft386OpcodePrefix) + { + /* A non-prefix opcode has been executed, reset the prefix flags */ + State->PrefixFlags = 0; } } while ((Command == SOFT386_CONTINUE) @@ -246,4 +252,19 @@ UNIMPLEMENTED; } +VOID +NTAPI +Soft386ExecuteAt(PSOFT386_STATE State, USHORT Segment, ULONG Offset) +{ + /* Load the new CS */ + if (!Soft386LoadSegment(State, SOFT386_REG_CS, Segment)) + { + /* An exception occurred, let the handler execute instead */ + return; + } + + /* Set the new IP */ + State->InstPtr.Long = Offset; +} + /* EOF */ Modified: branches/ntvdm/subsystems/ntvdm/emulator.c URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/ntvdm/emulator… ============================================================================== --- branches/ntvdm/subsystems/ntvdm/emulator.c [iso-8859-1] (original) +++ branches/ntvdm/subsystems/ntvdm/emulator.c [iso-8859-1] Sat Aug 31 19:18:12 2013 @@ -30,8 +30,6 @@ static BOOLEAN A20Line = FALSE; /* PRIVATE FUNCTIONS **********************************************************/ - -#ifndef NEW_EMULATOR static VOID EmulatorReadMemory(PVOID Context, UINT Address, LPBYTE Buffer, INT Size) { @@ -230,6 +228,8 @@ } } +#ifndef NEW_EMULATOR + static VOID EmulatorBop(WORD Code) { WORD StackSegment, StackPointer, CodeSegment, InstructionPointer; @@ -407,7 +407,14 @@ /* Connect the emulated FPU to the emulated CPU */ softx87_connect_to_CPU(&EmulatorContext, &FpuEmulatorContext); #else - // TODO: NOT IMPLEMENTED + /* Set the callbacks */ + EmulatorContext.MemReadCallback = (SOFT386_MEM_READ_PROC)EmulatorReadMemory; + EmulatorContext.MemWriteCallback = (SOFT386_MEM_WRITE_PROC)EmulatorWriteMemory; + EmulatorContext.IoReadCallback = (SOFT386_IO_READ_PROC)EmulatorReadIo; + EmulatorContext.IoWriteCallback = (SOFT386_IO_WRITE_PROC)EmulatorWriteIo; + + /* Reset the CPU */ + Soft386Reset(&EmulatorContext); #endif /* Enable interrupts */ @@ -426,13 +433,15 @@ #endif } +// FIXME: This function assumes 16-bit mode!!! VOID EmulatorExecute(WORD Segment, WORD Offset) { #ifndef NEW_EMULATOR /* Call the softx86 API */ softx86_set_instruction_ptr(&EmulatorContext, Segment, Offset); #else - // TODO: NOT IMPLEMENTED + /* Tell Soft386 to move the instruction pointer */ + Soft386ExecuteAt(&EmulatorContext, Segment, Offset); #endif } @@ -572,7 +581,11 @@ EmulatorInterrupt(EMULATOR_EXCEPTION_INVALID_OPCODE); } #else - // TODO: NOT IMPLEMENTED + /* Dump the state for debugging purposes */ + Soft386DumpState(&EmulatorContext); + + /* Execute the next instruction */ + Soft386StepInto(&EmulatorContext); #endif } Modified: branches/ntvdm/subsystems/ntvdm/ntvdm.h URL: http://svn.reactos.org/svn/reactos/branches/ntvdm/subsystems/ntvdm/ntvdm.h?… ============================================================================== --- branches/ntvdm/subsystems/ntvdm/ntvdm.h [iso-8859-1] (original) +++ branches/ntvdm/subsystems/ntvdm/ntvdm.h [iso-8859-1] Sat Aug 31 19:18:12 2013 @@ -27,6 +27,9 @@ #define FAR_POINTER(x) ((ULONG_PTR)BaseAddress + TO_LINEAR(HIWORD(x), LOWORD(x))) #define STEPS_PER_CYCLE 256 +// Uncomment the following to use the new Soft386 CPU emulator (EXPERIMENTAL) +// #define NEW_EMULATOR + /* FUNCTIONS ******************************************************************/ extern LPVOID BaseAddress;

1 0

[hbelusca] 59928: [RTL] Implement RtlDefaultNpAcl, needed for giving a default security to named pipes. Makes Win2k3 kernel32 happy when one creates named pipes for SCM and so on. Getting the SID o...
by hbelusca＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: hbelusca Date: Sat Aug 31 17:34:37 2013 New Revision: 59928 URL: http://svn.reactos.org/svn/reactos?rev=59928&view=rev Log: [RTL] Implement RtlDefaultNpAcl, needed for giving a default security to named pipes. Makes Win2k3 kernel32 happy when one creates named pipes for SCM and so on. Getting the SID of the caller is done as described in http://www.osronline.com/article.cfm?article=50 in "Extracting the SID from the Token". Modified: trunk/reactos/lib/rtl/security.c Modified: trunk/reactos/lib/rtl/security.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/security.c?rev=599… ============================================================================== --- trunk/reactos/lib/rtl/security.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/security.c [iso-8859-1] Sat Aug 31 17:34:37 2013 @@ -6,7 +6,7 @@ * PROGRAMMER: Eric Kohl */ -/* INCLUDES *****************************************************************/ +/* INCLUDES *******************************************************************/ #include <rtl.h> #define NDEBUG @@ -60,12 +60,160 @@ /* PUBLIC FUNCTIONS ***********************************************************/ -NTSTATUS -NTAPI -RtlDefaultNpAcl(OUT PACL Acl) -{ - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; +/* + * @implemented + */ +NTSTATUS +NTAPI +RtlDefaultNpAcl(OUT PACL *pAcl) +{ + NTSTATUS Status; + HANDLE TokenHandle; + PTOKEN_OWNER OwnerSid; + ULONG ReturnLength = 0; + ULONG AclSize; + SID_IDENTIFIER_AUTHORITY NtAuthority = {SECURITY_NT_AUTHORITY}; + SID_IDENTIFIER_AUTHORITY WorldAuthority = {SECURITY_WORLD_SID_AUTHORITY}; + + /* + * Temporary buffer large enough to hold a maximum of two SIDs. + * An alternative is to call RtlAllocateAndInitializeSid many times... + */ + UCHAR SidBuffer[16]; + PSID Sid = (PSID)&SidBuffer; + + ASSERT(RtlLengthRequiredSid(2) == 16); + + /* Initialize the user ACL pointer */ + *pAcl = NULL; + + /* + * Try to retrieve the SID of the current owner. For that, + * we first attempt to get the current thread level token. + */ + Status = NtOpenThreadToken(NtCurrentThread(), + TOKEN_QUERY, + TRUE, + &TokenHandle); + if (Status == STATUS_NO_TOKEN) + { + /* + * No thread level token, so use the process level token. + * This is the common case since the only time a thread + * has a token is when it is impersonating. + */ + Status = NtOpenProcessToken(NtCurrentProcess(), + TOKEN_QUERY, + &TokenHandle); + } + /* Fail if we didn't succeed in retrieving a handle to the token */ + if (!NT_SUCCESS(Status)) return Status; + + /* + * Retrieve the owner SID from the token. + */ + + /* Query the needed size... */ + Status = NtQueryInformationToken(TokenHandle, + TokenOwner, + NULL, 0, + &ReturnLength); + /* ... so that we must fail with STATUS_BUFFER_TOO_SMALL error */ + if (Status != STATUS_BUFFER_TOO_SMALL) goto Cleanup1; + + /* Allocate space for the owner SID */ + OwnerSid = RtlAllocateHeap(RtlGetProcessHeap(), 0, ReturnLength); + if (OwnerSid == NULL) + { + Status = STATUS_NO_MEMORY; + goto Cleanup1; + } + + /* Retrieve the owner SID; we must succeed */ + Status = NtQueryInformationToken(TokenHandle, + TokenOwner, + OwnerSid, + ReturnLength, + &ReturnLength); + if (!NT_SUCCESS(Status)) goto Cleanup2; + + /* + * Allocate one ACL with 5 ACEs. + * + * NOTE: sizeof(ACE) == sizeof(ACCESS_ALLOWED_ACE) - sizeof(((ACCESS_ALLOWED_ACE*)NULL)->SidStart) + * (see kernel32/client/debugger.c line 54). + */ + AclSize = sizeof(ACL) + // Header + 5 * sizeof(ACE /*ACCESS_ALLOWED_ACE*/) + // 5 ACEs: + RtlLengthRequiredSid(1) + // LocalSystem + RtlLengthRequiredSid(2) + // Administrators + RtlLengthRequiredSid(1) + // Anonymous + RtlLengthRequiredSid(1) + // World + RtlLengthSid(OwnerSid->Owner); // Owner + + *pAcl = RtlAllocateHeap(RtlGetProcessHeap(), 0, AclSize); + if (*pAcl == NULL) + { + Status = STATUS_NO_MEMORY; + goto Cleanup2; + } + + /* + * Build the ACL and add the five ACEs. + */ + Status = RtlCreateAcl(*pAcl, AclSize, ACL_REVISION2); + ASSERT(NT_SUCCESS(Status)); + + /* Local System SID - Generic All */ + Status = RtlInitializeSid(Sid, &NtAuthority, 1); + ASSERT(NT_SUCCESS(Status)); + *RtlSubAuthoritySid(Sid, 0) = SECURITY_LOCAL_SYSTEM_RID; + Status = RtlAddAccessAllowedAce(*pAcl, ACL_REVISION2, GENERIC_ALL, Sid); + ASSERT(NT_SUCCESS(Status)); + + /* Administrators SID - Generic All */ + Status = RtlInitializeSid(Sid, &NtAuthority, 2); + ASSERT(NT_SUCCESS(Status)); + *RtlSubAuthoritySid(Sid, 0) = SECURITY_BUILTIN_DOMAIN_RID; + *RtlSubAuthoritySid(Sid, 1) = DOMAIN_ALIAS_RID_ADMINS; + Status = RtlAddAccessAllowedAce(*pAcl, ACL_REVISION2, GENERIC_ALL, Sid); + ASSERT(NT_SUCCESS(Status)); + + /* Owner SID - Generic All */ + RtlAddAccessAllowedAce(*pAcl, ACL_REVISION2, GENERIC_ALL, OwnerSid->Owner); + ASSERT(NT_SUCCESS(Status)); + + /* Anonymous SID - Generic Read */ + Status = RtlInitializeSid(Sid, &NtAuthority, 1); + ASSERT(NT_SUCCESS(Status)); + *RtlSubAuthoritySid(Sid, 0) = SECURITY_ANONYMOUS_LOGON_RID; + Status = RtlAddAccessAllowedAce(*pAcl, ACL_REVISION2, GENERIC_READ, Sid); + ASSERT(NT_SUCCESS(Status)); + + /* World SID - Generic Read */ + Status = RtlInitializeSid(Sid, &WorldAuthority, 1); + ASSERT(NT_SUCCESS(Status)); + *RtlSubAuthoritySid(Sid, 0) = SECURITY_WORLD_RID; + Status = RtlAddAccessAllowedAce(*pAcl, ACL_REVISION2, GENERIC_READ, Sid); + ASSERT(NT_SUCCESS(Status)); + + /* If some problem happened, cleanup everything */ + if (!NT_SUCCESS(Status)) + { + RtlFreeHeap(RtlGetProcessHeap(), 0, *pAcl); + *pAcl = NULL; + } + +Cleanup2: + /* Get rid of the owner SID */ + RtlFreeHeap(RtlGetProcessHeap(), 0, OwnerSid); + +Cleanup1: + /* Close the token handle */ + NtClose(TokenHandle); + + /* Done */ + return Status; } /*

1 0

[gadamopoulos] 59927: [browseui] - Improve the stub for CAddressEditBox::SetOwner to make the rest of browseui happy for now - In CShellBrowser::Initialize browse to the pidl that is passed as para...
by gadamopoulos＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: gadamopoulos Date: Sat Aug 31 16:55:49 2013 New Revision: 59927 URL: http://svn.reactos.org/svn/reactos?rev=59927&view=rev Log: [browseui] - Improve the stub for CAddressEditBox::SetOwner to make the rest of browseui happy for now - In CShellBrowser::Initialize browse to the pidl that is passed as parameter instead of always browsing to the desktop folder - Fix a bug in atl class CContainedWindowT::DefWindowProc that was calling the window proc with an invalid hwnd. Modified: trunk/reactos/dll/win32/browseui/addresseditbox.cpp trunk/reactos/dll/win32/browseui/shellbrowser.cpp trunk/reactos/lib/atl/atlwin.h Modified: trunk/reactos/dll/win32/browseui/addresseditbox.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/address… ============================================================================== --- trunk/reactos/dll/win32/browseui/addresseditbox.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/addresseditbox.cpp [iso-8859-1] Sat Aug 31 16:55:49 2013 @@ -50,7 +50,7 @@ HRESULT STDMETHODCALLTYPE CAddressEditBox::SetOwner(IUnknown *) { // connect to browser connection point - return E_NOTIMPL; + return 0; } HRESULT STDMETHODCALLTYPE CAddressEditBox::FileSysChange(long param8, long paramC) Modified: trunk/reactos/dll/win32/browseui/shellbrowser.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/shellbr… ============================================================================== --- trunk/reactos/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] Sat Aug 31 16:55:49 2013 @@ -798,17 +798,12 @@ _AtlBaseModule.GetModuleInstance(), 0); fStatusBarVisible = true; - LPITEMIDLIST desktopPIDL; FOLDERSETTINGS newFolderSettings; - // browse desktop - hResult = SHGetFolderLocation(NULL, CSIDL_DESKTOP, NULL, 0, &desktopPIDL); - if (FAILED(hResult)) - return hResult; + // browse newFolderSettings.ViewMode = FVM_LIST; newFolderSettings.fFlags = 0; - hResult = BrowseToPIDL(desktopPIDL, BTP_UPDATE_NEXT_HISTORY); - ILFree(desktopPIDL); + hResult = BrowseToPIDL(pidl, BTP_UPDATE_NEXT_HISTORY); if (FAILED(hResult)) return hResult; Modified: trunk/reactos/lib/atl/atlwin.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/atl/atlwin.h?rev=59927… ============================================================================== --- trunk/reactos/lib/atl/atlwin.h [iso-8859-1] (original) +++ trunk/reactos/lib/atl/atlwin.h [iso-8859-1] Sat Aug 31 16:55:49 2013 @@ -585,10 +585,7 @@ LRESULT DefWindowProc(UINT uMsg, WPARAM wParam, LPARAM lParam) { - CWindowImplBaseT<TBase, TWinTraits> *pThis; - - pThis = reinterpret_cast<CWindowImplBaseT<TBase, TWinTraits> *>(this); - return ::CallWindowProc(m_pfnSuperWindowProc, pThis->m_hWnd, uMsg, wParam, lParam); + return ::CallWindowProc(m_pfnSuperWindowProc, this->m_hWnd, uMsg, wParam, lParam); } BOOL SubclassWindow(HWND hWnd)

1 0

[fireball] 59926: [NTOS/FSRTL] - FsRtlCopyWrite: Fix typos in local var names and comments. - FsRtlCopyWrite: Fix copypasta in a call to FastIoCheckIfPossible: wait flag shouldn't be always TRUE in...
by fireball＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: fireball Date: Sat Aug 31 16:36:34 2013 New Revision: 59926 URL: http://svn.reactos.org/svn/reactos?rev=59926&view=rev Log: [NTOS/FSRTL] - FsRtlCopyWrite: Fix typos in local var names and comments. - FsRtlCopyWrite: Fix copypasta in a call to FastIoCheckIfPossible: wait flag shouldn't be always TRUE in this case (it's determined by Wait parameter). - FsRtlCopyRead: Fix updating of CurrentByteOffset. - FsRtlAcquireFileForCcFlushEx / FsRtlReleaseFileForCcFlush: Handle the case when FastIO callback may fail and FsRtl still needs to act as if FastIO callback would be missing at all. - Implement FsRtlAcquireFileForModWriteEx / FsRtlReleaseFileForModWrite thanks to Rajeev Nagar's book. - Now all necessary FsRtl locking/unlocking mechanisms exist. Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/fastio.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/fastio.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fsrtl/fastio.c [iso-8859-1] Sat Aug 31 16:36:34 2013 @@ -229,7 +229,7 @@ /* Update the current file offset */ if (Result == TRUE) { - FileObject->CurrentByteOffset.QuadPart += IoStatus->Information; + FileObject->CurrentByteOffset.QuadPart = FileOffset->QuadPart + IoStatus->Information; } } _SEH2_EXCEPT(FsRtlIsNtstatusExpected(_SEH2_GetExceptionCode()) ? @@ -282,7 +282,7 @@ BOOLEAN FileOffsetAppend = (FileOffset->HighPart == (LONG)0xffffffff) && (FileOffset->LowPart == 0xffffffff); - BOOLEAN ResourceAquiredShared = FALSE; + BOOLEAN ResourceAcquiredShared = FALSE; BOOLEAN b_4GB = FALSE; BOOLEAN FileSizeModified = FALSE; LARGE_INTEGER OldFileSize; @@ -337,7 +337,7 @@ (Offset.LowPart <= FcbHeader->ValidDataLength.LowPart)) { ExAcquireResourceSharedLite(FcbHeader->Resource, TRUE); - ResourceAquiredShared = TRUE; + ResourceAcquiredShared = TRUE; } else { @@ -380,7 +380,7 @@ * release the lock and acquire it exclusively, because * we are going to need to update the FcbHeader. */ - if (ResourceAquiredShared && + if (ResourceAcquiredShared && (NewSize.LowPart > FcbHeader->ValidDataLength.LowPart + 0x2000)) { /* Then we need to acquire the resource exclusive */ @@ -566,7 +566,7 @@ { goto LeaveCriticalAndFail; } - ResourceAquiredShared = TRUE; + ResourceAcquiredShared = TRUE; } else { @@ -602,7 +602,7 @@ (FcbHeader->AllocationSize.QuadPart >= NewSize.QuadPart)) { /* Check if we can keep the lock shared */ - if (ResourceAquiredShared && + if (ResourceAcquiredShared && (NewSize.QuadPart > FcbHeader->ValidDataLength.QuadPart)) { ExReleaseResourceLite(FcbHeader->Resource); @@ -653,7 +653,7 @@ &FcbHeader->FileSize : FileOffset, Length, - TRUE, + Wait, LockKey, FALSE, &FastIoCheckIfPossibleStatus, @@ -708,8 +708,8 @@ &Offset, Wait))) { - /* If this operation fails, then we have to exit. We can jump - * outside the SEH, so I a using a variable to exit normally. + /* If this operation fails, then we have to exit. We can't jump + * outside the SEH, so I am using a variable to exit normally. */ CallCc = FALSE; } @@ -1303,7 +1303,7 @@ (FileOffset->LowPart == 0xffffffff); BOOLEAN FileSizeModified = FALSE; - BOOLEAN ResourceAquiredShared = FALSE; + BOOLEAN ResourceAcquiredShared = FALSE; /* Initialize some of the vars and pointers */ OldFileSize.QuadPart = 0; @@ -1339,7 +1339,7 @@ { /* Acquire the resource shared */ ExAcquireResourceSharedLite(FcbHeader->Resource, TRUE); - ResourceAquiredShared = TRUE; + ResourceAcquiredShared = TRUE; } else { @@ -1365,7 +1365,7 @@ (NewSize.QuadPart <= FcbHeader->AllocationSize.QuadPart)) { /* Check if we can keep the lock shared */ - if (ResourceAquiredShared && + if (ResourceAcquiredShared && (NewSize.QuadPart > FcbHeader->ValidDataLength.QuadPart)) { ExReleaseResourceLite(FcbHeader->Resource); @@ -1650,6 +1650,7 @@ PFSRTL_COMMON_FCB_HEADER FcbHeader; PDEVICE_OBJECT DeviceObject, BaseDeviceObject; PFAST_IO_DISPATCH FastDispatch; + NTSTATUS Status; /* Get the Base File System (Volume) and Fast Calls */ FcbHeader = (PFSRTL_COMMON_FCB_HEADER)FileObject->FsContext; @@ -1665,25 +1666,31 @@ FastDispatch->AcquireForCcFlush) { /* Call the AcquireForCcFlush FastIo handler */ - FastDispatch->AcquireForCcFlush(FileObject, BaseDeviceObject); - } - else - { - /* No FastIo handler, acquire file's resource */ - if (FcbHeader->Resource) - { - /* Acquire it - either shared if it's already acquired - or exclusively if we are the first */ - if (ExIsResourceAcquiredSharedLite(FcbHeader->Resource)) - ExAcquireResourceSharedLite(FcbHeader->Resource, TRUE); - else - ExAcquireResourceExclusiveLite(FcbHeader->Resource, TRUE); - } - - /* Also acquire its Paging I/O resource */ - if (FcbHeader->PagingIoResource) - ExAcquireResourceSharedLite(FcbHeader->PagingIoResource, TRUE); - } + Status = FastDispatch->AcquireForCcFlush(FileObject, BaseDeviceObject); + + /* Return either success or inability to wait. + In case of other failure - fall through */ + if (Status == STATUS_SUCCESS || + Status == STATUS_CANT_WAIT) + { + return Status; + } + } + + /* No FastIo handler (or it failed). Acquire Main resource */ + if (FcbHeader->Resource) + { + /* Acquire it - either shared if it's already acquired + or exclusively if we are the first */ + if (ExIsResourceAcquiredSharedLite(FcbHeader->Resource)) + ExAcquireResourceSharedLite(FcbHeader->Resource, TRUE); + else + ExAcquireResourceExclusiveLite(FcbHeader->Resource, TRUE); + } + + /* Also acquire its PagingIO resource */ + if (FcbHeader->PagingIoResource) + ExAcquireResourceSharedLite(FcbHeader->PagingIoResource, TRUE); return STATUS_SUCCESS; } @@ -1712,6 +1719,7 @@ PFSRTL_COMMON_FCB_HEADER FcbHeader; PDEVICE_OBJECT DeviceObject, BaseDeviceObject; PFAST_IO_DISPATCH FastDispatch; + NTSTATUS Status = STATUS_INVALID_DEVICE_REQUEST; /* Get Device Object and Fast Calls */ FcbHeader = (PFSRTL_COMMON_FCB_HEADER)FileObject->FsContext; @@ -1724,11 +1732,13 @@ FastDispatch->ReleaseForCcFlush) { /* Call the ReleaseForCcFlush FastIo handler */ - FastDispatch->ReleaseForCcFlush(FileObject, BaseDeviceObject); - } - else - { - /* No FastIo handler, release PagingIO and then file's resource */ + Status = FastDispatch->ReleaseForCcFlush(FileObject, BaseDeviceObject); + } + + if (!NT_SUCCESS(Status)) + { + /* No FastIo handler (or it failed). Release PagingIO resource and + then Main resource */ if (FcbHeader->PagingIoResource) ExReleaseResourceLite(FcbHeader->PagingIoResource); if (FcbHeader->Resource) ExReleaseResourceLite(FcbHeader->Resource); } @@ -1736,6 +1746,192 @@ /* Release master FsRtl lock */ FsRtlExitFileSystem(); } + +/* +* @implemented +*/ +NTSTATUS +NTAPI +FsRtlAcquireFileForModWriteEx(IN PFILE_OBJECT FileObject, + IN PLARGE_INTEGER EndingOffset, + IN PERESOURCE *ResourceToRelease) +{ + PFSRTL_COMMON_FCB_HEADER FcbHeader; + PDEVICE_OBJECT DeviceObject, BaseDeviceObject; + PFAST_IO_DISPATCH FastDispatch; + PERESOURCE ResourceToAcquire = NULL; + BOOLEAN Exclusive = FALSE; + BOOLEAN Result; + NTSTATUS Status = STATUS_SUCCESS; + + /* Get Device Object and Fast Calls */ + FcbHeader = (PFSRTL_COMMON_FCB_HEADER)FileObject->FsContext; + DeviceObject = IoGetRelatedDeviceObject(FileObject); + BaseDeviceObject = IoGetBaseFileSystemDeviceObject(FileObject); + FastDispatch = DeviceObject->DriverObject->FastIoDispatch; + + /* Check if Fast Calls are supported, and check AcquireForModWrite */ + if (FastDispatch && + FastDispatch->AcquireForModWrite) + { + /* Call the AcquireForModWrite FastIo handler */ + Status = FastDispatch->AcquireForModWrite(FileObject, + EndingOffset, + ResourceToRelease, + BaseDeviceObject); + + /* Return either success or inability to wait. + In case of other failure - fall through */ + if (Status == STATUS_SUCCESS || + Status == STATUS_CANT_WAIT) + { + return Status; + } + } + + Status = STATUS_SUCCESS; + + /* No FastIo handler, use algorithm from Nagar p.550. */ + if (!FcbHeader->Resource) + { + *ResourceToRelease = NULL; + return STATUS_SUCCESS; + } + + /* Default condition - shared acquiring of Paging IO Resource */ + ResourceToAcquire = FcbHeader->PagingIoResource; + + /* Decide on type of locking and type of resource based on historical magic + well explain by Nagar in p. 550-551 */ + if ((EndingOffset->QuadPart > FcbHeader->ValidDataLength.QuadPart && + FcbHeader->FileSize.QuadPart != FcbHeader->ValidDataLength.QuadPart) || + (FcbHeader->Flags & FSRTL_FLAG_ACQUIRE_MAIN_RSRC_EX)) + { + /* Either exclusive flag is set or write operation is extending + the valid data length. Prefer exclusive acquire then */ + Exclusive = TRUE; + ResourceToAcquire = FcbHeader->Resource; + } + else if (!FcbHeader->PagingIoResource || + (FcbHeader->Flags & FSRTL_FLAG_ACQUIRE_MAIN_RSRC_SH)) + { + /* Acquire main resource shared if flag is specified or + if PagingIo resource is missing */ + Exclusive = FALSE; + ResourceToAcquire = FcbHeader->Resource; + } + + /* Acquire the resource in the loop, since the above code is unsafe */ + while (TRUE) + { + Result = FALSE; + + if (Exclusive) + Result = ExAcquireResourceExclusiveLite(ResourceToAcquire, FALSE); + else + Result = ExAcquireSharedWaitForExclusive(ResourceToAcquire, FALSE); + + if (!Result) { + Status = STATUS_CANT_WAIT; + break; + } + + /* Do the magic ifs again */ + if ((EndingOffset->QuadPart > FcbHeader->ValidDataLength.QuadPart) || + (FcbHeader->Flags & FSRTL_FLAG_ACQUIRE_MAIN_RSRC_EX)) + { + /* Check what we have */ + if (Exclusive) + { + /* Asked for exclusive, got exclusive! */ + break; + } + else + { + /* Asked for exclusive, got shared. Release it and retry. */ + ExReleaseResourceLite(ResourceToAcquire); + Exclusive = TRUE; + ResourceToAcquire = FcbHeader->Resource; + } + } + else if (FcbHeader->Flags & FSRTL_FLAG_ACQUIRE_MAIN_RSRC_SH) + { + if (Exclusive) + { + /* Asked for shared, got exclusive - convert */ + ExConvertExclusiveToSharedLite(ResourceToAcquire); + break; + } + else if (ResourceToAcquire != FcbHeader->Resource) + { + /* Asked for main resource, got something else */ + ExReleaseResourceLite(ResourceToAcquire); + ResourceToAcquire = FcbHeader->Resource; + Exclusive = TRUE; + } + } + else if (FcbHeader->PagingIoResource && + ResourceToAcquire != FcbHeader->PagingIoResource) + { + /* There is PagingIo resource, but other resource was acquired */ + ResourceToAcquire = FcbHeader->PagingIoResource; + if (!ExAcquireSharedWaitForExclusive(ResourceToAcquire, FALSE)) + { + Status = STATUS_CANT_WAIT; + ExReleaseResourceLite(FcbHeader->Resource); + } + + break; + } + else if (Exclusive) + { + /* Asked for shared got exclusive - convert */ + ExConvertExclusiveToSharedLite(ResourceToAcquire); + break; + } + } + + /* If the resource was acquired successfully - pass it to the caller */ + if (NT_SUCCESS(Status)) + *ResourceToRelease = ResourceToAcquire; + + return Status; +} + +/* +* @implemented +*/ +VOID +NTAPI +FsRtlReleaseFileForModWrite(IN PFILE_OBJECT FileObject, + IN PERESOURCE ResourceToRelease) +{ + PDEVICE_OBJECT DeviceObject, BaseDeviceObject; + PFAST_IO_DISPATCH FastDispatch; + NTSTATUS Status = STATUS_SUCCESS; + + /* Get Device Object and Fast Calls */ + DeviceObject = IoGetRelatedDeviceObject(FileObject); + BaseDeviceObject = IoGetBaseFileSystemDeviceObject(FileObject); + FastDispatch = DeviceObject->DriverObject->FastIoDispatch; + + /* Check if Fast Calls are supported and check ReleaseFileForNtCreateSection */ + if (FastDispatch && + FastDispatch->ReleaseForModWrite) + { + /* Call the ReleaseForModWrite FastIo handler */ + Status = FastDispatch->ReleaseForModWrite(FileObject, + ResourceToRelease, + BaseDeviceObject); + } + + /* Just release the resource if previous op failed */ + if (!NT_SUCCESS(Status)) + { + ExReleaseResourceLite(ResourceToRelease); + } +} + /*++ * @name FsRtlRegisterFileSystemFilterCallbacks

1 0

[akhaldi] 59925: [APPWIZ] * Addendum to r59924. Radek please review.
by akhaldi＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: akhaldi Date: Sat Aug 31 16:28:01 2013 New Revision: 59925 URL: http://svn.reactos.org/svn/reactos?rev=59925&view=rev Log: [APPWIZ] * Addendum to r59924. Radek please review. Modified: trunk/reactos/dll/cpl/appwiz/lang/cs-CZ.rc Modified: trunk/reactos/dll/cpl/appwiz/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/cs-CZ.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/cs-CZ.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/cs-CZ.rc [iso-8859-1] Sat Aug 31 16:28:01 2013 @@ -66,7 +66,7 @@ CAPTION "Wine Gecko InstalÃ¡tor" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine nenalezlo balÃÄek Gecko nutnÃ½ k tomu, aby aplikace zapouzdÅujÃcÃ HTML fungovaly sprÃ¡vnÄ. Wine jej mÅ¯Å¾e automaticky stÃ¡hnout a nainstalovat.\n\nPoznÃ¡mka: doporuÄujeme pouÅ¾Ãt balÃÄek dodÃ¡vanÃ½ s distribucÃ. Pro vÃce informacÃ viz <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a>.", + CONTROL "ReactOS nenalezlo balÃÄek Wine Gecko nutnÃ½ k tomu, aby aplikace zapouzdÅujÃcÃ HTML fungovaly sprÃ¡vnÄ. ReactOS jej mÅ¯Å¾e automaticky stÃ¡hnout a nainstalovat.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Instalovat", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP

1 0

[akhaldi] 59924: [APPWIZ] * Remove some Wine specific text and introduce a tiny update to the German translation. By zehnvor. CORE-7221 #resolve #comment Committed in r59924. Danke.
by akhaldi＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: akhaldi Date: Sat Aug 31 16:14:12 2013 New Revision: 59924 URL: http://svn.reactos.org/svn/reactos?rev=59924&view=rev Log: [APPWIZ] * Remove some Wine specific text and introduce a tiny update to the German translation. By zehnvor. CORE-7221 #resolve #comment Committed in r59924. Danke. Modified: trunk/reactos/dll/cpl/appwiz/lang/bg-BG.rc trunk/reactos/dll/cpl/appwiz/lang/de-DE.rc trunk/reactos/dll/cpl/appwiz/lang/el-GR.rc trunk/reactos/dll/cpl/appwiz/lang/en-US.rc trunk/reactos/dll/cpl/appwiz/lang/es-ES.rc trunk/reactos/dll/cpl/appwiz/lang/fr-FR.rc trunk/reactos/dll/cpl/appwiz/lang/he-IL.rc trunk/reactos/dll/cpl/appwiz/lang/it-IT.rc trunk/reactos/dll/cpl/appwiz/lang/no-NO.rc trunk/reactos/dll/cpl/appwiz/lang/pl-PL.rc trunk/reactos/dll/cpl/appwiz/lang/pt-BR.rc trunk/reactos/dll/cpl/appwiz/lang/ro-RO.rc trunk/reactos/dll/cpl/appwiz/lang/ru-RU.rc trunk/reactos/dll/cpl/appwiz/lang/sk-SK.rc trunk/reactos/dll/cpl/appwiz/lang/uk-UA.rc trunk/reactos/dll/cpl/appwiz/lang/zh-CN.rc Modified: trunk/reactos/dll/cpl/appwiz/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/bg-BG.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/bg-BG.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,7 +61,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/de-DE.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/de-DE.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,9 +61,9 @@ CAPTION "Wine Gecko Installation" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "ReactOS konnte kein Gecko-Paket finden, welches für die korrekte Ausführung von Anwendungen mit eingebettetem HTML benötigt wird. ReactOS kann es automatisch für Sie herunterladen und installieren.\n\nAnmerkung: es wir empfohlen das entsprechende Paket Ihrer Distribution zu verwenden. Weitere Details auf: <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a>", + CONTROL "ReactOS konnte kein Gecko-Paket finden, welches für die korrekte Ausführung von Anwendungen mit eingebettetem HTML benötigt wird. ReactOS kann es automatisch für Sie herunterladen und installieren.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 - DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP - PUSHBUTTON "Cancel", IDCANCEL, 144, 76, 50, 14, WS_GROUP | WS_TABSTOP + DEFPUSHBUTTON "&Installieren", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP + PUSHBUTTON "Abbrechen", IDCANCEL, 144, 76, 50, 14, WS_GROUP | WS_TABSTOP END Modified: trunk/reactos/dll/cpl/appwiz/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/el-GR.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/el-GR.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,7 +61,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/en-US.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/en-US.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,7 +61,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/es-ES.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/es-ES.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -66,7 +66,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/fr-FR.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/fr-FR.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,7 +61,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/he-IL.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/he-IL.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/he-IL.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -62,7 +62,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/it-IT.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/it-IT.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,7 +61,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/no-NO.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/no-NO.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,7 +61,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/pl-PL.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/pl-PL.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -69,7 +69,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/pt-BR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/pt-BR.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/pt-BR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/pt-BR.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -63,7 +63,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/ro-RO.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/ro-RO.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -68,7 +68,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/ru-RU.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/ru-RU.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -61,7 +61,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/sk-SK.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/sk-SK.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -65,7 +65,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/uk-UA.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/uk-UA.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -69,7 +69,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP Modified: trunk/reactos/dll/cpl/appwiz/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz/lang/zh-CN.… ============================================================================== --- trunk/reactos/dll/cpl/appwiz/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/appwiz/lang/zh-CN.rc [iso-8859-1] Sat Aug 31 16:14:12 2013 @@ -68,7 +68,7 @@ CAPTION "Wine Gecko Installer" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Wine could not find a Gecko package which is needed for applications embedding HTML to work correctly. Wine can automatically download and install it for you.\n\nNote: it is recommended to use your distribution's packages instead. See <a href=""http://wiki.winehq.org/Gecko"">http://wiki.winehq.org/Gecko</a> for details.", + CONTROL "ReactOS could not find a Wine Gecko package which is needed for applications embedding HTML to work correctly. ReactOS can automatically download and install it for you.", ID_DWL_STATUS, "SysLink", 0, 10, 10, 240, 65 CONTROL "", ID_DWL_PROGRESS, PROGRESS_CLASSA, WS_BORDER | PBS_SMOOTH, 10, 40, 240, 12 DEFPUSHBUTTON "&Install", ID_DWL_INSTALL, 200, 76, 50, 14, WS_GROUP | WS_TABSTOP

1 0

[akhaldi] 59923: [NTOSKRNL] * Fix several print specifiers. * Add some missing variables to debug prints.
by akhaldi＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: akhaldi Date: Sat Aug 31 16:02:13 2013 New Revision: 59923 URL: http://svn.reactos.org/svn/reactos?rev=59923&view=rev Log: [NTOSKRNL] * Fix several print specifiers. * Add some missing variables to debug prints. Modified: trunk/reactos/ntoskrnl/cache/section/newmm.h trunk/reactos/ntoskrnl/cache/section/swapout.c trunk/reactos/ntoskrnl/config/cmlazy.c trunk/reactos/ntoskrnl/config/ntapi.c trunk/reactos/ntoskrnl/dbgk/dbgkobj.c trunk/reactos/ntoskrnl/ex/event.c trunk/reactos/ntoskrnl/ex/hdlsterm.c trunk/reactos/ntoskrnl/ex/init.c trunk/reactos/ntoskrnl/ex/resource.c trunk/reactos/ntoskrnl/ex/sysinfo.c trunk/reactos/ntoskrnl/ex/work.c trunk/reactos/ntoskrnl/fsrtl/filelock.c trunk/reactos/ntoskrnl/fsrtl/largemcb.c trunk/reactos/ntoskrnl/fsrtl/notify.c trunk/reactos/ntoskrnl/fstub/disksup.c trunk/reactos/ntoskrnl/fstub/fstubex.c trunk/reactos/ntoskrnl/io/iomgr/deviface.c trunk/reactos/ntoskrnl/io/iomgr/driver.c trunk/reactos/ntoskrnl/io/iomgr/iofunc.c trunk/reactos/ntoskrnl/io/iomgr/remlock.c trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.c trunk/reactos/ntoskrnl/io/pnpmgr/pnproot.c trunk/reactos/ntoskrnl/ke/i386/cpu.c trunk/reactos/ntoskrnl/ke/i386/exp.c trunk/reactos/ntoskrnl/ke/i386/ldt.c trunk/reactos/ntoskrnl/ke/i386/patpge.c trunk/reactos/ntoskrnl/ke/i386/traphdlr.c trunk/reactos/ntoskrnl/ke/timerobj.c trunk/reactos/ntoskrnl/lpc/complete.c trunk/reactos/ntoskrnl/lpc/connect.c trunk/reactos/ntoskrnl/lpc/create.c trunk/reactos/ntoskrnl/lpc/listen.c trunk/reactos/ntoskrnl/lpc/reply.c trunk/reactos/ntoskrnl/lpc/send.c trunk/reactos/ntoskrnl/mm/ARM3/expool.c trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c trunk/reactos/ntoskrnl/mm/ARM3/mminit.c trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c trunk/reactos/ntoskrnl/mm/ARM3/pfnlist.c trunk/reactos/ntoskrnl/mm/ARM3/pool.c trunk/reactos/ntoskrnl/mm/ARM3/procsup.c trunk/reactos/ntoskrnl/mm/ARM3/special.c trunk/reactos/ntoskrnl/mm/balance.c trunk/reactos/ntoskrnl/mm/freelist.c trunk/reactos/ntoskrnl/mm/i386/page.c trunk/reactos/ntoskrnl/mm/marea.c trunk/reactos/ntoskrnl/mm/mmfault.c trunk/reactos/ntoskrnl/mm/pagefile.c trunk/reactos/ntoskrnl/mm/section.c trunk/reactos/ntoskrnl/ob/obdir.c trunk/reactos/ntoskrnl/ob/obhandle.c trunk/reactos/ntoskrnl/ob/oblink.c trunk/reactos/ntoskrnl/po/poshtdwn.c trunk/reactos/ntoskrnl/po/povolume.c trunk/reactos/ntoskrnl/po/power.c trunk/reactos/ntoskrnl/ps/debug.c trunk/reactos/ntoskrnl/ps/kill.c trunk/reactos/ntoskrnl/rtl/libsupp.c trunk/reactos/ntoskrnl/se/sd.c trunk/reactos/ntoskrnl/se/token.c trunk/reactos/ntoskrnl/wmi/wmi.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/ntoskrnl/cache/section/newmm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cache/section/new… Modified: trunk/reactos/ntoskrnl/cache/section/swapout.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cache/section/swa… Modified: trunk/reactos/ntoskrnl/config/cmlazy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmlazy.c?r… Modified: trunk/reactos/ntoskrnl/config/ntapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/ntapi.c?re… Modified: trunk/reactos/ntoskrnl/dbgk/dbgkobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/dbgk/dbgkobj.c?re… Modified: trunk/reactos/ntoskrnl/ex/event.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/event.c?rev=59… Modified: trunk/reactos/ntoskrnl/ex/hdlsterm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/hdlsterm.c?rev… Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=599… Modified: trunk/reactos/ntoskrnl/ex/resource.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/resource.c?rev… Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=… Modified: trunk/reactos/ntoskrnl/ex/work.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/work.c?rev=599… Modified: trunk/reactos/ntoskrnl/fsrtl/filelock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/filelock.c?… Modified: trunk/reactos/ntoskrnl/fsrtl/largemcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/largemcb.c?… Modified: trunk/reactos/ntoskrnl/fsrtl/notify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/notify.c?re… Modified: trunk/reactos/ntoskrnl/fstub/disksup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?r… Modified: trunk/reactos/ntoskrnl/fstub/fstubex.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/fstubex.c?r… Modified: trunk/reactos/ntoskrnl/io/iomgr/deviface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/deviface… Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… Modified: trunk/reactos/ntoskrnl/io/iomgr/remlock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/remlock.… Modified: trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/plugpla… Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.… Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpres.… Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnproot.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnproot… Modified: trunk/reactos/ntoskrnl/ke/i386/cpu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/cpu.c?rev… Modified: trunk/reactos/ntoskrnl/ke/i386/exp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/exp.c?rev… Modified: trunk/reactos/ntoskrnl/ke/i386/ldt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/ldt.c?rev… Modified: trunk/reactos/ntoskrnl/ke/i386/patpge.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/patpge.c?… Modified: trunk/reactos/ntoskrnl/ke/i386/traphdlr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/traphdlr.… Modified: trunk/reactos/ntoskrnl/ke/timerobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/timerobj.c?rev… Modified: trunk/reactos/ntoskrnl/lpc/complete.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/lpc/complete.c?re… Modified: trunk/reactos/ntoskrnl/lpc/connect.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/lpc/connect.c?rev… Modified: trunk/reactos/ntoskrnl/lpc/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/lpc/create.c?rev=… Modified: trunk/reactos/ntoskrnl/lpc/listen.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/lpc/listen.c?rev=… Modified: trunk/reactos/ntoskrnl/lpc/reply.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/lpc/reply.c?rev=5… Modified: trunk/reactos/ntoskrnl/lpc/send.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/lpc/send.c?rev=59… Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/expool.c?… Modified: trunk/reactos/ntoskrnl/mm/ARM3/i386/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/i386/init… Modified: trunk/reactos/ntoskrnl/mm/ARM3/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mminit.c?… Modified: trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pagfault.… Modified: trunk/reactos/ntoskrnl/mm/ARM3/pfnlist.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pfnlist.c… Modified: trunk/reactos/ntoskrnl/mm/ARM3/pool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pool.c?re… Modified: trunk/reactos/ntoskrnl/mm/ARM3/procsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c… Modified: trunk/reactos/ntoskrnl/mm/ARM3/special.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/special.c… Modified: trunk/reactos/ntoskrnl/mm/balance.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/balance.c?rev=… Modified: trunk/reactos/ntoskrnl/mm/freelist.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/freelist.c?rev… Modified: trunk/reactos/ntoskrnl/mm/i386/page.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/page.c?re… Modified: trunk/reactos/ntoskrnl/mm/marea.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/marea.c?rev=59… Modified: trunk/reactos/ntoskrnl/mm/mmfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mmfault.c?rev=… Modified: trunk/reactos/ntoskrnl/mm/pagefile.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/pagefile.c?rev… Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… Modified: trunk/reactos/ntoskrnl/ob/obdir.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obdir.c?rev=59… Modified: trunk/reactos/ntoskrnl/ob/obhandle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev… Modified: trunk/reactos/ntoskrnl/ob/oblink.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/oblink.c?rev=5… Modified: trunk/reactos/ntoskrnl/po/poshtdwn.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/poshtdwn.c?rev… Modified: trunk/reactos/ntoskrnl/po/povolume.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/povolume.c?rev… Modified: trunk/reactos/ntoskrnl/po/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/power.c?rev=59… Modified: trunk/reactos/ntoskrnl/ps/debug.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/debug.c?rev=59… Modified: trunk/reactos/ntoskrnl/ps/kill.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/kill.c?rev=599… Modified: trunk/reactos/ntoskrnl/rtl/libsupp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/rtl/libsupp.c?rev… Modified: trunk/reactos/ntoskrnl/se/sd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sd.c?rev=59923… Modified: trunk/reactos/ntoskrnl/se/token.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/token.c?rev=59… Modified: trunk/reactos/ntoskrnl/wmi/wmi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/wmi/wmi.c?rev=599…

1 0

[gadamopoulos] 59922: really fix build
by gadamopoulos＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: gadamopoulos Date: Sat Aug 31 15:05:49 2013 New Revision: 59922 URL: http://svn.reactos.org/svn/reactos?rev=59922&view=rev Log: really fix build Modified: trunk/reactos/dll/win32/shell32/CMakeLists.txt Modified: trunk/reactos/dll/win32/shell32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/shell32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CMakeLists.txt [iso-8859-1] Sat Aug 31 15:05:49 2013 @@ -96,6 +96,7 @@ add_importlibs(shell32 advapi32 + browseui gdi32 user32 comctl32

1 0

[hbelusca] 59921: [FREELDR-KDCOM-KDBG] Fix debugging issues.
by hbelusca＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: hbelusca Date: Sat Aug 31 15:01:50 2013 New Revision: 59921 URL: http://svn.reactos.org/svn/reactos?rev=59921&view=rev Log: [FREELDR-KDCOM-KDBG] Fix debugging issues. Modified: trunk/reactos/boot/freeldr/freeldr/comm/rs232.c trunk/reactos/drivers/base/kdcom/kdcom.c trunk/reactos/ntoskrnl/kd/i386/kdbg.c Modified: trunk/reactos/boot/freeldr/freeldr/comm/rs232.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/comm/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/comm/rs232.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/comm/rs232.c [iso-8859-1] Sat Aug 31 15:01:50 2013 @@ -109,7 +109,7 @@ if (PortInitialized == FALSE) return FALSE; - return (CpGetByte(&Rs232ComPort, ByteReceived, FALSE) == CP_GET_SUCCESS); + return (CpGetByte(&Rs232ComPort, ByteReceived, FALSE, FALSE) == CP_GET_SUCCESS); } */ Modified: trunk/reactos/drivers/base/kdcom/kdcom.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kdcom/kdcom.c… ============================================================================== --- trunk/reactos/drivers/base/kdcom/kdcom.c [iso-8859-1] (original) +++ trunk/reactos/drivers/base/kdcom/kdcom.c [iso-8859-1] Sat Aug 31 15:01:50 2013 @@ -222,7 +222,7 @@ KdpPollByte(OUT PUCHAR OutByte) { /* Poll the byte */ - if (CpGetByte(&KdDebugComPort, OutByte, FALSE, TRUE) == CP_GET_SUCCESS) + if (CpGetByte(&KdDebugComPort, OutByte, FALSE, FALSE) == CP_GET_SUCCESS) { return KDP_PACKET_RECEIVED; } Modified: trunk/reactos/ntoskrnl/kd/i386/kdbg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/i386/kdbg.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/kd/i386/kdbg.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/i386/kdbg.c [iso-8859-1] Sat Aug 31 15:01:50 2013 @@ -136,7 +136,7 @@ IN PCPPORT PortInformation, OUT PUCHAR ByteReceived) { - return (CpGetByte(PortInformation, ByteReceived, FALSE, TRUE) == CP_GET_SUCCESS); + return (CpGetByte(PortInformation, ByteReceived, FALSE, FALSE) == CP_GET_SUCCESS); } VOID

1 0

[hbelusca] 59920: Code formatting only
by hbelusca＠svn.reactos.org 31 Aug '13

31 Aug '13

Author: hbelusca Date: Sat Aug 31 15:00:17 2013 New Revision: 59920 URL: http://svn.reactos.org/svn/reactos?rev=59920&view=rev Log: Code formatting only Modified: trunk/reactos/include/reactos/libs/cportlib/cportlib.h trunk/reactos/lib/cportlib/cport.c Modified: trunk/reactos/include/reactos/libs/cportlib/cportlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/cport… ============================================================================== --- trunk/reactos/include/reactos/libs/cportlib/cportlib.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/libs/cportlib/cportlib.h [iso-8859-1] Sat Aug 31 15:00:17 2013 @@ -72,7 +72,7 @@ IN PCPPORT Port, OUT PUCHAR Byte, IN BOOLEAN Wait, - IN BOOLEAN Poll + IN BOOLEAN Poll ); VOID Modified: trunk/reactos/lib/cportlib/cport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cportlib/cport.c?rev=5… ============================================================================== --- trunk/reactos/lib/cportlib/cport.c [iso-8859-1] (original) +++ trunk/reactos/lib/cportlib/cport.c [iso-8859-1] Sat Aug 31 15:00:17 2013 @@ -256,7 +256,7 @@ CpGetByte(IN PCPPORT Port, OUT PUCHAR Byte, IN BOOLEAN Wait, - IN BOOLEAN Poll) + IN BOOLEAN Poll) { UCHAR Lsr; ULONG LimitCount = Wait ? TIMEOUT_COUNT : 1; @@ -288,7 +288,7 @@ if (Port->Flags & CPPORT_FLAG_MODEM_CONTROL) { /* Not implemented yet */ - //DPRINT1("CP: CPPORT_FLAG_MODEM_CONTROL unexpected\n"); + // DPRINT1("CP: CPPORT_FLAG_MODEM_CONTROL unexpected\n"); } /* Byte was read */ @@ -311,7 +311,7 @@ if (Port->Flags & CPPORT_FLAG_MODEM_CONTROL) // To be removed when this becomes implemented. { /* Not implemented yet */ - //DPRINT1("CP: CPPORT_FLAG_MODEM_CONTROL unexpected\n"); + // DPRINT1("CP: CPPORT_FLAG_MODEM_CONTROL unexpected\n"); } /* Wait for LSR to say we can go ahead */

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs