Ros-diffs

ros-diffs@reactos.org

11 participants
81011 discussions

[reactos] 01/01: [EXPLORER_OLD] Update Romanian (ro-RO) translation (#6388)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a62cc5f9daf9d157a2d6d… commit a62cc5f9daf9d157a2d6dafec52be3bf70ff814e Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 23:05:11 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 22:05:11 2024 +0100 [EXPLORER_OLD] Update Romanian (ro-RO) translation (#6388) --- modules/rosapps/applications/explorer-old/explorer-ro.rc | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/modules/rosapps/applications/explorer-old/explorer-ro.rc b/modules/rosapps/applications/explorer-old/explorer-ro.rc index f2ef1371661..a7ff7da9322 100644 --- a/modules/rosapps/applications/explorer-old/explorer-ro.rc +++ b/modules/rosapps/applications/explorer-old/explorer-ro.rc @@ -1,3 +1,12 @@ +/* + * PROJECT: ReactOS Old Explorer + * LICENSE: LGPL-2.1-or-later (https://spdx.org/licenses/LGPL-2.1-or-later) + * PURPOSE: Romanian resource file + * TRANSLATORS: Copyright 2009 Petru Dimitriu <petrimetri(a)gmail.com> + * Copyright 2011-2014 Ștefan Fulea <stefan.fulea(a)mail.com> + * Copyright 2024 Andrei Miloiu <miloiuandrei(a)gmail.com> + */ + LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL /* Menus */ @@ -137,7 +146,7 @@ END IDD_DESKBAR_DESKTOP DIALOGEX 0, 0, 212, 194 STYLE DS_SHELLFONT | WS_CHILD | WS_DISABLED | WS_CAPTION -CAPTION "Ordinea pe birou" +CAPTION "Proprietăți desktop" FONT 8, "MS Shell Dlg" BEGIN LTEXT "Alegeți modul de ordonare a pictogramelor:", IDC_STATIC, 7, 7, 196, 8 @@ -283,8 +292,8 @@ BEGIN IDS_SEARCH "Căutare" IDS_ABOUT_EXPLORER "&Despre Explorator…" IDS_LAUNCH_MANY_PROGRAMS "Ați ales mai mult de un program.\nSigur doriți să le porniți pe toate?" - IDS_DESKTOPBAR_SETTINGS "Configurare birou" - IDS_DESKTOP "Birou" + IDS_DESKTOPBAR_SETTINGS "Setări desktop" + IDS_DESKTOP "Desktop" IDS_TASKBAR "Bară de activități" IDS_NAMECOLUMN "Nume" IDS_PATHCOLUMN "Cale"

11 months, 3 weeks

[reactos] 01/01: [USERENV] Update Romanian (ro-RO) translation (#6389)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=846980f299e23bd0b79d9… commit 846980f299e23bd0b79d95bdf7b2b30b2860baa1 Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 22:56:37 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 21:56:37 2024 +0100 [USERENV] Update Romanian (ro-RO) translation (#6389) --- dll/win32/userenv/lang/ro-RO.rc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/dll/win32/userenv/lang/ro-RO.rc b/dll/win32/userenv/lang/ro-RO.rc index 1a72d9ce54c..32911ad954e 100644 --- a/dll/win32/userenv/lang/ro-RO.rc +++ b/dll/win32/userenv/lang/ro-RO.rc @@ -1,7 +1,9 @@ /* - * FILE: dll/win32/userenv/lang/ro-RO.rc - * ReactOS Project (https://reactos.org) - * TRANSLATOR: Ștefan Fulea (stefan dot fulea at mail dot com) + * PROJECT: ReactOS Win32 User Environment + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Romanian resource file + * TRANSLATORS: Copyright 2011-2018 Ștefan Fulea <stefan.fulea(a)mail.com> + * Copyright 2024 Andrei Miloiu <miloiuandrei(a)gmail.com> */ LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL @@ -11,7 +13,7 @@ STRINGTABLE BEGIN IDS_PROFILEPATH "%SystemDrive%\\Documente și preferințe" IDS_APPDATA "Date de aplicație" - IDS_DESKTOP "Birou" + IDS_DESKTOP "Desktop" IDS_FAVORITES "Favorite" IDS_MYDOCUMENTS "Documentele mele" IDS_NETHOOD "Rețele"

11 months, 3 weeks

[reactos] 01/01: [COMDLG32] Update Romanian (ro-RO) translation (#6390)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cb97d8eaef90f6467118e… commit cb97d8eaef90f6467118e3150d12b6661f14a6f9 Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 22:56:11 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 21:56:11 2024 +0100 [COMDLG32] Update Romanian (ro-RO) translation (#6390) --- dll/win32/comdlg32/lang/cdlg_Ro.rc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dll/win32/comdlg32/lang/cdlg_Ro.rc b/dll/win32/comdlg32/lang/cdlg_Ro.rc index e636f3b62d4..31c09893561 100644 --- a/dll/win32/comdlg32/lang/cdlg_Ro.rc +++ b/dll/win32/comdlg32/lang/cdlg_Ro.rc @@ -5,7 +5,7 @@ * Copyright 1999 Klaas van Gend * Copyright 2008 Michael Stefaniuc * Copyright 2012 Ștefan Fulea <stefan.fulea(a)mail.com> - * Copyright 2023 Andrei Miloiu <miloiuandrei(a)gmail.com> + * Copyright 2023-2024 Andrei Miloiu <miloiuandrei(a)gmail.com> * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -42,11 +42,11 @@ Doriți să îl suprascrieți?" STRINGTABLE { - IDS_UPFOLDER "Nivelul dosarului părinte" + IDS_UPFOLDER "Sus cu un nivel" IDS_NEWFOLDER "Creează un dosar nou" IDS_LISTVIEW "Listă" IDS_REPORTVIEW "Detalii" - IDS_TODESKTOP "Către birou" + IDS_TODESKTOP "Către desktop" } STRINGTABLE

11 months, 3 weeks

[reactos] 01/01: [LABEL] Update Romanian (ro-RO) translation (#6392)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=559933d6de36d3ae808d4… commit 559933d6de36d3ae808d4a287197572d5ed4f367 Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 22:32:41 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 21:32:41 2024 +0100 [LABEL] Update Romanian (ro-RO) translation (#6392) --- base/applications/cmdutils/label/lang/ro-RO.rc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/base/applications/cmdutils/label/lang/ro-RO.rc b/base/applications/cmdutils/label/lang/ro-RO.rc index fe1df81ad2a..98d836287db 100644 --- a/base/applications/cmdutils/label/lang/ro-RO.rc +++ b/base/applications/cmdutils/label/lang/ro-RO.rc @@ -3,24 +3,23 @@ * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) * PURPOSE: Romanian resource file * TRANSLATORS: Copyright 2011-2019 Ștefan Fulea <stefan.fulea(a)mail.com> - * Copyright 2023 Andrei Miloiu <miloiuandrei(a)gmail.com> + * Copyright 2023-2024 Andrei Miloiu <miloiuandrei(a)gmail.com> */ LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL STRINGTABLE BEGIN -// STRING_LABEL_HELP "Afișează sau modifică eticheta unei unități (de stocare).\n\nLABEL [unitate:][etichetă]\n" STRING_LABEL_HELP "Crează, schimbă sau șterge denumirea unui disc.\n\n\ LABEL [disc:][denumire]\n\n\ disc: Specifică litera unui disc.\n\ denumire Specifică denumirea unui disc." - STRING_LABEL_TEXT1 "Volumul unității %c: este denumit ca %s\n" - STRING_LABEL_TEXT2 "Volumul unității %c: nu este denumit.\n" + STRING_LABEL_TEXT1 "Volumul discului %c: este %s\n" + STRING_LABEL_TEXT2 "Volumul discului %c: nu are denumire.\n" STRING_LABEL_TEXT3 "Numărul de serie al volumului este %04X-%04X\n" - STRING_LABEL_TEXT4 "Introduceți denumirea unității (opțională, de 32 caractere), apoi ENTER " + STRING_LABEL_TEXT4 "Denumirea volumului (32 de caractere, ENTER dacă dacă nu există)?" STRING_LABEL_PROMPT "Ștergeți denumirea actuală a volumului (D/N)? " STRING_LABEL_OPTIONS "DN" - STRING_ERROR_INVALID_DRIVE "Specificarea unității este eronată\n" + STRING_ERROR_INVALID_DRIVE "Specificarea discului este nevalidă\n" STRING_ERROR_INVALID_LABEL "Denumirea volumului e nevalidă\n" END

11 months, 3 weeks

[reactos] 01/01: [NETPLWIZ] Update Romanian (ro-RO) translation (#6393)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1c5b5ce8a48c717af3d2e… commit 1c5b5ce8a48c717af3d2e69272116972e914c56f Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 22:32:09 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 21:32:09 2024 +0100 [NETPLWIZ] Update Romanian (ro-RO) translation (#6393) --- dll/shellext/netplwiz/lang/ro-RO.rc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dll/shellext/netplwiz/lang/ro-RO.rc b/dll/shellext/netplwiz/lang/ro-RO.rc index 465e0cbcc93..f3f69473d21 100644 --- a/dll/shellext/netplwiz/lang/ro-RO.rc +++ b/dll/shellext/netplwiz/lang/ro-RO.rc @@ -2,18 +2,18 @@ * PROJECT: ReactOS Network Places Wizard * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+) * PURPOSE: Romanian resource file - * TRANSLATORS: Copyright 2022 Andrei Miloiu <miloiuandrei(a)gmail.com> + * TRANSLATORS: Copyright 2022-2024 Andrei Miloiu <miloiuandrei(a)gmail.com> */ LANGUAGE LANG_ROMANIAN, SUBLANG_DEFAULT IDD_DISCONNECTDRIVES DIALOGEX 0, 0, 300, 200 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU -CAPTION "Deconectează unitățile de rețea" +CAPTION "Demontează discurile de rețea" FONT 8, "MS Shell Dlg" BEGIN - LTEXT "Selectați unitatea/unitățile pe care vreți să le deconectați, apoi dați clic pe Confirmă.", -1, 7, 7, 286, 8 - LTEXT "&Unități de rețea:", -1, 7, 23, 286, 8 + LTEXT "Selectați dicul/discurile pe care vreți să le demontați, apoi dați clic pe Confirmă.", -1, 7, 7, 286, 8 + LTEXT "&Discuri de rețea:", -1, 7, 23, 286, 8 CONTROL "", IDC_CONNECTEDDRIVELIST, "SysListView32", LVS_REPORT | LVS_SHOWSELALWAYS | LVS_SORTASCENDING | LVS_SINGLESEL | WS_CHILD | WS_VISIBLE | WS_BORDER | WS_TABSTOP, 7, 31, 286, 140 PUSHBUTTON "Confirmă", ID_OK, 189, 179, 50, 14 PUSHBUTTON "Anulează", IDCANCEL, 243, 179, 50, 14 @@ -21,8 +21,8 @@ END STRINGTABLE BEGIN - IDS_DIALOG_CAPTION "Deconectează unitatea de rețea" - IDS_DRIVE_LETTER "Litera unității" + IDS_DIALOG_CAPTION "Demontează discul de rețea" + IDS_DRIVE_LETTER "Litera discului" IDS_NETWORK_PATH "Calea rețelei" - IDS_NO_DRIVES "Nu aveți unități de rețea de deconectat." + IDS_NO_DRIVES "Nu aveți discuri de rețea de demontat." END

11 months, 3 weeks

[reactos] 01/01: [ACPPAGE] Update Romanian (ro-RO) translation (#6394)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a0d7030a0670a362f6680… commit a0d7030a0670a362f6680971684e2bf34351c554 Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 22:28:27 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 21:28:27 2024 +0100 [ACPPAGE] Update Romanian (ro-RO) translation (#6394) --- dll/shellext/acppage/lang/ro-RO.rc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dll/shellext/acppage/lang/ro-RO.rc b/dll/shellext/acppage/lang/ro-RO.rc index 0a72863bbf7..76bcda12f18 100644 --- a/dll/shellext/acppage/lang/ro-RO.rc +++ b/dll/shellext/acppage/lang/ro-RO.rc @@ -28,7 +28,7 @@ END IDD_EDITCOMPATIBILITYMODES DIALOGEX 0, 0, 309, 134 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU -CAPTION "Modurile de compatibilitate" +CAPTION "Editează modurile de compatibilitate" FONT 8, "MS Shell Dlg", 0, 0, 0x0 BEGIN LISTBOX IDC_NEWCOMPATIBILITYMODE,6,18,132,90,LBS_NOINTEGRALHEIGHT | WS_VSCROLL @@ -45,7 +45,7 @@ END STRINGTABLE BEGIN IDS_COMPAT_TITLE "Compatibilitate" - IDS_FAILED_NETWORK "Modurile de compatibilitate nu pot fi instituite pentru acest program deoarece rezidă pe o unitate de stocare în rețea." - IDS_FAILED_PROTECTED "Modurile de compatibilitate nu pot fi instituite pentru acest program deoarece este parte din ReactOS." + IDS_FAILED_NETWORK "Modurile de compatibilitate nu pot fi setate pentru acest program deoarece rezidă pe o unitate de stocare în rețea." + IDS_FAILED_PROTECTED "Modurile de compatibilitate nu pot fi setate pentru acest program deoarece este parte din ReactOS." END

11 months, 3 weeks

[reactos] 01/01: [SUBST] Update Romanian (ro-RO) translation (#6395)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=82e6688e4da428dc1fba0… commit 82e6688e4da428dc1fba006e5e65a2cc05a12e8e Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 22:26:30 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 21:26:30 2024 +0100 [SUBST] Update Romanian (ro-RO) translation (#6395) --- base/system/subst/lang/ro-RO.rc | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/base/system/subst/lang/ro-RO.rc b/base/system/subst/lang/ro-RO.rc index ca3ba4ff97e..3e86b424b49 100644 --- a/base/system/subst/lang/ro-RO.rc +++ b/base/system/subst/lang/ro-RO.rc @@ -1,4 +1,10 @@ -/* Translator: Ștefan Fulea (stefan dot fulea at mail dot com) */ +/* + * PROJECT: ReactOS Subst Command + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Romanian resource file + * TRANSLATORS: Copyright 2011-2018 Ștefan Fulea <stefan.fulea(a)mail.com> + * Copyright 2024 Andrei Miloiu <miloiuandrei(a)gmail.com> + */ LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL @@ -8,15 +14,15 @@ BEGIN IDS_INVALID_PARAMETER "Număr eronat de parametri - %s\n" IDS_INVALID_PARAMETER2 "Parametru eronat - %s\n" IDS_PATH_NOT_FOUND "Cale inexistentă - %s\n" - IDS_ACCESS_DENIED "Acces respins - %s\n" - IDS_DRIVE_ALREADY_SUBSTED "Unitatea este deja SUBSTituită\n" + IDS_ACCESS_DENIED "Acces interzis - %s\n" + IDS_DRIVE_ALREADY_SUBSTED "Discul este deja SUBSTituit\n" IDS_FAILED_WITH_ERRORCODE "Operația a eșuat. Codul de eroare 0x%x: %s\n" - IDS_USAGE "Substituie un director cu o unitate de stocare.\n\n\ -SUBST [unitate1: [unitate2:]cale]\n\ -SUBST unitate1: /D\n\n\ - unitate1: Unitatea virtuală ce va fi asociată directorului.\n\ - [unitate:]cale Unitatea fizică și calea directorului substituit\n\ - cu unitatea virtuală.\n\ - /D șterge o unitate (virtuală) de substituție.\n\n\ -Tastați SUBST fără argumente pentru a enumera unitățile virtuale curente.\n" + IDS_USAGE "Asociază o cale cu o literă de disc.\n\n\ +SUBST [disc1: [disc2:]cale]\n\ +SUBST disc1: /D\n\n\ + disc1: Discul virtual ce va fi asociat directorului.\n\ + [disc:]cale Discul fizic și calea directorului substituit\n\ + cu discul virtual.\n\ + /D șterge un disc (virtual) de substituție.\n\n\ +Tastați SUBST fără argumente pentru a enumera discurile virtuale curente.\n" END

11 months, 3 weeks

[reactos] 01/01: [SETUPAPI] Update Romanian (ro-RO) translation (#6396)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=34d63501ba808b5b98294… commit 34d63501ba808b5b982941dbabaffbdfd7600437 Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Sun Jan 21 22:07:06 2024 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jan 21 21:07:06 2024 +0100 [SETUPAPI] Update Romanian (ro-RO) translation (#6396) --- dll/win32/setupapi/lang/ro-RO.rc | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/dll/win32/setupapi/lang/ro-RO.rc b/dll/win32/setupapi/lang/ro-RO.rc index e0138376188..982684708f3 100644 --- a/dll/win32/setupapi/lang/ro-RO.rc +++ b/dll/win32/setupapi/lang/ro-RO.rc @@ -1,10 +1,16 @@ -/* Translator: Ștefan Fulea (stefan dot fulea at mail dot com) */ +/* + * PROJECT: ReactOS SetupAPI DLL + * LICENSE: LGPL-2.1-or-later (https://spdx.org/licenses/LGPL-2.1-or-later) + * PURPOSE: Romanian resource file + * TRANSLATORS: Copyright 2011-2018 Ștefan Fulea <stefan.fulea(a)mail.com> + * Copyright 2024 Andrei Miloiu <miloiuandrei(a)gmail.com> + */ LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL COPYFILEDLGORD DIALOGEX 20, 20, 208, 105 STYLE DS_MODALFRAME | DS_SHELLFONT | WS_POPUP | WS_VISIBLE | WS_CAPTION -CAPTION "Copiere fișiere" +CAPTION "Copiere fișiere..." FONT 8, "MS Shell Dlg" BEGIN PUSHBUTTON "A&nulează", IDCANCEL, 79, 84, 50, 14, WS_CHILD | WS_VISIBLE | WS_TABSTOP @@ -20,9 +26,9 @@ STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Fișiere necesare" FONT 8, "MS Shell Dlg" BEGIN - LTEXT "Introduceți discul de instalare al producătorului apoi\nverificați că mai jos e selectată unitatea corectă", IDC_FILENEEDED, 10, 10, 175, 38, WS_CHILD | WS_VISIBLE | WS_GROUP + LTEXT "Introduceți discul de instalare al producătorului apoi\nverificați că discul corect e selectat mai jos", IDC_FILENEEDED, 10, 10, 175, 38, WS_CHILD | WS_VISIBLE | WS_GROUP LTEXT "", IDC_INFO, 10, 50, 175, 38, WS_CHILD | WS_VISIBLE | WS_GROUP - LTEXT "Fișierele producătorului vor fi copiate din:", IDC_COPYFROM, 10, 90, 175, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + LTEXT "Copiază fișierele producătorului din:", IDC_COPYFROM, 10, 90, 175, 11, WS_CHILD | WS_VISIBLE | WS_GROUP CONTROL "", IDC_PATH, "COMBOBOX", WS_TABSTOP | WS_GROUP | WS_VSCROLL | WS_VISIBLE | CBS_DISABLENOSCROLL | CBS_AUTOHSCROLL | CBS_DROPDOWN, 10, 100, 175, 14 DEFPUSHBUTTON "Con&firmă", IDOK, 195, 10, 60, 14, WS_CHILD | WS_VISIBLE | WS_TABSTOP PUSHBUTTON "A&nulează", IDCANCEL, 195, 30, 60, 14, WS_CHILD | WS_VISIBLE | WS_TABSTOP @@ -31,15 +37,15 @@ END STRINGTABLE BEGIN - IDS_PROMPTDISK "Este necesar fișierul «%1» din %2" - IDS_UNKNOWN "Nespecificat" - IDS_COPYFROM "Copie fișiere din:" - IDS_INFO "Tastați calea unde sunt amplasate fișierele, apoi confirmați." + IDS_PROMPTDISK "Este necesar fișierul «%1» pe %2" + IDS_UNKNOWN "Necunoscut" + IDS_COPYFROM "Copiază fișiere din:" + IDS_INFO "Tastați calea unde sunt situate fișierele, apoi dați clic pe Confirmă." END STRINGTABLE BEGIN - IDS_QUERY_REBOOT_TEXT "Este necesară repornirea calculatorului pentru a finaliza instalarea. Continuați?" + IDS_QUERY_REBOOT_TEXT "Este necesară repornirea calculatorului dvs. pentru a finaliza instalarea. Continuați?" IDS_QUERY_REBOOT_CAPTION "Repornire" IDS_INF_FILE "Informație de instalare" END

11 months, 3 weeks

[reactos] 01/01: [NTOS] Fix boot on UP build - PrcbLocks are not used on UP (#6391)

by Justin Miller

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=748a2e165534e107492a2… commit 748a2e165534e107492a2c97c231deb3e5d79bbc Author: Justin Miller <justin.miller(a)reactos.org> AuthorDate: Sat Jan 20 08:59:13 2024 -0800 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Jan 20 08:59:13 2024 -0800 [NTOS] Fix boot on UP build - PrcbLocks are not used on UP (#6391) On the uniprocessor kernel KiAcquirePrcbLock is a stub that doesn't modify the current Prcb's PrcbLock value. Quickly protect this assert around CONFIG_SMP --- ntoskrnl/include/internal/ke_x.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ntoskrnl/include/internal/ke_x.h b/ntoskrnl/include/internal/ke_x.h index fcf3edb2786..ae431649773 100644 --- a/ntoskrnl/include/internal/ke_x.h +++ b/ntoskrnl/include/internal/ke_x.h @@ -1359,7 +1359,9 @@ KxQueueReadyThread(IN PKTHREAD Thread, /* Sanity checks */ ASSERT(Prcb == KeGetCurrentPrcb()); +#ifdef CONFIG_SMP ASSERT(Prcb->PrcbLock != 0); +#endif ASSERT(Thread->State == Running); ASSERT(Thread->NextProcessor == Prcb->Number);

11 months, 3 weeks

[reactos] 01/01: [NTOS:KE] Acquire PRCB lock before marking thread ready for execution in dispatch interrupt routine (#6387)

by Oleg Dubinskiy

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ab528ac6ae105b19d4575… commit ab528ac6ae105b19d457587dc680d8016720bc3d Author: Oleg Dubinskiy <oleg.dubinskij30(a)gmail.com> AuthorDate: Sat Jan 20 15:58:39 2024 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Jan 20 15:58:39 2024 +0100 [NTOS:KE] Acquire PRCB lock before marking thread ready for execution in dispatch interrupt routine (#6387) Fixed in x86 and ARM (this was already done in x64). This is needed because thread preparation routine KxQueueReadyThread() releases PRCB lock, but does not acquire it, so that the locking must always be done outside the function, same as in all its other usage cases. This fixes an assert from release PRCB routine, when booting x86 ReactOS in SMP mode, because it attempts to release the lock when it is not actually acquired. Addendum to commit a011d19ed. + Add an assert in KxQueueReadyThread() to ensure the PRCB lock is actually acquired. --- ntoskrnl/include/internal/ke_x.h | 1 + ntoskrnl/ke/arm/thrdini.c | 3 +++ ntoskrnl/ke/i386/thrdini.c | 3 +++ 3 files changed, 7 insertions(+) diff --git a/ntoskrnl/include/internal/ke_x.h b/ntoskrnl/include/internal/ke_x.h index 70fa05e1d12..fcf3edb2786 100644 --- a/ntoskrnl/include/internal/ke_x.h +++ b/ntoskrnl/include/internal/ke_x.h @@ -1359,6 +1359,7 @@ KxQueueReadyThread(IN PKTHREAD Thread, /* Sanity checks */ ASSERT(Prcb == KeGetCurrentPrcb()); + ASSERT(Prcb->PrcbLock != 0); ASSERT(Thread->State == Running); ASSERT(Thread->NextProcessor == Prcb->Number); diff --git a/ntoskrnl/ke/arm/thrdini.c b/ntoskrnl/ke/arm/thrdini.c index 190b73f926c..c32b39c392d 100644 --- a/ntoskrnl/ke/arm/thrdini.c +++ b/ntoskrnl/ke/arm/thrdini.c @@ -334,6 +334,9 @@ KiDispatchInterrupt(VOID) } else if (Prcb->NextThread) { + /* Acquire the PRCB lock */ + KiAcquirePrcbLock(Prcb); + /* Capture current thread data */ OldThread = Prcb->CurrentThread; NewThread = Prcb->NextThread; diff --git a/ntoskrnl/ke/i386/thrdini.c b/ntoskrnl/ke/i386/thrdini.c index 3214f560872..91e8ad3931f 100644 --- a/ntoskrnl/ke/i386/thrdini.c +++ b/ntoskrnl/ke/i386/thrdini.c @@ -495,6 +495,9 @@ KiDispatchInterrupt(VOID) } else if (Prcb->NextThread) { + /* Acquire the PRCB lock */ + KiAcquirePrcbLock(Prcb); + /* Capture current thread data */ OldThread = Prcb->CurrentThread; NewThread = Prcb->NextThread;

11 months, 3 weeks

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs